[opensource-dev] Review Request: OPEN-8: allow specification of the configuration with env var AUTOBUILD_CONFIGURATION
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/141/ --- Review request for Viewer. Summary --- This patch adds support for specifying the configurations using the AUTOBUILD_CONFIGURATION environment variable (multiple configurations can be specified using commas to separate the values). This addresses bug open-8. Diffs - autobuild/autobuild_base.py 9ee2db08d677 autobuild/autobuild_tool_build.py 9ee2db08d677 autobuild/autobuild_tool_configure.py 9ee2db08d677 Diff: http://codereview.secondlife.com/r/141/diff Testing --- Tested manually with and without the command line argument, and with and without the environment variable set; the appropriate configuration values were used. Thanks, Oz ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition.
I'm sort of lost here, sorry :( I did try a lot of different things (except i didn't look in the python files as i'm not sure what i'd be looking at). our versions seem to match exactly Microsoft Visual Studio 2005 Version 8.0.50727.867 (vsvista.050727-8600) Microsoft .NET Framework Version 2.0.50727 SP2 Installed Edition: VC Express Microsoft Visual C++ 2005 76542-000-011-00125 Microsoft Visual C++ 2005 all my tests after you pointed out running from a vc2005 cmd window have that Setting environment for using Microsoft Visual Studio 2005 x86 tools. C:\Program Files (x86)\Microsoft Visual Studio 8\Common7\IDE> i also modified my vcvars32.bat file to include @set INCLUDE=C:\Program Files (x86)\Microsoft Visual Studio 8\VC\INCLUDE;%INCLUDE% @set INCLUDE=C:\Program Files\Microsoft SDKs\Windows\v6.1\Include;%INCLUDE% @set INCLUDE=C:\Program Files\Microsoft SDKs\Windows\v6.1\Include\gl;%INCLUDE% @set INCLUDE=C:\Program Files (x86)\Microsoft DirectX SDK (August 2008)\Include;%INCLUDE% didn't change anything for me :( Date: Sun, 6 Feb 2011 18:55:34 -0800 From: nickyper...@yahoo.com Subject: Re: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition. To: twisted_l...@hotmail.com; opensource-dev@lists.secondlife.com; ima.mechani...@blueyonder.co.uk Help->About VC++2005 Express Edition->Copy Info-->Paste from Clipboard yeilds-- Microsoft Visual Studio 2005 Version 8.0.50727.867 (vsvista.050727-8600) Microsoft .NET Framework Version 2.0.50727 SP2 Installed Edition: VC Express Microsoft Visual C++ 2005 76542-000-011-00125 Microsoft Visual C++ 2005 ** Invoke Terminal and execute->> "C:\Program Files\Microsoft Visual Studio 8\Common7\Tools\vsvars32.bat" Yeilds Setting environment for using Microsoft Visual Studio 2005 x86 tools. C:\> Early on I had a problem where vcvars32.bat did not execute properly when invoked from within Express. I had to drill down through All Programs and invoke from within Visual Studio Tools. You should have "Setting environment for using Microsoft Visual Studio 2005 x86 tools." without any errors before using the terminal. Anyway a couple things to check. I have tried unsucessfully to force a repo of failed includes. ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition.
Help->About VC++2005 Express Edition->Copy Info-->Paste from Clipboard
yeilds--
Microsoft Visual Studio 2005
Version 8.0.50727.867 (vsvista.050727-8600)
Microsoft .NET Framework
Version 2.0.50727 SP2
Installed Edition: VC Express
Microsoft Visual C++ 2005 76542-000-011-00125
Microsoft Visual C++ 2005
**
Invoke Terminal and execute->>
"C:\Program Files\Microsoft Visual Studio 8\Common7\Tools\vsvars32.bat"
Yeilds
Setting environment for using Microsoft Visual Studio 2005 x86 tools.
C:\>
Early on I had a problem where vcvars32.bat did not execute properly when
invoked from within Express. I had to drill down through All Programs
and invoke from within Visual Studio Tools.
You should have "Setting environment for using Microsoft Visual Studio 2005 x86
tools."
without any errors before using the terminal.
Anyway a couple things to check. I have tried unsucessfully
to force a repo of failed includes.
From: Twisted Laws
To: SLDEV
Sent: Sun, February 6, 2011 3:05:25 PM
Subject: Re: [opensource-dev] Review Request: Make viewer-autobuild work under
Visual Studio 2005 Express Edition.
I tried making these changes... it did not do anything different or help me
in my situation of not finding the windows.h and winsock2.h.
I'd start over and rebuild the dev environment but its not a good option for
me
at this time.
> Date: Sun, 6 Feb 2011 20:23:41 +
> From: ima.mechani...@blueyonder.co.uk
> To: opensource-dev@lists.secondlife.com
> Subject: Re: [opensource-dev] Review Request: Make viewer-autobuild work
> under
>Visual Studio 2005 Express Edition.
>
> > What is your windows OS? I may be able to Vbox/VM it to test.
>
> WinXP 64 bit.
>
> The following altered function from
>indra\lib\python\indra\util\test_win32_manifest.py
> fixes the issues for me.
>
> def find_vc_dir():
> supported_versions = (r'8.0', r'9.0')
> supported_products = (r'VisualStudio', r'VCExpress')
> value_str = (r'ProductDir')
>
> for product in supported_products:
> for version in supported_versions:
> key_str = (r'SOFTWARE\Microsoft\%s\%s\Setup\VC' %
> (product, version))
> try:
> return get_HKLM_registry_value(key_str, value_str)
> except WindowsError, err:
> if product == "VisualStudio":
> reg_key = "VS"
> elif product == "VCExpress":
> reg_key = "VC"
> else:
> raise Exception("Unknown package!")
>
> x64_key_str = (r'SOFTWARE\Wow6432Node\Microsoft\%s\%s\Setup\%s' %
> (product, version, reg_key))
>
> try:
> return get_HKLM_registry_value(x64_key_str, value_str)
> except:
> print >> sys.stderr, "Didn't find MS %s version %s " % (product,version)
>
> raise
>
>
> >
> > From: Ima Mechanique
> > To: opensource-dev@lists.secondlife.com
> > Sent: Sun, February 6, 2011 1:15:31 PM
> > Subject: Re: [opensource-dev] Review Request: Make viewer-autobuild work
>under
>
> > Visual Studio 2005 Express Edition.
> >
> > > I'm getting dozens of these errors
> > >
> > > fatal error C1083: Cannot open include file: 'winsock2.h': No such file
> > > or
> > >directory
> > >
> > > and
> > >
> > > fatal error C1083: Cannot open include file: 'windows.h': No such file or
> > >directory
> > >
> > > Seems that it is not using the Include directories list.
> >
> > Just to clarify. These errors are only generated when using "autobuild
> > build -c VCexpressRelWithDebInfo" If using the MSVC Express gui it
> > builds with only the usual niggles (like failing on x64 because it can't
> > find a directory)
> >
> >
> > --
> > Ima Mechanique
> > ima.mechanique(at)blueyonder.co.uk
> >
> >
> > ___
> > Policies and (un)subscribe information available here:
> > http://wiki.secondlife.com/wiki/OpenSource-Dev
> > Please read the policies before posting to keep unmoderated posting
>privileges
> >
> >
> >
> >
>
> --
> Ima Mechanique
> ima.mechanique(at)blueyonder.co.uk
>
>
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting privileges
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] Review Request: OPEN-7: allow specification of the config-file with env var AUTOBUILD_CONFIG_FILE
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/140/ --- Review request for Viewer. Summary --- This change allows the environment variable AUTOBUILD_CONFIG_FILE to specify a default config-file, so that the precedence becomes: 1. the --config-file command line option 2. the environment variable AUTOBUILD_CONFIG_FILE 3. "autobuild.xml" It also adds an info-level (--verbose) display of the config file name that is being loaded, and a warning level display if the config file does not exist. This addresses bug open-7. Diffs - autobuild/autobuild_tool_build.py 9ee2db08d677 autobuild/autobuild_tool_configure.py 9ee2db08d677 autobuild/autobuild_tool_edit.py 9ee2db08d677 autobuild/autobuild_tool_install.py 9ee2db08d677 autobuild/autobuild_tool_installables.py 9ee2db08d677 autobuild/autobuild_tool_manifest.py 9ee2db08d677 autobuild/autobuild_tool_package.py 9ee2db08d677 autobuild/autobuild_tool_print.py 9ee2db08d677 autobuild/autobuild_tool_uninstall.py 9ee2db08d677 autobuild/configfile.py 9ee2db08d677 Diff: http://codereview.secondlife.com/r/140/diff Testing --- Manually tested with and without the command line option, and with and without the environment variable set: confirmed that the correct file name is used per the precedence above. Confirmed that the new logging works correctly. Thanks, Oz ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition.
> I remembered reading about some issues (don't ask me to expand) of not having > the latest SDK's when using win64. I have both express and pro on my machine > and > my include settings for Pro reflect newer SDK's. > Maybe you can try these includes. > > http://picpaste.com/vs2005proIncludes-2Fa11vp6.PNG I have all those directories (and more, see https://wiki.secondlife.com/wiki/Viewer_2_Microsoft_Windows_Builds for complete list). I don't think the contents here are the issue. After all, those includes work for the GUI, for some reason the CLI is not getting them would seem more likely to me. > > From: Ima Mechanique > To: opensource-dev@lists.secondlife.com > Sent: Sun, February 6, 2011 3:34:41 PM > Subject: Re: [opensource-dev] Review Request: Make viewer-autobuild work > under > Visual Studio 2005 Express Edition. > > > On 2011-02-06 14:15, Ima Mechanique wrote: > > > Just to clarify. These errors are only generated when using "autobuild > > > build -c VCexpressRelWithDebInfo" If using the MSVC Express gui it > > > builds with only the usual niggles (like failing on x64 because it can't > > > find a directory) > > > > Can you tell what is being done differently? > > Not really. Looking at the build logs, apart from the lack of cmake > command and some packages missing (like fmod), they look pretty much the > same. > > > Perhaps from the gui it's not building the same set of targets? > > My suspicion, is that the GUI is using its Include files directory list > and the command line is not. The INCLUDE env variable only contains > "C:\Program Files (x86)\Microsoft\Visual Studio\8\VC\INCLUDE;" instead > of the dozen or more in the GUI list. However manually adding the two > SDK include directories where the files exist doesn't help (and the lack > doesn't harm the standard v-d build). > > > ___ > > Policies and (un)subscribe information available here: > > http://wiki.secondlife.com/wiki/OpenSource-Dev > > Please read the policies before posting to keep unmoderated posting > > privileges > > -- > Ima Mechanique > ima.mechanique(at)blueyonder.co.uk > > > ___ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting privileges > > > > -- Ima Mechanique ima.mechanique(at)blueyonder.co.uk ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition.
I remembered reading about some issues (don't ask me to expand) of not having the latest SDK's when using win64. I have both express and pro on my machine and my include settings for Pro reflect newer SDK's. Maybe you can try these includes. http://picpaste.com/vs2005proIncludes-2Fa11vp6.PNG From: Ima Mechanique To: opensource-dev@lists.secondlife.com Sent: Sun, February 6, 2011 3:34:41 PM Subject: Re: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition. > On 2011-02-06 14:15, Ima Mechanique wrote: > > Just to clarify. These errors are only generated when using "autobuild > > build -c VCexpressRelWithDebInfo" If using the MSVC Express gui it > > builds with only the usual niggles (like failing on x64 because it can't > > find a directory) > > Can you tell what is being done differently? Not really. Looking at the build logs, apart from the lack of cmake command and some packages missing (like fmod), they look pretty much the same. > Perhaps from the gui it's not building the same set of targets? My suspicion, is that the GUI is using its Include files directory list and the command line is not. The INCLUDE env variable only contains "C:\Program Files (x86)\Microsoft\Visual Studio\8\VC\INCLUDE;" instead of the dozen or more in the GUI list. However manually adding the two SDK include directories where the files exist doesn't help (and the lack doesn't harm the standard v-d build). > ___ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting privileges -- Ima Mechanique ima.mechanique(at)blueyonder.co.uk ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition.
> On 2011-02-06 14:15, Ima Mechanique wrote: > > Just to clarify. These errors are only generated when using "autobuild > > build -c VCexpressRelWithDebInfo" If using the MSVC Express gui it > > builds with only the usual niggles (like failing on x64 because it can't > > find a directory) > > Can you tell what is being done differently? Not really. Looking at the build logs, apart from the lack of cmake command and some packages missing (like fmod), they look pretty much the same. > Perhaps from the gui it's not building the same set of targets? My suspicion, is that the GUI is using its Include files directory list and the command line is not. The INCLUDE env variable only contains "C:\Program Files (x86)\Microsoft\Visual Studio\8\VC\INCLUDE;" instead of the dozen or more in the GUI list. However manually adding the two SDK include directories where the files exist doesn't help (and the lack doesn't harm the standard v-d build). > ___ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting privileges -- Ima Mechanique ima.mechanique(at)blueyonder.co.uk ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition.
>
> I tried making these changes... it did not do anything different or help me
> in my situation of not finding the windows.h and winsock2.h.
That change is only for Win XP x64 environment, to allow the build
process to identify the VC Express install directory. Otherwise build
fails. It has nothing to do with the winsock2.h and windows.h problem,
which I'm looking into now in response to Oz's mail.
> I'd start over and rebuild the dev environment but its not a good option for
> me at this time.
>
> > Date: Sun, 6 Feb 2011 20:23:41 +
> > From: ima.mechani...@blueyonder.co.uk
> > To: opensource-dev@lists.secondlife.com
> > Subject: Re: [opensource-dev] Review Request: Make viewer-autobuild work
> > under Visual Studio 2005 Express Edition.
> >
> > > What is your windows OS? I may be able to Vbox/VM it to test.
> >
> > WinXP 64 bit.
> >
> > The following altered function from
> > indra\lib\python\indra\util\test_win32_manifest.py
> > fixes the issues for me.
> >
> > def find_vc_dir():
> > supported_versions = (r'8.0', r'9.0')
> > supported_products = (r'VisualStudio', r'VCExpress')
> > value_str = (r'ProductDir')
> >
> > for product in supported_products:
> > for version in supported_versions:
> > key_str = (r'SOFTWARE\Microsoft\%s\%s\Setup\VC' %
> > (product, version))
> > try:
> > return get_HKLM_registry_value(key_str, value_str)
> > except WindowsError, err:
> > if product == "VisualStudio":
> > reg_key = "VS"
> > elif product == "VCExpress":
> > reg_key = "VC"
> > else:
> > raise Exception("Unknown package!")
> >
> > x64_key_str = (r'SOFTWARE\Wow6432Node\Microsoft\%s\%s\Setup\%s' %
> > (product, version, reg_key))
> >
> > try:
> > return get_HKLM_registry_value(x64_key_str, value_str)
> > except:
> > print >> sys.stderr, "Didn't find MS %s version %s " % (product,version)
> >
> > raise
> >
> >
> > >
> > > From: Ima Mechanique
> > > To: opensource-dev@lists.secondlife.com
> > > Sent: Sun, February 6, 2011 1:15:31 PM
> > > Subject: Re: [opensource-dev] Review Request: Make viewer-autobuild work
> > > under
> > > Visual Studio 2005 Express Edition.
> > >
> > > > I'm getting dozens of these errors
> > > >
> > > > fatal error C1083: Cannot open include file: 'winsock2.h': No such file
> > > > or
> > > >directory
> > > >
> > > > and
> > > >
> > > > fatal error C1083: Cannot open include file: 'windows.h': No such file
> > > > or
> > > >directory
> > > >
> > > > Seems that it is not using the Include directories list.
> > >
> > > Just to clarify. These errors are only generated when using "autobuild
> > > build -c VCexpressRelWithDebInfo" If using the MSVC Express gui it
> > > builds with only the usual niggles (like failing on x64 because it can't
> > > find a directory)
> > >
> > >
> > > --
> > > Ima Mechanique
> > > ima.mechanique(at)blueyonder.co.uk
> > >
> > >
> > > ___
> > > Policies and (un)subscribe information available here:
> > > http://wiki.secondlife.com/wiki/OpenSource-Dev
> > > Please read the policies before posting to keep unmoderated posting
> > > privileges
> > >
> > >
> > >
> > >
> >
> > --
> > Ima Mechanique
> > ima.mechanique(at)blueyonder.co.uk
> >
> >
> > ___
> > Policies and (un)subscribe information available here:
> > http://wiki.secondlife.com/wiki/OpenSource-Dev
> > Please read the policies before posting to keep unmoderated posting
> > privileges
>
--
Ima Mechanique
ima.mechanique(at)blueyonder.co.uk
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition.
I tried making these changes... it did not do anything different or help me
in my situation of not finding the windows.h and winsock2.h.
I'd start over and rebuild the dev environment but its not a good option for
me at this time.
> Date: Sun, 6 Feb 2011 20:23:41 +
> From: ima.mechani...@blueyonder.co.uk
> To: opensource-dev@lists.secondlife.com
> Subject: Re: [opensource-dev] Review Request: Make viewer-autobuild work
> under Visual Studio 2005 Express Edition.
>
> > What is your windows OS? I may be able to Vbox/VM it to test.
>
> WinXP 64 bit.
>
> The following altered function from
> indra\lib\python\indra\util\test_win32_manifest.py
> fixes the issues for me.
>
> def find_vc_dir():
> supported_versions = (r'8.0', r'9.0')
> supported_products = (r'VisualStudio', r'VCExpress')
> value_str = (r'ProductDir')
>
> for product in supported_products:
> for version in supported_versions:
> key_str = (r'SOFTWARE\Microsoft\%s\%s\Setup\VC' %
> (product, version))
> try:
> return get_HKLM_registry_value(key_str, value_str)
> except WindowsError, err:
> if product == "VisualStudio":
> reg_key = "VS"
> elif product == "VCExpress":
> reg_key = "VC"
> else:
> raise Exception("Unknown package!")
>
> x64_key_str = (r'SOFTWARE\Wow6432Node\Microsoft\%s\%s\Setup\%s' %
> (product, version, reg_key))
>
> try:
> return get_HKLM_registry_value(x64_key_str, value_str)
> except:
> print >> sys.stderr, "Didn't find MS %s version %s " % (product,version)
>
> raise
>
>
> >
> > From: Ima Mechanique
> > To: opensource-dev@lists.secondlife.com
> > Sent: Sun, February 6, 2011 1:15:31 PM
> > Subject: Re: [opensource-dev] Review Request: Make viewer-autobuild work
> > under
> > Visual Studio 2005 Express Edition.
> >
> > > I'm getting dozens of these errors
> > >
> > > fatal error C1083: Cannot open include file: 'winsock2.h': No such file
> > > or
> > >directory
> > >
> > > and
> > >
> > > fatal error C1083: Cannot open include file: 'windows.h': No such file or
> > >directory
> > >
> > > Seems that it is not using the Include directories list.
> >
> > Just to clarify. These errors are only generated when using "autobuild
> > build -c VCexpressRelWithDebInfo" If using the MSVC Express gui it
> > builds with only the usual niggles (like failing on x64 because it can't
> > find a directory)
> >
> >
> > --
> > Ima Mechanique
> > ima.mechanique(at)blueyonder.co.uk
> >
> >
> > ___
> > Policies and (un)subscribe information available here:
> > http://wiki.secondlife.com/wiki/OpenSource-Dev
> > Please read the policies before posting to keep unmoderated posting
> > privileges
> >
> >
> >
> >
>
> --
> Ima Mechanique
> ima.mechanique(at)blueyonder.co.uk
>
>
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting privileges
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition.
On 2011-02-06 14:15, Ima Mechanique wrote: > Just to clarify. These errors are only generated when using "autobuild > build -c VCexpressRelWithDebInfo" If using the MSVC Express gui it > builds with only the usual niggles (like failing on x64 because it can't > find a directory) Can you tell what is being done differently? Perhaps from the gui it's not building the same set of targets? ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition.
> What is your windows OS? I may be able to Vbox/VM it to test.
WinXP 64 bit.
The following altered function from
indra\lib\python\indra\util\test_win32_manifest.py
fixes the issues for me.
def find_vc_dir():
supported_versions = (r'8.0', r'9.0')
supported_products = (r'VisualStudio', r'VCExpress')
value_str = (r'ProductDir')
for product in supported_products:
for version in supported_versions:
key_str = (r'SOFTWARE\Microsoft\%s\%s\Setup\VC' %
(product, version))
try:
return get_HKLM_registry_value(key_str, value_str)
except WindowsError, err:
if product == "VisualStudio":
reg_key = "VS"
elif product == "VCExpress":
reg_key = "VC"
else:
raise Exception("Unknown package!")
x64_key_str = (r'SOFTWARE\Wow6432Node\Microsoft\%s\%s\Setup\%s'
%
(product, version, reg_key))
try:
return get_HKLM_registry_value(x64_key_str, value_str)
except:
print >> sys.stderr, "Didn't find MS %s version %s " %
(product,version)
raise
>
> From: Ima Mechanique
> To: opensource-dev@lists.secondlife.com
> Sent: Sun, February 6, 2011 1:15:31 PM
> Subject: Re: [opensource-dev] Review Request: Make viewer-autobuild work
> under
> Visual Studio 2005 Express Edition.
>
> > I'm getting dozens of these errors
> >
> > fatal error C1083: Cannot open include file: 'winsock2.h': No such file or
> >directory
> >
> > and
> >
> > fatal error C1083: Cannot open include file: 'windows.h': No such file or
> >directory
> >
> > Seems that it is not using the Include directories list.
>
> Just to clarify. These errors are only generated when using "autobuild
> build -c VCexpressRelWithDebInfo" If using the MSVC Express gui it
> builds with only the usual niggles (like failing on x64 because it can't
> find a directory)
>
>
> --
> Ima Mechanique
> ima.mechanique(at)blueyonder.co.uk
>
>
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting privileges
>
>
>
>
--
Ima Mechanique
ima.mechanique(at)blueyonder.co.uk
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition.
What is your windows OS? I may be able to Vbox/VM it to test. From: Ima Mechanique To: opensource-dev@lists.secondlife.com Sent: Sun, February 6, 2011 1:15:31 PM Subject: Re: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition. > I'm getting dozens of these errors > > fatal error C1083: Cannot open include file: 'winsock2.h': No such file or >directory > > and > > fatal error C1083: Cannot open include file: 'windows.h': No such file or >directory > > Seems that it is not using the Include directories list. Just to clarify. These errors are only generated when using "autobuild build -c VCexpressRelWithDebInfo" If using the MSVC Express gui it builds with only the usual niggles (like failing on x64 because it can't find a directory) -- Ima Mechanique ima.mechanique(at)blueyonder.co.uk ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition.
On 2011-02-06 10:40, Oz Linden (Scott Lawrence) wrote: On 2011-02-06 9:15, Oz Linden (Scott Lawrence) wrote: I've created a repo sync'ed up to the latest viewer-development, and with this workaround (I renamed the configuration VCexpressRelWithDebInfo to make it stand out a bit more). If folks with VS Express (2005) could please test it : https://bitbucket.org/oz_linden/viewer-autobuildvs8 I'm running a test in TeamCity now to make sure that it does not bother the production builds. That test appears to be a pass Please test (or retest, as the case may be) using the above repo at changeset 21ef0a07c2cd or later... To recap, our goal is to make it possible to build (albeit without FMOD - that's a separate issue) with just two commands in a command (not cygwin) shell: autobuild configure -c VCexpressRelWithDebInfo autobuild build -c VCexpressRelWithDebInfo you _do_ need to respecify the configuration argument for the build command (this is the way autobuild is expected to work, at least for now). ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition.
Later today Ill bring up in IDE and see it the same errors arise. idk what is happening but if 2 that we know have them of then we need to try and correct. From: Twisted Laws To: Oz Linden ; SLDEV Sent: Sun, February 6, 2011 1:07:27 PM Subject: Re: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition. Ok, i found i can get much further compiling in the IDE and this is all i end up with now. Note that the issue with winres.h is one i always have had with and easy change of defining IDC_STATIC and including winresrc.h instead. Twisted Warning 1 warning LNK4099: PDB 'vc80.pdb' was not found with '..\packages\lib\release\exception_handler.lib' or at 'C:\dev\hgbuilds\viewer-autobuildvs8\build-vc80\sharedlibs\RelWithDebInfo\vc80.pdb'; linking object as if no debug info exception_handler.lib Warning 2 warning LNK4099: PDB 'vc80.pdb' was not found with '..\packages\lib\release\crash_generation_client.lib' or at 'C:\dev\hgbuilds\viewer-autobuildvs8\build-vc80\sharedlibs\RelWithDebInfo\vc80.pdb'; linking object as if no debug info crash_generation_client.lib Warning 3 warning LNK4099: PDB 'vc80.pdb' was not found with '..\packages\lib\release\common.lib' or at 'C:\dev\hgbuilds\viewer-autobuildvs8\build-vc80\sharedlibs\RelWithDebInfo\vc80.pdb'; linking object as if no debug info common.lib Error 4 error PRJ0019: A tool returned an error code from "Generating PROJECT_llmessage_TEST_lltemplatemessagedispatcher_ok.txt" llmessage_tests Error 5 error PRJ0019: A tool returned an error code from "Generating PROJECT_llupdaterservice_TEST_llupdaterservice_ok.txt" llupdaterservice_tests Error 6 error PRJ0019: A tool returned an error code from "Performing viewer_manifest copy" copy_w_viewer_manifest Warning 7 warning LNK4221: no public symbols found; archive member will be inaccessible llfunctorregistry.obj Error 8 fatal error RC1015: cannot open include file 'winres.h'. c:\dev\hgbuilds\viewer-autobuildvs8\indra\newview\res\viewerRes.rc 10 Error 9 error PRJ0019: A tool returned an error code from "Generating RelWithDebInfo/touched.bat" package From: twisted_l...@hotmail.com To: o...@lindenlab.com; opensource-dev@lists.secondlife.com Date: Sun, 6 Feb 2011 12:56:55 -0500 Subject: Re: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition. Ok, i'm an idiot and can't follow instructions So i reread Oz's msg and found i was using the wrong config and redid it with autobuild configure -c VCexpressRelWithDebInfo Then that part worked ok. If i then just used "autobuild build" it had the same fmod error as before. So i tried autobuild build -c VCexpressRelWithDebInfo --verbose and things went further but as someone else reported then i got 100's of errors about winsock2.h not being found. Why does it continue to try to build everything after it gets so many errors? Build complete: 12 Projects succeeded, 113 Projects failed, 2 Projects skipped ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition.
> I'm getting dozens of these errors > > fatal error C1083: Cannot open include file: 'winsock2.h': No such file or > directory > > and > > fatal error C1083: Cannot open include file: 'windows.h': No such file or > directory > > Seems that it is not using the Include directories list. Just to clarify. These errors are only generated when using "autobuild build -c VCexpressRelWithDebInfo" If using the MSVC Express gui it builds with only the usual niggles (like failing on x64 because it can't find a directory) -- Ima Mechanique ima.mechanique(at)blueyonder.co.uk ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition.
Ok, i found i can get much further compiling in the IDE and this is all i end up with now. Note that the issue with winres.h is one i always have had with and easy change of defining IDC_STATIC and including winresrc.h instead. Twisted Warning 1 warning LNK4099: PDB 'vc80.pdb' was not found with '..\packages\lib\release\exception_handler.lib' or at 'C:\dev\hgbuilds\viewer-autobuildvs8\build-vc80\sharedlibs\RelWithDebInfo\vc80.pdb'; linking object as if no debug info exception_handler.lib Warning 2 warning LNK4099: PDB 'vc80.pdb' was not found with '..\packages\lib\release\crash_generation_client.lib' or at 'C:\dev\hgbuilds\viewer-autobuildvs8\build-vc80\sharedlibs\RelWithDebInfo\vc80.pdb'; linking object as if no debug info crash_generation_client.lib Warning 3 warning LNK4099: PDB 'vc80.pdb' was not found with '..\packages\lib\release\common.lib' or at 'C:\dev\hgbuilds\viewer-autobuildvs8\build-vc80\sharedlibs\RelWithDebInfo\vc80.pdb'; linking object as if no debug info common.lib Error 4 error PRJ0019: A tool returned an error code from "Generating PROJECT_llmessage_TEST_lltemplatemessagedispatcher_ok.txt" llmessage_tests Error 5 error PRJ0019: A tool returned an error code from "Generating PROJECT_llupdaterservice_TEST_llupdaterservice_ok.txt" llupdaterservice_tests Error 6 error PRJ0019: A tool returned an error code from "Performing viewer_manifest copy" copy_w_viewer_manifest Warning 7 warning LNK4221: no public symbols found; archive member will be inaccessible llfunctorregistry.obj Error 8 fatal error RC1015: cannot open include file 'winres.h'. c:\dev\hgbuilds\viewer-autobuildvs8\indra\newview\res\viewerRes.rc 10 Error 9 error PRJ0019: A tool returned an error code from "Generating RelWithDebInfo/touched.bat" package From: twisted_l...@hotmail.com To: o...@lindenlab.com; opensource-dev@lists.secondlife.com Date: Sun, 6 Feb 2011 12:56:55 -0500 Subject: Re: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition. Ok, i'm an idiot and can't follow instructions So i reread Oz's msg and found i was using the wrong config and redid it with autobuild configure -c VCexpressRelWithDebInfo Then that part worked ok. If i then just used "autobuild build" it had the same fmod error as before. So i tried autobuild build -c VCexpressRelWithDebInfo --verbose and things went further but as someone else reported then i got 100's of errors about winsock2.h not being found. Why does it continue to try to build everything after it gets so many errors? Build complete: 12 Projects succeeded, 113 Projects failed, 2 Projects skipped ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition.
Ok, i'm an idiot and can't follow instructions So i reread Oz's msg and found i was using the wrong config and redid it with autobuild configure -c VCexpressRelWithDebInfo Then that part worked ok. If i then just used "autobuild build" it had the same fmod error as before. So i tried autobuild build -c VCexpressRelWithDebInfo --verbose and things went further but as someone else reported then i got 100's of errors about winsock2.h not being found. Why does it continue to try to build everything after it gets so many errors? Build complete: 12 Projects succeeded, 113 Projects failed, 2 Projects skipped ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition.
try autobuild --debug build -c VCexpressRelWithDebInfo From: Twisted Laws To: Oz Linden ; SLDEV Sent: Sun, February 6, 2011 11:38:11 AM Subject: Re: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition. c:\dev\hgbuilds\viewer-autobuildvs8>autobuild build -c OpenSourceRelWithDebInfo Since I wasn't sure of the exact command to run I also tried: c:\dev\hgbuilds\viewer-autobuildvs8>autobuild build -c OpenSourceRelWithDebInfo --verbose executing configure command cmake -DCMAKE_BUILD_TYPE:STRING=RelWithDebInfo -DUNA TTENDED:BOOL=OFF -DWORD_SIZE:STRING=32 -DROOT_PROJECT_NAME:STRING=SecondLife -G "Visual Studio 8 2005" -DSTANDALONE:BOOL=FALSE -DINSTALL_PROPRIETARY=FALSE -DFMO D=FALSE ../indra package libuuid has no installation information configured for platform windows package fontconfig has no installation information configured for platform windo ws -- We seem to have an artwork bundle in the tree - brilliant. -- Version of viewer is 2.6.0.0 -- Configuring done -- Generating done -- Build files have been written to: C:/dev/hgbuilds/viewer-autobuildvs8/build-v c80 executing build command devenv.com /build RelWithDebInfo SecondLife.sln 'devenv.com' is not recognized as an internal or external command, operable program or batch file. ERROR: building default configuration returned 1 For more information: try re-running your command with --verbose or --debug c:\dev\hgbuilds\viewer-autobuildvs8> ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition.
Since I wasn't sure of the exact command to run I also tried: c:\dev\hgbuilds\viewer-autobuildvs8>autobuild build -c OpenSourceRelWithDebInfo --verbose executing configure command cmake -DCMAKE_BUILD_TYPE:STRING=RelWithDebInfo -DUNA TTENDED:BOOL=OFF -DWORD_SIZE:STRING=32 -DROOT_PROJECT_NAME:STRING=SecondLife -G "Visual Studio 8 2005" -DSTANDALONE:BOOL=FALSE -DINSTALL_PROPRIETARY=FALSE -DFMO D=FALSE ../indra package libuuid has no installation information configured for platform windows package fontconfig has no installation information configured for platform windo ws -- We seem to have an artwork bundle in the tree - brilliant. -- Version of viewer is 2.6.0.0 -- Configuring done -- Generating done -- Build files have been written to: C:/dev/hgbuilds/viewer-autobuildvs8/build-v c80 executing build command devenv.com /build RelWithDebInfo SecondLife.sln 'devenv.com' is not recognized as an internal or external command, operable program or batch file. ERROR: building default configuration returned 1 For more information: try re-running your command with --verbose or --debug c:\dev\hgbuilds\viewer-autobuildvs8> ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition.
The autobuild configure -c OpenSourceRelWithDebInfo worked fine if I run it from a Visual C++ command prompt but not in a cygwin window. But the build fails with an expected (??) error with fmod. c:\dev\hgbuilds\viewer-autobuildvs8>autobuild build unable to download file: Traceback (most recent call last): File "C:\Python26\Lib\site-packages\autobuild\common.py", line 243, in downloa d_package file(cachename, 'wb').write(urllib2.urlopen(package).read()) File "C:\Python26\lib\urllib2.py", line 124, in urlopen return _opener.open(url, data, timeout) File "C:\Python26\lib\urllib2.py", line 383, in open response = self._open(req, data) File "C:\Python26\lib\urllib2.py", line 401, in _open '_open', req) File "C:\Python26\lib\urllib2.py", line 361, in _call_chain result = func(*args) File "C:\Python26\lib\urllib2.py", line 1130, in http_open return self.do_open(httplib.HTTPConnection, req) File "C:\Python26\lib\urllib2.py", line 1105, in do_open raise URLError(err) URLError: ERROR: failed to download http://s3-proxy.lindenlab.com/private-builds-secondlif e-com/hg/repo/merov_fmod-autobuild/rev/219050/arch/CYGWIN/installer/fmod-3.75-wi ndows-20110113.tar.bz2 For more information: try re-running your command with --verbose or --debug CMake Error at cmake/Prebuilt.cmake:51 (message): Failed to download or unpack prebuilt 'fmod'. Process returned 1. Call Stack (most recent call first): cmake/FMOD.cmake:12 (use_prebuilt_binary) llaudio/CMakeLists.txt:8 (include) -- Configuring incomplete, errors occurred! ERROR: configuring default configuration returned 1 For more information: try re-running your command with --verbose or --debug c:\dev\hgbuilds\viewer-autobuildvs8> ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition.
I'm getting dozens of these errors fatal error C1083: Cannot open include file: 'winsock2.h': No such file or directory and fatal error C1083: Cannot open include file: 'windows.h': No such file or directory Seems that it is not using the Include directories list. -- Ima Mechanique ima.mechanique(at)blueyonder.co.uk ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition.
14773 (21ef0a07c2cd) OPEN-1 WORKAROUND correct build arg Build complete: 125 Projects succeeded, 0 Projects failed, 2 Projects skipped C:\lindenhg\viewer-autobuildvs8> From: Oz Linden (Scott Lawrence) To: opensource-dev@lists.secondlife.com Sent: Sun, February 6, 2011 9:40:52 AM Subject: Re: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition. On 2011-02-06 9:15, Oz Linden (Scott Lawrence) wrote: > I've created a repo sync'ed up to the latest viewer-development, and > with this workaround (I renamed the configuration > VCexpressRelWithDebInfo to make it stand out a bit more). If folks > with VS Express (2005) could please test it : > > https://bitbucket.org/oz_linden/viewer-autobuildvs8 > > I'm running a test in TeamCity now to make sure that it does not > bother the production builds. > > I don't consider this a real fix for the problem (now tracked as > OPEN-1, incidentally), but it's a good enough workaround that we could > lower the severity below Showstopper and remove this block on merging > autobuild into viewer-development. > > That would leave the only remaining Showstopper OPEN-4 (using Fmod in > an autobuild), which shouldn't be too hard to document some workaround > for. > Please test (or retest, as the case may be) using the above repo at changeset 21ef0a07c2cd or later... Thanks to NickyP, JonathanYap, and archer for developing and testing this workaround. ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition.
On 2011-02-06 9:15, Oz Linden (Scott Lawrence) wrote: > I've created a repo sync'ed up to the latest viewer-development, and > with this workaround (I renamed the configuration > VCexpressRelWithDebInfo to make it stand out a bit more). If folks > with VS Express (2005) could please test it : > > https://bitbucket.org/oz_linden/viewer-autobuildvs8 > > I'm running a test in TeamCity now to make sure that it does not > bother the production builds. > > I don't consider this a real fix for the problem (now tracked as > OPEN-1, incidentally), but it's a good enough workaround that we could > lower the severity below Showstopper and remove this block on merging > autobuild into viewer-development. > > That would leave the only remaining Showstopper OPEN-4 (using Fmod in > an autobuild), which shouldn't be too hard to document some workaround > for. > Please test (or retest, as the case may be) using the above repo at changeset 21ef0a07c2cd or later... Thanks to NickyP, JonathanYap, and archer for developing and testing this workaround. ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition.
I've created a repo sync'ed up to the latest viewer-development, and with this workaround (I renamed the configuration VCexpressRelWithDebInfo to make it stand out a bit more). If folks with VS Express (2005) could please test it : https://bitbucket.org/oz_linden/viewer-autobuildvs8 I'm running a test in TeamCity now to make sure that it does not bother the production builds. I don't consider this a real fix for the problem (now tracked as OPEN-1, incidentally), but it's a good enough workaround that we could lower the severity below Showstopper and remove this block on merging autobuild into viewer-development. That would leave the only remaining Showstopper OPEN-4 (using Fmod in an autobuild), which shouldn't be too hard to document some workaround for. ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Friends Permissions
On 02/06/2011 02:55 PM, Trilo Byte wrote: > [...] permissions the people on my friends list have (see me online, locate > me on the map, move my objects, etc), but I can't figure out how to change > those settings. It used to be on the Notes & Privacy tab of the Profile, but > the web profile doesn't have any such option. Any ideas? On the web profile, button *Action* > *Set Privacy*. Though, I must say I'd prefer if this was possible directly from the friends list. Boroondas ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] Friends Permissions
Please forgive the silly question, but I seemed to have missed something in the transition to web profiles. On the Friends sidebar panel I can see the icons that show what permissions the people on my friends list have (see me online, locate me on the map, move my objects, etc), but I can't figure out how to change those settings. It used to be on the Notes & Privacy tab of the Profile, but the web profile doesn't have any such option. Any ideas? TriloByte Zanzibar ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: VWR-22220 Chat preferences > font size should increase size of input text as well
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/139/ --- (Updated Feb. 6, 2011, 12:54 a.m.) Review request for Viewer. Changes --- Removed changes to bottomtray.cpp Summary --- This is a request for help. I am trying to learn more about c++ and how variables in one class are accessed from another. For someone who knows what they are doing this is probably a pretty easy question. I have been able to set the font size on the chat input box when it is created in llbottomtray.cpp. I would like to do the same thing when someone clicks in that box to input text; it is possible they have changed the font setting and I would like to apply the size there as well, but I am stuck on how to do this. I think the right place to do this is in llchatbar.cpp/LLChatBar::onInputEditorGainFocus(). I have tried all kinds of wrong ways but at this point am stymied. Exact steps on how to proceed would be appreciated. This addresses bug vwr-0. http://jira.secondlife.com/browse/vwr-0 Diffs (updated) - indra/llui/lllineeditor.h 3d2e71443c58 indra/llui/lllineeditor.cpp 3d2e71443c58 indra/newview/llchatbar.h 3d2e71443c58 indra/newview/llchatbar.cpp 3d2e71443c58 indra/newview/llnearbychatbar.cpp 3d2e71443c58 Diff: http://codereview.secondlife.com/r/139/diff Testing --- Thanks, Jonathan ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
