Re: [opensource-dev] STORM-1023 (was OPEN-4) : fmod
See my comment here: https://jira.secondlife.com/browse/STORM-1023?focusedCommentId=244786 https://jira.secondlife.com/browse/STORM-1023?focusedCommentId=244786page= com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-244 786 page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comme nt-244786 This might be a better solution as then the files could also be renamed to properly match what cmake is looking for plus when autobuild sets up the build tree the needed files would be placed automatically with no problems during the configuration process as they would be resident in the OS developers install.cache directory with the rest of the needed packaged for developers that DL libs form LL. And as I do not realy know the how to set up one of these lib systems assistance would be greatly welcomed. From: opensource-dev-boun...@lists.secondlife.com [mailto:opensource-dev-boun...@lists.secondlife.com] On Behalf Of Nicky Perian Sent: Friday, February 25, 2011 4:01 PM To: Philippe (Merov) Bossut Cc: opensource-dev@lists.secondlife.com Subject: Re: [opensource-dev] STORM-1023 (was OPEN-4) : fmod I am using oz's viewer-autobuild2010 with my mod's for VS2010 and your changes at the tip. https://bitbucket.org/NickyP/viewer-autobuild2010-wip this plus your changes at tip. I would not be able to test otherwise. Nicky _ From: Philippe (Merov) Bossut me...@lindenlab.com To: Nicky Perian nickyper...@yahoo.com Cc: opensource-dev@lists.secondlife.com Sent: Fri, February 25, 2011 12:33:27 PM Subject: Re: [opensource-dev] STORM-1023 (was OPEN-4) : fmod Hi Nicky, On Fri, Feb 25, 2011 at 8:03 AM, Nicky Perian nickyper...@yahoo.com wrote: I have -DFMOD:BOOL=ON on configure cl and DFMOD=TRUE in autobuild.xml Attempt is made to build with fmod but, the headers and libraries still need to be manually copied. Was that the intent? Nope. Looks like either FindFMOD couldn't locate the files or it wasn't invoked at all. Could you tell me which autobuild configure arguments you use? Again, thanks for the test. Looks like I've more coding to do. Cheers, - Merov _ No virus found in this message. Checked by AVG - www.avg.com Version: 10.0.1204 / Virus Database: 1435/3468 - Release Date: 02/25/11 ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] Review Request: OPEN-38: autobuild support for StandAlone
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/167/ --- Review request for Viewer. Summary --- Oz: please merge into your repository. This addresses bug OPEN-38. Diffs - indra/cmake/FindGLH.cmake PRE-CREATION indra/cmake/GLH.cmake PRE-CREATION indra/cmake/LLRender.cmake 5f0ab9443ece indra/cmake/LLSharedLibs.cmake 5f0ab9443ece indra/cmake/Linking.cmake 5f0ab9443ece indra/linux_crash_logger/CMakeLists.txt 5f0ab9443ece Diff: http://codereview.secondlife.com/r/167/diff Testing --- configures, compiles, runs. Thanks, Aleric ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] STORM-1023 (was OPEN-4) : fmod
After creating a local repository like the one Nicky has and running autobuild configure -c VC10msbuildRelWithDebInfo I get an error in FindFMOD stating cannot find FMOD and the configure fails. From: opensource-dev-boun...@lists.secondlife.com [mailto:opensource-dev-boun...@lists.secondlife.com] On Behalf Of WolfPup Lowenhar Sent: Saturday, February 26, 2011 8:58 AM To: OpenSource Mailing List Subject: Re: [opensource-dev] STORM-1023 (was OPEN-4) : fmod See my comment here: https://jira.secondlife.com/browse/STORM-1023?focusedCommentId=244786 https://jira.secondlife.com/browse/STORM-1023?focusedCommentId=244786page= com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-244 786 page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comme nt-244786 This might be a better solution as then the files could also be renamed to properly match what cmake is looking for plus when autobuild sets up the build tree the needed files would be placed automatically with no problems during the configuration process as they would be resident in the OS developers install.cache directory with the rest of the needed packaged for developers that DL libs form LL. And as I do not realy know the how to set up one of these lib systems assistance would be greatly welcomed. From: opensource-dev-boun...@lists.secondlife.com [mailto:opensource-dev-boun...@lists.secondlife.com] On Behalf Of Nicky Perian Sent: Friday, February 25, 2011 4:01 PM To: Philippe (Merov) Bossut Cc: opensource-dev@lists.secondlife.com Subject: Re: [opensource-dev] STORM-1023 (was OPEN-4) : fmod I am using oz's viewer-autobuild2010 with my mod's for VS2010 and your changes at the tip. https://bitbucket.org/NickyP/viewer-autobuild2010-wip this plus your changes at tip. I would not be able to test otherwise. Nicky _ From: Philippe (Merov) Bossut me...@lindenlab.com To: Nicky Perian nickyper...@yahoo.com Cc: opensource-dev@lists.secondlife.com Sent: Fri, February 25, 2011 12:33:27 PM Subject: Re: [opensource-dev] STORM-1023 (was OPEN-4) : fmod Hi Nicky, On Fri, Feb 25, 2011 at 8:03 AM, Nicky Perian nickyper...@yahoo.com wrote: I have -DFMOD:BOOL=ON on configure cl and DFMOD=TRUE in autobuild.xml Attempt is made to build with fmod but, the headers and libraries still need to be manually copied. Was that the intent? Nope. Looks like either FindFMOD couldn't locate the files or it wasn't invoked at all. Could you tell me which autobuild configure arguments you use? Again, thanks for the test. Looks like I've more coding to do. Cheers, - Merov _ No virus found in this message. Checked by AVG - www.avg.com Version: 10.0.1204 / Virus Database: 1435/3468 - Release Date: 02/25/11 _ No virus found in this message. Checked by AVG - www.avg.com Version: 10.0.1204 / Virus Database: 1435/3469 - Release Date: 02/26/11 ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: VWR-24333: Hardening against use of getLindenUserDir() before logging in.
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/91/#review386 --- indra/llvfs/lldir.cpp http://codereview.secondlife.com/r/91/#comment272 I know we already have a lot of methods taking boolean arguments, but it's probably worth mentioning http://doc.qt.nokia.com/qq/qq13-apis.html#thebooleanparametertrap here. (I.e., boolean arguments make the calls of the method harder to read, when the method name doesn't already imply the semantics of the argument. You can give the reader a hint towards the semantics by using nicely named enums instead.) indra/newview/llappviewer.cpp http://codereview.secondlife.com/r/91/#comment273 E.g. here, it's impossible to guess what the true indicates. Either you already know, or you have to look it up. - Boroondas On Jan. 14, 2011, 1:05 p.m., Aleric Inglewood wrote: --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/91/ --- (Updated Jan. 14, 2011, 1:05 p.m.) Review request for Viewer. Summary --- Without this patch, getLindenUserDir() is sometimes used without checking if it returns an empty value, resulting in trying to open an empty file and then gracefully recovering from that. So, this patch doesn't really fix a bug. However it might prevent one in the future. Note that this DID lead to a bug in Viewer 1 code, so it's possible. The main threat is that some singleton class that uses getLindenUserDir (indirectly) is instantiated before logging in: A singleton is only created once and when it is initialized with an empty getLindenUserDir() then that can remain. This patch aborts when the viewer is compiled in debug mode (not in release mode, when it will do what it did before this patch) and when getLindenUserDir() is called before it was initialized, unless the developer explicitely passes 'true' (empty_ok) to getLindenUserDir, signaling that they considered the possibility that the function is being called before the user logged in. This addresses bug VWR-24333. http://jira.secondlife.com/browse/VWR-24333 Diffs - indra/llvfs/lldir.h 422f636c3343 indra/llvfs/lldir.cpp 422f636c3343 indra/newview/llappviewer.cpp 422f636c3343 indra/newview/llbottomtray.cpp 422f636c3343 indra/newview/llfilepicker.cpp 422f636c3343 indra/newview/llnavigationbar.cpp 422f636c3343 indra/newview/llsearchhistory.h 422f636c3343 indra/newview/llurlhistory.cpp 422f636c3343 indra/newview/llviewerinventory.cpp 422f636c3343 indra/newview/llviewermedia.cpp 422f636c3343 indra/newview/llvoiceclient.cpp 422f636c3343 Diff: http://codereview.secondlife.com/r/91/diff Testing --- Thanks, Aleric ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] STORM-1023 (was OPEN-4) : fmod
to get fmod working i used this changeset and used autobuild --debug configure -c VC10msbuildRelWithDebInfo -- -DLL_TESTS:BOOL=OFF -DFMOD:BOOL=ON -DFMOD_INCLUDE_DIR=C:\Dev\fmod -DFMOD_LIBRARY=C:\Dev\fmod successfully compiles, runs and has sound (not standalone) From: me...@lindenlab.com Date: Thu, 24 Feb 2011 22:03:46 -0800 To: opensource-dev@lists.secondlife.com Subject: [opensource-dev] STORM-1023 (was OPEN-4) : fmod Hi, I worked on this and submitted what I think should solve the problem on a dev repo forked from oz_linden/viewer-autobuild: https://bitbucket.org/merov_linden/viewer-autobuild-open-4/changeset/e439abf2be8e If autobuild interested people building from home STANDALONE and NOT STANDALONE could review that proposal and test the changeset, that would help tremendously. Cheers, - Merov ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] Review Request: on-line fix for OPEN-39: (standalone) bitpack_test.o: No such file or directory
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/168/
---
Review request for Viewer and Aleric Inglewood.
Summary
---
On standalone, -I${TUT_INCLUDE_DIR} was added to the compile flags for
integration tests of llcommon when TUT_INCLUDE_DIR might not have been set yet.
This lead to a flag -I, which would confuse g++ and lead to the tests' object
files not being found.
This change makes sure that TUT_INCLUDE_DIR is set by including Tut.cmake,
which is responsible for setting it.
This addresses bug OPEN-39.
http://jira.secondlife.com/browse/OPEN-39
Diffs
-
doc/contributions.txt 1013caf84c2e
indra/cmake/LLAddBuildTest.cmake 1013caf84c2e
Diff: http://codereview.secondlife.com/r/168/diff
Testing
---
Clean rebuild with LL_TESTS ON (see also repro instructions on jira)
Thanks,
Boroondas
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-1001: Viewer needlessly hits the ObjectMedia cap with thousands of requests
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/162/#review387
---
indra/llprimitive/lltextureentry.cpp
http://codereview.secondlife.com/r/162/#comment274
Is this creation/destruction of mMediaEntry taken care off elsewhere
already?
- Boroondas
On Feb. 22, 2011, 11:12 a.m., Kitty Barnett wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/162/
---
(Updated Feb. 22, 2011, 11:12 a.m.)
Review request for Viewer.
Summary
---
S32 LLTextureEntry::setMediaTexGen(U8 media) would appear to be the root
cause of the bug:
The header file suggests that:
// The Media Tex Gen values are bits in a bit field:
// +--+
// | .TTM | M = Media Flags (web page), T = LLTextureEntry::eTexGen, . =
unused
// | 76543210 |
// +--+
const S32 TEM_MEDIA_MASK = 0x01;
const S32 TEM_TEX_GEN_MASK= 0x06;
and while LLTextureEntry::setTexGen() and LLTextureEntry::setMediaFlags()
each properly mask off the supplied parameter with their respective bit mask,
setMediaTexGen() will always return TEM_CHANGE_MEDIA even if only texgen has
changed while the media flag hasn't (causing
LLVOVolume::processUpdateMessage() to queue a request to the cap when it
shouldn't).
Changing it to:
S32 LLTextureEntry::setMediaTexGen(U8 media)
{
S32 result = setTexGen(media TEM_TEX_GEN_MASK);
result |= setMediaFlags(media TEM_MEDIA_MASK);
return result;
}
appears to resolve the issue completely (the cap isn't hit unless an object
nearby has media on it, or changes its URL)
This addresses bug STORM-1001.
http://jira.secondlife.com/browse/STORM-1001
Diffs
-
indra/llprimitive/lltextureentry.cpp UNKNOWN
Diff: http://codereview.secondlife.com/r/162/diff
Testing
---
Thanks,
Kitty
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: OPEN-38: autobuild support for StandAlone
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/167/#review388 --- Can you give some instructions on how to do a standalone build with these changes? I tried the following: patch -p1 /home/das-g/slsrc/patches/autobuild-standalone.diff autobuild install glh_linear autobuild configure -c OpenSourceStandAloneRelWithDebInfo but this fails with: CMake Error at cmake/FindGLH.cmake:26 (message): Could not find GLH Thanks - Boroondas On Feb. 26, 2011, 6:56 a.m., Aleric Inglewood wrote: --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/167/ --- (Updated Feb. 26, 2011, 6:56 a.m.) Review request for Viewer. Summary --- Oz: please merge into your repository. This addresses bug OPEN-38. Diffs - indra/cmake/FindGLH.cmake PRE-CREATION indra/cmake/GLH.cmake PRE-CREATION indra/cmake/LLRender.cmake 5f0ab9443ece indra/cmake/LLSharedLibs.cmake 5f0ab9443ece indra/cmake/Linking.cmake 5f0ab9443ece indra/linux_crash_logger/CMakeLists.txt 5f0ab9443ece Diff: http://codereview.secondlife.com/r/167/diff Testing --- configures, compiles, runs. Thanks, Aleric ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Forum for ATI, Apple and FBO problem
I've written to AMD support and got this answer which reject the responsibility to Apple : If your PC is an Apple system, we recommend you contact to Apple for the suppport for OpenGL for Mac. If you purchased one of our graphics cards designed for Mac sytem, for example the Radeon HD 3870 Mac, then the first driver version is developed by us and the following ones by Apple. This is the reason why we recommend you to contact Apple for more informations regarding your application. Le 13 févr. 2011 à 12:47, Trilo Byte a écrit : As I understand the issue, the problem is on the ATI side (possibly their implementation of OpenGL), and is not specific to Apple. On Feb 12, 2011, at 5:56 PM, Laurent Bechir wrote: Hello, Some time ago, I've opened a bug report on Apple website concerning the problem of ATI cards with FBO which stops Mac users to use dynamic shadows. I know they are not officials, but they work quite well with Nvidia cards :). I've received an answer recently asking me for the full System Profiler Report of my machine. I was wondering if accumulating the experiences on that subject would help make the things move faster. So I've set up a forum where mac users wanting to do it could tell their experience with ATI card and join their full System Profiler Report with their experience. I would then put the link to the forum in my bug report. Do you think this could be a good idea ? Bug report : https://bugreport.apple.com/cgi-bin/WebObjects/RadarWeb.woa/24/wo/KGyze933oURhrNytyxPfAw/5.83.28.0.9 Forum : http://macati.madonie.org/ ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: OPEN-38: autobuild support for StandAlone
On Feb. 26, 2011, 2:44 p.m., Boroondas Gupte wrote: Can you give some instructions on how to do a standalone build with these changes? I tried the following: patch -p1 /home/das-g/slsrc/patches/autobuild-standalone.diff autobuild install glh_linear autobuild configure -c OpenSourceStandAloneRelWithDebInfo but this fails with: CMake Error at cmake/FindGLH.cmake:26 (message): Could not find GLH Thanks The usual way, you have to include the path where you installed your library to CMAKE_INCLUDE_PATH and CMAKE_LIBRARY_PATH. For GLH just CMAKE_INCLUDE_PATH is enough since it only exists of headers. hikaru:/usr/src/secondlife/viewers/snowstorm/viewer-autobuildecho $CMAKE_INCLUDE_PATH /usr/src/secondlife/llqtwebkit/install-imprudence/include:/usr/src/secondlife/viewers/snowstorm/viewer-autobuild/include:/sl/usr/include hikaru:/usr/src/secondlife/viewers/snowstorm/viewer-autobuildls -l /usr/src/secondlife/viewers/snowstorm/viewer-autobuild/include total 0 lrwxrwxrwx 1 aleric src 48 Feb 25 20:33 GL - ../linden/build-linux-x86_64/packages/include/GL/ lrwxrwxrwx 1 aleric src 49 Feb 25 20:33 glh - ../linden/build-linux-x86_64/packages/include/glh/ lrwxrwxrwx 1 aleric src 49 Feb 25 20:33 tut - ../linden/build-linux-x86_64/packages/include/tut/ As you see, I created symbolic links in some random directory (that I then added to CMAKE_INCLUDE_PATH) to whereever the respective packages are installed by an 'autobuild install'. I did that because if you add */packages/include to CMAKE_INCLUDE_PATH it finds ALL packages that you installed, which might not be what you want if you use the same source tree for standlone and non-standalone testing. - Aleric --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/167/#review388 --- On Feb. 26, 2011, 6:56 a.m., Aleric Inglewood wrote: --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/167/ --- (Updated Feb. 26, 2011, 6:56 a.m.) Review request for Viewer. Summary --- Oz: please merge into your repository. This addresses bug OPEN-38. Diffs - indra/cmake/FindGLH.cmake PRE-CREATION indra/cmake/GLH.cmake PRE-CREATION indra/cmake/LLRender.cmake 5f0ab9443ece indra/cmake/LLSharedLibs.cmake 5f0ab9443ece indra/cmake/Linking.cmake 5f0ab9443ece indra/linux_crash_logger/CMakeLists.txt 5f0ab9443ece Diff: http://codereview.secondlife.com/r/167/diff Testing --- configures, compiles, runs. Thanks, Aleric ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
