[opensource-dev] Daily Scrum Summary - Monday, March 7

2011-03-07 Thread Anya Kanevsky 
 Sprint 12, ends 03.21.11 Monday, March 7 General Notes
--

   - MMOTD: Merov

Team Status
--
 Merov Linden
--

*PAST*

   - MM : mostly code review, no push
   - STORM-1023 : fmod : got the various strategies to work on Mac, made
   3p-fmod public, made local package URL work on Windows, need to modify
   Copy3rdPartyLibs.cmake to make the path specification work on Windows.

*FUTURE*

   - MM: 4 JIRAs to merge, update version to 2.5.2
   - STORM-1023 : fmod : modify Copy3rdPartyLibs.cmake to make the path
   specification work on Windows
   - STORM-987 : llimage_libtest: Add image stats output

*IMPEDIMENTS*

   - none

Oz Linden
--

*PAST*

   - Open Development User Group
   - Internal process discussions

*FUTURE*

   - Autobuild integration and testing
   - Internal process meetings

*IMPEDIMENTS*

   - none

Bao Linden
--

*PAST*

   - finished STORM-1026
   - OOO for half day

*FUTURE*

   - start to investigate STORM-948: meta-issue for bad_alloc exceptions

*IMPEDIMENTS*

   - none

Wolf Linden
--

*PAST*

   - Vacation

*FUTURE*

   - Open issues (will be working my way through "needs design" issues to
   make updates/comments)

*IMPEDIMENTS*

   - none

Grumpity ProductEngine
--

*PAST*

   - crashhunting - lots of new crashes in release, and some old ones we
   thought closed.
   - last-minute knowledge transfer
  - STORM-326 is deferred
  - Vadim investigating STORM-756
   - triage unscheduled issues in STORM
   - PO build - approved several, need to finish with rest.

*FUTURE*

   - crashhunting
   - review remaining results from Usability study
   - meet with Geo
   - get Wolf added as assignee for STORM project
   - triage unscheduled issues in STORM.
  - please remember to put a fix-version for any issues you create in
  STORM! otherwise, they’re lost for-nearly-ever
  - STORM-1027 (memory project) Bao/Bambers - should the QART be
  assigned to someone?
  - STORM-1005 Bao - current sprint?
  - Wolf - review STORM-323

*IMPEDIMENTS*

   - Tuesday, March 8th is a holiday in Ukraine. Paul, Seth, and the QA team
   are also off on Monday.
   - move triages to 11am this week?

Paul ProductEngine
--

*PAST*

   - BUG STORM-357 (Gestures button is in the pressed state after
   drag-n-drop but gestures list isn't visible)
  - WIP. Stuck in the problem with showing the gesture list in wrong
  place. Hope it wont take more than 4-5 hours to solve it.

*FUTURE*

   - STORM-357 (Gestures button is in the pressed state after drag-n-drop
   but gestures list isn't visible)

*IMPEDIMENTS*

   - none

Seth ProductEngine
--

*PAST*

   - BUG (STORM-380) There is a little delay in sound when gesture first
   time played
  - Investigated. Could not find the way to fix it for now. Commented in
  Jira about possible solutions.
   - Code review.

*FUTURE*

   - Pick some tasks from bug queue or sprint 12.

*IMPEDIMENTS*

   - BUG (STORM-380) There is a little delay in sound when gesture first
   time played
  - Need help from someone who is more familiar with gestures,
  animations, sound playback.

Andrey ProductEngine
--

*PAST*

   - continued with I18N testing against the v-d branch
  - almost done except German and Japanese locales
  - 9 issues have been reported today

*FUTURE*

   - holidays 7-8 March

*IMPEDIMENTS*

   - none

Jonathan Yap
--

*PAST*

   - Emailed Grumpity about VWR-25078 ([crash] ERROR:
   LLViewerObjectList::renderObjectsForMap:ASSERT (!objectp->isDead()))
   - SVC-2820 (Allow group IMs to be muted)
  - Pretty much finished being able to mute all aspects of a group (IMs,
  toasts, chicklets, voice, notices) only to realize it was mostly
a waste of
  time as toasts and notices can already be disabled other ways.

*FUTURE*

*IMPEDIMENTS*

   - STORM - 956
  - File message_template.msg needs to be pushed into viewer code tree
  from server code tree. Long term solution expected late March.

Cummere Mayo
--

*PAST*

   - jira stuff
   - more ccnaf stuff
   - new post on http://lindenw.blogspot.com/

*FUTURE*

   - same
   - track down amanda about moderation issues on new community site
   - talk to oz about community role for snowstorm peoples

*IMPEDIMENTS*

   - twisted hunt/steam hunt (will be major impediments all month)
   - dealing with a persistent small group of rz griefers...
   -
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: quote all COPY_IF_DIFFERENT argument variables (fixes OPEN-36: error "COPY_IF_DIFFERENT Macro invoked with incorrect arguments" due to insufficient quoting)

2011-03-07 Thread Merov Linden 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/182/#review433
---

Ship it!


Seems good.

- Merov


On March 7, 2011, 4:44 p.m., Boroondas Gupte wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/182/
> ---
> 
> (Updated March 7, 2011, 4:44 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Searched all uses of the copy_if_different CMake macro, and where variables 
> were passed as arguments, double-quoted them.
> 
> 
> This addresses bug OPEN-36.
> http://jira.secondlife.com/browse/OPEN-36
> 
> 
> Diffs
> -
> 
>   indra/cmake/Copy3rdPartyLibs.cmake ed35dc91644b 
>   indra/copy_win_scripts/CMakeLists.txt ed35dc91644b 
>   indra/test_apps/llplugintest/CMakeLists.txt ed35dc91644b 
> 
> Diff: http://codereview.secondlife.com/r/182/diff
> 
> 
> Testing
> ---
> 
> Successfully configured with
> autobuild configure -c OpenSourceStandAloneRelWithDebInfo
> 
> (Building still fails due to unrelated issues.)
> 
> 
> Thanks,
> 
> Boroondas
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1018 Improve error messaging for External Editor feature

2011-03-07 Thread Merov Linden 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/179/#review432
---


I like the intent. In the code though, I don't really understand why the 
EC_NOT_SPECIFIED case is treated differently than other error messages. I fail 
to understand why this needs a "custom" message (in the panel xml instead of 
strings.xml) and why having it in the panel xml has any advantage.

- Merov


On March 7, 2011, 9:16 a.m., Vadim ProductEngine wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/179/
> ---
> 
> (Updated March 7, 2011, 9:16 a.m.)
> 
> 
> Review request for Viewer and Seth ProductEngine.
> 
> 
> Summary
> ---
> 
> Let the user know what's wrong with external editor.
> 
> Added meaningful messages for the following errors:
> * Editor not specified.
> * Error parsing command line.
> * Specified binary not found.
> * Editor failed to run.
> 
> All the messages are translatable.
> 
> 
> This addresses bug STORM-1018.
> http://jira.secondlife.com/browse/STORM-1018
> 
> 
> Diffs
> -
> 
>   indra/newview/llexternaleditor.h ef2df52563bb 
>   indra/newview/llexternaleditor.cpp ef2df52563bb 
>   indra/newview/llfloateruipreview.cpp ef2df52563bb 
>   indra/newview/llpreviewscript.cpp ef2df52563bb 
>   indra/newview/skins/default/xui/en/floater_ui_preview.xml ef2df52563bb 
>   indra/newview/skins/default/xui/en/panel_script_ed.xml ef2df52563bb 
>   indra/newview/skins/default/xui/en/strings.xml ef2df52563bb 
> 
> Diff: http://codereview.secondlife.com/r/179/diff
> 
> 
> Testing
> ---
> 
> Test cases:
> 1. Use a path containing spaces without enclosing it with double quotes 
> (/path to/editor).
>Expected: the "not found" message.
> 2. Specify empty path ().
>Expected: the "not found" message.
> 3. Try using an odd number of double quotes ("/path to/editor "%s").
>Expected: the "parse error" message.
> 4. Specifying a nonexistent editor (/non/existent/editor).
>Expected: the "not found" message.
> 5. Specify a valid editor path (/usr/bin/editor).
>Expected: the editor is executed.
> 
> The command can be specified with the ExternalEditor debug setting or an 
> environment variable: LL_SCRIPT_EDITOR for script editor and LL_XUI_EDITOR 
> for the XUI preview tool. In the latter case you can also override the 
> command via the "Editor Path" floater input field.
> 
> 
> Thanks,
> 
> Vadim
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1044 Improved message template checking.

2011-03-07 Thread Merov Linden 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/174/#review431
---

Ship it!


This seems to be good.

- Merov


On March 3, 2011, 2:20 p.m., Kelly Washington wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/174/
> ---
> 
> (Updated March 3, 2011, 2:20 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Improved message template checking.
> * If no changes have been made to the message template the check is local 
> only and trivial.
> * If changes have been made to the message template then compatibility is 
> verified on the first build after the change instead of when they package.
> * Automated systems can use --force to force full message template 
> verification
> 
> 
> This addresses bug STORM-1044.
> http://jira.secondlife.com/browse/STORM-1044
> 
> 
> Diffs
> -
> 
>   indra/cmake/TemplateCheck.cmake 3683d7c533f9 
>   indra/newview/CMakeLists.txt 3683d7c533f9 
>   scripts/messages/message_template.msg.sha1 PRE-CREATION 
>   scripts/template_verifier.py 3683d7c533f9 
> 
> Diff: http://codereview.secondlife.com/r/174/diff
> 
> 
> Testing
> ---
> 
> * Built the viewer and verified only the hash is checked.
> * Changed the template and verified full verification happens and a new sha1 
> saved.
> 
> 
> Thanks,
> 
> Kelly
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1001: Viewer needlessly hits the "ObjectMedia" cap with thousands of requests

2011-03-07 Thread Merov Linden 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/162/#review430
---

Ship it!


Satisfied with Kelly's answer to my comment. I don't have anything against that 
fix now.

- Merov


On Feb. 22, 2011, 11:12 a.m., Kitty Barnett wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/162/
> ---
> 
> (Updated Feb. 22, 2011, 11:12 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> S32 LLTextureEntry::setMediaTexGen(U8 media) would appear to be the root 
> cause of the bug:
> 
> The header file suggests that:
> 
> // The Media Tex Gen values are bits in a bit field:
> // +--+
> // | .TTM | M = Media Flags (web page), T = LLTextureEntry::eTexGen, . = 
> unused
> // | 76543210 |
> // +--+
> const S32 TEM_MEDIA_MASK  = 0x01;
> const S32 TEM_TEX_GEN_MASK= 0x06;
> 
> and while LLTextureEntry::setTexGen() and LLTextureEntry::setMediaFlags() 
> each properly mask off the supplied parameter with their respective bit mask, 
> setMediaTexGen() will always return TEM_CHANGE_MEDIA even if only texgen has 
> changed while the media flag hasn't (causing 
> LLVOVolume::processUpdateMessage() to queue a request to the cap when it 
> shouldn't).
> 
> Changing it to:
> 
> S32 LLTextureEntry::setMediaTexGen(U8 media)
> {
>   S32 result = setTexGen(media & TEM_TEX_GEN_MASK);
>   result |= setMediaFlags(media & TEM_MEDIA_MASK);
>   return result;
> }
> 
> appears to resolve the issue completely (the cap isn't hit unless an object 
> nearby has media on it, or changes its URL)
> 
> 
> This addresses bug STORM-1001.
> http://jira.secondlife.com/browse/STORM-1001
> 
> 
> Diffs
> -
> 
>   indra/llprimitive/lltextureentry.cpp UNKNOWN 
> 
> Diff: http://codereview.secondlife.com/r/162/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kitty
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: the fix for STORM-1026: Viewer crahes while trying to reset Graphics quality

2011-03-07 Thread Xiaohong Bao 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/180/
---

(Updated March 7, 2011, 9:33 p.m.)


Review request for Viewer and Merov Linden.


Summary (updated)
---

The changeset: 781a5ad220e3


This addresses bug STORM-1026.
http://jira.secondlife.com/browse/STORM-1026


Diffs (updated)
-

  indra/llrender/llvertexbuffer.cpp 767feb16f05f 

Diff: http://codereview.secondlife.com/r/180/diff


Testing
---


Thanks,

Xiaohong

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: fix for STORM-1046:[crashhunters] crash in LWorld::removeRegion STORM-1014: Viewer crash in LLSurface::getWaterHeight STORM-1047:[crashhunters] crash at LLViewerObject

2011-03-07 Thread Xiaohong Bao 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/189/
---

Review request for Viewer and Merov Linden.


Summary
---

changeset: e4c78fbe827f

Merov: sorry I can not upload the diff because the parent of this changeset is 
still in the queue of the codereview.


This addresses bugs STORM-1014, STORM-1046 and STORM-1047.
http://jira.secondlife.com/browse/STORM-1014
http://jira.secondlife.com/browse/STORM-1046
http://jira.secondlife.com/browse/STORM-1047


Diffs
-


Diff: http://codereview.secondlife.com/r/189/diff


Testing
---


Thanks,

Xiaohong

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] PO Test build (222938)

2011-03-07 Thread Philippe (Merov) Bossut 
Hi there,

Here's a new PO test build:

http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/merov_viewer-development-import/rev/222938/index.html

Fixes it contains:
* STORM-1016 : Crash: ctrl-shift-w hides undocked Side Bar panels if almost
any floater is opened
* STORM-1038 : Viewer crash in texture cache pruning on startup
* STORM-1040 : Text that shows what Beacons you are viewing is always in
English

Still in there but not yet merge since no usable feedback:
* STORM-1020 : It is sometimes necessary to press ALT+CTRL+D twice to get
the Debug menu on the login screen
* STORM-1036 : Remove the unused "How to create a new Classified ad"
notification from XUI

Cheers,
- Merov
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Boost libraries and includes. For testing and comments (good and bad)

2011-03-07 Thread Nicky Perian 
Boost libraries and includes for 1x and 2x code bases.  Built with VS 2010. 
Have 
complied on imprudence 1.4 and viewer-autobuild2010.

diff's from LL 3p are  include/coroutine and 1x libraries.

This boost isnot included in any autobuild repository's autobuild.xml. Just 
needed a place to allow for downloading.


https://bitbucket.org/NickyP/viewer-autobuild2010-wip/downloads/boost_1_45_VC100_libs_inc_patch4073.tar.bz2


https://bitbucket.org/NickyP/viewer-autobuild2010-wip/downloads/50525693e357a7b86a56b72b5434f3b2%20boost_1_45_VC100_libs_inc_patch4073.tar.bz2.md5


  ___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: make PREHASH variables char const* const (fixes VWR-24487: llurlentry_stub.cpp:196: error: deprecated conversion from string constant to 'char*')

2011-03-07 Thread Aleric Inglewood 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/100/#review429
---

Ship it!


Perfect.

- Aleric


On March 7, 2011, 3:51 p.m., Boroondas Gupte wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/100/
> ---
> 
> (Updated March 7, 2011, 3:51 p.m.)
> 
> 
> Review request for Viewer and Seth ProductEngine.
> 
> 
> Summary
> ---
> 
> For the reason for this change, see 
> https://jira.secondlife.com/browse/VWR-24487 and 
> https://jira.secondlife.com/browse/VWR-24522
> 
> What I did:
> In indra/llmessage/message_prehash.(h|cpp), I turned everything into constant 
> pointers to constants by search/replace. Then I tried to compile and added 
> const qualifiers in dependent code as needed to stop the compiler complaining.
> 
> Note that comments in indra/llmessage/message_prehash.(h|cpp) say these files 
> have been generated from the message template. Because this generation might 
> not have been a one-off thing, I changed the generating code, too, so it 
> won't override this change here when the generation happens the next time. 
> However, that part of the code is not called by Viewer, although the relevant 
> function — dump_prehash_files() — ends up in the Viewer binary. That function 
> probably gets called by the simulator, when one runs the latter with 
> -prehash. (See 
> https://bitbucket.org/lindenlab/viewer-development/src/fc7e5dcf3059/indra/llmessage/message.cpp#cl-2532
>  )
> 
> 
> This addresses bug VWR-24487.
> http://jira.secondlife.com/browse/VWR-24487
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt fc7e5dcf3059 
>   indra/llmessage/message.cpp fc7e5dcf3059 
>   indra/llmessage/message_prehash.h fc7e5dcf3059 
>   indra/llmessage/message_prehash.cpp fc7e5dcf3059 
>   indra/llprimitive/llprimitive.h fc7e5dcf3059 
>   indra/llprimitive/llprimitive.cpp fc7e5dcf3059 
>   indra/llprimitive/llvolumemessage.h fc7e5dcf3059 
>   indra/llprimitive/llvolumemessage.cpp fc7e5dcf3059 
>   indra/llui/tests/llurlentry_stub.cpp fc7e5dcf3059 
>   indra/newview/tests/llremoteparcelrequest_test.cpp fc7e5dcf3059 
> 
> Diff: http://codereview.secondlife.com/r/100/diff
> 
> 
> Testing
> ---
> 
> Compiled (standalone, 64bit Linux) with and without LL_TESTS.
> Started the viewer, logged in, walked and flew around a bit. Everything seems 
> to work.
> 
> 
> Locally set _PREHASH_AgentData and _PREHASH_AgentID to (char const*)0x1 in 
> indra/llui/tests/llurlentry_stub.cpp and 
> indra/newview/tests/llremoteparcelrequest_test.cpp to verify they actually 
> are never dereferenced, even when not NULL, so that using NULL pointers 
> instead of place holder data won't change what code paths gets tested. Both 
> tests binaries executed without crashes and all the contained tests passed.
> 
> Locally invoked start_messaging_system() with b_dump_prehash_file == true 
> instead of FALSE, to see what would be generated after my change to 
> dump_prehash_files().
> The message_prehash.(h|cpp) generated by that had the correct type qualifiers 
> and formatting, but some lines were removed or added compared to the modified 
> files from the source tree. That probably means that the files aren't fully 
> synchronized with the message template file in the source tree. Because the 
> "added" constants are spread all over the file, while the "removed" ones were 
> at the end, I'd wager that message_prehash.(h|cpp) in the viewer source tree 
> are actually more up-to-date than the message template file in the source 
> tree.
> 
> 
> Thanks,
> 
> Boroondas
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: quote all COPY_IF_DIFFERENT argument variables (fixes OPEN-36: error "COPY_IF_DIFFERENT Macro invoked with incorrect arguments" due to insufficient quoting)

2011-03-07 Thread Boroondas Gupte 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/182/#review428
---



indra/cmake/Copy3rdPartyLibs.cmake


For me, this change here is sufficient for getting the expected result when 
performing the repro in OPEN-36.

Throwing in the other changes for consistency.


- Boroondas


On March 7, 2011, 4:44 p.m., Boroondas Gupte wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/182/
> ---
> 
> (Updated March 7, 2011, 4:44 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Searched all uses of the copy_if_different CMake macro, and where variables 
> were passed as arguments, double-quoted them.
> 
> 
> This addresses bug OPEN-36.
> http://jira.secondlife.com/browse/OPEN-36
> 
> 
> Diffs
> -
> 
>   indra/cmake/Copy3rdPartyLibs.cmake ed35dc91644b 
>   indra/copy_win_scripts/CMakeLists.txt ed35dc91644b 
>   indra/test_apps/llplugintest/CMakeLists.txt ed35dc91644b 
> 
> Diff: http://codereview.secondlife.com/r/182/diff
> 
> 
> Testing
> ---
> 
> Successfully configured with
> autobuild configure -c OpenSourceStandAloneRelWithDebInfo
> 
> (Building still fails due to unrelated issues.)
> 
> 
> Thanks,
> 
> Boroondas
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: quote all COPY_IF_DIFFERENT argument variables (fixes OPEN-36: error "COPY_IF_DIFFERENT Macro invoked with incorrect arguments" due to insufficient quoting)

2011-03-07 Thread Boroondas Gupte 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/182/
---

Review request for Viewer.


Summary
---

Searched all uses of the copy_if_different CMake macro, and where variables 
were passed as arguments, double-quoted them.


This addresses bug OPEN-36.
http://jira.secondlife.com/browse/OPEN-36


Diffs
-

  indra/cmake/Copy3rdPartyLibs.cmake ed35dc91644b 
  indra/copy_win_scripts/CMakeLists.txt ed35dc91644b 
  indra/test_apps/llplugintest/CMakeLists.txt ed35dc91644b 

Diff: http://codereview.secondlife.com/r/182/diff


Testing
---

Successfully configured with
autobuild configure -c OpenSourceStandAloneRelWithDebInfo

(Building still fails due to unrelated issues.)


Thanks,

Boroondas

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: make PREHASH variables char const* const (fixes VWR-24487: llurlentry_stub.cpp:196: error: deprecated conversion from string constant to 'char*')

2011-03-07 Thread Boroondas Gupte 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/100/
---

(Updated March 7, 2011, 3:51 p.m.)


Review request for Viewer and Seth ProductEngine.


Changes
---

(just mentioning the jira issue in the summary)


Summary (updated)
---

For the reason for this change, see 
https://jira.secondlife.com/browse/VWR-24487 and 
https://jira.secondlife.com/browse/VWR-24522

What I did:
In indra/llmessage/message_prehash.(h|cpp), I turned everything into constant 
pointers to constants by search/replace. Then I tried to compile and added 
const qualifiers in dependent code as needed to stop the compiler complaining.

Note that comments in indra/llmessage/message_prehash.(h|cpp) say these files 
have been generated from the message template. Because this generation might 
not have been a one-off thing, I changed the generating code, too, so it won't 
override this change here when the generation happens the next time. However, 
that part of the code is not called by Viewer, although the relevant function — 
dump_prehash_files() — ends up in the Viewer binary. That function probably 
gets called by the simulator, when one runs the latter with -prehash. (See 
https://bitbucket.org/lindenlab/viewer-development/src/fc7e5dcf3059/indra/llmessage/message.cpp#cl-2532
 )


This addresses bug VWR-24487.
http://jira.secondlife.com/browse/VWR-24487


Diffs
-

  doc/contributions.txt fc7e5dcf3059 
  indra/llmessage/message.cpp fc7e5dcf3059 
  indra/llmessage/message_prehash.h fc7e5dcf3059 
  indra/llmessage/message_prehash.cpp fc7e5dcf3059 
  indra/llprimitive/llprimitive.h fc7e5dcf3059 
  indra/llprimitive/llprimitive.cpp fc7e5dcf3059 
  indra/llprimitive/llvolumemessage.h fc7e5dcf3059 
  indra/llprimitive/llvolumemessage.cpp fc7e5dcf3059 
  indra/llui/tests/llurlentry_stub.cpp fc7e5dcf3059 
  indra/newview/tests/llremoteparcelrequest_test.cpp fc7e5dcf3059 

Diff: http://codereview.secondlife.com/r/100/diff


Testing
---

Compiled (standalone, 64bit Linux) with and without LL_TESTS.
Started the viewer, logged in, walked and flew around a bit. Everything seems 
to work.


Locally set _PREHASH_AgentData and _PREHASH_AgentID to (char const*)0x1 in 
indra/llui/tests/llurlentry_stub.cpp and 
indra/newview/tests/llremoteparcelrequest_test.cpp to verify they actually are 
never dereferenced, even when not NULL, so that using NULL pointers instead of 
place holder data won't change what code paths gets tested. Both tests binaries 
executed without crashes and all the contained tests passed.

Locally invoked start_messaging_system() with b_dump_prehash_file == true 
instead of FALSE, to see what would be generated after my change to 
dump_prehash_files().
The message_prehash.(h|cpp) generated by that had the correct type qualifiers 
and formatting, but some lines were removed or added compared to the modified 
files from the source tree. That probably means that the files aren't fully 
synchronized with the message template file in the source tree. Because the 
"added" constants are spread all over the file, while the "removed" ones were 
at the end, I'd wager that message_prehash.(h|cpp) in the viewer source tree 
are actually more up-to-date than the message template file in the source tree.


Thanks,

Boroondas

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Implementation of new testing hooks to enable the creation of a headless viewer for testing.

2011-03-07 Thread Boroondas Gupte 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/181/#review426
---


Any chance this big change could be split into several smaller (hopefully 
self-consistent) changes that could be reviewed separately? Dunno if that's 
feasible. If not, please at least push the hg changesets included in this 
change to some publicly readable repo, so we can look at those individually.

- Boroondas


On March 7, 2011, 3:22 p.m., Merov Linden wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/181/
> ---
> 
> (Updated March 7, 2011, 3:22 p.m.)
> 
> 
> Review request for Viewer and Oz Linden.
> 
> 
> Summary
> ---
> 
> Massive changes implementing a set of new testing hooks so to enable the 
> creation of a headless viewer for testing.
> 
> 
> This addresses bug STORM-1051.
> http://jira.secondlife.com/browse/STORM-1051
> 
> 
> Diffs
> -
> 
>   .hgtags 8b9f50878cc7 
>   indra/llcommon/CMakeLists.txt 8b9f50878cc7 
>   indra/llcommon/lleventdispatcher.h 8b9f50878cc7 
>   indra/llcommon/lleventdispatcher.cpp 8b9f50878cc7 
>   indra/llcommon/llevents.h 8b9f50878cc7 
>   indra/llcommon/llevents.cpp 8b9f50878cc7 
>   indra/llcommon/llsdutil.h 8b9f50878cc7 
>   indra/llcommon/llsdutil.cpp 8b9f50878cc7 
>   indra/llcommon/tests/lleventdispatcher_test.cpp PRE-CREATION 
>   indra/llrender/llgl.h 8b9f50878cc7 
>   indra/llrender/llgl.cpp 8b9f50878cc7 
>   indra/llrender/llimagegl.cpp 8b9f50878cc7 
>   indra/llui/llfloaterreglistener.h 8b9f50878cc7 
>   indra/llui/llfloaterreglistener.cpp 8b9f50878cc7 
>   indra/llui/llui.h 8b9f50878cc7 
>   indra/llui/llui.cpp 8b9f50878cc7 
>   indra/llui/tests/llurlentry_stub.cpp 8b9f50878cc7 
>   indra/llwindow/CMakeLists.txt 8b9f50878cc7 
>   indra/llwindow/llkeyboardheadless.h PRE-CREATION 
>   indra/llwindow/llkeyboardheadless.cpp PRE-CREATION 
>   indra/llwindow/llwindow.h 8b9f50878cc7 
>   indra/llwindow/llwindow.cpp 8b9f50878cc7 
>   indra/llwindow/llwindowheadless.cpp 8b9f50878cc7 
>   indra/llwindow/llwindowlistener.h PRE-CREATION 
>   indra/llwindow/llwindowlistener.cpp PRE-CREATION 
>   indra/newview/CMakeLists.txt 8b9f50878cc7 
>   indra/newview/app_settings/settings.xml 8b9f50878cc7 
>   indra/newview/llagent.cpp 8b9f50878cc7 
>   indra/newview/llagentcamera.cpp 8b9f50878cc7 
>   indra/newview/llagentlistener.h 8b9f50878cc7 
>   indra/newview/llagentlistener.cpp 8b9f50878cc7 
>   indra/newview/llappviewer.cpp 8b9f50878cc7 
>   indra/newview/llfloaterbump.cpp 8b9f50878cc7 
>   indra/newview/llhudeffectlookat.cpp 8b9f50878cc7 
>   indra/newview/llhudmanager.cpp 8b9f50878cc7 
>   indra/newview/llimview.cpp 8b9f50878cc7 
>   indra/newview/lllogininstance.cpp 8b9f50878cc7 
>   indra/newview/llselectmgr.cpp 8b9f50878cc7 
>   indra/newview/llsidetray.h 8b9f50878cc7 
>   indra/newview/llsidetray.cpp 8b9f50878cc7 
>   indra/newview/llsidetraylistener.h PRE-CREATION 
>   indra/newview/llsidetraylistener.cpp PRE-CREATION 
>   indra/newview/llstartup.cpp 8b9f50878cc7 
>   indra/newview/llsurface.cpp 8b9f50878cc7 
>   indra/newview/lltexturestats.cpp 8b9f50878cc7 
>   indra/newview/lluilistener.h 8b9f50878cc7 
>   indra/newview/lluilistener.cpp 8b9f50878cc7 
>   indra/newview/llviewerdisplay.cpp 8b9f50878cc7 
>   indra/newview/llviewermessage.cpp 8b9f50878cc7 
>   indra/newview/llviewerobject.cpp 8b9f50878cc7 
>   indra/newview/llviewerobjectlist.cpp 8b9f50878cc7 
>   indra/newview/llviewerparcelmgr.cpp 8b9f50878cc7 
>   indra/newview/llviewerregion.cpp 8b9f50878cc7 
>   indra/newview/llviewerstats.cpp 8b9f50878cc7 
>   indra/newview/llviewertexture.cpp 8b9f50878cc7 
>   indra/newview/llviewertexturelist.cpp 8b9f50878cc7 
>   indra/newview/llviewerwindow.cpp 8b9f50878cc7 
>   indra/newview/llviewerwindowlistener.cpp 8b9f50878cc7 
>   indra/newview/llvoavatar.cpp 8b9f50878cc7 
>   indra/newview/llvoavatarself.cpp 8b9f50878cc7 
>   indra/newview/llworld.cpp 8b9f50878cc7 
>   indra/newview/pipeline.cpp 8b9f50878cc7 
> 
> Diff: http://codereview.secondlife.com/r/181/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Merov
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: Implementation of new testing hooks to enable the creation of a headless viewer for testing.

2011-03-07 Thread Merov Linden 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/181/
---

Review request for Viewer and Oz Linden.


Summary
---

Massive changes implementing a set of new testing hooks so to enable the 
creation of a headless viewer for testing.


This addresses bug STORM-1051.
http://jira.secondlife.com/browse/STORM-1051


Diffs
-

  .hgtags 8b9f50878cc7 
  indra/llcommon/CMakeLists.txt 8b9f50878cc7 
  indra/llcommon/lleventdispatcher.h 8b9f50878cc7 
  indra/llcommon/lleventdispatcher.cpp 8b9f50878cc7 
  indra/llcommon/llevents.h 8b9f50878cc7 
  indra/llcommon/llevents.cpp 8b9f50878cc7 
  indra/llcommon/llsdutil.h 8b9f50878cc7 
  indra/llcommon/llsdutil.cpp 8b9f50878cc7 
  indra/llcommon/tests/lleventdispatcher_test.cpp PRE-CREATION 
  indra/llrender/llgl.h 8b9f50878cc7 
  indra/llrender/llgl.cpp 8b9f50878cc7 
  indra/llrender/llimagegl.cpp 8b9f50878cc7 
  indra/llui/llfloaterreglistener.h 8b9f50878cc7 
  indra/llui/llfloaterreglistener.cpp 8b9f50878cc7 
  indra/llui/llui.h 8b9f50878cc7 
  indra/llui/llui.cpp 8b9f50878cc7 
  indra/llui/tests/llurlentry_stub.cpp 8b9f50878cc7 
  indra/llwindow/CMakeLists.txt 8b9f50878cc7 
  indra/llwindow/llkeyboardheadless.h PRE-CREATION 
  indra/llwindow/llkeyboardheadless.cpp PRE-CREATION 
  indra/llwindow/llwindow.h 8b9f50878cc7 
  indra/llwindow/llwindow.cpp 8b9f50878cc7 
  indra/llwindow/llwindowheadless.cpp 8b9f50878cc7 
  indra/llwindow/llwindowlistener.h PRE-CREATION 
  indra/llwindow/llwindowlistener.cpp PRE-CREATION 
  indra/newview/CMakeLists.txt 8b9f50878cc7 
  indra/newview/app_settings/settings.xml 8b9f50878cc7 
  indra/newview/llagent.cpp 8b9f50878cc7 
  indra/newview/llagentcamera.cpp 8b9f50878cc7 
  indra/newview/llagentlistener.h 8b9f50878cc7 
  indra/newview/llagentlistener.cpp 8b9f50878cc7 
  indra/newview/llappviewer.cpp 8b9f50878cc7 
  indra/newview/llfloaterbump.cpp 8b9f50878cc7 
  indra/newview/llhudeffectlookat.cpp 8b9f50878cc7 
  indra/newview/llhudmanager.cpp 8b9f50878cc7 
  indra/newview/llimview.cpp 8b9f50878cc7 
  indra/newview/lllogininstance.cpp 8b9f50878cc7 
  indra/newview/llselectmgr.cpp 8b9f50878cc7 
  indra/newview/llsidetray.h 8b9f50878cc7 
  indra/newview/llsidetray.cpp 8b9f50878cc7 
  indra/newview/llsidetraylistener.h PRE-CREATION 
  indra/newview/llsidetraylistener.cpp PRE-CREATION 
  indra/newview/llstartup.cpp 8b9f50878cc7 
  indra/newview/llsurface.cpp 8b9f50878cc7 
  indra/newview/lltexturestats.cpp 8b9f50878cc7 
  indra/newview/lluilistener.h 8b9f50878cc7 
  indra/newview/lluilistener.cpp 8b9f50878cc7 
  indra/newview/llviewerdisplay.cpp 8b9f50878cc7 
  indra/newview/llviewermessage.cpp 8b9f50878cc7 
  indra/newview/llviewerobject.cpp 8b9f50878cc7 
  indra/newview/llviewerobjectlist.cpp 8b9f50878cc7 
  indra/newview/llviewerparcelmgr.cpp 8b9f50878cc7 
  indra/newview/llviewerregion.cpp 8b9f50878cc7 
  indra/newview/llviewerstats.cpp 8b9f50878cc7 
  indra/newview/llviewertexture.cpp 8b9f50878cc7 
  indra/newview/llviewertexturelist.cpp 8b9f50878cc7 
  indra/newview/llviewerwindow.cpp 8b9f50878cc7 
  indra/newview/llviewerwindowlistener.cpp 8b9f50878cc7 
  indra/newview/llvoavatar.cpp 8b9f50878cc7 
  indra/newview/llvoavatarself.cpp 8b9f50878cc7 
  indra/newview/llworld.cpp 8b9f50878cc7 
  indra/newview/pipeline.cpp 8b9f50878cc7 

Diff: http://codereview.secondlife.com/r/181/diff


Testing
---


Thanks,

Merov

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: STORM-1018 Improve error messaging for External Editor feature

2011-03-07 Thread Vadim ProductEngine 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/179/
---

Review request for Viewer and Seth ProductEngine.


Summary
---

Let the user know what's wrong with external editor.

Added meaningful messages for the following errors:
* Editor not specified.
* Error parsing command line.
* Specified binary not found.
* Editor failed to run.

All the messages are translatable.


This addresses bug STORM-1018.
http://jira.secondlife.com/browse/STORM-1018


Diffs
-

  indra/newview/llexternaleditor.h ef2df52563bb 
  indra/newview/llexternaleditor.cpp ef2df52563bb 
  indra/newview/llfloateruipreview.cpp ef2df52563bb 
  indra/newview/llpreviewscript.cpp ef2df52563bb 
  indra/newview/skins/default/xui/en/floater_ui_preview.xml ef2df52563bb 
  indra/newview/skins/default/xui/en/panel_script_ed.xml ef2df52563bb 
  indra/newview/skins/default/xui/en/strings.xml ef2df52563bb 

Diff: http://codereview.secondlife.com/r/179/diff


Testing
---

Test cases:
1. Use a path containing spaces without enclosing it with double quotes (/path 
to/editor).
   Expected: the "not found" message.
2. Specify empty path ().
   Expected: the "not found" message.
3. Try using an odd number of double quotes ("/path to/editor "%s").
   Expected: the "parse error" message.
4. Specifying a nonexistent editor (/non/existent/editor).
   Expected: the "not found" message.
5. Specify a valid editor path (/usr/bin/editor).
   Expected: the editor is executed.

The command can be specified with the ExternalEditor debug setting or an 
environment variable: LL_SCRIPT_EDITOR for script editor and LL_XUI_EDITOR for 
the XUI preview tool. In the latter case you can also override the command via 
the "Editor Path" floater input field.


Thanks,

Vadim

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: the fix for STORM-1026: Viewer crahes while trying to reset Graphics quality

2011-03-07 Thread Xiaohong Bao 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/180/
---

Review request for Viewer.


Summary
---

This is for STORM-1026: Viewer crahes while trying to reset Graphics quality.


Diffs
-

  indra/llrender/llvertexbuffer.cpp 767feb16f05f 

Diff: http://codereview.secondlife.com/r/180/diff


Testing
---


Thanks,

Xiaohong

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges