[opensource-dev] Daily Scrum Summary - Tuesday, March 29

[Anya Kanevsky]

 They're back! Sorry for the lengthy interruption. Now that I'm a bit more
caught up, I will try to keep these daily, like it says in the title.

Sprint 13, ends 04.11.11 Tuesday, March 29 General Notes
--

   - will try 2-week sprint for Sprint 13
   - issues we'd like open source devs to tackle are under fix verison
   "open-developer"
   - MMOTD: Oz

Team Status
--
 Merov Linden
--

*PAST*

   - STORM-1087 : viewer-autobuild2010 : Tried to find a solution to Oz's
   build issue (build of llimage_libtest on Linux). Unsuccessful so far.
   - Sprint 13 Planning Meeting and subsequent triaging
   - Prepare for internal presentation

*FUTURE*

   - STORM-1087 : viewer-autobuild2010 : Fix that llimage_libtest Linux
   build issue.
   - Internal meeting

*IMPEDIMENTS*

   - none

Oz Linden
--

*PAST*

   - Reviewed Havok-wrapper sources for publication
   - Sprint planning
   - Merge Monkey - build problem merging out llimage test to autobuild
   branch...

*FUTURE*

   - Library docs
   - STORM/OPEN contribution reviews

*IMPEDIMENTS*

   - may need some help on the linux build problem.

Grumpity ProductEngine
--

*PAST*

   - sprint planning and followup jira wrangling
   - almost done with PO build

*FUTURE*

   - crashhunters
   - jira cleanup
   - storm-2 to sprint 13
   - STORM-1065 bug Stone
   - STORM-1071 Richard
   - reschedule crashhunters
   - reschedule triages

*IMPEDIMENTS*

   - none

Paul ProductEngine
--

*PAST*

   - BUG STORM-1072 ([TRANSLATED BUT IN EN] in "Monde" > "Profil du lieu" >
   "À propos des terrains" > "Réglement" : "Estate / Full Region" is in
   english.)
  - Fixed and sent for review.
   - BUG STROM-1033 (Change Appearance Editor top-level Help link)
  - Finish investigation. To finish this bug i need to know help_topic
  value for the new Help link.

*FUTURE*

   - BUG STORM-972 ('My Dashboard' page doesn't open in internal browser if
   clear viewer cache)
   - BUG STORM-399 (Users that has chatted within chat range of the user
   in-world are not added to Recent tab)

*IMPEDIMENTS*

   - BUG STROM-1033 (Change Appearance Editor top-level Help link)
  - to finish this bug i need to know help_topic value for the new Help
  link.
   - BUG STORM-1066 (Top Scripts/Top Colliders filter needs to be updated
   for Display Names)
  - I commented this server side bug as you asked. Please assign it to
  someone who is familiar with this.

Seth ProductEngine
--

*PAST*

   - BUG (STORM-380) There is a little delay in sound when gesture first
   time played
  - Updated fix according to the feedback on the first revision.
  - Investigated potential memory leak problems.
   - BUG (VWR-25355) Blank floater opens after sending "Notice" to group
   - BUG (SOCIAL-756) Using the block feature in People panel mini
   inspectors brings up blank UI panel in Basic mode
  - Both resolved as duplicates of (SOCIAL-773) Empty floater created
  upon docking Places side panel.
   - BUG (STORM-1071) Switching language in preferences creates new calling
   cards folders for each language
  - Could not reproduce for now. Need to do some more checks. Some
  accounts might suffer from consequences of the bug which existed but was
  fixed.

*FUTURE*

   - (STORM-1071) Switching language in preferences creates new calling
   cards folders for each language
   - STORM-28: add a jira not to allow placing calling cards in prims.


*IMPEDIMENTS*

   - BUG (STORM-721) Information about resident is displayed incorrectly in
   mini-inspector if there are any resident or group SLURLs
  - Waiting for more info on the fix Richard has proposed.

Andrey ProductEngine
--

*PAST*

   - continued with v-d regression testing
  - Login Landmarks 100%
  - ToS 100%
  - About Land 100%
  - Nearby Media 100%
  - FlatList multi-selection 100%
  - URLs 100%
  - SideBar Basics - 100%
  - Home Panel - 100%
  - My Friends Panel - 100%
  - Preferences - General - in progress
  - Preferences - Graphics - in progress
   - reported VWR-25355

*FUTURE*

   - continue with v-d regression testing or pickup next one beta

*IMPEDIMENTS*

   - none

Wolfpup Lowenhar
--

*PAST*

   - STORM-941 : Tracking data flow for system messages during P2P
   conversations involving cross DN usage as this is the last hurdle that I can
   find to fixing this issue.
  - still cannot track down this last cause of Legacy name generation
  even though I know how to readily reproduce it.
  - The patch provided in the JIRA does work for all the other cases.
   - STORM-1087 : tested Merov's VS2010 autobuild repository.
  - the use of -DUSE_PRECOMPILED_HEADERS:BOOL=ON does improve both build
  tim

[opensource-dev] Review Request: STORM-1095 Chat preferences > font size should increase size of input text in the chat box

[Jonathan Yap]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/244/
---

Review request for Viewer.


Summary
---

 Chat preferences > font size should increase size of input text in the chat box


This addresses bug STORM-1095.
http://jira.secondlife.com/browse/STORM-1095


Diffs
-

  doc/contributions.txt 65ff7415f171 
  indra/llui/lllineeditor.h 65ff7415f171 
  indra/llui/lllineeditor.cpp 65ff7415f171 
  indra/newview/llbottomtray.cpp 65ff7415f171 
  indra/newview/llfloaterpreference.cpp 65ff7415f171 
  indra/newview/llnearbychatbar.h 65ff7415f171 
  indra/newview/llnearbychatbar.cpp 65ff7415f171 
  indra/newview/llviewerchat.h 65ff7415f171 
  indra/newview/llviewerchat.cpp 65ff7415f171 

Diff: http://codereview.secondlife.com/r/244/diff


Testing
---

Change font size in preferences and see
1) Font size in chat input box changes to new size immediately
2) Font size is set to selected size when viewer is restarted


Thanks,

Jonathan

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1095 Chat preferences > font size should increase size of input text in the chat box

[Jonathan Yap]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/244/
---

(Updated March 30, 2011, 5:43 a.m.)


Review request for Viewer.


Changes
---

Cleanup of where a few .h files were included.


Summary
---

 Chat preferences > font size should increase size of input text in the chat box


This addresses bug STORM-1095.
http://jira.secondlife.com/browse/STORM-1095


Diffs (updated)
-

  doc/contributions.txt 65ff7415f171 
  indra/llui/lllineeditor.h 65ff7415f171 
  indra/llui/lllineeditor.cpp 65ff7415f171 
  indra/newview/llbottomtray.cpp 65ff7415f171 
  indra/newview/llfloaterpreference.cpp 65ff7415f171 
  indra/newview/llnearbychatbar.h 65ff7415f171 
  indra/newview/llnearbychatbar.cpp 65ff7415f171 
  indra/newview/llviewerchat.h 65ff7415f171 
  indra/newview/llviewerchat.cpp 65ff7415f171 

Diff: http://codereview.secondlife.com/r/244/diff


Testing
---

Change font size in preferences and see
1) Font size in chat input box changes to new size immediately
2) Font size is set to selected size when viewer is restarted


Thanks,

Jonathan

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Mac/Linux testers needed for Open-52 (Superfluous source files)

[Jonathan Welch]

Hi,

If you can compile on Mac or Linux I would like you to try deleting
the .cpp (and associated .h) files listed in Open-52
 and report back in a
comment if any files in that list are needed.

You will have to update cmakelists.txt and also any files that include
any of those deleted .h files.

Once some testing has been done the files that are no longer in use
can be deleted from the code tree for general cleanup and to prevent
confusion about what files are really needed/in use.

Thank you,

-Jonathan
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: STORM-1122 Linux viewer sucks up file descriptors, stops loading content and crashes

[Discrete Dreamscape]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/245/
---

Review request for Viewer.


Summary
---

Resolved Linux file descriptor greediness by removing obsolete fallback font 
searching (call to LLWindowSDL::getDynamicFallbackFontList()), as this seems to 
be obsolete unless your skin's configuration references font files that are not 
packaged with the viewer, which is not the default case. Would like to know if 
this solves the instability described in STORM-1122 for Linux users, 
particularly those with lower than average file descriptor limits set (find out 
by running `ulimit -a`, it's the value 'open files', mine is 1024 on Ubuntu 
10.10 and I'd have extreme problems prior to the patch).


This addresses bug STORM-1122.
http://jira.secondlife.com/browse/STORM-1122


Diffs
-

  doc/contributions.txt a8f868007986 
  indra/llwindow/llwindow.cpp a8f868007986 

Diff: http://codereview.secondlife.com/r/245/diff


Testing
---

Useful ways to examine file descriptor usage for the viewer

lsof -c do-not | less

This should be much, much less than 1024
lsof -c do-not | wc -l

This shows all descriptors containing the word 'font' along with the number of 
each (there are tons of duplicates)
lsof -c do-not | egrep -o '[^ ]*font[^ ]*' | sort | uniq -c | less


Thanks,

Discrete

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Open Development meeting cancelled today

[Oz Linden (Scott Lawrence)]

I've got an urgent errand to run... any agenda items will be rolled over 
to our next meeting.

Contact me directly for anything urgent

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Mac/Linux testers needed for Open-52 (Superfluous source files)

[Boroondas Gupte]

On 03/30/2011 08:43 PM, Jonathan Welch wrote:
> [...] I would like you to try deleting
> the .cpp (and associated .h) files listed in Open-52
>  and report back in a
> comment if any files in that list are needed.
>
> You will have to update cmakelists.txt and also any files that include
> any of those deleted .h files.
Can you provide a patch and/or repo with these deletions and
modifications, so that we are sure everyone is testing the same?

Thanks,
Boroondas
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1095 Chat preferences > font size should increase size of input text in the chat box

[Boroondas Gupte]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/244/#review523
---



indra/llui/lllineeditor.h


Any reason why ...



indra/llui/lllineeditor.cpp


... this simple setter isn't implemented right at the declaration (i.e. in 
indra/llui/lllineeditor.h)?



indra/newview/llbottomtray.cpp


If font isn't used later, this could be written as
mNearbyChatBar->getChatBox()->setFont(LLViewerChat::getChatFont());

(Not sure which variant is more readable.)



indra/newview/llnearbychatbar.cpp


Put some punctuation between "font" and "whohoo" :-P



indra/newview/llviewerchat.cpp


Whatever the reason for that comment is, I guess the idea is that you put 
new members below it, not above.

Also, should this be initialized to null here ...



indra/newview/llviewerchat.cpp


... so that it actually will be null here the first time?


- Boroondas


On March 30, 2011, 5:43 a.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/244/
> ---
> 
> (Updated March 30, 2011, 5:43 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
>  Chat preferences > font size should increase size of input text in the chat 
> box
> 
> 
> This addresses bug STORM-1095.
> http://jira.secondlife.com/browse/STORM-1095
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt 65ff7415f171 
>   indra/llui/lllineeditor.h 65ff7415f171 
>   indra/llui/lllineeditor.cpp 65ff7415f171 
>   indra/newview/llbottomtray.cpp 65ff7415f171 
>   indra/newview/llfloaterpreference.cpp 65ff7415f171 
>   indra/newview/llnearbychatbar.h 65ff7415f171 
>   indra/newview/llnearbychatbar.cpp 65ff7415f171 
>   indra/newview/llviewerchat.h 65ff7415f171 
>   indra/newview/llviewerchat.cpp 65ff7415f171 
> 
> Diff: http://codereview.secondlife.com/r/244/diff
> 
> 
> Testing
> ---
> 
> Change font size in preferences and see
> 1) Font size in chat input box changes to new size immediately
> 2) Font size is set to selected size when viewer is restarted
> 
> 
> Thanks,
> 
> Jonathan
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Enable CURLOPT_ENCODING for Inventory caps, which uses the LLURLRequest code path

[Stone Linden]

> On March 29, 2011, 6:02 p.m., Merov Linden wrote:
> > Looks good.
> 
> Merov Linden wrote:
> BTW, what's the JIRA for this patch?

VWR-25286


- Stone


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/242/#review521
---


On March 28, 2011, 6:22 p.m., Stone Linden wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/242/
> ---
> 
> (Updated March 28, 2011, 6:22 p.m.)
> 
> 
> Review request for Viewer, Oz Linden, Joshua Linden, and Brad Kittenbrink.
> 
> 
> Summary
> ---
> 
> Enable Accept-Encoding: deflate, gzip in libcurl via setopt CURLOPT_ENCODING. 
> I'm approaching this for Inventory, but it would apply to any HTTP request 
> that goes through the LLURLRequest code path (vs. the LLCurl code path, which 
> already does this).
> 
> 
> Diffs
> -
> 
>   indra/llmessage/llurlrequest.cpp 2ae060c0fa91 
> 
> Diff: http://codereview.secondlife.com/r/242/diff
> 
> 
> Testing
> ---
> 
> Inventory loads, and I see the encoding options coming through on the backend 
> apache logs.
> 
> 
> Thanks,
> 
> Stone
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Enable CURLOPT_ENCODING for Inventory caps, which uses the LLURLRequest code path

[Stone Linden]

> On March 29, 2011, 6:02 p.m., Merov Linden wrote:
> > Looks good.
> 
> Merov Linden wrote:
> BTW, what's the JIRA for this patch?
> 
> Stone Linden wrote:
> VWR-25286

Sorry, VWR-25376


- Stone


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/242/#review521
---


On March 28, 2011, 6:22 p.m., Stone Linden wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/242/
> ---
> 
> (Updated March 28, 2011, 6:22 p.m.)
> 
> 
> Review request for Viewer, Oz Linden, Joshua Linden, and Brad Kittenbrink.
> 
> 
> Summary
> ---
> 
> Enable Accept-Encoding: deflate, gzip in libcurl via setopt CURLOPT_ENCODING. 
> I'm approaching this for Inventory, but it would apply to any HTTP request 
> that goes through the LLURLRequest code path (vs. the LLCurl code path, which 
> already does this).
> 
> 
> Diffs
> -
> 
>   indra/llmessage/llurlrequest.cpp 2ae060c0fa91 
> 
> Diff: http://codereview.secondlife.com/r/242/diff
> 
> 
> Testing
> ---
> 
> Inventory loads, and I see the encoding options coming through on the backend 
> apache logs.
> 
> 
> Thanks,
> 
> Stone
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Media plugin is completely broken on Linux in the Autobuild branch

[leliel]

Commit 284e995627ed on viewer-autobuild2010 reverted the linux
libqtwebkit to version 4.6 which has completely broken everything,
even the side bar doesn't work.
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Group Notices not getting delivered

[Ardy Lay]

I am getting complaints that group notices show up in history but are 
not delivered to residents.  I have checked history on an announcements 
group and see this has affected me too.  Any ideas?
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Daily Scrum Summary - Wednesday, March 30

[Anya Kanevsky]

Sprint 13, ends 04.11.11 Wedensday, March 30 General Notes
--

   - please remember to move issues to current sprint from bug-queue when
   you're working on them!
   - MMOTD: Oz

Team Status
--
 Merov Linden
--

*PAST*

   - STORM-1087 / STORM-1121 : viewer-autobuild2010 : Problem comes from
   complex recursive dependencies that confuses the Linux build script. No time
   to untangle this so implemented LLIMAGE_LIBTEST as a build option so that it
   doesn't block anyone (and doesn't block the merge). Filed STORM-1121 for the
   remaining llimage_libtest issue.

*FUTURE*

   - STORM-1121 : llimage_libtest : clean-up the build scripts of this
   applet for autobuild
   - STORM-1087 : viewer-autobuild2010 : Get ready for the big merge
   - STORM-1051 : merge request (testing hooks added) : merge test with
   autobuild

*IMPEDIMENTS*

   - none

Oz Linden
--

*PAST*

   - Merge Monkey
  - got linux fix from Merov - test build running
   - STORM/OPEN contribution reviews
   - Viewer Evolution User Group

*FUTURE*

   - Library docs
   - Open Development User Group
   - More merging
   - PO review build

*IMPEDIMENTS*

   - none

Grumpity ProductEngine
--

*PAST*

   - crashhunters
   - finished PO build
   - STORM-2 subtask to Sprint 13
   - rescheduled crashhunters, triages, new tirages, snowstorm sprint
   meetings. spent unforgettable hours with gcals.
   - process discussions with various stakeholders
   - finally restarted daily summaries
   - cleared out some lost issues in STORM
  - please remember to move issues to current sprint from bug-queue when
  you're working on them!

*FUTURE*

   - VWR triage
   - STORM-1065 still waiting for Stone
   - STORM-721 fix - Richard?
   - STORM-1033 - help link value
   - STORM-1031 - catch Ben: hint or tip?
   - STORM-1071 - server side fix?
   - get back to Nyx

*IMPEDIMENTS*

   - time
   - need new PO build


 Paul ProductEngine
--

*PAST*

   - BUG STORM-972 ('My Dashboard' page doesn't open in internal browser if
   clear viewer cache)
  - Resolved as cannot reproduce
   - BUG STORM-1066 (Top Scripts/Top Colliders filter needs to be updated
   for Display Names)
  - Investigated ability to print in human readable format messages
  (LLMessageSystem) which are sent between server and client. This
was needed
  to provide information about exact messages, for server teem, as
Oz asked.
  But seems it's not trivial, decided not to spent much time on it
and provide
  code snippets with explanation.
   - Spent some time on restoring Windows 7 and build problems in
   VisualStudio 2008

*FUTURE*

   - STORM-1109 (Check box resizes incorrectly if applying word wrap to its
   label.)

*IMPEDIMENTS*

   - I provided necessary info for STORM-1066 as Oz asked. I think now it
   can be assigned to someone who is familiar with server side.
   - And about STORM-1033, I still can't finish it before I get the value of
   help topic for "Changing Your Appearance" web page.

Seth ProductEngine
--

*PAST*

   - BUG (STORM-1071) Switching language in preferences creates new calling
   cards folders for each language
  - The issue is not reproducible now, but the accounts affected by it
  before should probably be fixed server side.
   - BUG (STORM-380) There is a little delay in sound when gesture first
   time played
  - Investigating possible memory leak problem.
  - Working on checking the pending downloads for each playing gesture
  separately.

*FUTURE*

   - BUG (STORM-1117) Placing calling cards in prims should be disabled.
  - Estimated: 5 - 6 hours.
   - BUG (STORM-380) There is a little delay in sound when gesture first
   time played
  - Estimated: 5 - 6 hours.

*IMPEDIMENTS*

   - BUG (STORM-721) Information about resident is displayed incorrectly in
   mini-inspector if there are any resident or group SLURLs
  - Waiting for more info on the fix Richard has proposed.
   - BUG (STORM-1071) Switching language in preferences creates new calling
   cards folders for each language
  - Looks like it needs a server side fix.

Andrey ProductEngine
--

*PAST*

   - failed smoke & integrity tests against 2.6.2 beta1, see IQA-112 for
   more details
   - passed 2.6.2 beta1 changes, IQA-114
   - converted Voice TP to gdocs format
   - published Hotkeys TP after review
   - continued v-d regression testing
  - reported VWR-25361 and VWR-25362

*FUTURE*

   - run Voice TP against v-d
   - verify integrated tickets

*IMPEDIMENTS*

   - none

Wolfpup Lowenhar
--

*PAST*

   - STORM-941 : After talking with Oz in IRC waiting on contact from PE.
   - STORM-1087 : tested Merov's VS2010 autobuild repository.
  - still have to disable the resident shield part of m