Re: [opensource-dev] Review Request: STORM-1175 Fixing close button, for Custom Port warning, in Preferences > Setup > Network

[Ima Mechanique]

> On April 19, 2011, 8:02 a.m., Vadim ProductEngine wrote:
> > Could you please provide the patch description? I.e what the problem was 
> > and how you fixed it.

I'm not sure what you want here.
If you're asking what I did? I updated Kitty's two line patch to apply against 
the current code, then tested that it fixed the problem.
If you're asking what Kitty's thinking was behind the solution? I can't answer 
that.


- Ima


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/271/#review631
---


On April 19, 2011, 7:57 a.m., Ima Mechanique wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/271/
> ---
> 
> (Updated April 19, 2011, 7:57 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Applying Kitty Barnett's patch against current code base.
> 
> 
> This addresses bug STORM-1175.
> http://jira.secondlife.com/browse/STORM-1175
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt 584211e99147 
>   indra/llui/llnotifications.cpp 584211e99147 
> 
> Diff: http://codereview.secondlife.com/r/271/diff
> 
> 
> Testing
> ---
> 
> Release build. tested preferences both in world and on the log in screen.
> 
> 
> Thanks,
> 
> Ima
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: (STORM-229) Loading Scripts takes a long time and stalls Viewer

[Richard Nelson]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/273/#review634
---

Ship it!


makes sense. ship it.

- Richard


On April 18, 2011, 11:25 a.m., Seth ProductEngine wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/273/
> ---
> 
> (Updated April 18, 2011, 11:25 a.m.)
> 
> 
> Review request for Viewer and Richard Nelson.
> 
> 
> Summary
> ---
> 
> Partial fix for selected text indentation in script editor stalling the 
> viewer: disabled updating text segments until all indentation commands are 
> executed.
> Looks like the viewer is not stalled but the indentation still works rather 
> slow.
> 
> 
> Diffs
> -
> 
>   indra/llui/lltexteditor.cpp 9c0506d10226 
> 
> Diff: http://codereview.secondlife.com/r/273/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Seth
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: (STORM-320) Script Editor in Viewer 2.0+ "tabs" incorrectly

[Richard Nelson]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/274/#review633
---

Ship it!


seems reasonable

- Richard


On April 19, 2011, 3:16 p.m., Seth ProductEngine wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/274/
> ---
> 
> (Updated April 19, 2011, 3:16 p.m.)
> 
> 
> Review request for Viewer and Richard Nelson.
> 
> 
> Summary
> ---
> 
> Fixed navigation with arrow keys through the text with enabled word-wrapping.
> 
> Steps to repro at 
> https://jira.secondlife.com/browse/STORM-320?focusedCommentId=244113&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-244113
> 
> 
> This addresses bug STORM-320.
> http://jira.secondlife.com/browse/STORM-320
> 
> 
> Diffs
> -
> 
>   indra/llui/lltextbase.cpp 9c0506d10226 
> 
> Diff: http://codereview.secondlife.com/r/274/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Seth
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: (STORM-320) Script Editor in Viewer 2.0+ "tabs" incorrectly

[Seth ProductEngine]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/274/
---

Review request for Viewer and Richard Nelson.


Summary
---

Fixed navigation with arrow keys through the text with enabled word-wrapping.

Steps to repro at 
https://jira.secondlife.com/browse/STORM-320?focusedCommentId=244113&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-244113


This addresses bug STORM-320.
http://jira.secondlife.com/browse/STORM-320


Diffs
-

  indra/llui/lltextbase.cpp 9c0506d10226 

Diff: http://codereview.secondlife.com/r/274/diff


Testing
---


Thanks,

Seth

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] In-world groups

[Opensource Obscure]

On Thu, Apr 7, 2011 at 18:49, Opensource Obscure
 wrote:
> What are currently the best in-world groups where to
> discuss viewer issues, announce new JIRA entries or updates,
> raise awareness about current bugs and such?
>
> I'd welcome both official and unofficial groups.

As a followup to this, here are 5 groups currently listed at
https://wiki.secondlife.com/wiki/Developer_communication_tools

SL Open Source Contributors
Second Life Beta
AW Groupies
Second Life Source Developers
and Second Life Viewer 2.0

I just got ownership of the last group, courtesy of the founder
Teqi Falta, and I invite you to join it to chat about Viewer 2:
general usage, existing and upcoming features, viewer preview
builds, hot JIRA issues etc. Any input welcome.

group name:
 Second Life Viewer 2.0
https://my.secondlife.com/groups/4a33a3b8-896c-5154-3922-c2bd20a9ae4d


Opensource Obscure
--
http://twitter.com/oobscure - http://opensourceobscure.com/lol
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Storm-1128 Sort the results of using search in the World Map

[Boroondas Gupte]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/262/#review632
---

Ship it!


One last (literally) tiny thing:


indra/newview/llfloaterworldmap.cpp


Put a space after the comma.


(No need for a new review-request diff for just that, I'd say.)

- Boroondas


On April 16, 2011, 1:52 p.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/262/
> ---
> 
> (Updated April 16, 2011, 1:52 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> The results of using the World Map search option are sorted.
> 
> 
> This addresses bug Storm-1128.
> http://jira.secondlife.com/browse/Storm-1128
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt a8f868007986 
>   indra/newview/llfloaterworldmap.cpp a8f868007986 
> 
> Diff: http://codereview.secondlife.com/r/262/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jonathan
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1175 Fixing close button, for Custom Port warning, in Preferences > Setup > Network

[Vadim ProductEngine]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/271/#review631
---


Could you please provide the patch description? I.e what the problem was and 
how you fixed it.

- Vadim


On April 19, 2011, 7:57 a.m., Ima Mechanique wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/271/
> ---
> 
> (Updated April 19, 2011, 7:57 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Applying Kitty Barnett's patch against current code base.
> 
> 
> This addresses bug STORM-1175.
> http://jira.secondlife.com/browse/STORM-1175
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt 584211e99147 
>   indra/llui/llnotifications.cpp 584211e99147 
> 
> Diff: http://codereview.secondlife.com/r/271/diff
> 
> 
> Testing
> ---
> 
> Release build. tested preferences both in world and on the log in screen.
> 
> 
> Thanks,
> 
> Ima
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1175 Fixing close button, for Custom Port warning, in Preferences > Setup > Network

[Vadim ProductEngine]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/271/
---

(Updated April 19, 2011, 7:57 a.m.)


Review request for Viewer.


Changes
---

adding ticket reference


Summary
---

Applying Kitty Barnett's patch against current code base.


This addresses bug STORM-1175.
http://jira.secondlife.com/browse/STORM-1175


Diffs
-

  doc/contributions.txt 584211e99147 
  indra/llui/llnotifications.cpp 584211e99147 

Diff: http://codereview.secondlife.com/r/271/diff


Testing
---

Release build. tested preferences both in world and on the log in screen.


Thanks,

Ima

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges