Re: [opensource-dev] Review Request: STORM-1804 Details... button on PERMISSION_DEBIT dialog triggers run_time_permissions() with a deny action

[Jonathan Yap]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/544/#review1157
---



indra/newview/llviewermessage.cpp


Oz, here is the early return you thought might be present.  Want to suggest 
an alternative?


- Jonathan Yap


On Jan. 25, 2012, 4:47 a.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/544/
> ---
> 
> (Updated Jan. 25, 2012, 4:47 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Description
> ---
> 
> When an object requests DEBIT permissions a large, yellow dialog appears. 
> This dialog has three buttons: "Grant", "Deny", and "Details..." When you 
> select "Details..." Additional information about DEBIT permission is 
> displayed.
> 
> The bug is that when "Details..." is selected PERMISSION_DEBIT is denied and 
> the run_time_permissions() event handler is triggered. There is also a system 
> message in the Local Chat pane of the communicate window that informs the 
> user that permission has been denied. Further, if "Grant" or "Deny" are 
> pressed AFTER details the run_time_permissions() event handler is NOT 
> triggered, yet there is a system message saying that permissions have been 
> granted or denied.
> 
> What should happen when "Details..." is pressed is no run_time_permissions 
> event should be triggered and the "Grant" and "Deny" buttons should operate 
> normally and trigger the run_time_permissions event afterwards.
> 
> 
> This addresses bug STORM-1804.
> http://jira.secondlife.com/browse/STORM-1804
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt 3f2162768b29 
>   indra/newview/llviewermessage.cpp 3f2162768b29 
> 
> Diff: http://codereview.secondlife.com/r/544/diff/diff
> 
> 
> Testing
> ---
> 
> See test script in jira.
> 
> Click on Details: additional information is shown, click on Ok to dismiss 
> that, then you can go back and click on Grant or Deny.
> 
> 
> Thanks,
> 
> Jonathan Yap
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Questions on Mesh Avatars

[Robert Martin]

Okay first off let me say that the documents on Mesh Avatars (unless
they have been updated in the last week of so) are either outdated or
partly fictional.
Does anybody have access to a decent and complete spec as to what is
needed to make a Rigged Mesh Avatar??
1 mesh Complexity should be below XK
2 how do you setup the mesh bones for correct rigging??

Also does anybody have access to a ready to upload Human avatar
(simplebot.dae does not count and that avastar file is useless) and
any hints on how to get it to work properly??

last bit if you after doing the upload edit the object to include say
an avatar overide and or a RVL relay would that work properly??

-- 
Robert L Martin
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] mesh upload crash in recent builds...

[Dave Booth]

reverified with todays build, VWR-28207 created.

On 1/24/2012 4:02 PM, Dave Booth wrote:
> Somewhere between the branch for the current beta and the tip is a
> mistake leading to an instant crash when selecting "upload ->  model"
> from the inventory floaters "+" menu. It's a 0xc5 exception, the
> windows equivalent of your garden-variety segfault, pulling up the dmp
> file in vs2010 looks like the viewer is passing a null pointer into a
> call to strstr somewhere.
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting privileges
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges