[opensource-dev] Review Request: STORM-1892 - Add Apply button to the edit content permission floater

2012-06-23 Thread Jonathan Yap

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/587/
---

Review request for Viewer.


Description
---

Add Apply button to the edit content permission floater, now called Adjust 
Content Permissions.

Minor rewording of title and floater text for clarity and to avoid confusion 
with STORM-68 (As a Builder, I want that ability to set default permissions on 
creation of objects, clothing, scripts, notecards, etc.), which is in the 
pipeline.


This addresses bug STORM-1892.
https://jira.secondlife.com/browse/STORM-1892


Diffs
-

  doc/contributions.txt 4d9106153407 
  indra/newview/llfloaterbulkpermission.h 4d9106153407 
  indra/newview/llfloaterbulkpermission.cpp 4d9106153407 
  indra/newview/skins/default/xui/en/floater_bulk_perms.xml 4d9106153407 

Diff: http://codereview.secondlife.com/r/587/diff/diff


Testing
---

See test plan in jira


Thanks,

Jonathan Yap

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1892 - Add Apply button to the edit content permission floater

2012-06-23 Thread MartinRJ Fayray

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/587/#review1236
---

Ship it!


Ship It!

- MartinRJ Fayray


On June 23, 2012, 4:34 p.m., Jonathan Yap wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://codereview.secondlife.com/r/587/
 ---
 
 (Updated June 23, 2012, 4:34 p.m.)
 
 
 Review request for Viewer.
 
 
 Description
 ---
 
 Add Apply button to the edit content permission floater, now called Adjust 
 Content Permissions.
 
 Minor rewording of title and floater text for clarity and to avoid confusion 
 with STORM-68 (As a Builder, I want that ability to set default permissions 
 on creation of objects, clothing, scripts, notecards, etc.), which is in the 
 pipeline.
 
 
 This addresses bug STORM-1892.
 https://jira.secondlife.com/browse/STORM-1892
 
 
 Diffs
 -
 
   doc/contributions.txt 4d9106153407 
   indra/newview/llfloaterbulkpermission.h 4d9106153407 
   indra/newview/llfloaterbulkpermission.cpp 4d9106153407 
   indra/newview/skins/default/xui/en/floater_bulk_perms.xml 4d9106153407 
 
 Diff: http://codereview.secondlife.com/r/587/diff/diff
 
 
 Testing
 ---
 
 See test plan in jira
 
 
 Thanks,
 
 Jonathan Yap
 


___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges