Re: [opensource-dev] accidental commits...

2012-09-07 Thread Henri Beauchamp
On Thu, 06 Sep 2012 17:30:10 -0400, Oz Linden (Scott Lawrence) wrote:

 We had an accidental push to viewer-development (steps have been taken 
 to avoid a repeat).
 
 The correct tip as of when I'm writing this is 24758:63088c18a73c
 
 Sorry about that...
 
 For the conspiracy-minded, this had nothing whatever to do with todays 
 Jira changes, and all those commits will be coming back when they've 
 been properly tested.

No need to invoke a conspiracy: LL simply *never* understood what
Open Source actually means... The new JIRA fiasco is just another
proof.

'nuff said.

Henri.
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges


Re: [opensource-dev] Review Request: STORM-1893: 'share' function (in friends-list) doesn't bring up the residents' IM window when it's minimized

2012-09-07 Thread MartinRJ Fayray

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/589/
---

(Updated Sept. 7, 2012, 7:31 p.m.)


Review request for Viewer.


Changes
---

Added a check for a null return.


Description
---

Repository is here: https://bitbucket.org/MartinRJ/storm-1893

I just added two calls to show() and setVisible() in LLAvatarActions::share to 
bring the IM window to front even when it's minimized.


This addresses bug STORM-1893.
https://jira.secondlife.com/browse/STORM-1893


Diffs (updated)
-

  doc/contributions.txt 7ae099f5a764 
  indra/newview/llavataractions.cpp 7ae099f5a764 

Diff: http://codereview.secondlife.com/r/589/diff/diff


Testing
---

Please see the test plan in the Jira.


Thanks,

MartinRJ Fayray

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges