Re: [opensource-dev] New Release Viewer 3.4.0 being partially blocked by popular antivirus-software AVAST
On Fri, Sep 14, 2012 at 3:47 AM, Martin Fürholz fuerh...@gmx.net wrote: The latest release viewer 3.4.0 from http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/viewer-release/rev/264700/arch/CYGWIN/installer/Second_Life_3-4-0-264700_Setup.exe is being partially blocked by the popular antivirus-software AVAST. The webkit plugin fails to load. Avast puts it into a sandbox by default because it is: 'not wide-spread enough or has bad reviews'. Avast's heuristics do that with more obscure software all the time. I've even had them randomly sandbox fairly well-known games downloaded from Steam. It might be worth you just disabling some or all of the heuristics until they manage to reduce the false positives a bit. ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: Added a UI field to display group count in the groups floater, plus code to update it. This adresses BUG-81.
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/598/ --- (Updated Sept. 14, 2012, 8:20 a.m.) Review request for Viewer. Changes --- diff updated to confirm with Oz' change request Description --- This patch adds the number of groups you're in to the bottom of the group list. This addresses bug BUG-81. http://jira.secondlife.com/browse/BUG-81 Diffs (updated) - doc/contributions.txt 33a11c2e6c61 indra/newview/llpanelpeople.cpp 33a11c2e6c61 indra/newview/skins/default/xui/en/panel_people.xml 33a11c2e6c61 Diff: http://codereview.secondlife.com/r/598/diff/ Testing --- Testing done in the latest dolphin viewer beta, and in a recent viewer-development fork. The actual implementation has been in Marine Kelleys RLV for a while, and has been adapted with her permission. Thanks, Lance Corrimal ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: Added a UI field to display group count in the groups floater, plus code to update it. This adresses BUG-81.
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/598/#review1260 --- Ship it! Ship It! - Oz Linden On Sept. 14, 2012, 8:20 a.m., Lance Corrimal wrote: --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/598/ --- (Updated Sept. 14, 2012, 8:20 a.m.) Review request for Viewer. Description --- This patch adds the number of groups you're in to the bottom of the group list. This addresses bug BUG-81. http://jira.secondlife.com/browse/BUG-81 Diffs - doc/contributions.txt 33a11c2e6c61 indra/newview/llpanelpeople.cpp 33a11c2e6c61 indra/newview/skins/default/xui/en/panel_people.xml 33a11c2e6c61 Diff: http://codereview.secondlife.com/r/598/diff/ Testing --- Testing done in the latest dolphin viewer beta, and in a recent viewer-development fork. The actual implementation has been in Marine Kelleys RLV for a while, and has been adapted with her permission. Thanks, Lance Corrimal ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: BUG-59: Go-to line function for the internal LSL script editor
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/596/#review1262 --- indra/newview/llpreviewscript.cpp http://codereview.secondlife.com/r/596/#comment1151 Please put new classes in a new file. (Don't mimic my bad code from years ago, please. :) ) indra/newview/llpreviewscript.cpp http://codereview.secondlife.com/r/596/#comment1152 Need null checks on mEditorCore and mEditor indra/newview/llpreviewscript.cpp http://codereview.secondlife.com/r/596/#comment1153 Need null checks on mEditorCore, mEditor and sInstance indra/newview/llpreviewscript.cpp http://codereview.secondlife.com/r/596/#comment1154 minor note: This comment is backwards from the code - you describe the unwritten else case instead of the implemented if case. It confused me at first. Something like '// only deselect, setfocus and close if the cursor actually moved' would match the code written, or moving the comment to after the if block with something like '// else do nothing etc' indra/newview/llpreviewscript.cpp http://codereview.secondlife.com/r/596/#comment1155 Need null pointer checks on mEditorCore and mEditor. - Kelly Washington On Sept. 13, 2012, 8:38 a.m., MartinRJ Fayray wrote: --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/596/ --- (Updated Sept. 13, 2012, 8:38 a.m.) Review request for Viewer. Description --- Repository is here: https://bitbucket.org/MartinRJ/bug-59 I more or less cloned the search-function and modified the floater via xml (new file: floater_goto_line.xml) to fit for a 'go to line' floater. Also I added a callback to prevalidate the input in the 'go to line' line-editor, so that only numbers can be entered into it. This addresses bug BUG-59. https://jira.secondlife.com/browse/BUG-59 Diffs - doc/contributions.txt 7a056d7afeb2 indra/newview/llpreviewscript.h 7a056d7afeb2 indra/newview/llpreviewscript.cpp 7a056d7afeb2 indra/newview/skins/default/xui/en/floater_goto_line.xml PRE-CREATION indra/newview/skins/default/xui/en/panel_script_ed.xml 7a056d7afeb2 Diff: http://codereview.secondlife.com/r/596/diff/ Testing --- Tested on my local PC with a modded 3.3.4-release3 version. Open a script with at least 300 lines inside inventory, go to menu 'Edit- go to line', enter a number less than 300 into the 'Go to' - field. Expected result: the cursor jumps to the entered line number (column 0). Repeat the test with a script inside an object's content. Thanks, MartinRJ Fayray ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
