Re: [opensource-dev] Review Request: STORM-1667 Square brackets around of Release Notes link in the About window
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/506/#review1068 --- Ship it! - Paul On Oct. 25, 2011, 10:28 a.m., Vadim ProductEngine wrote: --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/506/ --- (Updated Oct. 25, 2011, 10:28 a.m.) Review request for Viewer. Summary --- Adding back code that was accidentally removed in changeset ff333a95d1aa (the fix of STORM-1611). This addresses bug STORM-1667. http://jira.secondlife.com/browse/STORM-1667 Diffs - indra/newview/llfloaterabout.cpp 08e65f3ead3d Diff: http://codereview.secondlife.com/r/506/diff Testing --- Thanks, Vadim ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-1668 Localized strings.xml contains reference to non-existing gesture bow1
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/507/#review1069 --- Ship it! - Paul On Oct. 25, 2011, 10:37 a.m., Vadim ProductEngine wrote: --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/507/ --- (Updated Oct. 25, 2011, 10:37 a.m.) Review request for Viewer. Summary --- Fixed references to nonexistent gesture /bow1 in translations. This addresses bug STORM-1668. http://jira.secondlife.com/browse/STORM-1668 Diffs - indra/newview/skins/default/xui/es/strings.xml 08e65f3ead3d indra/newview/skins/default/xui/ja/strings.xml 08e65f3ead3d indra/newview/skins/default/xui/ru/strings.xml 08e65f3ead3d indra/newview/skins/default/xui/tr/strings.xml 08e65f3ead3d Diff: http://codereview.secondlife.com/r/507/diff Testing --- Thanks, Vadim ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-1585 Duplicated XUI ID: floater_preferences_proxy.xml
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/467/#review1021 --- Ship it! Looks good to me. - Paul On Sept. 12, 2011, 5:50 p.m., Vadim ProductEngine wrote: --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/467/ --- (Updated Sept. 12, 2011, 5:50 p.m.) Review request for Viewer and Log Linden. Summary --- Fixed duplicated/missing XUI IDs in floater_preferences_proxy.xml. This addresses bug STORM-1585. http://jira.secondlife.com/browse/STORM-1585 Diffs - indra/newview/skins/default/xui/en/floater_preferences_proxy.xml 25b876619ca6 Diff: http://codereview.secondlife.com/r/467/diff Testing --- Thanks, Vadim ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-1595 Crash in developer builds when changing selection in detached sidebar inventory panel
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/469/#review1022 --- Ship it! - Paul On Sept. 13, 2011, 7:26 a.m., Vadim ProductEngine wrote: --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/469/ --- (Updated Sept. 13, 2011, 7:26 a.m.) Review request for Viewer. Summary --- Removing a wrong debug assertion. This addresses bug STORM-1595. http://jira.secondlife.com/browse/STORM-1595 Diffs - indra/newview/llsidetray.cpp 25b876619ca6 Diff: http://codereview.secondlife.com/r/469/diff Testing --- Thanks, Vadim ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-1597 Inventory Window object profile warped when Inventory Window is a resized floater
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/470/#review1023 --- Ship it! Looks good! - Paul On Sept. 13, 2011, 8:05 a.m., Vadim ProductEngine wrote: --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/470/ --- (Updated Sept. 13, 2011, 8:05 a.m.) Review request for Viewer. Summary --- The Back button int the object profile panel now sticks to the left. This addresses bug STORM-1597. http://jira.secondlife.com/browse/STORM-1597 Diffs - indra/newview/skins/default/xui/en/sidepanel_task_info.xml 25b876619ca6 Diff: http://codereview.secondlife.com/r/470/diff Testing --- Thanks, Vadim ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-1599 Unexpected camera zoom occurs if scroll search history drop-down list by mouse wheel
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/471/#review1024 --- Ship it! Good! - Paul On Sept. 13, 2011, 8:44 a.m., Vadim ProductEngine wrote: --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/471/ --- (Updated Sept. 13, 2011, 8:44 a.m.) Review request for Viewer. Summary --- Trivial fix: don't pass mouse wheel events to parent views. This addresses bug STORM-1599. http://jira.secondlife.com/browse/STORM-1599 Diffs - indra/newview/skins/default/xui/en/panel_navigation_bar.xml 25b876619ca6 Diff: http://codereview.secondlife.com/r/471/diff Testing --- Thanks, Vadim ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-1474 Implement Show Last Search in viewer chrome
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/402/ --- (Updated July 22, 2011, 5:10 a.m.) Review request for Viewer. Changes --- Updated diff according to the new acceptance criteria of this issue. Now floater should be minimized on teleport. Summary (updated) --- - Minimize the search floater on teleport This addresses bug storm-1474. http://jira.secondlife.com/browse/storm-1474 Diffs (updated) - indra/newview/llagent.cpp 216ebc0442d2 Diff: http://codereview.secondlife.com/r/402/diff Testing --- Thanks, Paul ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-1458 ([crashhunters] crash at LLParticipantList::LLParticipantListMenu::isGroupModerator() [secondlife-bin llparticipantlist.cpp])
On July 21, 2011, 4:21 a.m., Boroondas Gupte wrote: indra/newview/llparticipantlist.cpp, lines 807-808 http://codereview.secondlife.com/r/404/diff/2/?file=6722#file6722line807 Hmm ... looking at the comment at https://bitbucket.org/lindenlab/viewer-development/src/d8c37b383028/indra/newview/llagent.h#cl-705 and the implementation of isInGroup at https://bitbucket.org/lindenlab/viewer-development/src/d8c37b383028/indra/newview/llagent.cpp#cl-2414 , this test actually checks whether the agent in question is a member of the group which has an UUID matching the conversation's session ID. Because the session IDs of group chats will match the UUID of the respective groups (and all other chat session types should have session IDs not matching any group UUIDs), this also tells us whether the session is a group chat. So maybe the comment should be yet different to reflect this. (Sorry, should have looked up this stuff for the first review already.) Maybe: // Is session a group chat? (It is if the session ID is the UUID of a group of which the agent is a member.) I wonder whether there is a better way (as in: making less assumptions / not using an agent as pivot) to test for this. I think the comment may be: Is agent in group call/chat ? - Paul --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/404/#review898 --- On July 21, 2011, 3:27 a.m., Paul ProductEngine wrote: --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/404/ --- (Updated July 21, 2011, 3:27 a.m.) Review request for Viewer. Summary --- - Added null checking This addresses bug storm-1458. http://jira.secondlife.com/browse/storm-1458 Diffs - indra/newview/llparticipantlist.cpp d8c37b383028 Diff: http://codereview.secondlife.com/r/404/diff Testing --- Thanks, Paul ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-1458 ([crashhunters] crash at LLParticipantList::LLParticipantListMenu::isGroupModerator() [secondlife-bin llparticipantlist.cpp])
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/404/ --- (Updated July 21, 2011, 7:01 a.m.) Review request for Viewer. Summary --- - Added null checking This addresses bug storm-1458. http://jira.secondlife.com/browse/storm-1458 Diffs (updated) - indra/newview/llparticipantlist.cpp d8c37b383028 Diff: http://codereview.secondlife.com/r/404/diff Testing --- Thanks, Paul ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] Review Request: STORM-1474 Implement Show Last Search in viewer chrome
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/402/ --- Review request for Viewer. Summary --- - Removed hiding floater on teleport This addresses bug storm-1474. http://jira.secondlife.com/browse/storm-1474 Diffs - indra/newview/llagent.cpp d8c37b383028 Diff: http://codereview.secondlife.com/r/402/diff Testing --- Thanks, Paul ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-519 ( Delete is enabled in the context menu for folders which contain worn items)
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/396/ --- (Updated July 19, 2011, 11:11 a.m.) Review request for Viewer. Summary --- - Disable Delete menu item in case selected folder contains non-removable items. This addresses bug storm-519. http://jira.secondlife.com/browse/storm-519 Diffs (updated) - indra/newview/llinventorybridge.cpp 7c7d01be2310 Diff: http://codereview.secondlife.com/r/396/diff Testing --- Thanks, Paul ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-519 ( Delete is enabled in the context menu for folders which contain worn items)
On July 14, 2011, 9:03 a.m., Boroondas Gupte wrote: indra/newview/llinventorybridge.cpp, line 2502 http://codereview.secondlife.com/r/396/diff/1/?file=6693#file6693line2502 We could just use if (!isItemRemovable()) here, couldn't we? You are right. Changed according to your commentaries. - Paul --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/396/#review877 --- On July 19, 2011, 11:11 a.m., Paul ProductEngine wrote: --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/396/ --- (Updated July 19, 2011, 11:11 a.m.) Review request for Viewer. Summary --- - Disable Delete menu item in case selected folder contains non-removable items. This addresses bug storm-519. http://jira.secondlife.com/browse/storm-519 Diffs - indra/newview/llinventorybridge.cpp 7c7d01be2310 Diff: http://codereview.secondlife.com/r/396/diff Testing --- Thanks, Paul ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-1503 (Find floater doesn't set focus to its browser)
On July 14, 2011, 9:05 a.m., Boroondas Gupte wrote: indra/newview/skins/default/xui/en/floater_search.xml, lines 40-43 http://codereview.secondlife.com/r/393/diff/1/?file=6663#file6663line40 While we're editing around here, fix indentation of line 42. It's too late to fix this indentation because the repo for this fix has already been published. - Paul --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/393/#review878 --- On July 13, 2011, 8:48 a.m., Paul ProductEngine wrote: --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/393/ --- (Updated July 13, 2011, 8:48 a.m.) Review request for Viewer. Summary --- Just added tab_stop to the browser. This addresses bug storm-1503. http://jira.secondlife.com/browse/storm-1503 Diffs - indra/newview/skins/default/xui/en/floater_search.xml 68ad362920c1 Diff: http://codereview.secondlife.com/r/393/diff Testing --- Thanks, Paul ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] Review Request: STORM-519 ( Delete is enabled in the context menu for folders which contain worn items)
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/396/ --- Review request for Viewer. Summary --- - Disable Delete menu item in case selected folder contains non-removable items. This addresses bug storm-519. http://jira.secondlife.com/browse/storm-519 Diffs - indra/newview/llinventorybridge.cpp 68ad362920c1 Diff: http://codereview.secondlife.com/r/396/diff Testing --- Thanks, Paul ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] Review Request: STORM-1503 (Find floater doesn't set focus to its browser)
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/393/ --- Review request for Viewer. Summary --- Just added tab_stop to the browser. This addresses bug storm-1503. http://jira.secondlife.com/browse/storm-1503 Diffs - indra/newview/skins/default/xui/en/floater_search.xml 68ad362920c1 Diff: http://codereview.secondlife.com/r/393/diff Testing --- Thanks, Paul ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] Review Request: STORM-1460 (Cursor doesn't go to the input field on the Find Floater due to lack of window focus)
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/386/ --- Review request for Viewer. Summary --- Reason: Focus didn't go to the browser Solution: Set the focus to the browser if a page is loaded and a floater containing a browser has a focus This addresses bug storm-1460. http://jira.secondlife.com/browse/storm-1460 Diffs - indra/newview/llfloatersearch.h 68ad362920c1 indra/newview/llfloatersearch.cpp 68ad362920c1 Diff: http://codereview.secondlife.com/r/386/diff Testing --- Thanks, Paul ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-974 UI button alignment issues in Landmark panel, About Land window, and Hardware Settings window
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/142/#review365 --- Ship it! - Paul On Feb. 8, 2011, 5:22 a.m., Jonathan Yap wrote: --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/142/ --- (Updated Feb. 8, 2011, 5:22 a.m.) Review request for Viewer. Summary --- Please see the jira for the referenced pictures. In picture #1, in the preferences graphics hardware settings, the line of gamma setting is a little too up and it collides with the antialiasing line. In picture #2 in the places tab under my landmarks tab the profile button gets cut off at the end from the rest of the sidebar's UI. There are a number of other buttons with alignment issues with no screenshot. In picture #3 in the Access tab in the About Land window, the remove buttons are off to the right a few millimetres. Changes made were to align the Hardware Settings and About Land buttons and to completely go over the buttons in the Landmarks panel. The small down-arrow at the bottom right corner was using an imbedded UTF-8 so I fixed that and also made it point up while the menu is open (there is a separate jira for reversing the direction it points in these two states). This patch really needs a test viewer built to make sure all works and that nothing was missed in the Landmarks panel. There are 3 other related jiras that I hope are taken in; a test viewer could be made incorporating all 4 jiras at that point. This addresses bug STORM-974. http://jira.secondlife.com/browse/STORM-974 Diffs - indra/newview/skins/default/xui/en/panel_places.xml b0bceb572090 Diff: http://codereview.secondlife.com/r/142/diff Testing --- Thanks, Jonathan ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: (STORM-433) Friendship offer shifted up and placed over Second Life text
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/138/#review339 --- - Paul On Feb. 4, 2011, 10:49 a.m., Seth ProductEngine wrote: --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/138/ --- (Updated Feb. 4, 2011, 10:49 a.m.) Review request for Viewer. Summary --- Fixed reshaping notification panel with friendship offer when it is inserted into IM chat. This addresses bug STORM-433. http://jira.secondlife.com/browse/STORM-433 Diffs - indra/newview/llchathistory.cpp 2fe9d48e5881 indra/newview/lltoastnotifypanel.cpp 2fe9d48e5881 Diff: http://codereview.secondlife.com/r/138/diff Testing --- Thanks, Seth ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: (STORM-433) Friendship offer shifted up and placed over Second Life text
On Feb. 8, 2011, 8:42 a.m., Paul ProductEngine wrote: Looks good. Ship it! - Paul --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/138/#review339 --- On Feb. 4, 2011, 10:49 a.m., Seth ProductEngine wrote: --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/138/ --- (Updated Feb. 4, 2011, 10:49 a.m.) Review request for Viewer. Summary --- Fixed reshaping notification panel with friendship offer when it is inserted into IM chat. This addresses bug STORM-433. http://jira.secondlife.com/browse/STORM-433 Diffs - indra/newview/llchathistory.cpp 2fe9d48e5881 indra/newview/lltoastnotifypanel.cpp 2fe9d48e5881 Diff: http://codereview.secondlife.com/r/138/diff Testing --- Thanks, Seth ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: (STORM-433) Friendship offer shifted up and placed over Second Life text
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/138/#review341 --- Ship it! - Paul On Feb. 4, 2011, 10:49 a.m., Seth ProductEngine wrote: --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/138/ --- (Updated Feb. 4, 2011, 10:49 a.m.) Review request for Viewer. Summary --- Fixed reshaping notification panel with friendship offer when it is inserted into IM chat. This addresses bug STORM-433. http://jira.secondlife.com/browse/STORM-433 Diffs - indra/newview/llchathistory.cpp 2fe9d48e5881 indra/newview/lltoastnotifypanel.cpp 2fe9d48e5881 Diff: http://codereview.secondlife.com/r/138/diff Testing --- Thanks, Seth ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] Review Request: STORM-680 (Avaline callers are added to the Recent list)
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/146/ --- Review request for Viewer. Summary --- - When accepting an avaline call, add a caller to the recent list as AvalineListItem - When adding item to the LLRecentPeople, check whether item with the same phone number exists and delete it if exists. This is need to avoid duplication in the Recent list of the panel People. This addresses bug STORM-680. http://jira.secondlife.com/browse/STORM-680 Diffs - indra/newview/llavatarlist.h 33fc9ed99d29 indra/newview/llavatarlist.cpp 33fc9ed99d29 indra/newview/llrecentpeople.h 33fc9ed99d29 indra/newview/llrecentpeople.cpp 33fc9ed99d29 indra/newview/llvoicechannel.h 33fc9ed99d29 indra/newview/llvoicechannel.cpp 33fc9ed99d29 Diff: http://codereview.secondlife.com/r/146/diff Testing --- Thanks, Paul ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
