[opensource-dev] Code Review Request: VWR-21253 (Permissions icons in the friends list)

[Aimee Linden]

Hi,

Could I get some eyes on a fix for http://jira.secondlife.com/browse/VWR-21253 
...

http://bitbucket.org/aimee_linden/viewer-development-tweaks/changeset/fb38222f1b08

A test build containing this is available here ...

http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/aimee_viewer-development-tweaks/rev/208486/index.html

Thanks,

Aimee.
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Code Review Request: VWR-21253 (Permissions icons in the friends list)

[Marine Kelley]

Err... color me stupid but... how does one show the friends list in this
style on viewer 2 ? I can detach tabs from the sidebar, but I cannot find a
way to show the permissions matrix. It would be so handy !

Thanks,
Marine


On 6 September 2010 18:53, Aimee Linden  wrote:

> Hi,
>
> Could I get some eyes on a fix for
> http://jira.secondlife.com/browse/VWR-21253 ...
>
>
> http://bitbucket.org/aimee_linden/viewer-development-tweaks/changeset/fb38222f1b08
>
> A test build containing this is available here ...
>
>
> http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/aimee_viewer-development-tweaks/rev/208486/index.html
>
> Thanks,
>
> Aimee.
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting
> privileges
>
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Code Review Request: VWR-21253 (Permissions icons in the friends list)

[leliel]

On Mon, Sep 6, 2010 at 10:37 AM, Marine Kelley  wrote:
> Err... color me stupid but... how does one show the friends list in this
> style on viewer 2 ? I can detach tabs from the sidebar, but I cannot find a
> way to show the permissions matrix. It would be so handy !

Hover the mouse over their name in the friends list and it will show
the permission icons.

Works fine for me on Linux. Looks like it uses the 1.23 icons which
don't fit in with the theme on 2.x tho.
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Code Review Request: VWR-21253 (Permissions icons in the friends list)

[Alexandrea Fride]

Works fine on windows to
however icons dont fit with viewer 2 style :)
if not mistaken those are the icons from viewer 1

(and prefered if the icons where a bit smaller in weight & height and more 
easly to define what is what)

@Kelley that was probly a alpha viewer 2 release since if you look at 
chatbar etc style its completly different then we are used to

On Mon, Sep 6, 2010 at 7:50 AM, leliel  wrote:
> On Mon, Sep 6, 2010 at 10:37 AM, Marine Kelley  
> wrote:
>> Err... color me stupid but... how does one show the friends list in this
>> style on viewer 2 ? I can detach tabs from the sidebar, but I cannot find 
>> a
>> way to show the permissions matrix. It would be so handy !
>
> Hover the mouse over their name in the friends list and it will show
> the permission icons.
>
> Works fine for me on Linux. Looks like it uses the 1.23 icons which
> don't fit in with the theme on 2.x tho. 

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Code Review Request: VWR-21253 (Permissions icons in the friends list)

[Boroondas Gupte]

 On 09/06/2010 07:37 PM, Marine Kelley wrote:
> Err... color me stupid but... how does one show the friends list in
> this style on viewer 2 ? I can detach tabs from the sidebar, but I
> cannot find a way to show the permissions matrix. It would be so handy !
> [...]
>
> On 6 September 2010 18:53, Aimee Linden  > wrote:
>
> Hi,
>
> Could I get some eyes on a fix for
> http://jira.secondlife.com/browse/VWR-21253 ...
> [...]
>
I guess you refer to the screenshot attached to the jira issue? Note the
date when that one was added, Oct. 15, 20*09*. Also note the artwork and
color scheme. I guess that was from an early development version of
Viewer 2 that already had the people sidebar tab but also still had the
old code of the contacts panel, so that both could be compared within a
single application. (That, or it's a mock-up.)

If you read the comments you'll note this isn't what Aimee has
implemented now: She shows permissions in the hover tips, it seems.

I'd still prefer to see all perms at one glance without hovering. Moon
Metty's suggestion to only display non-default values would indeed avoid
the cluttering and, more important, would also make these values stand
out. I think this could nicely be done with icons similar the maturity
rating and parcel permission ones in the navigation bar.

Cheers,
Boroondas

PS: why are you CCing to snowst...@lists.lindenlab.com? That list
doesn't seem to exist.
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Code Review Request: VWR-21253 (Permissions icons in the friends list)

[Marine Kelley]

On 6 September 2010 22:23, Boroondas Gupte wrote:

> I guess you refer to the screenshot attached to the jira issue? Note the
> date when that one was added, Oct. 15, 20*09*. Also note the artwork and
> color scheme. I guess that was from an early development version of Viewer 2
> that already had the people sidebar tab but also still had the old code of
> the contacts panel, so that both could be compared within a single
> application. (That, or it's a mock-up.)
>

Yes that's what I suspected, but there was a chance that the old code would
still be there and activated with a secret voodoo gesture.



> PS: why are you CCing to snowst...@lists.lindenlab.com? That list doesn't
> seem to exist.
>

I replied to all as I always do, without bothering to what list I was
actually sending. lol
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Code Review Request: VWR-21253 (Permissions icons in the friends list)

[Aimee Linden]

> On 09/06/2010 07:37 PM, Marine Kelley wrote:
>> 
>> Err... color me stupid but... how does one show the friends list in this 
>> style on viewer 2 ? I can detach tabs from the sidebar, but I cannot find a 
>> way to show the permissions matrix. It would be so handy !

On 6 Sep 2010, at 21:23, Boroondas Gupte wrote:

> I guess you refer to the screenshot attached to the jira issue? Note the date 
> when that one was added, Oct. 15, 2009. Also note the artwork and color 
> scheme. I guess that was from an early development version of Viewer 2 that 
> already had the people sidebar tab but also still had the old code of the 
> contacts panel, so that both could be compared within a single application. 
> (That, or it's a mock-up.)

Yes, that screenshot is quite old, sorry for the confusion :)

> If you read the comments you'll note this isn't what Aimee has implemented 
> now: She shows permissions in the hover tips, it seems.

The permission icons appear inline, alongside the 'i' and '->' buttons for each 
person.
> 
> I'd still prefer to see all perms at one glance without hovering. Moon 
> Metty's suggestion to only display non-default values would indeed avoid the 
> cluttering and, more important, would also make these values stand out. I 
> think this could nicely be done with icons similar the maturity rating and 
> parcel permission ones in the navigation bar.

On 6 Sep 2010, at 20:50, leliel wrote:

> Works fine for me on Linux. Looks like it uses the 1.23 icons which
> don't fit in with the theme on 2.x tho.

Yes that's expected, just temporary until we have new artwork.

Aimee.

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Code Review Request: VWR-21253 (Permissions icons in the friends list)

[Boroondas Gupte]

 During testing, I made some interesting observations that I wanted to
comment about, but JIRA is read-only at the moment, so I'll just paste
it here:

Tested, works as expected with the following exceptions:


  Revoking "See my online status" permission automatically also
  revokes "See me on the map" permission

This can be seen by the following observations:

* In *step 8*, the "See me on the map" icon also no longer appears
* In *step 9*, the "See me on the map" is already unchecked
  (OFF), so this step cannot be performed

I guess this is expected behavior, as the ability to locate someone
on the map would leak the fact that they're online. However, I think
there should be some visual indication of this when revoking the
"See my online status" permission. I.e. in *step 7*, we should have:

* *Expected:* The "See me on the map" checkbox is unchecked
  (OFF) and disabled (grayed out)


  Permission icons not updating for granter while hovering over
  grantee's name


To reproduce:

As TESTER1:

   1. View "Notes & Privacy" of TESTER2's profile and change the
  permissions.
   2. Immediately click *[<]* to return to TESTER1's friend list.
   3. Immediately hover over TESTER2's name.
  * *Observed:* Sometimes you still see the old permissions.
  * *Observed:* If this happens, as long as you keep
hovering, they won't update.
   4. Move the mouse off the friends list.
   5. Re-hover the mouse cursor over TESTER2's name.
  * *Observed:* Now the visible icons correspond to the new
permissions.

Interestingly, when TESTER2 hovers over TESTER1's name while TESTER1
changes the "Edit, delete or take my objects" permission, TESTER2
will see the corresponding icon appear/disappear without having to
un-hover and re-hover.

On 09/07/2010 01:18 PM, Aimee Linden wrote:
>> If you read the comments you'll note this isn't what Aimee has
>> implemented now: She shows permissions in the hover tips, it seems.
>
> The permission icons appear inline, alongside the 'i' and '->' buttons
> for each person.
Yes, I noticed that when finally testing your build myself today. This
is of course much better than in tool tips, because like this the icons
are visible immediately on mouse-over. :-) While that makes it less
pressing, I still stand by my wish below:
>> I'd still prefer to see all perms at one glance without hovering.
>> Moon Metty's suggestion to only display non-default values would
>> indeed avoid the cluttering and, more important, would also make
>> these values stand out. I think this could nicely be done with icons
>> similar the maturity rating and parcel permission ones in the
>> navigation bar.
I don't really see the use case for the option to *not show* the icons
even *when hovering*. Maybe the above could be solved by replacing it
with an option to *show* the icons even *when not hovering*?

Cheers,
Boroondas
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Code Review Request: VWR-21253 (Permissions icons in the friends list)

[Ardy Lay]

  On 9/6/2010 11:53 AM, Aimee Linden wrote:
> Hi,
>
> Could I get some eyes on a fix for 
> http://jira.secondlife.com/browse/VWR-21253 ...
>
> http://bitbucket.org/aimee_linden/viewer-development-tweaks/changeset/fb38222f1b08
>
> A test build containing this is available here ...
>
> http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/aimee_viewer-development-tweaks/rev/208486/index.html
>
> Thanks,
>
> Aimee.
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting privileges
The provided build implodes 4 seconds after launch it on Windows 7.
I'll pick up the change set, build that and see what happens.
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Code Review Request: VWR-21253 (Permissions icons in the friends list)

[Alexandrea Fride]

llkdu.dll problem hapend to me to, replace the dll from the officialy viewer 
2.1 or devenlopbuild that worked

--
From: "Ardy Lay" 
Sent: Tuesday, September 07, 2010 4:18 PM
To: 
Subject: Re: [opensource-dev] Code Review Request: VWR-21253 (Permissions 
icons in the friends list)

> The provided build implodes 4 seconds after launch it on Windows 7.
> I'll pick up the change set, build that and see what happens. 

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Code Review Request: VWR-21253 (Permissions icons in the friends list)

[Aimee Linden]

Ah yep, that build's not been rebuilt since before the LLKDU fix, sorry about 
that, a new build should be up shortly.

Aimee.

On 7 Sep 2010, at 15:21, Alexandrea Fride wrote:

> llkdu.dll problem hapend to me to, replace the dll from the officialy viewer 
> 2.1 or devenlopbuild that worked
> 
> --
> From: "Ardy Lay" 
> Sent: Tuesday, September 07, 2010 4:18 PM
> To: 
> Subject: Re: [opensource-dev] Code Review Request: VWR-21253 (Permissions 
> icons in the friends list)
> 
>> The provided build implodes 4 seconds after launch it on Windows 7.
>> I'll pick up the change set, build that and see what happens. 
> 
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting privileges

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges