[opensource-dev] Review Request: BUG-540: Math updates by Moon Metty. Reviewed by Chieron Tenk.
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/606/ --- Review request for Viewer. Description --- Improved functions: getEulerAngles ( now: setQuat(F32 roll, F32 pitch, F32 yaw) ) packToVector3 getAngleAxis setAngleAxis shortestArc projected_vec angle_between For details please see: http://jira.phoenixviewer.com/browse/FIRE-7989 and http://jira.phoenixviewer.com/browse/FIRE-7997 This addresses bug BUG-540. https://jira.secondlife.com/browse/BUG-540 Diffs - indra/llmath/llmath.h f32c39fdfcfe indra/llmath/llquaternion.h f32c39fdfcfe indra/llmath/llquaternion.cpp f32c39fdfcfe indra/llmath/v3math.h f32c39fdfcfe Diff: http://codereview.secondlife.com/r/606/diff/ Testing --- Please go to https://jira.secondlife.com/browse/BUG-540 Thanks, MartinRJ Fayray ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: BUG-540: Math updates by Moon Metty. Reviewed by Chieron Tenk.
On Wed, 24 Oct 2012 07:22:27 -, MartinRJ Fayray wrote: This addresses bug BUG-540. https://jira.secondlife.com/browse/BUG-540 .../... Testing --- Please go to https://jira.secondlife.com/browse/BUG-540 Permission Violation Gotta love the crippled JIRA... :-( Henri. ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: BUG-540: Math updates by Moon Metty. Reviewed by Chieron Tenk.
On Wed, Oct 24, 2012 at 12:45 AM, Henri Beauchamp sl...@free.fr wrote: On Wed, 24 Oct 2012 07:22:27 -, MartinRJ Fayray wrote: This addresses bug BUG-540. https://jira.secondlife.com/browse/BUG-540 .../... Testing --- Please go to https://jira.secondlife.com/browse/BUG-540 Permission Violation Gotta love the crippled JIRA... :-( Henri. ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges Try these links:see http://jira.phoenixviewer.com/browse/FIRE-7989 and http://jira.phoenixviewer.com/browse/FIRE-7997 ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: BUG-540: Math updates by Moon Metty. Reviewed by Chieron Tenk.
On Wed, 24 Oct 2012 12:56:21 -0400 Geenz Spad ge...@exodusviewer.com wrote: Question: I noticed that at least one item on the Firestorm JIRA had listed instruction count differences, however I'd be more interested in seeing actual execution time measurement differences between the two. Has the execution time between the originals and modified versions of the code been measured? I second that. I also like to see some benchmarks. -- Techwolf Lupindo ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: BUG-540: Math updates by Moon Metty. Reviewed by Chieron Tenk.
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/606/ --- (Updated Oct. 24, 2012, 10:44 p.m.) Review request for Viewer. Changes --- Fixed the attachment bug. Test/performance results will be posted later. I also updated the repository at https://bitbucket.org/MartinRJ/bug-540 Description --- Improved functions: getEulerAngles ( now: setQuat(F32 roll, F32 pitch, F32 yaw) ) packToVector3 getAngleAxis setAngleAxis shortestArc projected_vec angle_between For details please see: http://jira.phoenixviewer.com/browse/FIRE-7989 and http://jira.phoenixviewer.com/browse/FIRE-7997 This addresses bug BUG-540. https://jira.secondlife.com/browse/BUG-540 Diffs (updated) - indra/llmath/llmath.h f32c39fdfcfe indra/llmath/llquaternion.h f32c39fdfcfe indra/llmath/llquaternion.cpp f32c39fdfcfe indra/llmath/v3math.h f32c39fdfcfe Diff: http://codereview.secondlife.com/r/606/diff/ Testing --- Please go to https://jira.secondlife.com/browse/BUG-540 Thanks, MartinRJ Fayray ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
