Re: [opensource-dev] Review Request: Fixes paste action in editor windows.

[Ima Mechanique]

> On May 11, 2012, 6:20 a.m., Oz Linden wrote:
> > indra/llui/lltexteditor.h, line 242
> > 
> >
> > It would be much clearer when reading calls to this method if the 
> > parameter were an enum rather than a boolean.  Consider the readability 
> > difference between:
> >  addLineBreakChar(FALSE);
> > and
> >  addLineBreakChar(DoNotGroupLines);
> >
> 
> Ima Mechanique wrote:
> This would require additional, and IMO, inelegant code to set an 
> additional boolean variable in the function.
> A comment would make it equally, if not more, clear and not require 
> unnecessary code or an enum.

After adding the diff with comments, it occurred to me a constant could also be 
used.

addLineBreakChar(GROUP_LINES);


- Ima


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/579/#review1219
---


On May 13, 2012, 10:15 p.m., Ima Mechanique wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/579/
> ---
> 
> (Updated May 13, 2012, 10:15 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Description
> ---
> 
> Fixes paste action in editor windows (notecards, scripts, etc.) so that 
> pasting text is a single action as far as Undo is concerned.
> This is an updating of Satomi Ahn's patch to work with v3.3.1.
> 
> 
> This addresses bug VWR-20553.
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt 3142ebd0bc5a 
>   indra/llui/lltexteditor.h 3142ebd0bc5a 
>   indra/llui/lltexteditor.cpp 3142ebd0bc5a 
> 
> Diff: http://codereview.secondlife.com/r/579/diff/diff
> 
> 
> Testing
> ---
> 
> Tried pasting/undoing.
> 
> 
> Thanks,
> 
> Ima Mechanique
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Fixes paste action in editor windows.

[Ima Mechanique]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/579/
---

(Updated May 13, 2012, 10:15 p.m.)


Review request for Viewer.


Changes
---

Updated diff, with comments, to address readability.


Description
---

Fixes paste action in editor windows (notecards, scripts, etc.) so that pasting 
text is a single action as far as Undo is concerned.
This is an updating of Satomi Ahn's patch to work with v3.3.1.


This addresses bug VWR-20553.


Diffs (updated)
-

  doc/contributions.txt 3142ebd0bc5a 
  indra/llui/lltexteditor.h 3142ebd0bc5a 
  indra/llui/lltexteditor.cpp 3142ebd0bc5a 

Diff: http://codereview.secondlife.com/r/579/diff/diff


Testing
---

Tried pasting/undoing.


Thanks,

Ima Mechanique

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Fixes paste action in editor windows.

[Ima Mechanique]

> On May 11, 2012, 6:20 a.m., Oz Linden wrote:
> > indra/llui/lltexteditor.h, line 242
> > 
> >
> > It would be much clearer when reading calls to this method if the 
> > parameter were an enum rather than a boolean.  Consider the readability 
> > difference between:
> >  addLineBreakChar(FALSE);
> > and
> >  addLineBreakChar(DoNotGroupLines);
> >

This would require additional, and IMO, inelegant code to set an additional 
boolean variable in the function.
A comment would make it equally, if not more, clear and not require unnecessary 
code or an enum.


- Ima


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/579/#review1219
---


On May 5, 2012, 8:06 p.m., Ima Mechanique wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/579/
> ---
> 
> (Updated May 5, 2012, 8:06 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Description
> ---
> 
> Fixes paste action in editor windows (notecards, scripts, etc.) so that 
> pasting text is a single action as far as Undo is concerned.
> This is an updating of Satomi Ahn's patch to work with v3.3.1.
> 
> 
> This addresses bug VWR-20553.
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt 3142ebd0bc5a 
>   indra/llui/lltexteditor.h 3142ebd0bc5a 
>   indra/llui/lltexteditor.cpp 3142ebd0bc5a 
> 
> Diff: http://codereview.secondlife.com/r/579/diff/diff
> 
> 
> Testing
> ---
> 
> Tried pasting/undoing.
> 
> 
> Thanks,
> 
> Ima Mechanique
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Fixes paste action in editor windows.

[Oz Linden]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/579/#review1219
---



indra/llui/lltexteditor.h


It would be much clearer when reading calls to this method if the parameter 
were an enum rather than a boolean.  Consider the readability difference 
between:
 addLineBreakChar(FALSE);
and
 addLineBreakChar(DoNotGroupLines);



- Oz Linden


On May 5, 2012, 8:06 p.m., Ima Mechanique wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/579/
> ---
> 
> (Updated May 5, 2012, 8:06 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Description
> ---
> 
> Fixes paste action in editor windows (notecards, scripts, etc.) so that 
> pasting text is a single action as far as Undo is concerned.
> This is an updating of Satomi Ahn's patch to work with v3.3.1.
> 
> 
> This addresses bug VWR-20553.
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt 3142ebd0bc5a 
>   indra/llui/lltexteditor.h 3142ebd0bc5a 
>   indra/llui/lltexteditor.cpp 3142ebd0bc5a 
> 
> Diff: http://codereview.secondlife.com/r/579/diff/diff
> 
> 
> Testing
> ---
> 
> Tried pasting/undoing.
> 
> 
> Thanks,
> 
> Ima Mechanique
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Fixes paste action in editor windows.

[Ima Mechanique]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/579/
---

(Updated May 5, 2012, 8:06 p.m.)


Review request for Viewer.


Description
---

Fixes paste action in editor windows (notecards, scripts, etc.) so that pasting 
text is a single action as far as Undo is concerned.
This is an updating of Satomi Ahn's patch to work with v3.3.1.


This addresses bug VWR-20553.


Diffs
-

  doc/contributions.txt 3142ebd0bc5a 
  indra/llui/lltexteditor.h 3142ebd0bc5a 
  indra/llui/lltexteditor.cpp 3142ebd0bc5a 

Diff: http://codereview.secondlife.com/r/579/diff/diff


Testing
---

Tried pasting/undoing.


Thanks,

Ima Mechanique

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: Fixes paste action in editor windows.

[Ima Mechanique]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/579/
---

Review request for Viewer.


Description
---

Fixes paste action in editor windows (notecards, scripts, etc.) so that pasting 
text is a single action as far as Undo is concerned.
This is an updating of Satomi Ahn's patch to work with v3.3.1.


This addresses bug VWR-20553.


Diffs
-

  doc/contributions.txt 3142ebd0bc5a 
  indra/llui/lltexteditor.h 3142ebd0bc5a 
  indra/llui/lltexteditor.cpp 3142ebd0bc5a 

Diff: http://codereview.secondlife.com/r/579/diff/diff


Testing
---

Tried pasting/undoing.


Thanks,

Ima Mechanique

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges