Re: [opensource-dev] Review Request: STORM-1879: Inventory gear menu remains on screen after floater is closed

2012-08-16 Thread Oz Linden

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/588/#review1246
---

Ship it!


Ship It!

- Oz Linden


On June 25, 2012, 5:45 a.m., MartinRJ Fayray wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://codereview.secondlife.com/r/588/
 ---
 
 (Updated June 25, 2012, 5:45 a.m.)
 
 
 Review request for Viewer.
 
 
 Description
 ---
 
 Hide menus when the closed floater has focus.
 Added a check whether a VisibilityChange-action was triggered via shortcut.
 
 Repository: https://bitbucket.org/MartinRJ/storm-1879
 
 
 This addresses bug STORM-1879.
 https://jira.secondlife.com/browse/STORM-1879
 
 
 Diffs
 -
 
   indra/llui/llfloater.cpp 4d9106153407 
   indra/llui/lltoggleablemenu.cpp 4d9106153407 
 
 Diff: http://codereview.secondlife.com/r/588/diff/diff
 
 
 Testing
 ---
 
 See test plan in JIRA: https://jira.secondlife.com/browse/STORM-1879
 
 
 Thanks,
 
 MartinRJ Fayray
 


___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1879: Inventory gear menu remains on screen after floater is closed

2012-06-25 Thread MartinRJ Fayray

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/588/
---

(Updated June 25, 2012, 5:45 a.m.)


Review request for Viewer.


Changes
---

Updated only some comments.


Description
---

Hide menus when the closed floater has focus.
Added a check whether a VisibilityChange-action was triggered via shortcut.

Repository: https://bitbucket.org/MartinRJ/storm-1879


This addresses bug STORM-1879.
https://jira.secondlife.com/browse/STORM-1879


Diffs (updated)
-

  indra/llui/llfloater.cpp 4d9106153407 
  indra/llui/lltoggleablemenu.cpp 4d9106153407 

Diff: http://codereview.secondlife.com/r/588/diff/diff


Testing
---

See test plan in JIRA: https://jira.secondlife.com/browse/STORM-1879


Thanks,

MartinRJ Fayray

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: STORM-1879: Inventory gear menu remains on screen after floater is closed

2012-06-24 Thread MartinRJ Fayray

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/588/
---

Review request for Viewer.


Description
---

Hide menus when the closed floater has focus.
Added a check whether a VisibilityChange-action was triggered via shortcut.

Repository: https://bitbucket.org/MartinRJ/storm-1879


This addresses bug STORM-1879.
https://jira.secondlife.com/browse/STORM-1879


Diffs
-

  indra/llui/llfloater.cpp 4d9106153407 
  indra/llui/lltoggleablemenu.cpp 4d9106153407 

Diff: http://codereview.secondlife.com/r/588/diff/diff


Testing
---

See test plan in JIRA: https://jira.secondlife.com/browse/STORM-1879


Thanks,

MartinRJ Fayray

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges