[opensource-dev] Review Request: STORM-1893: 'share' function (in friends-list) doesn't bring up the residents' IM window when it's minimized

[MartinRJ Fayray]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/589/
---

Review request for Viewer.


Description
---

Repository is here: https://bitbucket.org/MartinRJ/storm-1893

I just added two calls to show() and setVisible() in LLAvatarActions::share to 
bring the IM window to front even when it's minimized.


This addresses bug STORM-1893.
https://jira.secondlife.com/browse/STORM-1893


Diffs
-

  indra/newview/llavataractions.cpp 4d9106153407 

Diff: http://codereview.secondlife.com/r/589/diff/diff


Testing
---

Please see the test plan in the Jira.


Thanks,

MartinRJ Fayray

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1893: 'share' function (in friends-list) doesn't bring up the residents' IM window when it's minimized

[Oz Linden]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/589/#review1245
---



indra/newview/llavataractions.cpp


Shouldn't this check for a null return?


- Oz Linden


On July 2, 2012, 3:59 p.m., MartinRJ Fayray wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/589/
> ---
> 
> (Updated July 2, 2012, 3:59 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Description
> ---
> 
> Repository is here: https://bitbucket.org/MartinRJ/storm-1893
> 
> I just added two calls to show() and setVisible() in LLAvatarActions::share 
> to bring the IM window to front even when it's minimized.
> 
> 
> This addresses bug STORM-1893.
> https://jira.secondlife.com/browse/STORM-1893
> 
> 
> Diffs
> -
> 
>   indra/newview/llavataractions.cpp 4d9106153407 
> 
> Diff: http://codereview.secondlife.com/r/589/diff/diff
> 
> 
> Testing
> ---
> 
> Please see the test plan in the Jira.
> 
> 
> Thanks,
> 
> MartinRJ Fayray
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1893: 'share' function (in friends-list) doesn't bring up the residents' IM window when it's minimized

[MartinRJ Fayray]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/589/
---

(Updated Sept. 7, 2012, 7:31 p.m.)


Review request for Viewer.


Changes
---

Added a check for a null return.


Description
---

Repository is here: https://bitbucket.org/MartinRJ/storm-1893

I just added two calls to show() and setVisible() in LLAvatarActions::share to 
bring the IM window to front even when it's minimized.


This addresses bug STORM-1893.
https://jira.secondlife.com/browse/STORM-1893


Diffs (updated)
-

  doc/contributions.txt 7ae099f5a764 
  indra/newview/llavataractions.cpp 7ae099f5a764 

Diff: http://codereview.secondlife.com/r/589/diff/diff


Testing
---

Please see the test plan in the Jira.


Thanks,

MartinRJ Fayray

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1893: 'share' function (in friends-list) doesn't bring up the residents' IM window when it's minimized

[Oz Linden]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/589/#review1250
---

Ship it!


Ship It!

- Oz Linden


On Sept. 7, 2012, 7:31 p.m., MartinRJ Fayray wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/589/
> ---
> 
> (Updated Sept. 7, 2012, 7:31 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Description
> ---
> 
> Repository is here: https://bitbucket.org/MartinRJ/storm-1893
> 
> I just added two calls to show() and setVisible() in LLAvatarActions::share 
> to bring the IM window to front even when it's minimized.
> 
> 
> This addresses bug STORM-1893.
> https://jira.secondlife.com/browse/STORM-1893
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt 7ae099f5a764 
>   indra/newview/llavataractions.cpp 7ae099f5a764 
> 
> Diff: http://codereview.secondlife.com/r/589/diff/diff
> 
> 
> Testing
> ---
> 
> Please see the test plan in the Jira.
> 
> 
> Thanks,
> 
> MartinRJ Fayray
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges