Re: [opensource-dev] Review Request: STORM-465 Missing Strings from strings.xml
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/108/#review318 --- Ship it! I'm happy now. :) - Kent On Feb. 3, 2011, 8:20 a.m., Vadim ProductEngine wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/108/ > --- > > (Updated Feb. 3, 2011, 8:20 a.m.) > > > Review request for Viewer. > > > Summary > --- > > Made all keys localizable. > > > This addresses bug STORM-465. > http://jira.secondlife.com/browse/STORM-465 > > > Diffs > - > > indra/newview/llmaniprotate.cpp b542f8134a2b > indra/newview/skins/default/xui/da/strings.xml b542f8134a2b > indra/newview/skins/default/xui/de/strings.xml b542f8134a2b > indra/newview/skins/default/xui/en/strings.xml b542f8134a2b > indra/newview/skins/default/xui/es/strings.xml b542f8134a2b > indra/newview/skins/default/xui/fr/strings.xml b542f8134a2b > indra/newview/skins/default/xui/it/strings.xml b542f8134a2b > indra/newview/skins/default/xui/ja/strings.xml b542f8134a2b > indra/newview/skins/default/xui/nl/strings.xml b542f8134a2b > indra/newview/skins/default/xui/pl/strings.xml b542f8134a2b > indra/newview/skins/default/xui/pt/strings.xml b542f8134a2b > > Diff: http://codereview.secondlife.com/r/108/diff > > > Testing > --- > > Tested on Linux. No keys produce the warning for me. > > > Thanks, > > Vadim > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-465 Missing Strings from strings.xml
> On Feb. 2, 2011, 8:56 a.m., Kent Quirk wrote: > > So I have a couple of issues with this patch: > > > > * I'm worried about the translation impact, how these strings are used and > > where. Should they be localized? Should they not be localized? I find it > > hard to believe that we ONLY need to translate Home and End. > > * The "1" key is duplicated. Are there others? > > * I think the single-letter keys should be placed in a more useful order so > > that we can easily find missing items. Keyboard order (especially since > > keyboards differ) is not good enough. > > * I'm worried about the naming convention; single-letter names (ahem, yes, > > I know who's talking here) can be rather ambiguous. It's probably the > > easiest fix -- anything else may require much more extensive changes -- but > > I'm worried about this. Is this fix robust under localization? > > > > I haven't had time to investigate these issues yet; does someone else have > > the knowledge to discuss? > > > > Vadim ProductEngine wrote: > 1) AFAIU, only those keys need translation that are currrently used in > menu shortcuts (see menu_*.xml). >We don't know in advance what keys we're gonna use in future > shortcuts, so it makes sense to make them all localizable. > 2) Thanks, the "1" is indeed duplicated. Looks like a copy&paste issue. > 3) Ok, the order doesn't matter to me. I can change it if you want. > 4) I borrowed the naming style from existing code (see llkeyboard.cpp). > Moreover, we tried adding "Key_" prefix to key names for the same reasons as > you say, but had to roll that change back because it had broken translation > of older shortcuts (see comments in STORM-362). > > Kent Quirk wrote: > I would like to see a revised changeset please, reflecting 2 and 3. I'm > happy with your responses to 1 and 4. > > Torben Trautman wrote: > There is a few more keys that have been localized or need to be > localized. In german we also translated Shift (Umschalt) and Home > (Zuhause)[which is a wrong translation by the way]. We still need to localize > ` (snapshot to disk and region debug console shortcuts don´t work in german) > and \ (Look at last speaker shortcut doesn´t work). I´m pretty sure this is > also true at least for french. > > Hope this helps :) > > Dil Spitz wrote: > just a tiny hint, on my german keyboard they call home (Pos 1) > > Dil Spitz wrote: > indeed the de\strings.xml looks like google translated it. > Now i remember why i always switch SL to english ;) > Due the translation is out of the context in the strings.xml a normal > translating person, who do not know SL, couldn't get the job right. > /me guessing the other non-english languages might look like the german > too. > I suggest to give the residents a role to tune the translation of the > language they speak. https://jira.secondlife.com/browse/VWR-24712 Dil, it's not me who works on the German translation. :-) I think you should file bugs about invalid translations you notice. - Vadim --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/108/#review307 --- On Feb. 3, 2011, 8:20 a.m., Vadim ProductEngine wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/108/ > --- > > (Updated Feb. 3, 2011, 8:20 a.m.) > > > Review request for Viewer. > > > Summary > --- > > Made all keys localizable. > > > This addresses bug STORM-465. > http://jira.secondlife.com/browse/STORM-465 > > > Diffs > - > > indra/newview/llmaniprotate.cpp b542f8134a2b > indra/newview/skins/default/xui/da/strings.xml b542f8134a2b > indra/newview/skins/default/xui/de/strings.xml b542f8134a2b > indra/newview/skins/default/xui/en/strings.xml b542f8134a2b > indra/newview/skins/default/xui/es/strings.xml b542f8134a2b > indra/newview/skins/default/xui/fr/strings.xml b542f8134a2b > indra/newview/skins/default/xui/it/strings.xml b542f8134a2b > indra/newview/skins/default/xui/ja/strings.xml b542f8134a2b > indra/newview/skins/default/xui/nl/strings.xml b542f8134a2b > indra/newview/skins/default/xui/pl/strings.xml b542f8134a2b > indra/newview/skins/default/xui/pt/strings.xml b542f8134a2b > > Diff: http://codereview.secondlife.com/r/108/diff > > > Testing > --- > > Tested on Linux. No keys produce the warning for me. > > > Thanks, > > Vadim > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-465 Missing Strings from strings.xml
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/108/
---
(Updated Feb. 3, 2011, 8:20 a.m.)
Review request for Viewer.
Changes
---
- Reordered strings more logically.
- Removed duplicated "1" string.
- Using a script, found two more duplicates ("Home", "Esc"), removed them.
- Using the same script, found out that the arrow keys names ("Left", "Right",
"Up", "Down") were duplicated as well.
Fixed that by renaming HUD direction strings and updated the code utilizing
them accordingly.
Automated the work as much as possible to avoid further errors (I hope that
helped :-)).
Summary
---
Made all keys localizable.
This addresses bug STORM-465.
http://jira.secondlife.com/browse/STORM-465
Diffs (updated)
-
indra/newview/llmaniprotate.cpp b542f8134a2b
indra/newview/skins/default/xui/da/strings.xml b542f8134a2b
indra/newview/skins/default/xui/de/strings.xml b542f8134a2b
indra/newview/skins/default/xui/en/strings.xml b542f8134a2b
indra/newview/skins/default/xui/es/strings.xml b542f8134a2b
indra/newview/skins/default/xui/fr/strings.xml b542f8134a2b
indra/newview/skins/default/xui/it/strings.xml b542f8134a2b
indra/newview/skins/default/xui/ja/strings.xml b542f8134a2b
indra/newview/skins/default/xui/nl/strings.xml b542f8134a2b
indra/newview/skins/default/xui/pl/strings.xml b542f8134a2b
indra/newview/skins/default/xui/pt/strings.xml b542f8134a2b
Diff: http://codereview.secondlife.com/r/108/diff
Testing
---
Tested on Linux. No keys produce the warning for me.
Thanks,
Vadim
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-465 Missing Strings from strings.xml
> On Feb. 2, 2011, 8:56 a.m., Kent Quirk wrote: > > So I have a couple of issues with this patch: > > > > * I'm worried about the translation impact, how these strings are used and > > where. Should they be localized? Should they not be localized? I find it > > hard to believe that we ONLY need to translate Home and End. > > * The "1" key is duplicated. Are there others? > > * I think the single-letter keys should be placed in a more useful order so > > that we can easily find missing items. Keyboard order (especially since > > keyboards differ) is not good enough. > > * I'm worried about the naming convention; single-letter names (ahem, yes, > > I know who's talking here) can be rather ambiguous. It's probably the > > easiest fix -- anything else may require much more extensive changes -- but > > I'm worried about this. Is this fix robust under localization? > > > > I haven't had time to investigate these issues yet; does someone else have > > the knowledge to discuss? > > > > Vadim ProductEngine wrote: > 1) AFAIU, only those keys need translation that are currrently used in > menu shortcuts (see menu_*.xml). >We don't know in advance what keys we're gonna use in future > shortcuts, so it makes sense to make them all localizable. > 2) Thanks, the "1" is indeed duplicated. Looks like a copy&paste issue. > 3) Ok, the order doesn't matter to me. I can change it if you want. > 4) I borrowed the naming style from existing code (see llkeyboard.cpp). > Moreover, we tried adding "Key_" prefix to key names for the same reasons as > you say, but had to roll that change back because it had broken translation > of older shortcuts (see comments in STORM-362). > > Kent Quirk wrote: > I would like to see a revised changeset please, reflecting 2 and 3. I'm > happy with your responses to 1 and 4. There is a few more keys that have been localized or need to be localized. In german we also translated Shift (Umschalt) and Home (Zuhause)[which is a wrong translation by the way]. We still need to localize ` (snapshot to disk and region debug console shortcuts don´t work in german) and \ (Look at last speaker shortcut doesn´t work). I´m pretty sure this is also true at least for french. Hope this helps :) - Torben --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/108/#review307 --- On Jan. 19, 2011, 8:30 a.m., Vadim ProductEngine wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/108/ > --- > > (Updated Jan. 19, 2011, 8:30 a.m.) > > > Review request for Viewer. > > > Summary > --- > > Made all keys localizable. > > > This addresses bug STORM-465. > http://jira.secondlife.com/browse/STORM-465 > > > Diffs > - > > indra/newview/skins/default/xui/en/strings.xml 38465c40c060 > > Diff: http://codereview.secondlife.com/r/108/diff > > > Testing > --- > > Tested on Linux. No keys produce the warning for me. > > > Thanks, > > Vadim > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-465 Missing Strings from strings.xml
> On Feb. 2, 2011, 8:56 a.m., Kent Quirk wrote: > > So I have a couple of issues with this patch: > > > > * I'm worried about the translation impact, how these strings are used and > > where. Should they be localized? Should they not be localized? I find it > > hard to believe that we ONLY need to translate Home and End. > > * The "1" key is duplicated. Are there others? > > * I think the single-letter keys should be placed in a more useful order so > > that we can easily find missing items. Keyboard order (especially since > > keyboards differ) is not good enough. > > * I'm worried about the naming convention; single-letter names (ahem, yes, > > I know who's talking here) can be rather ambiguous. It's probably the > > easiest fix -- anything else may require much more extensive changes -- but > > I'm worried about this. Is this fix robust under localization? > > > > I haven't had time to investigate these issues yet; does someone else have > > the knowledge to discuss? > > > > Vadim ProductEngine wrote: > 1) AFAIU, only those keys need translation that are currrently used in > menu shortcuts (see menu_*.xml). >We don't know in advance what keys we're gonna use in future > shortcuts, so it makes sense to make them all localizable. > 2) Thanks, the "1" is indeed duplicated. Looks like a copy&paste issue. > 3) Ok, the order doesn't matter to me. I can change it if you want. > 4) I borrowed the naming style from existing code (see llkeyboard.cpp). > Moreover, we tried adding "Key_" prefix to key names for the same reasons as > you say, but had to roll that change back because it had broken translation > of older shortcuts (see comments in STORM-362). I would like to see a revised changeset please, reflecting 2 and 3. I'm happy with your responses to 1 and 4. - Kent --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/108/#review307 --- On Jan. 19, 2011, 8:30 a.m., Vadim ProductEngine wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/108/ > --- > > (Updated Jan. 19, 2011, 8:30 a.m.) > > > Review request for Viewer. > > > Summary > --- > > Made all keys localizable. > > > This addresses bug STORM-465. > http://jira.secondlife.com/browse/STORM-465 > > > Diffs > - > > indra/newview/skins/default/xui/en/strings.xml 38465c40c060 > > Diff: http://codereview.secondlife.com/r/108/diff > > > Testing > --- > > Tested on Linux. No keys produce the warning for me. > > > Thanks, > > Vadim > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-465 Missing Strings from strings.xml
> On Feb. 2, 2011, 8:56 a.m., Kent Quirk wrote: > > So I have a couple of issues with this patch: > > > > * I'm worried about the translation impact, how these strings are used and > > where. Should they be localized? Should they not be localized? I find it > > hard to believe that we ONLY need to translate Home and End. > > * The "1" key is duplicated. Are there others? > > * I think the single-letter keys should be placed in a more useful order so > > that we can easily find missing items. Keyboard order (especially since > > keyboards differ) is not good enough. > > * I'm worried about the naming convention; single-letter names (ahem, yes, > > I know who's talking here) can be rather ambiguous. It's probably the > > easiest fix -- anything else may require much more extensive changes -- but > > I'm worried about this. Is this fix robust under localization? > > > > I haven't had time to investigate these issues yet; does someone else have > > the knowledge to discuss? > > 1) AFAIU, only those keys need translation that are currrently used in menu shortcuts (see menu_*.xml). We don't know in advance what keys we're gonna use in future shortcuts, so it makes sense to make them all localizable. 2) Thanks, the "1" is indeed duplicated. Looks like a copy&paste issue. 3) Ok, the order doesn't matter to me. I can change it if you want. 4) I borrowed the naming style from existing code (see llkeyboard.cpp). Moreover, we tried adding "Key_" prefix to key names for the same reasons as you say, but had to roll that change back because it had broken translation of older shortcuts (see comments in STORM-362). - Vadim --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/108/#review307 --- On Jan. 19, 2011, 8:30 a.m., Vadim ProductEngine wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/108/ > --- > > (Updated Jan. 19, 2011, 8:30 a.m.) > > > Review request for Viewer. > > > Summary > --- > > Made all keys localizable. > > > This addresses bug STORM-465. > http://jira.secondlife.com/browse/STORM-465 > > > Diffs > - > > indra/newview/skins/default/xui/en/strings.xml 38465c40c060 > > Diff: http://codereview.secondlife.com/r/108/diff > > > Testing > --- > > Tested on Linux. No keys produce the warning for me. > > > Thanks, > > Vadim > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-465 Missing Strings from strings.xml
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/108/#review307 --- So I have a couple of issues with this patch: * I'm worried about the translation impact, how these strings are used and where. Should they be localized? Should they not be localized? I find it hard to believe that we ONLY need to translate Home and End. * The "1" key is duplicated. Are there others? * I think the single-letter keys should be placed in a more useful order so that we can easily find missing items. Keyboard order (especially since keyboards differ) is not good enough. * I'm worried about the naming convention; single-letter names (ahem, yes, I know who's talking here) can be rather ambiguous. It's probably the easiest fix -- anything else may require much more extensive changes -- but I'm worried about this. Is this fix robust under localization? I haven't had time to investigate these issues yet; does someone else have the knowledge to discuss? - Kent On Jan. 19, 2011, 8:30 a.m., Vadim ProductEngine wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/108/ > --- > > (Updated Jan. 19, 2011, 8:30 a.m.) > > > Review request for Viewer. > > > Summary > --- > > Made all keys localizable. > > > This addresses bug STORM-465. > http://jira.secondlife.com/browse/STORM-465 > > > Diffs > - > > indra/newview/skins/default/xui/en/strings.xml 38465c40c060 > > Diff: http://codereview.secondlife.com/r/108/diff > > > Testing > --- > > Tested on Linux. No keys produce the warning for me. > > > Thanks, > > Vadim > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-465 Missing Strings from strings.xml
> On Jan. 31, 2011, 3:19 p.m., Merov Linden wrote: > > Good I think. I'm assuming that localization hasn't left those outside > > strings.xml for a reason (like: make sure no one ever tries to translate > > them). No, there was no reason. It's just only two keys were initially localized (Home and End) that were described in STORM-362. Obviously, the added localization also introduced the "Missing String" warnings, so to avoid them we now have to localize all keys. - Vadim --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/108/#review291 --- On Jan. 19, 2011, 8:30 a.m., Vadim ProductEngine wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/108/ > --- > > (Updated Jan. 19, 2011, 8:30 a.m.) > > > Review request for Viewer. > > > Summary > --- > > Made all keys localizable. > > > This addresses bug STORM-465. > http://jira.secondlife.com/browse/STORM-465 > > > Diffs > - > > indra/newview/skins/default/xui/en/strings.xml 38465c40c060 > > Diff: http://codereview.secondlife.com/r/108/diff > > > Testing > --- > > Tested on Linux. No keys produce the warning for me. > > > Thanks, > > Vadim > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-465 Missing Strings from strings.xml
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/108/#review291 --- Ship it! Good I think. I'm assuming that localization hasn't left those outside strings.xml for a reason (like: make sure no one ever tries to translate them). - Merov On Jan. 19, 2011, 8:30 a.m., Vadim ProductEngine wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/108/ > --- > > (Updated Jan. 19, 2011, 8:30 a.m.) > > > Review request for Viewer. > > > Summary > --- > > Made all keys localizable. > > > This addresses bug STORM-465. > http://jira.secondlife.com/browse/STORM-465 > > > Diffs > - > > indra/newview/skins/default/xui/en/strings.xml 38465c40c060 > > Diff: http://codereview.secondlife.com/r/108/diff > > > Testing > --- > > Tested on Linux. No keys produce the warning for me. > > > Thanks, > > Vadim > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-465 Missing Strings from strings.xml
> On Jan. 20, 2011, 6:46 a.m., Seth ProductEngine wrote: > > No missing string warnings while looking through the menu with this patch. > > Twisted Laws wrote: > 2011-01-26T19:57:39Z WARNING: LLTrans::getString: ONCE: Missing String in > strings.xml: [LSLTipText_llSound] > 2011-01-26T19:30:59Z WARNING: LLTrans::findString: ONCE: Missing String > in strings.xml: [InvFolder Favorites] > > Not saying they should hold anything up tho. This came from running Oz's > build with this patch applied. That's a different issue. STORM-465 is about unlocalized key names. - Vadim --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/108/#review208 --- On Jan. 19, 2011, 8:30 a.m., Vadim ProductEngine wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/108/ > --- > > (Updated Jan. 19, 2011, 8:30 a.m.) > > > Review request for Viewer. > > > Summary > --- > > Made all keys localizable. > > > This addresses bug STORM-465. > http://jira.secondlife.com/browse/STORM-465 > > > Diffs > - > > indra/newview/skins/default/xui/en/strings.xml 38465c40c060 > > Diff: http://codereview.secondlife.com/r/108/diff > > > Testing > --- > > Tested on Linux. No keys produce the warning for me. > > > Thanks, > > Vadim > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-465 Missing Strings from strings.xml
> On Jan. 20, 2011, 6:46 a.m., Seth ProductEngine wrote: > > No missing string warnings while looking through the menu with this patch. 2011-01-26T19:57:39Z WARNING: LLTrans::getString: ONCE: Missing String in strings.xml: [LSLTipText_llSound] 2011-01-26T19:30:59Z WARNING: LLTrans::findString: ONCE: Missing String in strings.xml: [InvFolder Favorites] Not saying they should hold anything up tho. This came from running Oz's build with this patch applied. - Twisted --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/108/#review208 --- On Jan. 19, 2011, 8:30 a.m., Vadim ProductEngine wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/108/ > --- > > (Updated Jan. 19, 2011, 8:30 a.m.) > > > Review request for Viewer. > > > Summary > --- > > Made all keys localizable. > > > This addresses bug STORM-465. > http://jira.secondlife.com/browse/STORM-465 > > > Diffs > - > > indra/newview/skins/default/xui/en/strings.xml 38465c40c060 > > Diff: http://codereview.secondlife.com/r/108/diff > > > Testing > --- > > Tested on Linux. No keys produce the warning for me. > > > Thanks, > > Vadim > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-465 Missing Strings from strings.xml
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/108/#review208 --- Ship it! No missing string warnings while looking through the menu with this patch. - Seth On Jan. 19, 2011, 8:30 a.m., Vadim ProductEngine wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/108/ > --- > > (Updated Jan. 19, 2011, 8:30 a.m.) > > > Review request for Viewer. > > > Summary > --- > > Made all keys localizable. > > > This addresses bug STORM-465. > http://jira.secondlife.com/browse/STORM-465 > > > Diffs > - > > indra/newview/skins/default/xui/en/strings.xml 38465c40c060 > > Diff: http://codereview.secondlife.com/r/108/diff > > > Testing > --- > > Tested on Linux. No keys produce the warning for me. > > > Thanks, > > Vadim > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] Review Request: STORM-465 Missing Strings from strings.xml
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/108/ --- Review request for Viewer. Summary --- Made all keys localizable. This addresses bug STORM-465. http://jira.secondlife.com/browse/STORM-465 Diffs - indra/newview/skins/default/xui/en/strings.xml 38465c40c060 Diff: http://codereview.secondlife.com/r/108/diff Testing --- Tested on Linux. No keys produce the warning for me. Thanks, Vadim ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
