[opensource-dev] Review Request: VWR-10579: Fix NDOF.cmake to do the right thing on standalone.
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/45/ --- Review request for Viewer. Summary --- Only define -DLIB_NDOF=1 when NDOF is actually found, on standalone. While FindNDOF.cmake was added to the repository, it wasn't used. This addresses bug VWR-10579. http://jira.secondlife.com/browse/VWR-10579 Diffs - indra/cmake/NDOF.cmake b0689af42a71 Diff: http://codereview.secondlife.com/r/45/diff Testing --- I can't remember when I started using this, but it was long ago. I don't have libndofdev installed. I just installed Michelle's debian package libndofdev-dev and then it found it: -- Found NDOF: Library in '/usr/lib/libndofdev.so' and header in '/usr/include' Thanks, Aleric ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: VWR-10579: Fix NDOF.cmake to do the right thing on standalone.
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/45/#review53 --- I'd prefer the following behavior: Let the user specify whether to use libndofdev or not. (Of course we'd have to agree on a default if nothing was specified). Then ... ... if libndofdev use has been enabled and libndofdev can be found, --> build with libndofdev support, thus with the joystick/spacenavigator features. ... if libndofdev use has been enabled but libndofdev can not be found, --> error out. (With some meaningful message) ... if libndofdev use has been disabled, --> don't build with libndofdev support, even if libndofdev is present. Rationale: If I *want* spacenavigator or joystick support, but libndofdev cannot be found (e.g. because I forgot to install it or because it was installed to a location that isn't searched), I'll get a heads-up at build time rather than having to figure out why stuff doesn't behave the way I want at runtime. Note: This would be analogous to how we currently handle FMOD, even although disabling FMOD -- other than disabling libndofdev -- doesn't result in unavailable viewer features. - Boroondas On 2010-12-19 07:54:19, Aleric Inglewood wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/45/ > --- > > (Updated 2010-12-19 07:54:19) > > > Review request for Viewer. > > > Summary > --- > > Only define -DLIB_NDOF=1 when NDOF is actually found, on standalone. While > FindNDOF.cmake was added to the repository, it wasn't used. > > > This addresses bug VWR-10579. > http://jira.secondlife.com/browse/VWR-10579 > > > Diffs > - > > indra/cmake/NDOF.cmake b0689af42a71 > > Diff: http://codereview.secondlife.com/r/45/diff > > > Testing > --- > > I can't remember when I started using this, but it was long ago. I don't have > libndofdev installed. > I just installed Michelle's debian package libndofdev-dev and then it found > it: > -- Found NDOF: Library in '/usr/lib/libndofdev.so' and header in > '/usr/include' > > > Thanks, > > Aleric > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: VWR-10579: Fix NDOF.cmake to do the right thing on standalone.
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/45/ --- (Updated 2010-12-20 06:04:05.704478) Review request for Viewer. Changes --- This new patch addresses Boroondas -heh- preferences ;) it tries to find NDOF and when not found prints an error and the instructions to configure with -DNDOF:BOOL=OFF if you really don't want space navigator joystick support. This is indeed very simular to how FMOD works currently. This new patch also adds indra/cmake/FindNDOF.cmake, which was erroneously missing from the first patch, oops! Summary (updated) --- On standalone, only define -DLIB_NDOF=1 when NDOF can be found. This addresses bug VWR-10579. http://jira.secondlife.com/browse/VWR-10579 Diffs (updated) - indra/cmake/FindNDOF.cmake PRE-CREATION indra/cmake/NDOF.cmake b0689af42a71 Diff: http://codereview.secondlife.com/r/45/diff Testing --- I can't remember when I started using this, but it was long ago. I don't have libndofdev installed. I just installed Michelle's debian package libndofdev-dev and then it found it: -- Found NDOF: Library in '/usr/lib/libndofdev.so' and header in '/usr/include' Thanks, Aleric ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
