Re: [opensource-dev] Review Request: VWR-24317: Incorrect start up warnings: WARNING: ll_apr_warn_status: APR: No such file or directory
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/83/#review212 --- Ship it! - Oz On Jan. 14, 2011, 12:48 p.m., Aleric Inglewood wrote: --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/83/ --- (Updated Jan. 14, 2011, 12:48 p.m.) Review request for Viewer. Summary --- At start up one can get the following “warnings”: 2010-10-23T12:22:44Z WARNING: ll_apr_warn_status: APR: No such file or directory 2010-10-23T12:22:44Z WARNING: remove: Attempting to remove filename: /home/aleric/.imprudence/logs/Imprudence.logout_marker 2010-10-23T12:22:44Z WARNING: ll_apr_warn_status: APR: No such file or directory 2010-10-23T12:22:44Z WARNING: remove: Attempting to remove filename: /home/aleric/.imprudence/logs/Imprudence.llerror_marker 2010-10-23T12:22:44Z WARNING: ll_apr_warn_status: APR: No such file or directory 2010-10-23T12:22:44Z WARNING: remove: Attempting to remove filename: /home/aleric/.imprudence/logs/Imprudence.error_marker This is nonsense since it is perfectly ok when those files don’t exist. This addresses bug VWR-24317. http://jira.secondlife.com/browse/VWR-24317 Diffs - indra/newview/llappviewer.cpp b0bd26c5638a Diff: http://codereview.secondlife.com/r/83/diff Testing --- Thanks, Aleric ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: VWR-24317: Incorrect start up warnings: WARNING: ll_apr_warn_status: APR: No such file or directory
On Jan. 14, 2011, 1:47 p.m., Boroondas Gupte wrote: indra/newview/llappviewer.cpp, lines 3091-3094 http://codereview.secondlife.com/r/83/diff/1/?file=402#file402line3091 what's the reason for moving the LL_INFOS around? The last two, in order to print the correct value that gLastExecEvent is being set to: depending on the conditional, the value is set to what was printed, or to another value. The first hunk to have more symmetric code and treat that part the same as the others: first set the variable and then print it's contents. - Aleric --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/83/#review154 --- On Jan. 14, 2011, 12:48 p.m., Aleric Inglewood wrote: --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/83/ --- (Updated Jan. 14, 2011, 12:48 p.m.) Review request for Viewer. Summary --- At start up one can get the following “warnings”: 2010-10-23T12:22:44Z WARNING: ll_apr_warn_status: APR: No such file or directory 2010-10-23T12:22:44Z WARNING: remove: Attempting to remove filename: /home/aleric/.imprudence/logs/Imprudence.logout_marker 2010-10-23T12:22:44Z WARNING: ll_apr_warn_status: APR: No such file or directory 2010-10-23T12:22:44Z WARNING: remove: Attempting to remove filename: /home/aleric/.imprudence/logs/Imprudence.llerror_marker 2010-10-23T12:22:44Z WARNING: ll_apr_warn_status: APR: No such file or directory 2010-10-23T12:22:44Z WARNING: remove: Attempting to remove filename: /home/aleric/.imprudence/logs/Imprudence.error_marker This is nonsense since it is perfectly ok when those files don’t exist. This addresses bug VWR-24317. http://jira.secondlife.com/browse/VWR-24317 Diffs - indra/newview/llappviewer.cpp b0bd26c5638a Diff: http://codereview.secondlife.com/r/83/diff Testing --- Thanks, Aleric ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: VWR-24317: Incorrect start up warnings: WARNING: ll_apr_warn_status: APR: No such file or directory
On Jan. 14, 2011, 1:47 p.m., Boroondas Gupte wrote: indra/newview/llappviewer.cpp, lines 3091-3094 http://codereview.secondlife.com/r/83/diff/1/?file=402#file402line3091 what's the reason for moving the LL_INFOS around? Aleric Inglewood wrote: The last two, in order to print the correct value that gLastExecEvent is being set to: depending on the conditional, the value is set to what was printed, or to another value. The first hunk to have more symmetric code and treat that part the same as the others: first set the variable and then print it's contents. Makes sense. - Boroondas --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/83/#review154 --- On Jan. 14, 2011, 12:48 p.m., Aleric Inglewood wrote: --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/83/ --- (Updated Jan. 14, 2011, 12:48 p.m.) Review request for Viewer. Summary --- At start up one can get the following “warnings”: 2010-10-23T12:22:44Z WARNING: ll_apr_warn_status: APR: No such file or directory 2010-10-23T12:22:44Z WARNING: remove: Attempting to remove filename: /home/aleric/.imprudence/logs/Imprudence.logout_marker 2010-10-23T12:22:44Z WARNING: ll_apr_warn_status: APR: No such file or directory 2010-10-23T12:22:44Z WARNING: remove: Attempting to remove filename: /home/aleric/.imprudence/logs/Imprudence.llerror_marker 2010-10-23T12:22:44Z WARNING: ll_apr_warn_status: APR: No such file or directory 2010-10-23T12:22:44Z WARNING: remove: Attempting to remove filename: /home/aleric/.imprudence/logs/Imprudence.error_marker This is nonsense since it is perfectly ok when those files don’t exist. This addresses bug VWR-24317. http://jira.secondlife.com/browse/VWR-24317 Diffs - indra/newview/llappviewer.cpp b0bd26c5638a Diff: http://codereview.secondlife.com/r/83/diff Testing --- Thanks, Aleric ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] Review Request: VWR-24317: Incorrect start up warnings: WARNING: ll_apr_warn_status: APR: No such file or directory
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/83/ --- Review request for Viewer. Summary --- At start up one can get the following “warnings”: 2010-10-23T12:22:44Z WARNING: ll_apr_warn_status: APR: No such file or directory 2010-10-23T12:22:44Z WARNING: remove: Attempting to remove filename: /home/aleric/.imprudence/logs/Imprudence.logout_marker 2010-10-23T12:22:44Z WARNING: ll_apr_warn_status: APR: No such file or directory 2010-10-23T12:22:44Z WARNING: remove: Attempting to remove filename: /home/aleric/.imprudence/logs/Imprudence.llerror_marker 2010-10-23T12:22:44Z WARNING: ll_apr_warn_status: APR: No such file or directory 2010-10-23T12:22:44Z WARNING: remove: Attempting to remove filename: /home/aleric/.imprudence/logs/Imprudence.error_marker This is nonsense since it is perfectly ok when those files don’t exist. This addresses bug VWR-24317. http://jira.secondlife.com/browse/VWR-24317 Diffs - indra/newview/llappviewer.cpp b0bd26c5638a Diff: http://codereview.secondlife.com/r/83/diff Testing --- Thanks, Aleric ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: VWR-24317: Incorrect start up warnings: WARNING: ll_apr_warn_status: APR: No such file or directory
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/83/#review154 --- Ship it! Looks good. Files should only be removed when they actually exists, which this change accomplishes. Just wondering: indra/newview/llappviewer.cpp http://codereview.secondlife.com/r/83/#comment97 indra/newview/llappviewer.cpp http://codereview.secondlife.com/r/83/#comment98 indra/newview/llappviewer.cpp http://codereview.secondlife.com/r/83/#comment99 what's the reason for moving the LL_INFOS around? - Boroondas On Jan. 14, 2011, 12:48 p.m., Aleric Inglewood wrote: --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/83/ --- (Updated Jan. 14, 2011, 12:48 p.m.) Review request for Viewer. Summary --- At start up one can get the following “warnings”: 2010-10-23T12:22:44Z WARNING: ll_apr_warn_status: APR: No such file or directory 2010-10-23T12:22:44Z WARNING: remove: Attempting to remove filename: /home/aleric/.imprudence/logs/Imprudence.logout_marker 2010-10-23T12:22:44Z WARNING: ll_apr_warn_status: APR: No such file or directory 2010-10-23T12:22:44Z WARNING: remove: Attempting to remove filename: /home/aleric/.imprudence/logs/Imprudence.llerror_marker 2010-10-23T12:22:44Z WARNING: ll_apr_warn_status: APR: No such file or directory 2010-10-23T12:22:44Z WARNING: remove: Attempting to remove filename: /home/aleric/.imprudence/logs/Imprudence.error_marker This is nonsense since it is perfectly ok when those files don’t exist. This addresses bug VWR-24317. http://jira.secondlife.com/browse/VWR-24317 Diffs - indra/newview/llappviewer.cpp b0bd26c5638a Diff: http://codereview.secondlife.com/r/83/diff Testing --- Thanks, Aleric ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
