[Bug 2162] New: Log needs to contain the port on which connection is made

2013-10-17 Thread bugzilla-daemon
https://bugzilla.mindrot.org/show_bug.cgi?id=2162

Bug ID: 2162
   Summary: Log needs to contain the port on which connection is
made
   Product: Portable OpenSSH
   Version: 6.2p1
  Hardware: All
OS: FreeBSD
Status: NEW
  Severity: normal
  Priority: P5
 Component: sshd
  Assignee: unassigned-b...@mindrot.org
  Reporter: y...@rawbw.com

I have sshd listening on multiple ports.
Currently I see the log message:
Oct 17 11:59:32 myhost sshd[13784]: Bad protocol version identification
'\200F\001\003\001' from NNN.NNN.NNN.NNN

Somebody connected to it and protocol was invalid. The message will
become much more informative if it contained the port on which the
connection wad made.

This should be fixed for all messages that sshd prints on
per-connection basis.

OpenSSH 6.2p2 from FreeBSD tree.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs


[Bug 2162] Log needs to contain the port on which connection is made

2013-10-17 Thread bugzilla-daemon
https://bugzilla.mindrot.org/show_bug.cgi?id=2162

Damien Miller d...@mindrot.org changed:

   What|Removed |Added

 CC||d...@mindrot.org
   Assignee|unassigned-b...@mindrot.org |d...@mindrot.org

--- Comment #1 from Damien Miller d...@mindrot.org ---
Created attachment 2355
  -- https://bugzilla.mindrot.org/attachment.cgi?id=2355action=edit
include port in invalid banner message

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs


[Bug 2130] Bugs intended to be fixed in 6.4

2013-10-17 Thread bugzilla-daemon
https://bugzilla.mindrot.org/show_bug.cgi?id=2130

Damien Miller d...@mindrot.org changed:

   What|Removed |Added

 Depends on||2162

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching the reporter of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs


[Bug 2162] Log needs to contain the port on which connection is made

2013-10-17 Thread bugzilla-daemon
https://bugzilla.mindrot.org/show_bug.cgi?id=2162

--- Comment #3 from Darren Tucker dtuc...@zip.com.au ---
Comment on attachment 2355
  -- https://bugzilla.mindrot.org/attachment.cgi?id=2355
include port in invalid banner message

+  logit(Bad protocol version identification '%.100s' 
+  from %s port %d, client_version_string,
+  get_remote_ipaddr(), get_remote_port());

that's the remote port, the request was for the local (ie listening)
port.  Certainly I think it's worth having the remote port (eg for NAT
pools).

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs


[Bug 2162] Log needs to contain the port on which connection is made

2013-10-17 Thread bugzilla-daemon
https://bugzilla.mindrot.org/show_bug.cgi?id=2162

Darren Tucker dtuc...@zip.com.au changed:

   What|Removed |Added

 CC||dtuc...@zip.com.au
 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs


[Bug 2130] Bugs intended to be fixed in 6.4

2013-10-17 Thread bugzilla-daemon
https://bugzilla.mindrot.org/show_bug.cgi?id=2130

Bug 2130 depends on bug 2162, which changed state.

Bug 2162 Summary: Log needs to contain the port on which connection is made
https://bugzilla.mindrot.org/show_bug.cgi?id=2162

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching the reporter of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs