[Bug 1319] ssh-keygen does not properly handle multiple keys

2016-08-01 Thread bugzilla-daemon
https://bugzilla.mindrot.org/show_bug.cgi?id=1319

Damien Miller  changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED

--- Comment #21 from Damien Miller  ---
Close all resolved bugs after 7.3p1 release

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs


[Bug 1319] ssh-keygen does not properly handle multiple keys

2015-11-16 Thread bugzilla-daemon
https://bugzilla.mindrot.org/show_bug.cgi?id=1319

Damien Miller  changed:

   What|Removed |Added

 Depends on|2451|
 Blocks||2451

--- Comment #20 from Damien Miller  ---
This is now implemented in HEAD, supporting RSA1 private keys, v2
public keys, authorized_keys, known_hosts and allowing ssh-keygen -lf-
to read from stdin.

https://anongit.mindrot.org/openssh.git/commit/?id=c56a255162c2166884539c0a1f7511575325b477

It will be in the forthmcoming openssh-7.2 release


Referenced Bugs:

https://bugzilla.mindrot.org/show_bug.cgi?id=2451
[Bug 2451] Bugs intended to be fixed in 7.2
-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs


[Bug 1319] ssh-keygen does not properly handle multiple keys

2015-11-16 Thread bugzilla-daemon
https://bugzilla.mindrot.org/show_bug.cgi?id=1319

Damien Miller  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Depends on||2451
 Status|NEW |RESOLVED

--- Comment #19 from Damien Miller  ---
This is fixed in HEAD and will be in the openssh-7.2 release.


Referenced Bugs:

https://bugzilla.mindrot.org/show_bug.cgi?id=2451
[Bug 2451] Bugs intended to be fixed in 7.2
-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs


[Bug 1319] ssh-keygen does not properly handle multiple keys

2014-07-07 Thread bugzilla-daemon
https://bugzilla.mindrot.org/show_bug.cgi?id=1319

Damien Miller  changed:

   What|Removed |Added

 Blocks|2226|

--- Comment #18 from Damien Miller  ---
Remove from 6.7 blocker list. I'm not sure yet sure how to do this
reliably

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs


[Bug 1319] ssh-keygen does not properly handle multiple keys

2014-04-11 Thread bugzilla-daemon
https://bugzilla.mindrot.org/show_bug.cgi?id=1319

Damien Miller  changed:

   What|Removed |Added

 Blocks|2188|

--- Comment #17 from Damien Miller  ---
Remove from 6.6 tracking bug

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs


[Bug 1319] ssh-keygen does not properly handle multiple keys

2014-04-11 Thread bugzilla-daemon
https://bugzilla.mindrot.org/show_bug.cgi?id=1319

Damien Miller  changed:

   What|Removed |Added

 Blocks||2226

--- Comment #16 from Damien Miller  ---
Retarget to 6.7 release, since 6.6 was mostly bugfixing.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs


[Bug 1319] ssh-keygen does not properly handle multiple keys

2014-02-05 Thread bugzilla-daemon
https://bugzilla.mindrot.org/show_bug.cgi?id=1319

Damien Miller  changed:

   What|Removed |Added

 Blocks|2130|

--- Comment #15 from Damien Miller  ---
Retarget incomplete bugs / feature requests to 6.6 release

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs


[Bug 1319] ssh-keygen does not properly handle multiple keys

2014-02-05 Thread bugzilla-daemon
https://bugzilla.mindrot.org/show_bug.cgi?id=1319

Damien Miller  changed:

   What|Removed |Added

 Blocks||2188

--- Comment #14 from Damien Miller  ---
Retarget incomplete bugs / feature requests to 6.6 release

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs


[Bug 1319] ssh-keygen does not properly handle multiple keys

2013-07-24 Thread bugzilla-daemon
https://bugzilla.mindrot.org/show_bug.cgi?id=1319

Damien Miller  changed:

   What|Removed |Added

 Blocks|2076|

--- Comment #13 from Damien Miller  ---
Retarget 6.3 -> 6.4

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs


[Bug 1319] ssh-keygen does not properly handle multiple keys

2013-07-24 Thread bugzilla-daemon
https://bugzilla.mindrot.org/show_bug.cgi?id=1319

Damien Miller  changed:

   What|Removed |Added

 Blocks||2130

--- Comment #12 from Damien Miller  ---
Retarget to openssh-6.4

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs


[Bug 1319] ssh-keygen does not properly handle multiple keys

2013-03-07 Thread bugzilla-daemon
https://bugzilla.mindrot.org/show_bug.cgi?id=1319

Damien Miller  changed:

   What|Removed |Added

 Blocks|2035|

--- Comment #11 from Damien Miller  ---
retarget to openssh-6.3

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs


[Bug 1319] ssh-keygen does not properly handle multiple keys

2013-03-07 Thread bugzilla-daemon
https://bugzilla.mindrot.org/show_bug.cgi?id=1319

Damien Miller  changed:

   What|Removed |Added

 Blocks||2076

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs


[Bug 1319] ssh-keygen does not properly handle multiple keys

2012-09-06 Thread bugzilla-daemon
https://bugzilla.mindrot.org/show_bug.cgi?id=1319

Damien Miller  changed:

   What|Removed |Added

 Blocks||2035

--- Comment #9 from Damien Miller  ---
Retarget uncompleted bugs from 6.1 => 6.2

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs


[Bug 1319] ssh-keygen does not properly handle multiple keys

2012-09-06 Thread bugzilla-daemon
https://bugzilla.mindrot.org/show_bug.cgi?id=1319

Damien Miller  changed:

   What|Removed |Added

 Blocks|1986|

--- Comment #10 from Damien Miller  ---
Retarget bugs from 6.1 => 6.2

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs


[Bug 1319] ssh-keygen does not properly handle multiple keys

2012-02-23 Thread bugzilla-daemon
https://bugzilla.mindrot.org/show_bug.cgi?id=1319

Damien Miller  changed:

   What|Removed |Added

 Blocks|1930|

--- Comment #8 from Damien Miller  2012-02-24 10:38:04 EST ---
Retarget 6.0 => 6.1

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs


[Bug 1319] ssh-keygen does not properly handle multiple keys

2012-02-23 Thread bugzilla-daemon
https://bugzilla.mindrot.org/show_bug.cgi?id=1319

Damien Miller  changed:

   What|Removed |Added

 Blocks||1986

--- Comment #7 from Damien Miller  2012-02-24 10:34:25 EST ---
Retarget from 6.0 to 6.1

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs


[Bug 1319] ssh-keygen does not properly handle multiple keys

2011-12-01 Thread bugzilla-daemon
https://bugzilla.mindrot.org/show_bug.cgi?id=1319

Damien Miller  changed:

   What|Removed |Added

 Blocks||1544

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs


[Bug 1319] ssh-keygen does not properly handle multiple keys

2011-12-01 Thread bugzilla-daemon
https://bugzilla.mindrot.org/show_bug.cgi?id=1319

--- Comment #6 from Damien Miller  2011-12-02 12:19:01 EST ---
Fixing this is trickier than I thought. The cases that need to be
supported are:

1. SSH1 public key in a private blob
2. SSH1/SSH2 public key in text form
3. known_hosts
4. authorized_keys

We can deal with case #1 by using key_load_public_type() instead of
key_load_public.

It is a little more tricky to support the other cases together though.
For a start, known_hosts always has a hostname before the key string
whereas a public key in text format never does. authorized_keys has
optional key restrictions that need to be recognised and skipped.

A final (?) complication comes in the printing - when printing
fingerprints from known_hosts, one wants to print the hostname obtained
from the start of the line, but when printing everything else the key
comment (end of the line, or baked into the a binary SSH1 private key)
is the most important thing.

So, do_fingerprint needs to be rewritten to look something like this:

k = key_load_public_type(KEY_RSA1, identity_file, comment)
if (k != NULL)
  print fingerprint+comment and exit
for line in identity_file
  split_key_line(line, &preamble, &key, &comment)
  if (auth_parse_options(preamble)) {
// If it has options then it's definitely authorized keys
authorized_keys = 1
  } else if (*preamble != '\0') {
// If the preamble doesn't look like options, then it's probably
// known_hosts
known_hosts = 1
  } else {
// If no preamble at all then it's a plain key or authorized_keys
  }
  print_fingerprint(key)
  print_comment(known_hosts ? preamble : comment)
}

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs


[Bug 1319] ssh-keygen does not properly handle multiple keys

2011-09-05 Thread bugzilla-daemon
https://bugzilla.mindrot.org/show_bug.cgi?id=1319

Damien Miller  changed:

   What|Removed |Added

 Blocks|1845|

--- Comment #5 from Damien Miller  2011-09-06 10:39:03 EST ---
Retarget unresolved bugs/features to 6.0 release

(try again - bugzilla's "change several" isn't)

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs


[Bug 1319] ssh-keygen does not properly handle multiple keys

2011-09-05 Thread bugzilla-daemon
https://bugzilla.mindrot.org/show_bug.cgi?id=1319

--- Comment #4 from Damien Miller  2011-09-06 10:36:29 EST ---
Retarget unresolved bugs/features to 6.0 release

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs


[Bug 1319] ssh-keygen does not properly handle multiple keys

2011-09-05 Thread bugzilla-daemon
https://bugzilla.mindrot.org/show_bug.cgi?id=1319

Damien Miller  changed:

   What|Removed |Added

 Blocks||1930

--- Comment #3 from Damien Miller  2011-09-06 10:34:16 EST ---
Retarget unresolved bugs/features to 6.0 release

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs


[Bug 1319] ssh-keygen does not properly handle multiple keys

2011-06-02 Thread bugzilla-daemon
https://bugzilla.mindrot.org/show_bug.cgi?id=1319

Damien Miller  changed:

   What|Removed |Added

 Blocks||1845

--- Comment #2 from Damien Miller  2011-06-03 13:40:19 EST ---
We can do this with the new authfile.c code that supports parsing from
memory buffers.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs