[Bug 1542] Send echo on/off flag to SSH_ASKPASS

[bugzilla-daemon]

https://bugzilla.mindrot.org/show_bug.cgi?id=1542

Damien Miller  changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED

--- Comment #26 from Damien Miller  ---
close bugs that were resolved in OpenSSH 8.5 release cycle

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs

[Bug 1542] Send echo on/off flag to SSH_ASKPASS

[bugzilla-daemon]

https://bugzilla.mindrot.org/show_bug.cgi?id=1542

Damien Miller  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #25 from Damien Miller  ---
OpenSSH 8.2 sets a $SSH_ASKPASS_PROMPT environment variable that passes
context through to the askpass program. The
contrib/gnome-ssh-askpass[23] helper has been updated to use it too.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs

[Bug 1542] Send echo on/off flag to SSH_ASKPASS

[bugzilla-daemon]

https://bugzilla.mindrot.org/show_bug.cgi?id=1542

beer  changed:

   What|Removed |Added

   Attachment #1874||ok+
  Flags||

--- Comment #24 from beer  ---
Comment on attachment 1874
  --> https://bugzilla.mindrot.org/attachment.cgi?id=1874
/home/djm/askpass-env-echo.diff

>Index: readpass.c
>===
>RCS file: /cvs/src/usr.bin/ssh/readpass.c,v
>retrieving revision 1.47
>diff -u -p -r1.47 readpass.c
>--- readpass.c 3 Aug 2006 03:34:42 -   1.47
>+++ readpass.c 18 Jun 2010 05:06:21 -
>@@ -44,7 +44,7 @@
> #include "uidswap.h"
> 
> static char *
>-ssh_askpass(char *askpass, const char *msg)
>+ssh_askpass(char *askpass, const char *msg, int echo_on)
> {
>   pid_t pid;
>   size_t len;
>@@ -69,6 +69,10 @@ ssh_askpass(char *askpass, const char *m
>   close(p[0]);
>   if (dup2(p[1], STDOUT_FILENO) < 0)
>   fatal("ssh_askpass: dup2: %s", strerror(errno));
>+  if (echo_on)
>+  setenv("SSH_ASKPASS_ECHO", "1", 1);
>+  else
>+  unsetenv("SSH_ASKPASS_ECHO");
>   execlp(askpass, askpass, msg, (char *) 0);
>   fatal("ssh_askpass: exec(%s): %s", askpass, strerror(errno));
>   }
>@@ -141,7 +145,8 @@ read_passphrase(const char *prompt, int 
>   askpass = getenv(SSH_ASKPASS_ENV);
>   else
>   askpass = _PATH_SSH_ASKPASS_DEFAULT;
>-  if ((ret = ssh_askpass(askpass, prompt)) == NULL)
>+  if ((ret = ssh_askpass(askpass, prompt,
>+  flags & RP_ECHO)) == NULL)
>   if (!(flags & RP_ALLOW_EOF))
>   return xstrdup("");
>   return ret;

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs

[Bug 1542] Send echo on/off flag to SSH_ASKPASS

[bugzilla-daemon]

https://bugzilla.mindrot.org/show_bug.cgi?id=1542

Damien Miller  changed:

   What|Removed |Added

 Blocks|2451|


Referenced Bugs:

https://bugzilla.mindrot.org/show_bug.cgi?id=2451
[Bug 2451] Bugs intended to be fixed in 7.2
-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs

[Bug 1542] Send echo on/off flag to SSH_ASKPASS

[bugzilla-daemon]

https://bugzilla.mindrot.org/show_bug.cgi?id=1542

Darren Tucker dtuc...@zip.com.au changed:

   What|Removed |Added

 Blocks||2451


Referenced Bugs:

https://bugzilla.mindrot.org/show_bug.cgi?id=2451
[Bug 2451] Bugs intended to be fixed in 7.2
-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs

[Bug 1542] Send echo on/off flag to SSH_ASKPASS

[bugzilla-daemon]

https://bugzilla.mindrot.org/show_bug.cgi?id=1542

Darren Tucker dtuc...@zip.com.au changed:

   What|Removed |Added

 Blocks|2443|


Referenced Bugs:

https://bugzilla.mindrot.org/show_bug.cgi?id=2443
[Bug 2443] Bugs intended to be fixed for OpenSSH 7.1
-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs

[Bug 1542] Send echo on/off flag to SSH_ASKPASS

[bugzilla-daemon]

https://bugzilla.mindrot.org/show_bug.cgi?id=1542

Damien Miller d...@mindrot.org changed:

   What|Removed |Added

 Blocks|2403|

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs

[Bug 1542] Send echo on/off flag to SSH_ASKPASS

[bugzilla-daemon]

https://bugzilla.mindrot.org/show_bug.cgi?id=1542

Damien Miller d...@mindrot.org changed:

   What|Removed |Added

 Blocks||2443

--- Comment #23 from Damien Miller d...@mindrot.org ---
Retarget pending bugs to openssh-7.1

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs

[Bug 1542] Send echo on/off flag to SSH_ASKPASS

[bugzilla-daemon]

https://bugzilla.mindrot.org/show_bug.cgi?id=1542

Damien Miller d...@mindrot.org changed:

   What|Removed |Added

 Blocks|2360|2403

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs

[Bug 1542] Send echo on/off flag to SSH_ASKPASS

[bugzilla-daemon]

https://bugzilla.mindrot.org/show_bug.cgi?id=1542

Damien Miller d...@mindrot.org changed:

   What|Removed |Added

 Blocks||2360

--- Comment #22 from Damien Miller d...@mindrot.org ---
Retarget to 6.9

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs

[Bug 1542] Send echo on/off flag to SSH_ASKPASS

[bugzilla-daemon]

https://bugzilla.mindrot.org/show_bug.cgi?id=1542

Damien Miller d...@mindrot.org changed:

   What|Removed |Added

 Blocks|2266|

--- Comment #21 from Damien Miller d...@mindrot.org ---
OpenSSH 6.8 is approaching release and closed for major work. Retarget
these bugs for the next release.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs

[Bug 1542] Send echo on/off flag to SSH_ASKPASS

[bugzilla-daemon]

https://bugzilla.mindrot.org/show_bug.cgi?id=1542

Damien Miller d...@mindrot.org changed:

   What|Removed |Added

 Blocks||2266

--- Comment #19 from Damien Miller d...@mindrot.org ---
Retarget incomplete bugs to 6.8 release.

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs

[Bug 1542] Send echo on/off flag to SSH_ASKPASS

[bugzilla-daemon]

https://bugzilla.mindrot.org/show_bug.cgi?id=1542

Damien Miller d...@mindrot.org changed:

   What|Removed |Added

 Blocks|2188|

--- Comment #18 from Damien Miller d...@mindrot.org ---
Remove from 6.6 tracking bug

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs

[Bug 1542] Send echo on/off flag to SSH_ASKPASS

[bugzilla-daemon]

https://bugzilla.mindrot.org/show_bug.cgi?id=1542

Damien Miller d...@mindrot.org changed:

   What|Removed |Added

 Blocks||2226

--- Comment #17 from Damien Miller d...@mindrot.org ---
Retarget to 6.7 release, since 6.6 was mostly bugfixing.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs

[Bug 1542] Send echo on/off flag to SSH_ASKPASS

[bugzilla-daemon]

https://bugzilla.mindrot.org/show_bug.cgi?id=1542

Damien Miller d...@mindrot.org changed:

   What|Removed |Added

 Blocks||2188

--- Comment #15 from Damien Miller d...@mindrot.org ---
Retarget incomplete bugs / feature requests to 6.6 release

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs

[Bug 1542] Send echo on/off flag to SSH_ASKPASS

[bugzilla-daemon]

https://bugzilla.mindrot.org/show_bug.cgi?id=1542

Damien Miller d...@mindrot.org changed:

   What|Removed |Added

 Blocks|2130|

--- Comment #16 from Damien Miller d...@mindrot.org ---
Retarget incomplete bugs / feature requests to 6.6 release

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs

[Bug 1542] Send echo on/off flag to SSH_ASKPASS

[bugzilla-daemon]

https://bugzilla.mindrot.org/show_bug.cgi?id=1542

Damien Miller d...@mindrot.org changed:

   What|Removed |Added

 Blocks|2076|

--- Comment #14 from Damien Miller d...@mindrot.org ---
Retarget 6.3 - 6.4

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs

[Bug 1542] Send echo on/off flag to SSH_ASKPASS

[bugzilla-daemon]

https://bugzilla.mindrot.org/show_bug.cgi?id=1542

Damien Miller d...@mindrot.org changed:

   What|Removed |Added

 Blocks||2130

--- Comment #13 from Damien Miller d...@mindrot.org ---
Retarget to openssh-6.4

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs

[Bug 1542] Send echo on/off flag to SSH_ASKPASS

[bugzilla-daemon]

https://bugzilla.mindrot.org/show_bug.cgi?id=1542

Damien Miller d...@mindrot.org changed:

   What|Removed |Added

 Blocks||2076

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs

[Bug 1542] Send echo on/off flag to SSH_ASKPASS

[bugzilla-daemon]

https://bugzilla.mindrot.org/show_bug.cgi?id=1542

Damien Miller d...@mindrot.org changed:

   What|Removed |Added

 Blocks|1986|

--- Comment #11 from Damien Miller d...@mindrot.org ---
Retarget bugs from 6.1 = 6.2

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs

[Bug 1542] Send echo on/off flag to SSH_ASKPASS

[bugzilla-daemon]

https://bugzilla.mindrot.org/show_bug.cgi?id=1542

Damien Miller d...@mindrot.org changed:

   What|Removed |Added

 Blocks|1930|

--- Comment #9 from Damien Miller d...@mindrot.org 2012-02-24 10:38:03 EST ---
Retarget 6.0 = 6.1

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs

[Bug 1542] Send echo on/off flag to SSH_ASKPASS

[bugzilla-daemon]

https://bugzilla.mindrot.org/show_bug.cgi?id=1542

Damien Miller d...@mindrot.org changed:

   What|Removed |Added

 Blocks||1986

--- Comment #8 from Damien Miller d...@mindrot.org 2012-02-24 10:34:24 EST ---
Retarget from 6.0 to 6.1

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs

[Bug 1542] Send echo on/off flag to SSH_ASKPASS

[bugzilla-daemon]

https://bugzilla.mindrot.org/show_bug.cgi?id=1542

--- Comment #6 from Damien Miller d...@mindrot.org 2011-09-06 10:36:28 EST ---
Retarget unresolved bugs/features to 6.0 release

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs

[Bug 1542] Send echo on/off flag to SSH_ASKPASS

[bugzilla-daemon]

https://bugzilla.mindrot.org/show_bug.cgi?id=1542

Damien Miller d...@mindrot.org changed:

   What|Removed |Added

 Blocks|1845|

--- Comment #7 from Damien Miller d...@mindrot.org 2011-09-06 10:39:03 EST ---
Retarget unresolved bugs/features to 6.0 release

(try again - bugzilla's change several isn't)

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs

[Bug 1542] Send echo on/off flag to SSH_ASKPASS

[bugzilla-daemon]

https://bugzilla.mindrot.org/show_bug.cgi?id=1542

--- Comment #2 from Damien Miller d...@mindrot.org  ---
We are freezing for the OpenSSH 5.6 release. Retargetting these bugs to
the next release.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs

[Bug 1542] Send echo on/off flag to SSH_ASKPASS

[bugzilla-daemon]

https://bugzilla.mindrot.org/show_bug.cgi?id=1542

Damien Miller d...@mindrot.org changed:

   What|Removed |Added

 Blocks|1708|

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs

[Bug 1542] Send echo on/off flag to SSH_ASKPASS

[bugzilla-daemon]

https://bugzilla.mindrot.org/show_bug.cgi?id=1542

Damien Miller d...@mindrot.org changed:

   What|Removed |Added

 CC||d...@mindrot.org
 Blocks||1708

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs