[Bug 1988] ControlPersist causes stderr to be left open until the master connection times out
https://bugzilla.mindrot.org/show_bug.cgi?id=1988 --- Comment #20 from Christoph Anton Mitterer --- @Damien... have a look at the previous message... weird form of spam (or some image that tries to abuse a security hole)... guess that should be removed and the user banned. -- You are receiving this mail because: You are watching the assignee of the bug. You are watching someone on the CC list of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 1988] ControlPersist causes stderr to be left open until the master connection times out
https://bugzilla.mindrot.org/show_bug.cgi?id=1988 Adam Spiers changed: What|Removed |Added CC||mind...@adamspiers.org -- Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching the assignee of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 1988] ControlPersist causes stderr to be left open until the master connection times out
https://bugzilla.mindrot.org/show_bug.cgi?id=1988 Damien Miller changed: What|Removed |Added CC||d...@mindrot.org --- Comment #1 from Damien Miller 2012-03-09 10:15:12 EST --- Closing stderr in the backgrounded process would lose any output from it (usually visiable at loglevel verbose or higher) -- Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching the assignee of the bug. You are watching someone on the CC list of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 1988] ControlPersist causes stderr to be left open until the master connection times out
https://bugzilla.mindrot.org/show_bug.cgi?id=1988 --- Comment #2 from Andrew McNabb 2012-03-09 10:46:36 EST --- (In reply to comment #1) > Closing stderr in the backgrounded process would lose any output from > it (usually visiable at loglevel verbose or higher) But if loglevel is not verbose, there's nothing to lose, right? -- Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching the assignee of the bug. You are watching someone on the CC list of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 1988] ControlPersist causes stderr to be left open until the master connection times out
https://bugzilla.mindrot.org/show_bug.cgi?id=1988 --- Comment #3 from Damien Miller 2012-03-30 11:39:32 EST --- not necessarily - e.g. messages sent at loglevel fatal() or error() -- Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching the assignee of the bug. You are watching someone on the CC list of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 1988] ControlPersist causes stderr to be left open until the master connection times out
https://bugzilla.mindrot.org/show_bug.cgi?id=1988 --- Comment #4 from Andrew McNabb 2012-04-01 03:35:25 EST --- If ssh has forked a background daemon, the user can't reasonably expect to see messages on stderr anyway. For example, they might close the terminal in which the original ssh connection was created. Furthermore, such messages might not even be welcome. After all, the user is probably running some other application. Any fatal errors would be relevant to other foreground ssh processes, but not to a terminal window that is no longer running any ssh processes. Might the best long-term solution be to send any logging messages to foreground ssh processes? In any case, I think it's incorrect to send logging messages to a now-unrelated tty. Especially since this can make scripts hang. -- Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching the assignee of the bug. You are watching someone on the CC list of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 1988] ControlPersist causes stderr to be left open until the master connection times out
https://bugzilla.mindrot.org/show_bug.cgi?id=1988 Darren Tucker changed: What|Removed |Added CC||dtuc...@zip.com.au Blocks||2076 -- You are receiving this mail because: You are watching the assignee of the bug. You are watching someone on the CC list of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 1988] ControlPersist causes stderr to be left open until the master connection times out
https://bugzilla.mindrot.org/show_bug.cgi?id=1988 Darren Tucker changed: What|Removed |Added Attachment #2299||ok?(d...@mindrot.org) Flags|| --- Comment #5 from Darren Tucker --- Created attachment 2299 --> https://bugzilla.mindrot.org/attachment.cgi?id=2299&action=edit daemonize backgrounded mux master with controlpersist please try this patch from tedu: daemon'ize the backgrounded mux master. the new -E options should make the logging more useful in this case. -- You are receiving this mail because: You are watching the assignee of the bug. You are watching someone on the CC list of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 1988] ControlPersist causes stderr to be left open until the master connection times out
https://bugzilla.mindrot.org/show_bug.cgi?id=1988
Damien Miller changed:
What|Removed |Added
Attachment #2299|ok?(d...@mindrot.org)|ok+
Flags||
--- Comment #6 from Damien Miller ---
Comment on attachment 2299
--> https://bugzilla.mindrot.org/attachment.cgi?id=2299
daemonize backgrounded mux master with controlpersist
>Index: ssh.c
>===
>RCS file: /cvs/src/usr.bin/ssh/ssh.c,v
>retrieving revision 1.378
>diff -u -p -r1.378 ssh.c
>--- ssh.c 17 May 2013 00:13:14 - 1.378
>+++ ssh.c 6 Jun 2013 01:51:58 -
>@@ -947,6 +947,8 @@ control_persist_detach(void)
> fatal("%s: fork: %s", __func__, strerror(errno));
> case 0:
> /* Child: master process continues mainloop */
>+ if (daemon(1, 0) == -1)
>+ fatal("Failed to daemonize control master");
I'd prefer this happen in the block after the switch statement, where
the fd cleanup already occurs.
Otherwise ok by me
--
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 1988] ControlPersist causes stderr to be left open until the master connection times out
https://bugzilla.mindrot.org/show_bug.cgi?id=1988 Damien Miller changed: What|Removed |Added Blocks||2130 --- Comment #7 from Damien Miller --- Retarget to openssh-6.4 -- You are receiving this mail because: You are watching the assignee of the bug. You are watching someone on the CC list of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 1988] ControlPersist causes stderr to be left open until the master connection times out
https://bugzilla.mindrot.org/show_bug.cgi?id=1988 Damien Miller changed: What|Removed |Added Blocks|2076| --- Comment #8 from Damien Miller --- Retarget 6.3 -> 6.4 -- You are receiving this mail because: You are watching the assignee of the bug. You are watching someone on the CC list of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 1988] ControlPersist causes stderr to be left open until the master connection times out
https://bugzilla.mindrot.org/show_bug.cgi?id=1988 Darren Tucker changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED Blocks|2130|2076 --- Comment #9 from Darren Tucker --- nope, it's actually in 6.3: revision 1.381 date: 2013/07/25 00:29:10; author: djm; state: Exp; lines: +2 -1; daemonise backgrounded (ControlPersist'ed) multiplexing master to ensure it is fully detached from its controlling terminal. based on debugging and patch from tedu@ ok dtucker@ "be careful" deraadt@ please reopen if you can reproduce the problem with 6.3 or newer. -- You are receiving this mail because: You are watching the assignee of the bug. You are watching someone on the CC list of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 1988] ControlPersist causes stderr to be left open until the master connection times out
https://bugzilla.mindrot.org/show_bug.cgi?id=1988 Jeremy changed: What|Removed |Added Status|RESOLVED|REOPENED CC||bugzi...@highwarp.com Resolution|FIXED |--- --- Comment #10 from Jeremy --- (In reply to Darren Tucker from comment #9) > please reopen if you can reproduce the problem with 6.3 or newer. I've been able to reproduce this on 6.2 and 6.6. In those versions (and 6.3 as well), a daemon(1, 1) call is used and stderr is not detached. -- You are receiving this mail because: You are watching someone on the CC list of the bug. You are watching the assignee of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 1988] ControlPersist causes stderr to be left open until the master connection times out
https://bugzilla.mindrot.org/show_bug.cgi?id=1988 Dmitry Malinovsky changed: What|Removed |Added CC||damali...@gmail.com --- Comment #11 from Dmitry Malinovsky --- I can confirm this bug with $ ssh -V OpenSSH_6.6.1p1 Ubuntu-2ubuntu2, OpenSSL 1.0.1f 6 Jan 2014 $ cat /etc/issue Linux Mint 17.2 Rafaela \n \l -- You are receiving this mail because: You are watching the assignee of the bug. You are watching someone on the CC list of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 1988] ControlPersist causes stderr to be left open until the master connection times out
https://bugzilla.mindrot.org/show_bug.cgi?id=1988 Alex Vandiver changed: What|Removed |Added CC||mind...@chmrr.net --- Comment #12 from Alex Vandiver --- I agree with the other recent comments on this ticket; while the patch discussed on this ticket suggested `daemon(1,0)` (which would have adjusted the file descriptors) the commit as it was landed used `daemon(1,1)` instead, which has no effect on the FDs. It's also not clear why the return code check was omitted. -- You are receiving this mail because: You are watching someone on the CC list of the bug. You are watching the assignee of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 1988] ControlPersist causes stderr to be left open until the master connection times out
https://bugzilla.mindrot.org/show_bug.cgi?id=1988 Damien Miller changed: What|Removed |Added CC||cales...@scientia.net --- Comment #13 from Damien Miller --- *** Bug 2000 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching someone on the CC list of the bug. You are watching the assignee of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 1988] ControlPersist causes stderr to be left open until the master connection times out
https://bugzilla.mindrot.org/show_bug.cgi?id=1988 Damien Miller changed: What|Removed |Added Attachment #2299|0 |1 is obsolete|| Status|REOPENED|ASSIGNED Assignee|unassigned-b...@mindrot.org |d...@mindrot.org Attachment #2810||ok?(dtuc...@zip.com.au) Flags|| --- Comment #14 from Damien Miller --- Created attachment 2810 --> https://bugzilla.mindrot.org/attachment.cgi?id=2810&action=edit close ControlPersist stderr when logging to file/syslog or when not in debug mode We want to keep stderr open when in debug mode, so it's a little more complex than that. This patch tries to do the right thing. -- You are receiving this mail because: You are watching the assignee of the bug. You are watching someone on the CC list of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 1988] ControlPersist causes stderr to be left open until the master connection times out
https://bugzilla.mindrot.org/show_bug.cgi?id=1988 --- Comment #15 from Christoph Anton Mitterer --- Seems to also cause quite some troubles in the use case I've described in bug #2000, which Damien just marked a dup of this one. So people may want to have a look there as well for possibly further information. Can anyone make some predictions whether this issue can be solved? It would even be already helpful, when it would offer a special option that cause the FDs to be closed, just in case there are reasons why you don't want to make that the default. Further, when you have a look at the use case I describe in #2000, it should become obvious that this is done with likely many different versions of OpenSSH (our oldest still in use 5.3, as part of Scientific Linux 6)... do you think it requires just an up to date client (which would be easy for us, as there's one node which opens all the muxes, which anyway runs recent Debian)... or would all servers need to be updated as well? -- You are receiving this mail because: You are watching the assignee of the bug. You are watching someone on the CC list of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 1988] ControlPersist causes stderr to be left open until the master connection times out
https://bugzilla.mindrot.org/show_bug.cgi?id=1988 Damien Miller changed: What|Removed |Added Attachment #2810|0 |1 is obsolete|| Attachment #2810|ok?(dtuc...@zip.com.au) | Flags|| Attachment #2811||ok?(dtuc...@zip.com.au) Flags|| --- Comment #16 from Damien Miller --- Created attachment 2811 --> https://bugzilla.mindrot.org/attachment.cgi?id=2811&action=edit close ControlPersist stderr when logging to file/syslog or when not in debug mode (v2) Same as last patch, but the logic is a little more readable this way -- You are receiving this mail because: You are watching someone on the CC list of the bug. You are watching the assignee of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 1988] ControlPersist causes stderr to be left open until the master connection times out
https://bugzilla.mindrot.org/show_bug.cgi?id=1988 Darren Tucker changed: What|Removed |Added Attachment #2811|ok?(dtuc...@zip.com.au) |ok+ Flags|| -- You are receiving this mail because: You are watching the assignee of the bug. You are watching someone on the CC list of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 1988] ControlPersist causes stderr to be left open until the master connection times out
https://bugzilla.mindrot.org/show_bug.cgi?id=1988 Damien Miller changed: What|Removed |Added Blocks|2076|2543 Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #17 from Damien Miller --- patch applied - this will be in openssh-7.3 commit d2d6bf864e52af8491a60dd507f85b74361f5da3 Author: d...@openbsd.org Date: Fri Apr 29 08:07:53 2016 + upstream commit close ControlPersist background process stderr when not in debug mode or when logging to a file or syslog. bz#1988 ok dtucker Upstream-ID: 4fb726f0fdcb155ad419913cea10dc4afd409d24 Referenced Bugs: https://bugzilla.mindrot.org/show_bug.cgi?id=2076 [Bug 2076] Bugs intended to be fixed in 6.3 https://bugzilla.mindrot.org/show_bug.cgi?id=2543 [Bug 2543] Tracking bug for OpenSSH 7.3 release -- You are receiving this mail because: You are watching the assignee of the bug. You are watching someone on the CC list of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 1988] ControlPersist causes stderr to be left open until the master connection times out
https://bugzilla.mindrot.org/show_bug.cgi?id=1988 Damien Miller changed: What|Removed |Added Status|RESOLVED|CLOSED --- Comment #18 from Damien Miller --- Close all resolved bugs after 7.3p1 release -- You are receiving this mail because: You are watching the assignee of the bug. You are watching someone on the CC list of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 1988] ControlPersist causes stderr to be left open until the master connection times out
https://bugzilla.mindrot.org/show_bug.cgi?id=1988 huming <18381302...@163.com> changed: What|Removed |Added CC||18381302...@163.com --- Comment #19 from huming <18381302...@163.com> --- Created attachment 3409 --> https://bugzilla.mindrot.org/attachment.cgi?id=3409&action=edit 镜像出错总是报出下载yii asset连接超时 -- You are receiving this mail because: You are watching the assignee of the bug. You are watching someone on the CC list of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 1988] ControlPersist causes stderr to be left open until the master connection times out
https://bugzilla.mindrot.org/show_bug.cgi?id=1988 huming <18381302...@163.com> changed: What|Removed |Added Version|5.8p2 |-current URL||The ||"https://asset-packagist.or ||g/p/provider-latest/34e4352 ||9ebd311a360a582c4 ||7f976fccddef9b51df961e06303 ||dc694bbe1d319.json" -- You are receiving this mail because: You are watching someone on the CC list of the bug. You are watching the assignee of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 1988] ControlPersist causes stderr to be left open until the master connection times out
https://bugzilla.mindrot.org/show_bug.cgi?id=1988 Damien Miller changed: What|Removed |Added URL|The | |"https://asset-packagist.or | |g/p/provider-latest/34e4352 | |9ebd311a360a582c4 | |7f976fccddef9b51df961e06303 | |dc694bbe1d319.json" | -- You are receiving this mail because: You are watching the assignee of the bug. You are watching someone on the CC list of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
