[Bug 2464] Adding timestamp to debug messages (log.c:do_log)

[bugzilla-daemon]

https://bugzilla.mindrot.org/show_bug.cgi?id=2464

jason.na...@protonmail.com changed:

   What|Removed |Added

 CC||jason.na...@protonmail.com

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs

[Bug 2464] Adding timestamp to debug messages (log.c:do_log)

[bugzilla-daemon]

https://bugzilla.mindrot.org/show_bug.cgi?id=2464

--- Comment #6 from Darren Moffat  ---
As for it being on by default, maybe a good compromise would be that
timestamps are only added when the debug output is sent to a file
rather than on stderr/syslog.

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs

[Bug 2464] Adding timestamp to debug messages (log.c:do_log)

[bugzilla-daemon]

https://bugzilla.mindrot.org/show_bug.cgi?id=2464

Darren Moffat  changed:

   What|Removed |Added

 CC||darren.mof...@oracle.com

--- Comment #5 from Darren Moffat  ---
I've had some usecases recently for some sort of timestamp or timedelta
in the debug messages output.

It is fairly common to request 'ssh -vvv' output when debugging
connection problems.

In my environment the person assisting with the debugging of the
connection is almost never the one running the client (or server). 
While it is true that syslog would add a timestamp, it isn't always
possible for the user that is running the 'ssh -vvv' to update the
syslog configuration.  That could be for a various reasons, eg lacking
privilege to do so or the system syslog configuration is controlled via
a configuration management system and isn't allowed to be altered.

I agree with the prior comments that a delta rather than an absolute
time is probably more generally useful but either would be sufficient.

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs

[Bug 2464] Adding timestamp to debug messages (log.c:do_log)

[bugzilla-daemon]

https://bugzilla.mindrot.org/show_bug.cgi?id=2464

Darren Tucker  changed:

   What|Removed |Added

 CC||dtuc...@zip.com.au
   Attachment #2702|application/octet-stream|text/plain
  mime type||
   Attachment #2702|0   |1
   is patch||

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs

[Bug 2464] Adding timestamp to debug messages (log.c:do_log)

[bugzilla-daemon]

https://bugzilla.mindrot.org/show_bug.cgi?id=2464

--- Comment #2 from Darren Tucker  ---
Comment on attachment 2740
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2740
adding timestamp to debug messages

>+#include 

style(9) says this should go with the other  includes. 

>+  ftime ();

ftime is obsolete and has been removed from POSIX.1-2008.  Should use
gettimeofday instead.

>+  localtime_r (, );
>+  p += strftime (p, 16, "%Y%m%d.%H%M%S", );

I'm not a fan of unnecessary pointer arithmetic.  Since this is neither
time nor space critical, I'd rather strftime into a static buffer then
use snprintf to assemble the final string.

>+  p += sprintf (p, ".%03d ", tb.millitm);

also not a fan of unbounded string functions even if this particular
one is safe.

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs

[Bug 2464] Adding timestamp to debug messages (log.c:do_log)

[bugzilla-daemon]

https://bugzilla.mindrot.org/show_bug.cgi?id=2464

--- Comment #3 from Darren Tucker  ---
Created attachment 2741
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2741=edit
Changes as suggested.

Diff updated with suggested changes (also, making the timestamp format
ISO8601 compliant).

That said, what's the use case for this?  The timestamps are bulky, and
the only time I'm ever interested in the timing of them is the relative
time, which could be done in a lot less space by printing the number of
seconds since the previous log message.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs

[Bug 2464] Adding timestamp to debug messages (log.c:do_log)

[bugzilla-daemon]

https://bugzilla.mindrot.org/show_bug.cgi?id=2464

Damien Miller  changed:

   What|Removed |Added

 CC||d...@mindrot.org

--- Comment #4 from Damien Miller  ---
Why not use syslog? Both ssh and sshd support it and you get timestamps
for free?

I definitely don't think it should be on by default.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs

[Bug 2464] Adding timestamp to debug messages (log.c:do_log)

[bugzilla-daemon]

https://bugzilla.mindrot.org/show_bug.cgi?id=2464

Lőrinczy Zsigmond  changed:

   What|Removed |Added

 CC||lzs...@freemail.c3.hu

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
___
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs