[Bug 2982] gssapi_cleanup: supported mechs should be freed via gss_release_oid_set
https://bugzilla.mindrot.org/show_bug.cgi?id=2982 Damien Miller changed: What|Removed |Added Resolution|--- |FIXED Status|ASSIGNED|RESOLVED --- Comment #11 from Damien Miller --- This has been committed and will be in openssh-9.6, due around the end of the year. Thanks! -- You are receiving this mail because: You are watching the assignee of the bug. You are watching someone on the CC list of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 2982] gssapi_cleanup: supported mechs should be freed via gss_release_oid_set
https://bugzilla.mindrot.org/show_bug.cgi?id=2982 Darren Tucker changed: What|Removed |Added Attachment #3533|ok?(dtuc...@dtucker.net)|ok+ Flags|| -- You are receiving this mail because: You are watching the assignee of the bug. You are watching someone on the CC list of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 2982] gssapi_cleanup: supported mechs should be freed via gss_release_oid_set
https://bugzilla.mindrot.org/show_bug.cgi?id=2982 Damien Miller changed: What|Removed |Added Blocks|3549| Referenced Bugs: https://bugzilla.mindrot.org/show_bug.cgi?id=3549 [Bug 3549] Tracking bug for OpenSSH 9.4 -- You are receiving this mail because: You are watching the assignee of the bug. You are watching someone on the CC list of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 2982] gssapi_cleanup: supported mechs should be freed via gss_release_oid_set
https://bugzilla.mindrot.org/show_bug.cgi?id=2982 Damien Miller changed: What|Removed |Added Blocks||3628 Referenced Bugs: https://bugzilla.mindrot.org/show_bug.cgi?id=3628 [Bug 3628] tracking bug for openssh-9.6 -- You are receiving this mail because: You are watching the assignee of the bug. You are watching someone on the CC list of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 2982] gssapi_cleanup: supported mechs should be freed via gss_release_oid_set
https://bugzilla.mindrot.org/show_bug.cgi?id=2982 Damien Miller changed: What|Removed |Added Blocks|3533| Referenced Bugs: https://bugzilla.mindrot.org/show_bug.cgi?id=3533 [Bug 3533] tracking bug for openssh-9.3 -- You are receiving this mail because: You are watching someone on the CC list of the bug. You are watching the assignee of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 2982] gssapi_cleanup: supported mechs should be freed via gss_release_oid_set
https://bugzilla.mindrot.org/show_bug.cgi?id=2982 Damien Miller changed: What|Removed |Added Blocks||3549 Referenced Bugs: https://bugzilla.mindrot.org/show_bug.cgi?id=3549 [Bug 3549] Tracking bug for OpenSSH 9.4 -- You are receiving this mail because: You are watching the assignee of the bug. You are watching someone on the CC list of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 2982] gssapi_cleanup: supported mechs should be freed via gss_release_oid_set
https://bugzilla.mindrot.org/show_bug.cgi?id=2982 Darren Tucker changed: What|Removed |Added Blocks|3480| Referenced Bugs: https://bugzilla.mindrot.org/show_bug.cgi?id=3480 [Bug 3480] tracking bug for openssh-9.2 -- You are receiving this mail because: You are watching the assignee of the bug. You are watching someone on the CC list of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 2982] gssapi_cleanup: supported mechs should be freed via gss_release_oid_set
https://bugzilla.mindrot.org/show_bug.cgi?id=2982 Darren Tucker changed: What|Removed |Added Blocks||3533 Referenced Bugs: https://bugzilla.mindrot.org/show_bug.cgi?id=3533 [Bug 3533] tracking bug for openssh-9.3 -- You are receiving this mail because: You are watching someone on the CC list of the bug. You are watching the assignee of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 2982] gssapi_cleanup: supported mechs should be freed via gss_release_oid_set
https://bugzilla.mindrot.org/show_bug.cgi?id=2982 Damien Miller changed: What|Removed |Added Blocks|3418| Referenced Bugs: https://bugzilla.mindrot.org/show_bug.cgi?id=3418 [Bug 3418] tracking bug for openssh-9.1 -- You are receiving this mail because: You are watching the assignee of the bug. You are watching someone on the CC list of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 2982] gssapi_cleanup: supported mechs should be freed via gss_release_oid_set
https://bugzilla.mindrot.org/show_bug.cgi?id=2982 Damien Miller changed: What|Removed |Added Blocks||3480 Referenced Bugs: https://bugzilla.mindrot.org/show_bug.cgi?id=3480 [Bug 3480] tracking bug for openssh-9.1 -- You are receiving this mail because: You are watching the assignee of the bug. You are watching someone on the CC list of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 2982] gssapi_cleanup: supported mechs should be freed via gss_release_oid_set
https://bugzilla.mindrot.org/show_bug.cgi?id=2982 Damien Miller changed: What|Removed |Added Blocks||3418 Referenced Bugs: https://bugzilla.mindrot.org/show_bug.cgi?id=3418 [Bug 3418] tracking bug for openssh-9.1 -- You are receiving this mail because: You are watching someone on the CC list of the bug. You are watching the assignee of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 2982] gssapi_cleanup: supported mechs should be freed via gss_release_oid_set
https://bugzilla.mindrot.org/show_bug.cgi?id=2982 Damien Miller changed: What|Removed |Added Blocks|3302| Referenced Bugs: https://bugzilla.mindrot.org/show_bug.cgi?id=3302 [Bug 3302] Tracking bug for openssh-8.7 -- You are receiving this mail because: You are watching the assignee of the bug. You are watching someone on the CC list of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 2982] gssapi_cleanup: supported mechs should be freed via gss_release_oid_set
https://bugzilla.mindrot.org/show_bug.cgi?id=2982 Damien Miller changed: What|Removed |Added Blocks||3395 Referenced Bugs: https://bugzilla.mindrot.org/show_bug.cgi?id=3395 [Bug 3395] Tracking bug for openssh-9.0 -- You are receiving this mail because: You are watching someone on the CC list of the bug. You are watching the assignee of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 2982] gssapi_cleanup: supported mechs should be freed via gss_release_oid_set
https://bugzilla.mindrot.org/show_bug.cgi?id=2982 Damien Miller changed: What|Removed |Added Attachment #3299|0 |1 is obsolete|| Status|NEW |ASSIGNED CC||dtuc...@dtucker.net Assignee|unassigned-b...@mindrot.org |d...@mindrot.org Attachment #3533||ok?(dtuc...@dtucker.net) Flags|| --- Comment #10 from Damien Miller --- Created attachment 3533 --> https://bugzilla.mindrot.org/attachment.cgi?id=3533=edit cleanup GSSAPI mechanisms at end of authentication -- You are receiving this mail because: You are watching someone on the CC list of the bug. You are watching the assignee of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 2982] gssapi_cleanup: supported mechs should be freed via gss_release_oid_set
https://bugzilla.mindrot.org/show_bug.cgi?id=2982 Damien Miller changed: What|Removed |Added Blocks|3270| Referenced Bugs: https://bugzilla.mindrot.org/show_bug.cgi?id=3270 [Bug 3270] Tracking bug for 8.6 release -- You are receiving this mail because: You are watching someone on the CC list of the bug. You are watching the assignee of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 2982] gssapi_cleanup: supported mechs should be freed via gss_release_oid_set
https://bugzilla.mindrot.org/show_bug.cgi?id=2982 --- Comment #9 from Damien Miller --- retarget after 8.6p1 release -- You are receiving this mail because: You are watching the assignee of the bug. You are watching someone on the CC list of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 2982] gssapi_cleanup: supported mechs should be freed via gss_release_oid_set
https://bugzilla.mindrot.org/show_bug.cgi?id=2982 Damien Miller changed: What|Removed |Added Blocks||3302 Referenced Bugs: https://bugzilla.mindrot.org/show_bug.cgi?id=3302 [Bug 3302] Tracking bug for openssh-8.7 -- You are receiving this mail because: You are watching someone on the CC list of the bug. You are watching the assignee of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 2982] gssapi_cleanup: supported mechs should be freed via gss_release_oid_set
https://bugzilla.mindrot.org/show_bug.cgi?id=2982 Damien Miller changed: What|Removed |Added Blocks|3217| Referenced Bugs: https://bugzilla.mindrot.org/show_bug.cgi?id=3217 [Bug 3217] Tracking bug for 8.5 release -- You are receiving this mail because: You are watching the assignee of the bug. You are watching someone on the CC list of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 2982] gssapi_cleanup: supported mechs should be freed via gss_release_oid_set
https://bugzilla.mindrot.org/show_bug.cgi?id=2982 Damien Miller changed: What|Removed |Added Blocks||3270 --- Comment #8 from Damien Miller --- retarget to 8.6 Referenced Bugs: https://bugzilla.mindrot.org/show_bug.cgi?id=3270 [Bug 3270] Tracking bug for 8.6 release -- You are receiving this mail because: You are watching the assignee of the bug. You are watching someone on the CC list of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 2982] gssapi_cleanup: supported mechs should be freed via gss_release_oid_set
https://bugzilla.mindrot.org/show_bug.cgi?id=2982 Darren Tucker changed: What|Removed |Added Blocks|3162| Referenced Bugs: https://bugzilla.mindrot.org/show_bug.cgi?id=3162 [Bug 3162] Tracking bug for 8.4 release -- You are receiving this mail because: You are watching someone on the CC list of the bug. You are watching the assignee of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 2982] gssapi_cleanup: supported mechs should be freed via gss_release_oid_set
https://bugzilla.mindrot.org/show_bug.cgi?id=2982 Darren Tucker changed: What|Removed |Added Blocks||3217 Referenced Bugs: https://bugzilla.mindrot.org/show_bug.cgi?id=3217 [Bug 3217] Tracking bug for 8.5 release -- You are receiving this mail because: You are watching someone on the CC list of the bug. You are watching the assignee of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 2982] gssapi_cleanup: supported mechs should be freed via gss_release_oid_set
https://bugzilla.mindrot.org/show_bug.cgi?id=2982 Damien Miller changed: What|Removed |Added Blocks|3117| --- Comment #7 from Damien Miller --- Retarget bugs to 8.4 release Referenced Bugs: https://bugzilla.mindrot.org/show_bug.cgi?id=3117 [Bug 3117] Tracking bug for 8.3 release -- You are receiving this mail because: You are watching the assignee of the bug. You are watching someone on the CC list of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 2982] gssapi_cleanup: supported mechs should be freed via gss_release_oid_set
https://bugzilla.mindrot.org/show_bug.cgi?id=2982 Damien Miller changed: What|Removed |Added Blocks||3162 Referenced Bugs: https://bugzilla.mindrot.org/show_bug.cgi?id=3162 [Bug 3162] Tracking bug for 8.4 release -- You are receiving this mail because: You are watching someone on the CC list of the bug. You are watching the assignee of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 2982] gssapi_cleanup: supported mechs should be freed via gss_release_oid_set
https://bugzilla.mindrot.org/show_bug.cgi?id=2982 Damien Miller changed: What|Removed |Added Blocks|3079| Referenced Bugs: https://bugzilla.mindrot.org/show_bug.cgi?id=3079 [Bug 3079] Tracking bug for 8.2 release -- You are receiving this mail because: You are watching the assignee of the bug. You are watching someone on the CC list of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 2982] gssapi_cleanup: supported mechs should be freed via gss_release_oid_set
https://bugzilla.mindrot.org/show_bug.cgi?id=2982 Damien Miller changed: What|Removed |Added Blocks||3117 --- Comment #6 from Damien Miller --- Prepare for 8.2 release; retarget bugs Referenced Bugs: https://bugzilla.mindrot.org/show_bug.cgi?id=3117 [Bug 3117] Tracking bug for 8.2 release -- You are receiving this mail because: You are watching the assignee of the bug. You are watching someone on the CC list of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 2982] gssapi_cleanup: supported mechs should be freed via gss_release_oid_set
https://bugzilla.mindrot.org/show_bug.cgi?id=2982 Damien Miller changed: What|Removed |Added Blocks|2988| Referenced Bugs: https://bugzilla.mindrot.org/show_bug.cgi?id=2988 [Bug 2988] Tracking bug for 8.1 release -- You are receiving this mail because: You are watching the assignee of the bug. You are watching someone on the CC list of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 2982] gssapi_cleanup: supported mechs should be freed via gss_release_oid_set
https://bugzilla.mindrot.org/show_bug.cgi?id=2982 --- Comment #5 from Damien Miller --- Retarget these bugs to 8.2 release -- You are receiving this mail because: You are watching someone on the CC list of the bug. You are watching the assignee of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 2982] gssapi_cleanup: supported mechs should be freed via gss_release_oid_set
https://bugzilla.mindrot.org/show_bug.cgi?id=2982 Damien Miller changed: What|Removed |Added Blocks||3079 Referenced Bugs: https://bugzilla.mindrot.org/show_bug.cgi?id=3079 [Bug 3079] Tracking bug for 8.2 release -- You are receiving this mail because: You are watching someone on the CC list of the bug. You are watching the assignee of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 2982] gssapi_cleanup: supported mechs should be freed via gss_release_oid_set
https://bugzilla.mindrot.org/show_bug.cgi?id=2982 --- Comment #4 from Markus --- (If you are not comfortable with this change, please go back to the old behavior (I think in 7.8 before gssapi_cleanup was introducted) and let the supported-mechs list leak instead.) -- You are receiving this mail because: You are watching the assignee of the bug. You are watching someone on the CC list of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 2982] gssapi_cleanup: supported mechs should be freed via gss_release_oid_set
https://bugzilla.mindrot.org/show_bug.cgi?id=2982 --- Comment #3 from Markus --- > I think we should reuse the existing cleanup mechanism here. I don't > have a working krb/gssapi installation ATM so I can't really test > this though. I have debugged this and found that in some circumstances, gssapi_cleanup() is called multiple times (see comment1). If the gssapi system reports multiple mechs it goes through the cycle init/cleanup for each mech. So the supported-mechs-list is on sort of a higher level than a single gssapi auth attempt. Hence, releasing the mechs-list itself should not be done in the gssapi_cleanup function but at the very end of authentication. -- You are receiving this mail because: You are watching someone on the CC list of the bug. You are watching the assignee of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 2982] gssapi_cleanup: supported mechs should be freed via gss_release_oid_set
https://bugzilla.mindrot.org/show_bug.cgi?id=2982 Damien Miller changed: What|Removed |Added Attachment #3254|0 |1 is obsolete|| Attachment #3269|0 |1 is obsolete|| --- Comment #2 from Damien Miller --- Created attachment 3299 --> https://bugzilla.mindrot.org/attachment.cgi?id=3299=edit use existing cleanup mechanism I think we should reuse the existing cleanup mechanism here. I don't have a working krb/gssapi installation ATM so I can't really test this though. -- You are receiving this mail because: You are watching someone on the CC list of the bug. You are watching the assignee of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 2982] gssapi_cleanup: supported mechs should be freed via gss_release_oid_set
https://bugzilla.mindrot.org/show_bug.cgi?id=2982 Damien Miller changed: What|Removed |Added Blocks||2988 Referenced Bugs: https://bugzilla.mindrot.org/show_bug.cgi?id=2988 [Bug 2988] Tracking bug for 8.1 release -- You are receiving this mail because: You are watching the assignee of the bug. You are watching someone on the CC list of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 2982] gssapi_cleanup: supported mechs should be freed via gss_release_oid_set
https://bugzilla.mindrot.org/show_bug.cgi?id=2982 Damien Miller changed: What|Removed |Added CC||d...@mindrot.org Attachment #3269|application/octet-stream|text/plain mime type|| Attachment #3269|0 |1 is patch|| -- You are receiving this mail because: You are watching the assignee of the bug. You are watching someone on the CC list of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 2982] gssapi_cleanup: supported mechs should be freed via gss_release_oid_set
https://bugzilla.mindrot.org/show_bug.cgi?id=2982 --- Comment #1 from Markus --- Created attachment 3269 --> https://bugzilla.mindrot.org/attachment.cgi?id=3269=edit better version It turns out that the mechs should not only be freed via gss_release_oid_set. I also found that that it would be better to do this at the end of the userauth2() function because gss_cleanup is called multiple times when more than one method is reported/tried. -- You are receiving this mail because: You are watching the assignee of the bug. ___ openssh-bugs mailing list openssh-bugs@mindrot.org https://lists.mindrot.org/mailman/listinfo/openssh-bugs