[openssl-commits] Coverity Scan: Analysis completed for OpenSSL-1.0.2
Your request for analysis of OpenSSL-1.0.2 has been completed successfully. The results are available at https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRakUl6QyjujEohY7rPpoYUEeuRTZVWU4ku8PUBnVPw8PQ-3D-3D_19DGMz38yO7VfzGQuXkecdlEmzBoDG4v8Dvyanv-2F1I2C-2FCIwGE-2BGmFHzFbgDQ-2BuvjELN7dTM1v8-2F-2BcQI-2BHDzyOAoQkVwX2DrzEOqbfg9-2F9F1ur9HQOsrwTponIfDmTT4CZU7CTRRwUqna1lvv9Pr-2FeUXhoagYTXMaMo4rrR9F7jDGFPZbaGS9mMUNjlXU9kKBVMVBrFnXyZpSB59PbNfwg29MbRfJ4vc4Ya-2BvSZe7uo-3D Build ID: 238949 Analysis Summary: New defects found: 1 Defects eliminated: 0 If you have difficulty understanding any defects, email us at scan-ad...@coverity.com, or post your question to StackOverflow at https://u2389337.ct.sendgrid.net/wf/click?upn=OgIsEqWzmIl4S-2FzEUMxLXL-2BukuZt9UUdRZhgmgzAKchwAzH1nH3073xDEXNRgHN6q227lMNIWoOb8ZgSjAjKcg-3D-3D_19DGMz38yO7VfzGQuXkecdlEmzBoDG4v8Dvyanv-2F1I2C-2FCIwGE-2BGmFHzFbgDQ-2BuvjELN7dTM1v8-2F-2BcQI-2BHDzyDEKQT7qAkrbjoMopR55-2BtqcmC4ci9nOSlbxIf-2F91J59UySMesZIiqK-2F0PlwK20fB-2FF5WlCGKZQLmS2-2BttJfe6Ydqnh2bnsKkSpuhP7KY4J7-2Bbu-2FJ0mC6K7oQ2UsoMfTWdTrgD3BhoeGtiiDAcjLehE-3D _ openssl-commits mailing list To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-commits
[openssl-commits] [openssl] master update
The branch master has been updated
via 707c19f42113f90405b67cde59e5f1c1e42e6ab2 (commit)
via 04375857cf4971460c473fa44bef86351f2177fe (commit)
from 9f15e5b911ba6053e09578f190354568e01c07d7 (commit)
- Log -
commit 707c19f42113f90405b67cde59e5f1c1e42e6ab2
Author: Richard Levitte
Date: Sat Nov 24 17:39:56 2018 +0100
VMS build: typo in build file template, generatesrc
Reviewed-by: Tim Hudson
(Merged from https://github.com/openssl/openssl/pull/7700)
commit 04375857cf4971460c473fa44bef86351f2177fe
Author: Richard Levitte
Date: Sat Nov 24 11:37:10 2018 +0100
VMS config: Typo fix, as -> AS
This typo prevented ia64 assembler to be compiled on VMS
Reviewed-by: Tim Hudson
(Merged from https://github.com/openssl/openssl/pull/7700)
---
Summary of changes:
Configurations/10-main.conf | 2 +-
Configurations/descrip.mms.tmpl | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Configurations/10-main.conf b/Configurations/10-main.conf
index e3cc34c..d86691c 100644
--- a/Configurations/10-main.conf
+++ b/Configurations/10-main.conf
@@ -1791,7 +1791,7 @@ my %targets = (
},
"vms-ia64" => {
inherit_from => [ "vms-generic",
- sub { vms_info()->{as}
+ sub { vms_info()->{AS}
? asm("ia64_asm")->() : () } ],
bn_ops => "SIXTY_FOUR_BIT RC4_INT",
pointer_size => "",
diff --git a/Configurations/descrip.mms.tmpl b/Configurations/descrip.mms.tmpl
index 71660b3..d06c699 100644
--- a/Configurations/descrip.mms.tmpl
+++ b/Configurations/descrip.mms.tmpl
@@ -766,7 +766,7 @@ reconfigure reconf :
$target : $args{generator}->[0] $deps $mkdef
\$(PERL) $mkdef$ord_ver --ordinals $args{generator}->[0] --name
$ord_name "--OS" "VMS"$case_insensitive > $target
EOF
- } elsif ($target !~ /\.[sS]$/) {
+ } elsif ($args{src} !~ /\.[sS]$/) {
my $target = $args{src};
if ($args{generator}->[0] =~ m|^.*\.in$|) {
my $dofile = abs2rel(rel2abs(catfile($config{sourcedir},
_
openssl-commits mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-commits
[openssl-commits] [openssl] master update
The branch master has been updated
via 3be389435fc7b94623d972b622dbd9f0cd5c34f7 (commit)
via b741f153b2f24139d7210b1b0c9caf561f4900e8 (commit)
via 76bc401cc63219a462224884cb4af787e17725ed (commit)
via b9a694717902af796639e1dff641ba620703303b (commit)
via b42922ea2f605fd6c42faad1743fb27be5f7f1f3 (commit)
from 707c19f42113f90405b67cde59e5f1c1e42e6ab2 (commit)
- Log -
commit 3be389435fc7b94623d972b622dbd9f0cd5c34f7
Author: Richard Levitte
Date: Sat Nov 24 17:51:24 2018 +0100
Have util/mktar.sh display the absolute path to the tarball
Reviewed-by: Matthias St. Pierre
(Merged from https://github.com/openssl/openssl/pull/7696)
commit b741f153b2f24139d7210b1b0c9caf561f4900e8
Author: Richard Levitte
Date: Sat Nov 24 11:27:50 2018 +0100
Make sure to run util/mktar.sh from the source directory
Reviewed-by: Matthias St. Pierre
(Merged from https://github.com/openssl/openssl/pull/7696)
commit 76bc401cc63219a462224884cb4af787e17725ed
Author: Richard Levitte
Date: Sat Nov 24 00:59:33 2018 +0100
Don't export the submodules 'boringssl', 'krb5' and 'pyca-cryptography'
Reviewed-by: Matthias St. Pierre
(Merged from https://github.com/openssl/openssl/pull/7696)
commit b9a694717902af796639e1dff641ba620703303b
Author: Richard Levitte
Date: Fri Nov 23 14:43:16 2018 +0100
Don't export util/mktar.sh
When creating a tarball, it's pointless to include scripts that assume
a git workspace.
Reviewed-by: Matthias St. Pierre
(Merged from https://github.com/openssl/openssl/pull/7696)
commit b42922ea2f605fd6c42faad1743fb27be5f7f1f3
Author: Richard Levitte
Date: Fri Nov 23 14:40:39 2018 +0100
Document the removed 'dist' target
Also adds missing copyright boilerplate to util/mktar.sh
Reviewed-by: Matthias St. Pierre
(Merged from https://github.com/openssl/openssl/pull/7696)
---
Summary of changes:
.gitattributes| 4
CHANGES | 5 +
Configurations/unix-Makefile.tmpl | 3 ++-
util/mktar.sh | 11 ++-
4 files changed, 21 insertions(+), 2 deletions(-)
diff --git a/.gitattributes b/.gitattributes
index 912b4ae..96e40b6 100644
--- a/.gitattributes
+++ b/.gitattributes
@@ -6,3 +6,7 @@
fuzz/corpora/** export-ignore
Configurations/*.norelease.conf export-ignore
.* export-ignore
+util/mktar.sh export-ignore
+boringssl export-ignore
+krb5export-ignore
+pyca-cryptography export-ignore
diff --git a/CHANGES b/CHANGES
index 95bced8..c554575 100644
--- a/CHANGES
+++ b/CHANGES
@@ -9,6 +9,11 @@
Changes between 1.1.1 and 1.1.2 [xx XXX ]
+ *) Remove the 'dist' target and add a tarball building script. The
+ 'dist' target has fallen out of use, and it shouldn't be
+ necessary to configure just to create a source distribution.
+ [Richard Levitte]
+
*) Recreate the OS390-Unix config target. It no longer relies on a
special script like it did for OpenSSL pre-1.1.0.
[Richard Levitte]
diff --git a/Configurations/unix-Makefile.tmpl
b/Configurations/unix-Makefile.tmpl
index b5c6991..ecdd0c1 100644
--- a/Configurations/unix-Makefile.tmpl
+++ b/Configurations/unix-Makefile.tmpl
@@ -231,6 +231,7 @@ TARFLAGS= {- $target{TARFLAGS} -}
BASENAME= openssl
NAME= $(BASENAME)-$(VERSION)
+# Relative to $(SRCDIR)
TARFILE=../$(NAME).tar
# Project flags ##
@@ -873,7 +874,7 @@ tags TAGS: FORCE
# Release targets (note: only available on Unix) #
tar:
- $(SRCDIR)/util/mktar.sh --name='$(NAME)' --tarfile='$(TARFILE)'
+ (cd $(SRCDIR); ./util/mktar.sh --name='$(NAME)' --tarfile='$(TARFILE)')
# Helper targets #
diff --git a/util/mktar.sh b/util/mktar.sh
index 0848b7b..17115cf 100755
--- a/util/mktar.sh
+++ b/util/mktar.sh
@@ -1,4 +1,10 @@
#! /bin/sh
+# Copyright 2018 The OpenSSL Project Authors. All Rights Reserved.
+#
+# Licensed under the OpenSSL license (the "License"). You may not use
+# this file except in compliance with the License. You can obtain a copy
+# in the file LICENSE in the source distribution or at
+# https://www.openssl.org/source/license.html
HERE=`dirname $0`
@@ -24,4 +30,7 @@ if [ -z "$TARFILE" ]; then TARFILE="$NAME.tar"; fi
git archive --worktree-attributes --format=tar --prefix="$NAME/" -v HEAD \
| gzip -9 > "$TARFILE.gz"
-ls -l "$TARFILE.gz"
+# Good old way to ensure we display an absolute path
+td=`dirname $TARFILE`
+tf=`basename $TARFILE`
+ls -l "`cd $td;
[openssl-commits] [openssl] OpenSSL_1_1_1-stable update
The branch OpenSSL_1_1_1-stable has been updated
via 97afd2b6b13fd79bccf8b85abbc1c15af4b945d4 (commit)
via d4fd89996866f320d6193b5f5e2c2b9efeed31c5 (commit)
via 105d4c0cdf5de96ca4241bbdad735ed6a590ff90 (commit)
via a6d4cc8257b6852fa3b84935434d75aba396bdab (commit)
via 909ecd4f371a5de20e2d74985cee3258f4d1d6d3 (commit)
from 5f90d1b88204b893555b575cb1f22f9a4ea53522 (commit)
- Log -
commit 97afd2b6b13fd79bccf8b85abbc1c15af4b945d4
Author: Richard Levitte
Date: Sat Nov 24 17:51:24 2018 +0100
Have util/mktar.sh display the absolute path to the tarball
Reviewed-by: Matthias St. Pierre
(Merged from https://github.com/openssl/openssl/pull/7696)
(cherry picked from commit 3be389435fc7b94623d972b622dbd9f0cd5c34f7)
commit d4fd89996866f320d6193b5f5e2c2b9efeed31c5
Author: Richard Levitte
Date: Sat Nov 24 11:27:50 2018 +0100
Make sure to run util/mktar.sh from the source directory
Reviewed-by: Matthias St. Pierre
(Merged from https://github.com/openssl/openssl/pull/7696)
(cherry picked from commit b741f153b2f24139d7210b1b0c9caf561f4900e8)
commit 105d4c0cdf5de96ca4241bbdad735ed6a590ff90
Author: Richard Levitte
Date: Sat Nov 24 00:59:33 2018 +0100
Don't export the submodules 'boringssl', 'krb5' and 'pyca-cryptography'
Reviewed-by: Matthias St. Pierre
(Merged from https://github.com/openssl/openssl/pull/7696)
(cherry picked from commit 76bc401cc63219a462224884cb4af787e17725ed)
commit a6d4cc8257b6852fa3b84935434d75aba396bdab
Author: Richard Levitte
Date: Fri Nov 23 14:43:16 2018 +0100
Don't export util/mktar.sh
When creating a tarball, it's pointless to include scripts that assume
a git workspace.
Reviewed-by: Matthias St. Pierre
(Merged from https://github.com/openssl/openssl/pull/7696)
(cherry picked from commit b9a694717902af796639e1dff641ba620703303b)
commit 909ecd4f371a5de20e2d74985cee3258f4d1d6d3
Author: Richard Levitte
Date: Fri Nov 23 14:40:39 2018 +0100
Document the removed 'dist' target
Also adds missing copyright boilerplate to util/mktar.sh
Reviewed-by: Matthias St. Pierre
(Merged from https://github.com/openssl/openssl/pull/7696)
(cherry picked from commit b42922ea2f605fd6c42faad1743fb27be5f7f1f3)
---
Summary of changes:
.gitattributes| 4
CHANGES | 5 -
Configurations/unix-Makefile.tmpl | 3 ++-
util/mktar.sh | 11 ++-
4 files changed, 20 insertions(+), 3 deletions(-)
diff --git a/.gitattributes b/.gitattributes
index 912b4ae..96e40b6 100644
--- a/.gitattributes
+++ b/.gitattributes
@@ -6,3 +6,7 @@
fuzz/corpora/** export-ignore
Configurations/*.norelease.conf export-ignore
.* export-ignore
+util/mktar.sh export-ignore
+boringssl export-ignore
+krb5export-ignore
+pyca-cryptography export-ignore
diff --git a/CHANGES b/CHANGES
index 9cc29b7..94ccdc0 100644
--- a/CHANGES
+++ b/CHANGES
@@ -9,7 +9,10 @@
Changes between 1.1.1a and 1.1.1b [xx XXX ]
- *)
+ *) Remove the 'dist' target and add a tarball building script. The
+ 'dist' target has fallen out of use, and it shouldn't be
+ necessary to configure just to create a source distribution.
+ [Richard Levitte]
Changes between 1.1.1 and 1.1.1a [20 Nov 2018]
diff --git a/Configurations/unix-Makefile.tmpl
b/Configurations/unix-Makefile.tmpl
index 003b28a..3d99985 100644
--- a/Configurations/unix-Makefile.tmpl
+++ b/Configurations/unix-Makefile.tmpl
@@ -227,6 +227,7 @@ TARFLAGS= {- $target{TARFLAGS} -}
BASENAME= openssl
NAME= $(BASENAME)-$(VERSION)
+# Relative to $(SRCDIR)
TARFILE=../$(NAME).tar
# Project flags ##
@@ -831,7 +832,7 @@ tags TAGS: FORCE
# Release targets (note: only available on Unix) #
tar:
- $(SRCDIR)/util/mktar.sh --name='$(NAME)' --tarfile='$(TARFILE)'
+ (cd $(SRCDIR); ./util/mktar.sh --name='$(NAME)' --tarfile='$(TARFILE)')
# Helper targets #
diff --git a/util/mktar.sh b/util/mktar.sh
index 0848b7b..17115cf 100755
--- a/util/mktar.sh
+++ b/util/mktar.sh
@@ -1,4 +1,10 @@
#! /bin/sh
+# Copyright 2018 The OpenSSL Project Authors. All Rights Reserved.
+#
+# Licensed under the OpenSSL license (the "License"). You may not use
+# this file except in compliance with the License. You can obtain a copy
+# in the file LICENSE in the source distribution or at
+# https://www.openssl.org/source/license.html
HERE=`dirname $0`
@@
[openssl-commits] [openssl] OpenSSL_1_1_0-stable update
The branch OpenSSL_1_1_0-stable has been updated
via 403783ce05991e21a50d637398798a014e2c4f9d (commit)
via ffe7659f788300d924179209c854e6826f2c0332 (commit)
via 58381f26c288505766daac9e0f20f879fcd06631 (commit)
via 0e17281a9c35077263128f721e82199a89c36cb8 (commit)
via ed207080455147f76d575687f1a7743fa6b0ae0a (commit)
from 7dac8144a760f0d9780cd7eb0771894874becd78 (commit)
- Log -
commit 403783ce05991e21a50d637398798a014e2c4f9d
Author: Richard Levitte
Date: Sat Nov 24 17:51:24 2018 +0100
Have util/mktar.sh display the absolute path to the tarball
Reviewed-by: Matthias St. Pierre
(Merged from https://github.com/openssl/openssl/pull/7696)
(cherry picked from commit 3be389435fc7b94623d972b622dbd9f0cd5c34f7)
commit ffe7659f788300d924179209c854e6826f2c0332
Author: Richard Levitte
Date: Sat Nov 24 11:27:50 2018 +0100
Make sure to run util/mktar.sh from the source directory
Reviewed-by: Matthias St. Pierre
(Merged from https://github.com/openssl/openssl/pull/7696)
(cherry picked from commit b741f153b2f24139d7210b1b0c9caf561f4900e8)
commit 58381f26c288505766daac9e0f20f879fcd06631
Author: Richard Levitte
Date: Sat Nov 24 00:59:33 2018 +0100
Don't export the submodules 'boringssl', 'krb5' and 'pyca-cryptography'
Reviewed-by: Matthias St. Pierre
(Merged from https://github.com/openssl/openssl/pull/7696)
(cherry picked from commit 76bc401cc63219a462224884cb4af787e17725ed)
commit 0e17281a9c35077263128f721e82199a89c36cb8
Author: Richard Levitte
Date: Fri Nov 23 14:43:16 2018 +0100
Don't export util/mktar.sh
When creating a tarball, it's pointless to include scripts that assume
a git workspace.
Reviewed-by: Matthias St. Pierre
(Merged from https://github.com/openssl/openssl/pull/7696)
(cherry picked from commit b9a694717902af796639e1dff641ba620703303b)
commit ed207080455147f76d575687f1a7743fa6b0ae0a
Author: Richard Levitte
Date: Fri Nov 23 14:40:39 2018 +0100
Document the removed 'dist' target
Also adds missing copyright boilerplate to util/mktar.sh
Reviewed-by: Matthias St. Pierre
(Merged from https://github.com/openssl/openssl/pull/7696)
(cherry picked from commit b42922ea2f605fd6c42faad1743fb27be5f7f1f3)
---
Summary of changes:
.gitattributes| 4
CHANGES | 5 -
Configurations/unix-Makefile.tmpl | 3 ++-
util/mktar.sh | 11 ++-
4 files changed, 20 insertions(+), 3 deletions(-)
diff --git a/.gitattributes b/.gitattributes
index 912b4ae..96e40b6 100644
--- a/.gitattributes
+++ b/.gitattributes
@@ -6,3 +6,7 @@
fuzz/corpora/** export-ignore
Configurations/*.norelease.conf export-ignore
.* export-ignore
+util/mktar.sh export-ignore
+boringssl export-ignore
+krb5export-ignore
+pyca-cryptography export-ignore
diff --git a/CHANGES b/CHANGES
index 60c0dd1..e19b976 100644
--- a/CHANGES
+++ b/CHANGES
@@ -9,7 +9,10 @@
Changes between 1.1.0j and 1.1.0k [xx XXX ]
- *)
+ *) Remove the 'dist' target and add a tarball building script. The
+ 'dist' target has fallen out of use, and it shouldn't be
+ necessary to configure just to create a source distribution.
+ [Richard Levitte]
Changes between 1.1.0i and 1.1.0j [20 Nov 2018]
diff --git a/Configurations/unix-Makefile.tmpl
b/Configurations/unix-Makefile.tmpl
index b35db4f..af84bd4 100644
--- a/Configurations/unix-Makefile.tmpl
+++ b/Configurations/unix-Makefile.tmpl
@@ -201,6 +201,7 @@ MAKEDEPEND={- $config{makedepprog} -}
BASENAME= openssl
NAME= $(BASENAME)-$(VERSION)
+# Relative to $(SRCDIR)
TARFILE=../$(NAME).tar
# We let the C compiler driver to take care of .s files. This is done in
@@ -666,7 +667,7 @@ tags TAGS: FORCE
# Release targets (note: only available on Unix) #
tar:
- $(SRCDIR)/util/mktar.sh --name='$(NAME)' --tarfile='$(TARFILE)'
+ (cd $(SRCDIR); ./util/mktar.sh --name='$(NAME)' --tarfile='$(TARFILE)')
# Helper targets #
diff --git a/util/mktar.sh b/util/mktar.sh
index 0848b7b..17115cf 100755
--- a/util/mktar.sh
+++ b/util/mktar.sh
@@ -1,4 +1,10 @@
#! /bin/sh
+# Copyright 2018 The OpenSSL Project Authors. All Rights Reserved.
+#
+# Licensed under the OpenSSL license (the "License"). You may not use
+# this file except in compliance with the License. You can obtain a copy
+# in the file LICENSE in the source distribution or at
+# https://www.openssl.org/source/license.html
HERE=`dirname $0`
[openssl-commits] [openssl] master update
The branch master has been updated
via 9f15e5b911ba6053e09578f190354568e01c07d7 (commit)
from 8d9535ec3e317641b8e551973c8cfe2ee1c89296 (commit)
- Log -
commit 9f15e5b911ba6053e09578f190354568e01c07d7
Author: Richard Levitte
Date: Sat Nov 24 13:08:56 2018 +0100
VMS: fix collected error strings
It turns out that on VMS, strerror() returns messages with added
spaces at the end.
We wouldn't had noticed if it wasn't for perl trimming those spaces
off for its own sake and thereby having test/recipes/02-test_errstr.t
fail on VMS.
The safe fix is to do the same trimming ourselves.
Reviewed-by: Paul Dale
(Merged from https://github.com/openssl/openssl/pull/7701)
---
Summary of changes:
crypto/err/err.c | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/crypto/err/err.c b/crypto/err/err.c
index ffdc140..34061bc 100644
--- a/crypto/err/err.c
+++ b/crypto/err/err.c
@@ -19,6 +19,7 @@
#include
#include
#include "internal/thread_once.h"
+#include "internal/ctype.h"
static int err_load_strings(const ERR_STRING_DATA *str);
@@ -217,13 +218,24 @@ static void build_SYS_str_reasons(void)
str->error = ERR_PACK(ERR_LIB_SYS, 0, i);
if (str->string == NULL) {
if (openssl_strerror_r(i, cur, sizeof(strerror_pool) - cnt)) {
-size_t l = strlen(cur) + 1;
+size_t l = strlen(cur);
str->string = cur;
cnt += l;
if (cnt > sizeof(strerror_pool))
cnt = sizeof(strerror_pool);
cur += l;
+
+/*
+ * VMS has an unusual quirk of adding spaces at the end of
+ * some (most? all?) messages. Lets trim them off.
+ */
+while (ossl_isspace(cur[-1])) {
+cur--;
+cnt--;
+}
+*cur++ = '\0';
+cnt++;
}
}
if (str->string == NULL)
_
openssl-commits mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-commits
[openssl-commits] [openssl] OpenSSL_1_1_1-stable update
The branch OpenSSL_1_1_1-stable has been updated
via 5f90d1b88204b893555b575cb1f22f9a4ea53522 (commit)
from 1119d4e7f4b1f9eeb0e50063081c516708e3ca72 (commit)
- Log -
commit 5f90d1b88204b893555b575cb1f22f9a4ea53522
Author: Richard Levitte
Date: Sat Nov 24 11:37:10 2018 +0100
VMS config: Typo fix, as -> AS
This typo prevented ia64 assembler to be compiled on VMS
Reviewed-by: Tim Hudson
(Merged from https://github.com/openssl/openssl/pull/7700)
(cherry picked from commit 04375857cf4971460c473fa44bef86351f2177fe)
---
Summary of changes:
Configurations/10-main.conf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Configurations/10-main.conf b/Configurations/10-main.conf
index 5cf345d..f0cf6c1 100644
--- a/Configurations/10-main.conf
+++ b/Configurations/10-main.conf
@@ -1782,7 +1782,7 @@ my %targets = (
},
"vms-ia64" => {
inherit_from => [ "vms-generic",
- sub { vms_info()->{as}
+ sub { vms_info()->{AS}
? asm("ia64_asm")->() : () } ],
bn_ops => "SIXTY_FOUR_BIT RC4_INT",
pointer_size => "",
_
openssl-commits mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-commits
[openssl-commits] [openssl] OpenSSL_1_1_1-stable update
The branch OpenSSL_1_1_1-stable has been updated
via 1119d4e7f4b1f9eeb0e50063081c516708e3ca72 (commit)
from 6aca8d1a5fb1fa8b359d0ddeab636174c09bf534 (commit)
- Log -
commit 1119d4e7f4b1f9eeb0e50063081c516708e3ca72
Author: Richard Levitte
Date: Sat Nov 24 13:08:56 2018 +0100
VMS: fix collected error strings
It turns out that on VMS, strerror() returns messages with added
spaces at the end.
We wouldn't had noticed if it wasn't for perl trimming those spaces
off for its own sake and thereby having test/recipes/02-test_errstr.t
fail on VMS.
The safe fix is to do the same trimming ourselves.
Reviewed-by: Paul Dale
(Merged from https://github.com/openssl/openssl/pull/7701)
(cherry picked from commit 9f15e5b911ba6053e09578f190354568e01c07d7)
---
Summary of changes:
crypto/err/err.c | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/crypto/err/err.c b/crypto/err/err.c
index ffdc140..34061bc 100644
--- a/crypto/err/err.c
+++ b/crypto/err/err.c
@@ -19,6 +19,7 @@
#include
#include
#include "internal/thread_once.h"
+#include "internal/ctype.h"
static int err_load_strings(const ERR_STRING_DATA *str);
@@ -217,13 +218,24 @@ static void build_SYS_str_reasons(void)
str->error = ERR_PACK(ERR_LIB_SYS, 0, i);
if (str->string == NULL) {
if (openssl_strerror_r(i, cur, sizeof(strerror_pool) - cnt)) {
-size_t l = strlen(cur) + 1;
+size_t l = strlen(cur);
str->string = cur;
cnt += l;
if (cnt > sizeof(strerror_pool))
cnt = sizeof(strerror_pool);
cur += l;
+
+/*
+ * VMS has an unusual quirk of adding spaces at the end of
+ * some (most? all?) messages. Lets trim them off.
+ */
+while (ossl_isspace(cur[-1])) {
+cur--;
+cnt--;
+}
+*cur++ = '\0';
+cnt++;
}
}
if (str->string == NULL)
_
openssl-commits mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-commits
[openssl-commits] [openssl] OpenSSL_1_1_1-stable update
The branch OpenSSL_1_1_1-stable has been updated
via ca554c02df8fb207e346f07c70c5f4d3b84cdb1d (commit)
from 97afd2b6b13fd79bccf8b85abbc1c15af4b945d4 (commit)
- Log -
commit ca554c02df8fb207e346f07c70c5f4d3b84cdb1d
Author: Richard Levitte
Date: Fri Nov 23 18:53:32 2018 +0100
Avoid test_errstr in a cross compiled configuration
There's too high a chance that the openssl app and perl get different
messages for some error numbers.
[extended tests]
Reviewed-by: Matt Caswell
(Merged from https://github.com/openssl/openssl/pull/7699)
(cherry picked from commit 0777de15ff09105593c7e778cf47f97a9144d273)
---
Summary of changes:
test/recipes/02-test_errstr.t | 9 +
1 file changed, 9 insertions(+)
diff --git a/test/recipes/02-test_errstr.t b/test/recipes/02-test_errstr.t
index 3d806f0..745c3c0 100644
--- a/test/recipes/02-test_errstr.t
+++ b/test/recipes/02-test_errstr.t
@@ -9,6 +9,7 @@
use strict;
no strict 'refs'; # To be able to use strings as function refs
use OpenSSL::Test;
+use OpenSSL::Test::Utils;
use Errno qw(:POSIX);
use POSIX qw(strerror);
@@ -22,6 +23,14 @@ use constant NUM_SYS_STR_REASONS => 127;
setup('test_errstr');
+# In a cross compiled situation, there are chances that our
+# application is linked against different C libraries than
+# perl, and may thereby get different error messages for the
+# same error.
+# The safest is not to test under such circumstances.
+plan skip_all => 'This is unsupported for cross compiled configurations'
+if config('CROSS_COMPILE');
+
# These are POSIX error names, which Errno implements as functions
# (this is documented)
my @posix_errors = @{$Errno::EXPORT_TAGS{POSIX}};
_
openssl-commits mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-commits
[openssl-commits] Still Failing: openssl/openssl#21907 (OpenSSL_1_1_1-stable - 97afd2b)
Build Update for openssl/openssl - Build: #21907 Status: Still Failing Duration: 22 mins and 26 secs Commit: 97afd2b (OpenSSL_1_1_1-stable) Author: Richard Levitte Message: Have util/mktar.sh display the absolute path to the tarball Reviewed-by: Matthias St. Pierre (Merged from https://github.com/openssl/openssl/pull/7696) (cherry picked from commit 3be389435fc7b94623d972b622dbd9f0cd5c34f7) View the changeset: https://github.com/openssl/openssl/compare/5f90d1b88204...97afd2b6b13f View the full build log and details: https://travis-ci.org/openssl/openssl/builds/459179289?utm_medium=notification_source=email -- You can unsubscribe from build emails from the openssl/openssl repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=5849220_medium=notification_source=email. Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notification_source=email. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications. _ openssl-commits mailing list To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-commits
[openssl-commits] Fixed: openssl/openssl#21909 (master - 0777de1)
Build Update for openssl/openssl - Build: #21909 Status: Fixed Duration: 20 mins and 8 secs Commit: 0777de1 (master) Author: Richard Levitte Message: Avoid test_errstr in a cross compiled configuration There's too high a chance that the openssl app and perl get different messages for some error numbers. [extended tests] Reviewed-by: Matt Caswell (Merged from https://github.com/openssl/openssl/pull/7699) View the changeset: https://github.com/openssl/openssl/compare/3be389435fc7...0777de15ff09 View the full build log and details: https://travis-ci.org/openssl/openssl/builds/459180523?utm_medium=notification_source=email -- You can unsubscribe from build emails from the openssl/openssl repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=5849220_medium=notification_source=email. Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notification_source=email. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications. _ openssl-commits mailing list To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-commits
[openssl-commits] Still Failing: openssl/openssl#21904 (master - 707c19f)
Build Update for openssl/openssl - Build: #21904 Status: Still Failing Duration: 17 mins and 38 secs Commit: 707c19f (master) Author: Richard Levitte Message: VMS build: typo in build file template, generatesrc Reviewed-by: Tim Hudson (Merged from https://github.com/openssl/openssl/pull/7700) View the changeset: https://github.com/openssl/openssl/compare/9f15e5b911ba...707c19f42113 View the full build log and details: https://travis-ci.org/openssl/openssl/builds/459177578?utm_medium=notification_source=email -- You can unsubscribe from build emails from the openssl/openssl repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=5849220_medium=notification_source=email. Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notification_source=email. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications. _ openssl-commits mailing list To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-commits
[openssl-commits] Still Failing: openssl/openssl#21902 (OpenSSL_1_1_1-stable - 1119d4e)
Build Update for openssl/openssl - Build: #21902 Status: Still Failing Duration: 21 mins and 51 secs Commit: 1119d4e (OpenSSL_1_1_1-stable) Author: Richard Levitte Message: VMS: fix collected error strings It turns out that on VMS, strerror() returns messages with added spaces at the end. We wouldn't had noticed if it wasn't for perl trimming those spaces off for its own sake and thereby having test/recipes/02-test_errstr.t fail on VMS. The safe fix is to do the same trimming ourselves. Reviewed-by: Paul Dale (Merged from https://github.com/openssl/openssl/pull/7701) (cherry picked from commit 9f15e5b911ba6053e09578f190354568e01c07d7) View the changeset: https://github.com/openssl/openssl/compare/6aca8d1a5fb1...1119d4e7f4b1 View the full build log and details: https://travis-ci.org/openssl/openssl/builds/459164846?utm_medium=notification_source=email -- You can unsubscribe from build emails from the openssl/openssl repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=5849220_medium=notification_source=email. Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notification_source=email. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications. _ openssl-commits mailing list To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-commits
[openssl-commits] Still Failing: openssl/openssl#21905 (OpenSSL_1_1_1-stable - 5f90d1b)
Build Update for openssl/openssl - Build: #21905 Status: Still Failing Duration: 22 mins and 55 secs Commit: 5f90d1b (OpenSSL_1_1_1-stable) Author: Richard Levitte Message: VMS config: Typo fix, as -> AS This typo prevented ia64 assembler to be compiled on VMS Reviewed-by: Tim Hudson (Merged from https://github.com/openssl/openssl/pull/7700) (cherry picked from commit 04375857cf4971460c473fa44bef86351f2177fe) View the changeset: https://github.com/openssl/openssl/compare/1119d4e7f4b1...5f90d1b88204 View the full build log and details: https://travis-ci.org/openssl/openssl/builds/459178336?utm_medium=notification_source=email -- You can unsubscribe from build emails from the openssl/openssl repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=5849220_medium=notification_source=email. Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notification_source=email. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications. _ openssl-commits mailing list To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-commits
[openssl-commits] Still Failing: openssl/openssl#21906 (master - 3be3894)
Build Update for openssl/openssl - Build: #21906 Status: Still Failing Duration: 24 mins and 16 secs Commit: 3be3894 (master) Author: Richard Levitte Message: Have util/mktar.sh display the absolute path to the tarball Reviewed-by: Matthias St. Pierre (Merged from https://github.com/openssl/openssl/pull/7696) View the changeset: https://github.com/openssl/openssl/compare/707c19f42113...3be389435fc7 View the full build log and details: https://travis-ci.org/openssl/openssl/builds/459178800?utm_medium=notification_source=email -- You can unsubscribe from build emails from the openssl/openssl repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=5849220_medium=notification_source=email. Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notification_source=email. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications. _ openssl-commits mailing list To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-commits
[openssl-commits] Fixed: openssl/openssl#21910 (OpenSSL_1_1_1-stable - ca554c0)
Build Update for openssl/openssl - Build: #21910 Status: Fixed Duration: 22 mins and 19 secs Commit: ca554c0 (OpenSSL_1_1_1-stable) Author: Richard Levitte Message: Avoid test_errstr in a cross compiled configuration There's too high a chance that the openssl app and perl get different messages for some error numbers. [extended tests] Reviewed-by: Matt Caswell (Merged from https://github.com/openssl/openssl/pull/7699) (cherry picked from commit 0777de15ff09105593c7e778cf47f97a9144d273) View the changeset: https://github.com/openssl/openssl/compare/97afd2b6b13f...ca554c02df8f View the full build log and details: https://travis-ci.org/openssl/openssl/builds/459180727?utm_medium=notification_source=email -- You can unsubscribe from build emails from the openssl/openssl repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=5849220_medium=notification_source=email. Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notification_source=email. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications. _ openssl-commits mailing list To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-commits
