Still FAILED build of OpenSSL branch master with options -d enable-fuzz-afl no-shared

2019-04-15 Thread OpenSSL run-checker
Platform and configuration command:

$ uname -a
Linux run 4.4.0-135-generic #161-Ubuntu SMP Mon Aug 27 10:45:01 UTC 2018 x86_64 
x86_64 x86_64 GNU/Linux
$ CC=afl-clang-fast ../openssl/config -d enable-fuzz-afl no-shared

Commit log since last time:

3e3dcf9ab8 Call RSA generation callback at the correct time.
72eb100f8a Don't use '-z defs' with Clang's sanitizers
f2dbb71cb6 providers/common/digests/sha2.c: forward declare all dispatched 
functions
0ad50b4dee Providers: for the digest_final operation, pass a output buffer size

Build log ended with (last 100 lines):

/home/openssl/run-checker/enable-fuzz-afl/../openssl/crypto/include/internal/md32_common.h:128:
 undefined reference to `__afl_area_ptr'
/home/openssl/run-checker/enable-fuzz-afl/../openssl/crypto/include/internal/md32_common.h:138:
 undefined reference to `__afl_prev_loc'
/home/openssl/run-checker/enable-fuzz-afl/../openssl/crypto/include/internal/md32_common.h:140:
 undefined reference to `__afl_prev_loc'
/home/openssl/run-checker/enable-fuzz-afl/../openssl/crypto/include/internal/md32_common.h:141:
 undefined reference to `__afl_prev_loc'
/home/openssl/run-checker/enable-fuzz-afl/../openssl/crypto/include/internal/md32_common.h:147:
 undefined reference to `__afl_prev_loc'
/home/openssl/run-checker/enable-fuzz-afl/../openssl/crypto/include/internal/md32_common.h:147:
 undefined reference to `__afl_area_ptr'
/home/openssl/run-checker/enable-fuzz-afl/../openssl/crypto/include/internal/md32_common.h:150:
 undefined reference to `__afl_prev_loc'
/home/openssl/run-checker/enable-fuzz-afl/../openssl/crypto/include/internal/md32_common.h:150:
 undefined reference to `__afl_area_ptr'
/home/openssl/run-checker/enable-fuzz-afl/../openssl/crypto/include/internal/md32_common.h:(.text+0x3a8):
 undefined reference to `__afl_area_ptr'
/home/openssl/run-checker/enable-fuzz-afl/../openssl/crypto/include/internal/md32_common.h:130:
 undefined reference to `__afl_prev_loc'
/home/openssl/run-checker/enable-fuzz-afl/../openssl/crypto/include/internal/md32_common.h:172:
 undefined reference to `__afl_prev_loc'
/home/openssl/run-checker/enable-fuzz-afl/../openssl/crypto/include/internal/md32_common.h:164:
 undefined reference to `__afl_prev_loc'
/home/openssl/run-checker/enable-fuzz-afl/../openssl/crypto/include/internal/md32_common.h:164:
 undefined reference to `__afl_area_ptr'
/home/openssl/run-checker/enable-fuzz-afl/../openssl/crypto/include/internal/md32_common.h:130:
 undefined reference to `__afl_prev_loc'
/home/openssl/run-checker/enable-fuzz-afl/../openssl/crypto/include/internal/md32_common.h:179:
 undefined reference to `__afl_prev_loc'
/home/openssl/run-checker/enable-fuzz-afl/../openssl/crypto/include/internal/md32_common.h:184:
 undefined reference to `__afl_prev_loc'
crypto/sha/fips-dso-sha256.o: In function `SHA256_Final':
/home/openssl/run-checker/enable-fuzz-afl/../openssl/crypto/include/internal/md32_common.h:191:
 undefined reference to `__afl_prev_loc'
/home/openssl/run-checker/enable-fuzz-afl/../openssl/crypto/include/internal/md32_common.h:191:
 undefined reference to `__afl_area_ptr'
/home/openssl/run-checker/enable-fuzz-afl/../openssl/crypto/include/internal/md32_common.h:200:
 undefined reference to `__afl_prev_loc'
/home/openssl/run-checker/enable-fuzz-afl/../openssl/crypto/include/internal/md32_common.h:194:
 undefined reference to `__afl_prev_loc'
/home/openssl/run-checker/enable-fuzz-afl/../openssl/crypto/include/internal/md32_common.h:222:
 undefined reference to `__afl_prev_loc'
/home/openssl/run-checker/enable-fuzz-afl/../openssl/crypto/include/internal/md32_common.h:222:
 undefined reference to `__afl_prev_loc'
/home/openssl/run-checker/enable-fuzz-afl/../openssl/crypto/include/internal/md32_common.h:222:
 undefined reference to `__afl_prev_loc'
crypto/sha/fips-dso-sha256.o:/home/openssl/run-checker/enable-fuzz-afl/../openssl/crypto/include/internal/md32_common.h:222:
 more undefined references to `__afl_prev_loc' follow
crypto/sha/fips-dso-sha256.o: In function `SHA256':
/home/openssl/run-checker/enable-fuzz-afl/../openssl/crypto/sha/sha256.c:64: 
undefined reference to `__afl_area_ptr'
crypto/sha/fips-dso-sha256.o: In function `SHA224_Update':
/home/openssl/run-checker/enable-fuzz-afl/../openssl/crypto/sha/sha256.c:77: 
undefined reference to `__afl_prev_loc'
/home/openssl/run-checker/enable-fuzz-afl/../openssl/crypto/sha/sha256.c:77: 
undefined reference to `__afl_area_ptr'
crypto/sha/fips-dso-sha256.o: In function `SHA224_Final':
/home/openssl/run-checker/enable-fuzz-afl/../openssl/crypto/sha/sha256.c:82: 
undefined reference to `__afl_prev_loc'
/home/openssl/run-checker/enable-fuzz-afl/../openssl/crypto/sha/sha256.c:82: 
undefined reference to `__afl_area_ptr'
crypto/sha/fips-dso-sha256.o: In function `sha256_block_data_order':
/home/openssl/run-checker/enable-fuzz-afl/../openssl/crypto/sha/sha256.c:248: 
undefined reference to `__afl_prev_loc'
/home/openssl/run-checker/enable-fuzz-afl/../openssl/crypto/sha/sha256.c:248: 
un

Still FAILED build of OpenSSL branch master with options -d --strict-warnings no-ec2m

2019-04-15 Thread OpenSSL run-checker
Platform and configuration command:

$ uname -a
Linux run 4.4.0-135-generic #161-Ubuntu SMP Mon Aug 27 10:45:01 UTC 2018 x86_64 
x86_64 x86_64 GNU/Linux
$ CC=clang ../openssl/config -d --strict-warnings no-ec2m

Commit log since last time:

3e3dcf9ab8 Call RSA generation callback at the correct time.
72eb100f8a Don't use '-z defs' with Clang's sanitizers
f2dbb71cb6 providers/common/digests/sha2.c: forward declare all dispatched 
functions
0ad50b4dee Providers: for the digest_final operation, pass a output buffer size

Build log ended with (last 100 lines):

/usr/bin/perl ../openssl/test/generate_buildtest.pl e_os2 > 
test/buildtest_e_os2.c
/usr/bin/perl ../openssl/test/generate_buildtest.pl ebcdic > 
test/buildtest_ebcdic.c
/usr/bin/perl ../openssl/test/generate_buildtest.pl ec > test/buildtest_ec.c
/usr/bin/perl ../openssl/test/generate_buildtest.pl ecdh > test/buildtest_ecdh.c
/usr/bin/perl ../openssl/test/generate_buildtest.pl ecdsa > 
test/buildtest_ecdsa.c
/usr/bin/perl ../openssl/test/generate_buildtest.pl engine > 
test/buildtest_engine.c
/usr/bin/perl ../openssl/test/generate_buildtest.pl ess > test/buildtest_ess.c
/usr/bin/perl ../openssl/test/generate_buildtest.pl evp > test/buildtest_evp.c
/usr/bin/perl ../openssl/test/generate_buildtest.pl hmac > test/buildtest_hmac.c
/usr/bin/perl ../openssl/test/generate_buildtest.pl idea > test/buildtest_idea.c
/usr/bin/perl ../openssl/test/generate_buildtest.pl kdf > test/buildtest_kdf.c
/usr/bin/perl ../openssl/test/generate_buildtest.pl lhash > 
test/buildtest_lhash.c
/usr/bin/perl ../openssl/test/generate_buildtest.pl md4 > test/buildtest_md4.c
/usr/bin/perl ../openssl/test/generate_buildtest.pl md5 > test/buildtest_md5.c
/usr/bin/perl ../openssl/test/generate_buildtest.pl mdc2 > test/buildtest_mdc2.c
/usr/bin/perl ../openssl/test/generate_buildtest.pl modes > 
test/buildtest_modes.c
/usr/bin/perl ../openssl/test/generate_buildtest.pl obj_mac > 
test/buildtest_obj_mac.c
/usr/bin/perl ../openssl/test/generate_buildtest.pl objects > 
test/buildtest_objects.c
/usr/bin/perl ../openssl/test/generate_buildtest.pl ocsp > test/buildtest_ocsp.c
/usr/bin/perl ../openssl/test/generate_buildtest.pl opensslv > 
test/buildtest_opensslv.c
/usr/bin/perl ../openssl/test/generate_buildtest.pl ossl_typ > 
test/buildtest_ossl_typ.c
/usr/bin/perl ../openssl/test/generate_buildtest.pl params > 
test/buildtest_params.c
/usr/bin/perl ../openssl/test/generate_buildtest.pl pem > test/buildtest_pem.c
/usr/bin/perl ../openssl/test/generate_buildtest.pl pem2 > test/buildtest_pem2.c
/usr/bin/perl ../openssl/test/generate_buildtest.pl pkcs12 > 
test/buildtest_pkcs12.c
/usr/bin/perl ../openssl/test/generate_buildtest.pl pkcs7 > 
test/buildtest_pkcs7.c
/usr/bin/perl ../openssl/test/generate_buildtest.pl provider > 
test/buildtest_provider.c
/usr/bin/perl ../openssl/test/generate_buildtest.pl rand > test/buildtest_rand.c
/usr/bin/perl ../openssl/test/generate_buildtest.pl rand_drbg > 
test/buildtest_rand_drbg.c
/usr/bin/perl ../openssl/test/generate_buildtest.pl rc2 > test/buildtest_rc2.c
/usr/bin/perl ../openssl/test/generate_buildtest.pl rc4 > test/buildtest_rc4.c
/usr/bin/perl ../openssl/test/generate_buildtest.pl ripemd > 
test/buildtest_ripemd.c
/usr/bin/perl ../openssl/test/generate_buildtest.pl rsa > test/buildtest_rsa.c
/usr/bin/perl ../openssl/test/generate_buildtest.pl safestack > 
test/buildtest_safestack.c
/usr/bin/perl ../openssl/test/generate_buildtest.pl seed > test/buildtest_seed.c
/usr/bin/perl ../openssl/test/generate_buildtest.pl sha > test/buildtest_sha.c
/usr/bin/perl ../openssl/test/generate_buildtest.pl srp > test/buildtest_srp.c
/usr/bin/perl ../openssl/test/generate_buildtest.pl srtp > test/buildtest_srtp.c
/usr/bin/perl ../openssl/test/generate_buildtest.pl ssl > test/buildtest_ssl.c
/usr/bin/perl ../openssl/test/generate_buildtest.pl ssl2 > test/buildtest_ssl2.c
/usr/bin/perl ../openssl/test/generate_buildtest.pl stack > 
test/buildtest_stack.c
/usr/bin/perl ../openssl/test/generate_buildtest.pl store > 
test/buildtest_store.c
/usr/bin/perl ../openssl/test/generate_buildtest.pl symhacks > 
test/buildtest_symhacks.c
/usr/bin/perl ../openssl/test/generate_buildtest.pl tls1 > test/buildtest_tls1.c
/usr/bin/perl ../openssl/test/generate_buildtest.pl ts > test/buildtest_ts.c
/usr/bin/perl ../openssl/test/generate_buildtest.pl txt_db > 
test/buildtest_txt_db.c
/usr/bin/perl ../openssl/test/generate_buildtest.pl ui > test/buildtest_ui.c
/usr/bin/perl ../openssl/test/generate_buildtest.pl whrlpool > 
test/buildtest_whrlpool.c
/usr/bin/perl ../openssl/test/generate_buildtest.pl x509 > test/buildtest_x509.c
/usr/bin/perl ../openssl/test/generate_buildtest.pl x509_vfy > 
test/buildtest_x509_vfy.c
/usr/bin/perl ../openssl/test/generate_buildtest.pl x509v3 > 
test/buildtest_x509v3.c
clang  -Iinclude -Iapps/include -I../openssl/include -I../openssl/apps/include  
-pthread -m64 -Wa,--noexecstack -Qunused-arguments -Wall -O0 -g -DDEBUG_UNUSED 
-DPEDANTIC -pedantic -Wno-long-lo

SUCCESSFUL build of OpenSSL branch master with options -d --strict-warnings enable-asan no-shared -DOPENSSL_SMALL_FOOTPRINT

2019-04-15 Thread OpenSSL run-checker
Platform and configuration command:

$ uname -a
Linux run 4.4.0-135-generic #161-Ubuntu SMP Mon Aug 27 10:45:01 UTC 2018 x86_64 
x86_64 x86_64 GNU/Linux
$ CC=clang ../openssl/config -d --strict-warnings enable-asan no-shared 
-DOPENSSL_SMALL_FOOTPRINT

Commit log since last time:

3e3dcf9ab8 Call RSA generation callback at the correct time.
72eb100f8a Don't use '-z defs' with Clang's sanitizers
f2dbb71cb6 providers/common/digests/sha2.c: forward declare all dispatched 
functions
0ad50b4dee Providers: for the digest_final operation, pass a output buffer size


Still Failing: openssl/openssl#24767 (master - 3e3dcf9)

2019-04-15 Thread Travis CI
Build Update for openssl/openssl
-

Build: #24767
Status: Still Failing

Duration: 18 mins and 22 secs
Commit: 3e3dcf9 (master)
Author: Kurt Roeckx
Message: Call RSA generation callback at the correct time.

The callback should be called with 1 when a Miller-Rabin round marked
the candidate as probably prime.

Reviewed-by: Bernd Edlinger 
GH: #8742

View the changeset: 
https://github.com/openssl/openssl/compare/72eb100f8a38...3e3dcf9ab8a2

View the full build log and details: 
https://travis-ci.org/openssl/openssl/builds/520471077?utm_medium=notification&utm_source=email

--

You can unsubscribe from build emails from the openssl/openssl repository going 
to 
https://travis-ci.org/account/preferences/unsubscribe?repository=5849220&utm_medium=notification&utm_source=email.
Or unsubscribe from *all* email updating your settings at 
https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notification&utm_source=email.
Or configure specific recipients for build notifications in your .travis.yml 
file. See https://docs.travis-ci.com/user/notifications.



[openssl] master update

2019-04-15 Thread Kurt Roeckx
The branch master has been updated
   via  3e3dcf9ab8a2fc0214502dad56d94fd95bcbbfd5 (commit)
  from  72eb100f8a38c5b3822d7751eddaa2f3f4576fa1 (commit)


- Log -
commit 3e3dcf9ab8a2fc0214502dad56d94fd95bcbbfd5
Author: Kurt Roeckx 
Date:   Sat Apr 13 14:04:35 2019 +0200

Call RSA generation callback at the correct time.

The callback should be called with 1 when a Miller-Rabin round marked
the candidate as probably prime.

Reviewed-by: Bernd Edlinger 
GH: #8742

---

Summary of changes:
 crypto/bn/bn_prime.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/crypto/bn/bn_prime.c b/crypto/bn/bn_prime.c
index 2c9f89d..03402c2 100644
--- a/crypto/bn/bn_prime.c
+++ b/crypto/bn/bn_prime.c
@@ -329,8 +329,6 @@ int bn_miller_rabin_is_prime(const BIGNUM *w, int 
iterations, BN_CTX *ctx,
 if (BN_is_one(z))
 goto composite;
 }
-if (!BN_GENCB_call(cb, 1, i))
-goto err;
 /* At this point z = b^((w-1)/2) mod w */
 /* (Steps 4.8 - 4.9) x = z, z = x^2 mod w */
 if (!BN_copy(x, z) || !BN_mod_mul(z, x, x, w, ctx))
@@ -358,6 +356,8 @@ composite:
 goto err;
 outer_loop: ;
 /* (Step 4.1.5) */
+if (!BN_GENCB_call(cb, 1, i))
+goto err;
 }
 /* (Step 5) */
 *status = BN_PRIMETEST_PROBABLY_PRIME;


Build completed: openssl master.24167

2019-04-15 Thread AppVeyor


Build openssl master.24167 completed



Commit 7426af4103 by Richard Levitte on 4/15/2019 3:30 PM:

doc/man3/X509_LOOKUP_meth_new.pod: clarify the requirements


Configure your notification preferences



Build failed: openssl master.24166

2019-04-15 Thread AppVeyor



Build openssl master.24166 failed


Commit 9b7f79ea3a by Matt Caswell on 4/15/2019 2:33 PM:

Add forward declarations of the AES dispatch table functions


Configure your notification preferences



Still Failing: openssl/openssl#24760 (master - 72eb100)

2019-04-15 Thread Travis CI
Build Update for openssl/openssl
-

Build: #24760
Status: Still Failing

Duration: 20 mins and 44 secs
Commit: 72eb100 (master)
Author: Richard Levitte
Message: Don't use '-z defs' with Clang's sanitizers

The clang documentation in all sanitizers we currently use says this:

When linking shared libraries, the {flavor}Sanitizer run-time is
not linked, so -Wl,-z,defs may cause link errors (don’t use it
with {flavor}Sanitizer)

(in our case, {flavor} is one of Address, Memory, or UndefinedBehavior)

Therefore, we turn off that particular flag specifically when using
the sanitizers.

Fixes #8735

Reviewed-by: Matt Caswell 
(Merged from https://github.com/openssl/openssl/pull/8749)

View the changeset: 
https://github.com/openssl/openssl/compare/f2dbb71cb6bf...72eb100f8a38

View the full build log and details: 
https://travis-ci.org/openssl/openssl/builds/520332906?utm_medium=notification&utm_source=email

--

You can unsubscribe from build emails from the openssl/openssl repository going 
to 
https://travis-ci.org/account/preferences/unsubscribe?repository=5849220&utm_medium=notification&utm_source=email.
Or unsubscribe from *all* email updating your settings at 
https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notification&utm_source=email.
Or configure specific recipients for build notifications in your .travis.yml 
file. See https://docs.travis-ci.com/user/notifications.




[openssl] master update

2019-04-15 Thread Richard Levitte
The branch master has been updated
   via  72eb100f8a38c5b3822d7751eddaa2f3f4576fa1 (commit)
  from  f2dbb71cb6bf6cd570f96e7663a22dd87854f08b (commit)


- Log -
commit 72eb100f8a38c5b3822d7751eddaa2f3f4576fa1
Author: Richard Levitte 
Date:   Mon Apr 15 10:40:18 2019 +0200

Don't use '-z defs' with Clang's sanitizers

The clang documentation in all sanitizers we currently use says this:

When linking shared libraries, the {flavor}Sanitizer run-time is
not linked, so -Wl,-z,defs may cause link errors (don’t use it
with {flavor}Sanitizer)

(in our case, {flavor} is one of Address, Memory, or UndefinedBehavior)

Therefore, we turn off that particular flag specifically when using
the sanitizers.

Fixes #8735

Reviewed-by: Matt Caswell 
(Merged from https://github.com/openssl/openssl/pull/8749)

---

Summary of changes:
 Configurations/shared-info.pl | 5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/Configurations/shared-info.pl b/Configurations/shared-info.pl
index f821ad7..83f28bd 100644
--- a/Configurations/shared-info.pl
+++ b/Configurations/shared-info.pl
@@ -32,7 +32,10 @@ my %shared_info;
 return {
 %{$shared_info{'gnu-shared'}},
 shared_defflag=> '-Wl,--version-script=',
-dso_ldflags   => '-z defs',
+dso_ldflags   =>
+$disabled{asan} && $disabled{msan} && $disabled{ubsan}
+? '-z defs'
+: '',
 };
 },
 'bsd-gcc-shared' => sub { return $shared_info{'linux-shared'}; },


Still Failing: openssl/openssl#24758 (OpenSSL_1_1_1-stable - 1ced49f)

2019-04-15 Thread Travis CI
Build Update for openssl/openssl
-

Build: #24758
Status: Still Failing

Duration: 17 mins and 33 secs
Commit: 1ced49f (OpenSSL_1_1_1-stable)
Author: Joshua Lock
Message: Further harmonisation of manual page HISTORY sections

A couple of minor tweaks to match the style introduced in #7854:
- BIO_connect: remove line break to make more grep friendly
- SSL_CTX_new: harmoise the format of the HISTORY section

Reviewed-by: Matthias St. Pierre 
Reviewed-by: Richard Levitte 

(cherry picked from commit 938e82f622eb04ebbfe534c79d234d0f6a0df035)

Reviewed-by: Matt Caswell 
(Merged from https://github.com/openssl/openssl/pull/8736)

View the changeset: 
https://github.com/openssl/openssl/compare/e861d659c0b2...1ced49fbb742

View the full build log and details: 
https://travis-ci.org/openssl/openssl/builds/520224699?utm_medium=notification&utm_source=email

--

You can unsubscribe from build emails from the openssl/openssl repository going 
to 
https://travis-ci.org/account/preferences/unsubscribe?repository=5849220&utm_medium=notification&utm_source=email.
Or unsubscribe from *all* email updating your settings at 
https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notification&utm_source=email.
Or configure specific recipients for build notifications in your .travis.yml 
file. See https://docs.travis-ci.com/user/notifications.



[openssl] OpenSSL_1_1_1-stable update

2019-04-15 Thread matthias . st . pierre
The branch OpenSSL_1_1_1-stable has been updated
   via  1ced49fbb7428994b137248d52f108d4045bb4a3 (commit)
   via  18bad53564e10b92832475dfce0c56665b5d3bed (commit)
   via  3b01f353b8533f2d66f7411c3513d9444ba68329 (commit)
   via  32a775df9b720781220556549d7e52c45ebb562d (commit)
   via  a345fa370e6acd1293e7370a85266e87dc7ebc38 (commit)
   via  d090fc0019b8ef04bcae8c7eafe98950a9694fc8 (commit)
  from  e861d659c0b2ddccc5eff577b322d2fd4a8f9616 (commit)


- Log -
commit 1ced49fbb7428994b137248d52f108d4045bb4a3
Author: Joshua Lock 
Date:   Thu Apr 11 15:38:56 2019 +0100

Further harmonisation of manual page HISTORY sections

A couple of minor tweaks to match the style introduced in #7854:
- BIO_connect: remove line break to make more grep friendly
- SSL_CTX_new: harmoise the format of the HISTORY section

Reviewed-by: Matthias St. Pierre 
Reviewed-by: Richard Levitte 

(cherry picked from commit 938e82f622eb04ebbfe534c79d234d0f6a0df035)

Reviewed-by: Matt Caswell 
(Merged from https://github.com/openssl/openssl/pull/8736)

commit 18bad53564e10b92832475dfce0c56665b5d3bed
Author: Joshua Lock 
Date:   Tue Apr 9 15:13:55 2019 +0100

Update various man pages to place HISTORY section after SEE ALSO

SEE ALSO before HISTORY is the more common pattern in OpenSSL manual
pages and seems to be the prevalent order based on sampling my system
manual pages.

Fixes #8631

Reviewed-by: Matthias St. Pierre 
Reviewed-by: Richard Levitte 

(cherry picked from commit b5c4bbbe54e112b976155004b3d702e47ce7d9d9)

 Conflicts:
doc/man3/RAND_DRBG_generate.pod
doc/man3/RAND_DRBG_reseed.pod

Reviewed-by: Matt Caswell 
(Merged from https://github.com/openssl/openssl/pull/8736)

commit 3b01f353b8533f2d66f7411c3513d9444ba68329
Author: Joshua Lock 
Date:   Tue Apr 9 15:10:08 2019 +0100

Add a check for history section location to find-doc-nits

Check that the HISTORY section is located after the SEE ALSO section,
this is a much more frequent order in OpenSSL manual pages (and UNIX
manual pages in general).

Also check that SEE ALSO comes after EXAMPLES, so that the tool can
ensure the correct manual section sequence.

Reviewed-by: Matthias St. Pierre 
Reviewed-by: Richard Levitte 

(cherry picked from commit 573ac8f2228241771f727ecd8ff10f54073536d3)

Reviewed-by: Matt Caswell 
(Merged from https://github.com/openssl/openssl/pull/8736)

commit 32a775df9b720781220556549d7e52c45ebb562d
Author: Joshua Lock 
Date:   Tue Apr 9 14:53:58 2019 +0100

Make check_example_location() in find-doc-nits generic

Change to check_section_location(), a generic function to ensure that
section SECTION appears before section BEFORE in the man pages.

Reviewed-by: Matthias St. Pierre 
Reviewed-by: Richard Levitte 

(cherry picked from commit 95f92d57755a9bfc83135a585da69d497f7293d9)

Reviewed-by: Matt Caswell 
(Merged from https://github.com/openssl/openssl/pull/8736)

commit a345fa370e6acd1293e7370a85266e87dc7ebc38
Author: Paul Yang 
Date:   Tue Feb 26 13:51:02 2019 +0800

Add section order check in util/find-doc-nits

This patch checks if the EXAMPLES section in a pod file is placed
before the RETURN VALUES section.

Reviewed-by: Richard Levitte 

(cherry picked from commit cc838ee2d66f7295bf7a7e6695aab1080d6791e9)

Reviewed-by: Matt Caswell 
Reviewed-by: Matthias St. Pierre 
(Merged from https://github.com/openssl/openssl/pull/8736)

commit d090fc0019b8ef04bcae8c7eafe98950a9694fc8
Author: Paul Yang 
Date:   Tue Feb 26 13:11:10 2019 +0800

Place return values after examples in doc

Reviewed-by: Richard Levitte 

(cherry picked from commit 4564e77ae9dd1866e8a033f03511b6a1792c024e)

 Conflicts:
doc/internal/man3/openssl_ctx_get_data.pod (non-existant)
doc/man3/OPENSSL_s390xcap.pod (non-existant)

Reviewed-by: Matt Caswell 
Reviewed-by: Matthias St. Pierre 
(Merged from https://github.com/openssl/openssl/pull/8736)

---

Summary of changes:
 doc/man3/ASN1_TIME_set.pod|  64 ++--
 doc/man3/ASN1_generate_nconf.pod  |  14 +--
 doc/man3/BIO_connect.pod  |  14 +--
 doc/man3/BIO_push.pod |  14 +--
 doc/man3/BIO_s_file.pod   |  36 +++
 doc/man3/BN_rand.pod  |  20 ++--
 doc/man3/BN_security_bits.pod |  10 +-
 doc/man3/CONF_modules_load_file.pod   |  12 +--
 doc/man3/DES_random_key.pod   |  12 +--
 doc/man3/EVP_PKEY_set1_RSA.pod|  14 +--
 doc/man3/OBJ_nid2obj.pod  |

Still FAILED build of OpenSSL branch master with options -d --strict-warnings enable-ubsan -DPEDANTIC -DOPENSSL_SMALL_FOOTPRINT -fno-sanitize=alignment

2019-04-15 Thread OpenSSL run-checker
Platform and configuration command:

$ uname -a
Linux run 4.4.0-135-generic #161-Ubuntu SMP Mon Aug 27 10:45:01 UTC 2018 x86_64 
x86_64 x86_64 GNU/Linux
$ CC=clang ../openssl/config -d --strict-warnings enable-ubsan -DPEDANTIC 
-DOPENSSL_SMALL_FOOTPRINT -fno-sanitize=alignment

Commit log since last time:

15972296af Fix calling convention bug in ecp_nistz256_ord_sqr_mont
3051bf2afa Don't use coordinate blinding when scalar is group order
938e82f622 Further harmonisation of manual page HISTORY sections
b5c4bbbe54 Update various man pages to place HISTORY section after SEE ALSO
573ac8f222 Add a check for history section location to find-doc-nits
95f92d5775 Make check_example_location() in find-doc-nits generic
fd367b4ce3 Deprecate AES_ige_encrypt() and AES_bi_ige_encrypt()
9bba2c4c97 Add CMAC speed measurements
6517516324 Add prediction resistance capability to the DRBG reseeding process.

Build log ended with (last 100 lines):

/home/openssl/run-checker/enable-ubsan/../openssl/crypto/sha/sha256.c:210: 
undefined reference to `__ubsan_handle_shift_out_of_bounds_abort'
/home/openssl/run-checker/enable-ubsan/../openssl/crypto/sha/sha256.c:210: 
undefined reference to `__ubsan_handle_shift_out_of_bounds_abort'
/home/openssl/run-checker/enable-ubsan/../openssl/crypto/sha/sha256.c:210: 
undefined reference to `__ubsan_handle_shift_out_of_bounds_abort'
/home/openssl/run-checker/enable-ubsan/../openssl/crypto/sha/sha256.c:210: 
undefined reference to `__ubsan_handle_shift_out_of_bounds_abort'
crypto/sha/fips-dso-sha256.o:/home/openssl/run-checker/enable-ubsan/../openssl/crypto/sha/sha256.c:210:
 more undefined references to `__ubsan_handle_shift_out_of_bounds_abort' follow
crypto/sha/fips-dso-sha256.o: In function `sha256_block_data_order':
/home/openssl/run-checker/enable-ubsan/../openssl/crypto/sha/sha256.c:202: 
undefined reference to `__ubsan_handle_add_overflow_abort'
/home/openssl/run-checker/enable-ubsan/../openssl/crypto/sha/sha256.c:221: 
undefined reference to `__ubsan_handle_type_mismatch_v1_abort'
/home/openssl/run-checker/enable-ubsan/../openssl/crypto/sha/sha256.c:221: 
undefined reference to `__ubsan_handle_out_of_bounds_abort'
/home/openssl/run-checker/enable-ubsan/../openssl/crypto/sha/sha256.c:221: 
undefined reference to `__ubsan_handle_type_mismatch_v1_abort'
/home/openssl/run-checker/enable-ubsan/../openssl/crypto/sha/sha256.c:222: 
undefined reference to `__ubsan_handle_type_mismatch_v1_abort'
/home/openssl/run-checker/enable-ubsan/../openssl/crypto/sha/sha256.c:222: 
undefined reference to `__ubsan_handle_out_of_bounds_abort'
/home/openssl/run-checker/enable-ubsan/../openssl/crypto/sha/sha256.c:222: 
undefined reference to `__ubsan_handle_pointer_overflow_abort'
/home/openssl/run-checker/enable-ubsan/../openssl/crypto/sha/sha256.c:222: 
undefined reference to `__ubsan_handle_type_mismatch_v1_abort'
/home/openssl/run-checker/enable-ubsan/../openssl/crypto/sha/sha256.c:223: 
undefined reference to `__ubsan_handle_type_mismatch_v1_abort'
/home/openssl/run-checker/enable-ubsan/../openssl/crypto/sha/sha256.c:223: 
undefined reference to `__ubsan_handle_out_of_bounds_abort'
/home/openssl/run-checker/enable-ubsan/../openssl/crypto/sha/sha256.c:223: 
undefined reference to `__ubsan_handle_pointer_overflow_abort'
/home/openssl/run-checker/enable-ubsan/../openssl/crypto/sha/sha256.c:223: 
undefined reference to `__ubsan_handle_type_mismatch_v1_abort'
/home/openssl/run-checker/enable-ubsan/../openssl/crypto/sha/sha256.c:224: 
undefined reference to `__ubsan_handle_type_mismatch_v1_abort'
/home/openssl/run-checker/enable-ubsan/../openssl/crypto/sha/sha256.c:224: 
undefined reference to `__ubsan_handle_out_of_bounds_abort'
/home/openssl/run-checker/enable-ubsan/../openssl/crypto/sha/sha256.c:224: 
undefined reference to `__ubsan_handle_pointer_overflow_abort'
/home/openssl/run-checker/enable-ubsan/../openssl/crypto/sha/sha256.c:224: 
undefined reference to `__ubsan_handle_type_mismatch_v1_abort'
/home/openssl/run-checker/enable-ubsan/../openssl/crypto/sha/sha256.c:225: 
undefined reference to `__ubsan_handle_type_mismatch_v1_abort'
/home/openssl/run-checker/enable-ubsan/../openssl/crypto/sha/sha256.c:225: 
undefined reference to `__ubsan_handle_out_of_bounds_abort'
/home/openssl/run-checker/enable-ubsan/../openssl/crypto/sha/sha256.c:225: 
undefined reference to `__ubsan_handle_pointer_overflow_abort'
/home/openssl/run-checker/enable-ubsan/../openssl/crypto/sha/sha256.c:225: 
undefined reference to `__ubsan_handle_type_mismatch_v1_abort'
/home/openssl/run-checker/enable-ubsan/../openssl/crypto/sha/sha256.c:226: 
undefined reference to `__ubsan_handle_type_mismatch_v1_abort'
/home/openssl/run-checker/enable-ubsan/../openssl/crypto/sha/sha256.c:226: 
undefined reference to `__ubsan_handle_out_of_bounds_abort'
/home/openssl/run-checker/enable-ubsan/../openssl/crypto/sha/sha256.c:226: 
undefined reference to `__ubsan_handle_pointer_overflow_abort'
/home/openssl/run-checker/enable-ubsan/../openssl/crypto/sha/

Still Failing: openssl/openssl#24755 (master - f2dbb71)

2019-04-15 Thread Travis CI
Build Update for openssl/openssl
-

Build: #24755
Status: Still Failing

Duration: 25 mins and 12 secs
Commit: f2dbb71 (master)
Author: Richard Levitte
Message: providers/common/digests/sha2.c: forward declare all dispatched 
functions

Forward declare the dispatched functions using typedefs from
core_numbers.h.  This will ensure that they have correct signatures.

Reviewed-by: Paul Dale 
(Merged from https://github.com/openssl/openssl/pull/8747)

View the changeset: 
https://github.com/openssl/openssl/compare/15972296af6b...f2dbb71cb6bf

View the full build log and details: 
https://travis-ci.org/openssl/openssl/builds/520185218?utm_medium=notification&utm_source=email

--

You can unsubscribe from build emails from the openssl/openssl repository going 
to 
https://travis-ci.org/account/preferences/unsubscribe?repository=5849220&utm_medium=notification&utm_source=email.
Or unsubscribe from *all* email updating your settings at 
https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notification&utm_source=email.
Or configure specific recipients for build notifications in your .travis.yml 
file. See https://docs.travis-ci.com/user/notifications.



[openssl] master update

2019-04-15 Thread Richard Levitte
The branch master has been updated
   via  f2dbb71cb6bf6cd570f96e7663a22dd87854f08b (commit)
   via  0ad50b4dee36d4b576473ccbf744284d66fbffd6 (commit)
  from  15972296af6b98ae495ada9d4695f2a0e71f891c (commit)


- Log -
commit f2dbb71cb6bf6cd570f96e7663a22dd87854f08b
Author: Richard Levitte 
Date:   Mon Apr 15 09:40:22 2019 +0200

providers/common/digests/sha2.c: forward declare all dispatched functions

Forward declare the dispatched functions using typedefs from
core_numbers.h.  This will ensure that they have correct signatures.

Reviewed-by: Paul Dale 
(Merged from https://github.com/openssl/openssl/pull/8747)

commit 0ad50b4dee36d4b576473ccbf744284d66fbffd6
Author: Richard Levitte 
Date:   Mon Apr 15 09:37:51 2019 +0200

Providers: for the digest_final operation, pass a output buffer size

This allows the provider digest_final operation to check that it
doesn't over-run the output buffer.

The EVP_DigestFinal_ex function doesn't take that same parameter, so
it will have to assume that the user provided a properly sized buffer,
but this leaves better room for future enhancements of the public API.

Reviewed-by: Paul Dale 
(Merged from https://github.com/openssl/openssl/pull/8747)

---

Summary of changes:
 crypto/evp/digest.c |  7 ---
 include/openssl/core_numbers.h  |  4 ++--
 providers/common/digests/sha2.c | 24 +---
 3 files changed, 27 insertions(+), 8 deletions(-)

diff --git a/crypto/evp/digest.c b/crypto/evp/digest.c
index 527c5d6..e4787e6 100644
--- a/crypto/evp/digest.c
+++ b/crypto/evp/digest.c
@@ -295,6 +295,7 @@ int EVP_DigestFinal_ex(EVP_MD_CTX *ctx, unsigned char *md, 
unsigned int *isize)
 {
 int ret;
 size_t size = 0;
+size_t mdsize = EVP_MD_size(ctx->digest);
 
 if (ctx->digest == NULL || ctx->digest->prov == NULL)
 goto legacy;
@@ -304,7 +305,7 @@ int EVP_DigestFinal_ex(EVP_MD_CTX *ctx, unsigned char *md, 
unsigned int *isize)
 return 0;
 }
 
-ret = ctx->digest->dfinal(ctx->provctx, md, &size);
+ret = ctx->digest->dfinal(ctx->provctx, md, &size, mdsize);
 
 if (isize != NULL) {
 if (size <= UINT_MAX) {
@@ -321,10 +322,10 @@ int EVP_DigestFinal_ex(EVP_MD_CTX *ctx, unsigned char 
*md, unsigned int *isize)
 
 /* TODO(3.0): Remove legacy code below */
  legacy:
-OPENSSL_assert(ctx->digest->md_size <= EVP_MAX_MD_SIZE);
+OPENSSL_assert(mdsize <= EVP_MAX_MD_SIZE);
 ret = ctx->digest->final(ctx, md);
 if (isize != NULL)
-*isize = ctx->digest->md_size;
+*isize = mdsize;
 if (ctx->digest->cleanup) {
 ctx->digest->cleanup(ctx);
 EVP_MD_CTX_set_flags(ctx, EVP_MD_CTX_FLAG_CLEANED);
diff --git a/include/openssl/core_numbers.h b/include/openssl/core_numbers.h
index 1e53627..2054381 100644
--- a/include/openssl/core_numbers.h
+++ b/include/openssl/core_numbers.h
@@ -91,10 +91,10 @@ OSSL_CORE_MAKE_FUNC(int, OP_digest_init, (void *vctx))
 OSSL_CORE_MAKE_FUNC(int, OP_digest_update,
 (void *, const unsigned char *in, size_t inl))
 OSSL_CORE_MAKE_FUNC(int, OP_digest_final,
-(void *, unsigned char *out, size_t *outl))
+(void *, unsigned char *out, size_t *outl, size_t outsz))
 OSSL_CORE_MAKE_FUNC(int, OP_digest_digest,
 (const unsigned char *in, size_t inl, unsigned char *out,
- size_t *out_l))
+ size_t *out_l, size_t outsz))
 OSSL_CORE_MAKE_FUNC(void, OP_digest_cleanctx, (void *vctx))
 OSSL_CORE_MAKE_FUNC(void, OP_digest_freectx, (void *vctx))
 OSSL_CORE_MAKE_FUNC(void *, OP_digest_dupctx, (void *vctx))
diff --git a/providers/common/digests/sha2.c b/providers/common/digests/sha2.c
index 4332e98..3698046 100644
--- a/providers/common/digests/sha2.c
+++ b/providers/common/digests/sha2.c
@@ -11,10 +11,28 @@
 #include 
 #include 
 
-static int sha256_final(void *ctx, unsigned char *md, size_t *size)
+/*
+ * Forward declaration of everything implemented here.  This is not strictly
+ * necessary for the compiler, but provides an assurance that the signatures
+ * of the functions in the dispatch table are correct.
+ */
+static OSSL_OP_digest_newctx_fn sha256_newctx;
+#if 0   /* Not defined here */
+static OSSL_OP_digest_init_fn sha256_init;
+static OSSL_OP_digest_update_fn sha256_update;
+#endif
+static OSSL_OP_digest_final_fn sha256_final;
+static OSSL_OP_digest_freectx_fn sha256_freectx;
+static OSSL_OP_digest_dupctx_fn sha256_dupctx;
+static OSSL_OP_digest_size_fn sha256_size;
+static OSSL_OP_digest_block_size_fn sha256_size;
+
+static int sha256_final(void *ctx,
+unsigned char *md, size_t *mdl, size_t mdsz)
 {
-if (SHA256_Final(md, ctx)) {
-*size = SHA256_DIGEST_LENGTH;
+