Coverity Scan: Analysis completed for openssl/openssl

2022-08-04 Thread scan-admin


Your request for analysis of openssl/openssl has been completed 
successfully.
The results are available at 
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yoN-2BQSVjTtaSz8wS4wOr7HlekBtV1P4YRtWclMVkCdvAA-3D-3DSwkq_MulOTlHne1IxTRELXXnGni8d68xSVF-2BUCe3a7Ux-2BjeF5eMdOp1sZAQ1TvPGr5e369CfvTiL9NY0h-2BlKNcG7mI8ZnK11FL3bmora2CbeXbo-2BOw02djpo9ujzjK8xvWp8PWTC0WGipUQrcqYrGpQJIrgoxlpmx3fNNVY0rk8H-2FRurO5i2Xogl7eA3L8ITFN5uwCYh9DUOguZJHVfkrvVs7-2Bz97MYGmvU-2Bt-2FTacYNa-2F5fw-3D

Build ID: 471719

Analysis Summary:
   New defects found: 0
   Defects eliminated: 0



[openssl/openssl] 08d420: providers: Set the size of EC signature on s390.

2022-08-04 Thread openssl-machine
  Branch: refs/heads/openssl-3.0
  Home:   https://github.com/openssl/openssl
  Commit: 08d420dd8edb9b6b5a0616171b30b5a53beb630b
  
https://github.com/openssl/openssl/commit/08d420dd8edb9b6b5a0616171b30b5a53beb630b
  Author: Sebastian Andrzej Siewior 
  Date:   2022-08-04 (Thu, 04 Aug 2022)

  Changed paths:
M providers/implementations/signature/eddsa_sig.c

  Log Message:
  ---
  providers: Set the size of EC signature on s390.

The s390x provides its custom implementation for the creation of the
ed448 and ed25519 signatures. Unfortunately it does not set the size.
Users that rely of this return parameter end up with wrong values and
will compare wrong sizes of signature.

Set the proper size of the returned signature on success. Set an error
if the signing operation fails.

Fixes: #18912
Signed-off-by: Sebastian Andrzej Siewior 

Reviewed-by: Matt Caswell 
Reviewed-by: Todd Short 
(Merged from https://github.com/openssl/openssl/pull/18928)

(cherry picked from commit bbedc052973b1c2fab7d7fb891d02aea393ff579)


  Commit: b3f53a2f6fa6ed2ccab0423aadc753fbb3d70878
  
https://github.com/openssl/openssl/commit/b3f53a2f6fa6ed2ccab0423aadc753fbb3d70878
  Author: Sebastian Andrzej Siewior 
  Date:   2022-08-04 (Thu, 04 Aug 2022)

  Changed paths:
M test/evp_test.c

  Log Message:
  ---
  test/evp_test: Test if EVP_DigestSign() set signature's length.

Increase the signature's length, that is passed to EVP_DigestSign(). The
implementation should set this parameter back to the actual length, that
has been written.

This (oneshot_digestsign_test_run()) fails for the ed25519/ ed448
implementation of s390 prio the fix. The change in digestsign_test_run()
follows the same pattern and is for collecting bonus points.

Signed-off-by: Sebastian Andrzej Siewior 

Reviewed-by: Matt Caswell 
Reviewed-by: Todd Short 
(Merged from https://github.com/openssl/openssl/pull/18928)

(cherry picked from commit fc5888ccb60f33b366972299f30b976c4dc12162)


Compare: https://github.com/openssl/openssl/compare/c69410a78666...b3f53a2f6fa6


[openssl/openssl] bbedc0: providers: Set the size of EC signature on s390.

2022-08-04 Thread openssl-machine
  Branch: refs/heads/master
  Home:   https://github.com/openssl/openssl
  Commit: bbedc052973b1c2fab7d7fb891d02aea393ff579
  
https://github.com/openssl/openssl/commit/bbedc052973b1c2fab7d7fb891d02aea393ff579
  Author: Sebastian Andrzej Siewior 
  Date:   2022-08-04 (Thu, 04 Aug 2022)

  Changed paths:
M providers/implementations/signature/eddsa_sig.c

  Log Message:
  ---
  providers: Set the size of EC signature on s390.

The s390x provides its custom implementation for the creation of the
ed448 and ed25519 signatures. Unfortunately it does not set the size.
Users that rely of this return parameter end up with wrong values and
will compare wrong sizes of signature.

Set the proper size of the returned signature on success. Set an error
if the signing operation fails.

Fixes: #18912
Signed-off-by: Sebastian Andrzej Siewior 

Reviewed-by: Matt Caswell 
Reviewed-by: Todd Short 
(Merged from https://github.com/openssl/openssl/pull/18928)


  Commit: fc5888ccb60f33b366972299f30b976c4dc12162
  
https://github.com/openssl/openssl/commit/fc5888ccb60f33b366972299f30b976c4dc12162
  Author: Sebastian Andrzej Siewior 
  Date:   2022-08-04 (Thu, 04 Aug 2022)

  Changed paths:
M test/evp_test.c

  Log Message:
  ---
  test/evp_test: Test if EVP_DigestSign() set signature's length.

Increase the signature's length, that is passed to EVP_DigestSign(). The
implementation should set this parameter back to the actual length, that
has been written.

This (oneshot_digestsign_test_run()) fails for the ed25519/ ed448
implementation of s390 prio the fix. The change in digestsign_test_run()
follows the same pattern and is for collecting bonus points.

Signed-off-by: Sebastian Andrzej Siewior 

Reviewed-by: Matt Caswell 
Reviewed-by: Todd Short 
(Merged from https://github.com/openssl/openssl/pull/18928)


Compare: https://github.com/openssl/openssl/compare/2bd8190aace8...fc5888ccb60f


[openssl/openssl] 2bd819: Change name of parameter in documentation from sig...

2022-08-04 Thread Kurt Roeckx
  Branch: refs/heads/master
  Home:   https://github.com/openssl/openssl
  Commit: 2bd8190aace8109a06aff495a3e20c863ef48653
  
https://github.com/openssl/openssl/commit/2bd8190aace8109a06aff495a3e20c863ef48653
  Author: Kurt Roeckx 
  Date:   2022-08-04 (Thu, 04 Aug 2022)

  Changed paths:
M doc/man3/EVP_DigestSignInit.pod
M doc/man3/EVP_DigestVerifyInit.pod
M doc/man7/provider-signature.pod

  Log Message:
  ---
  Change name of parameter in documentation from sigret to sig

The rest of the documentation talks about sig, not sigret

Reviewed-by: Matt Caswell 
Reviewed-by: Todd Short 
Reviewed-by: Hugo Landau 
(Merged from https://github.com/openssl/openssl/pull/18943)




[openssl/openssl] c69410: Properly document deprecation of DH_new() and rela...

2022-08-04 Thread Tomáš Mráz
  Branch: refs/heads/openssl-3.0
  Home:   https://github.com/openssl/openssl
  Commit: c69410a78666853454fafca071dea49fb4a4c515
  
https://github.com/openssl/openssl/commit/c69410a78666853454fafca071dea49fb4a4c515
  Author: Tomas Mraz 
  Date:   2022-08-04 (Thu, 04 Aug 2022)

  Changed paths:
M doc/man3/DH_new.pod
M doc/man3/DH_new_by_nid.pod

  Log Message:
  ---
  Properly document deprecation of DH_new() and related functions

Reviewed-by: Matt Caswell 
Reviewed-by: Todd Short 
Reviewed-by: Hugo Landau 
(Merged from https://github.com/openssl/openssl/pull/18925)

(cherry picked from commit 65b41ab31917e3bb25920c4b27017786db668850)




[openssl/openssl] 65b41a: Properly document deprecation of DH_new() and rela...

2022-08-04 Thread Tomáš Mráz
  Branch: refs/heads/master
  Home:   https://github.com/openssl/openssl
  Commit: 65b41ab31917e3bb25920c4b27017786db668850
  
https://github.com/openssl/openssl/commit/65b41ab31917e3bb25920c4b27017786db668850
  Author: Tomas Mraz 
  Date:   2022-08-04 (Thu, 04 Aug 2022)

  Changed paths:
M doc/man3/DH_new.pod
M doc/man3/DH_new_by_nid.pod

  Log Message:
  ---
  Properly document deprecation of DH_new() and related functions

Reviewed-by: Matt Caswell 
Reviewed-by: Todd Short 
Reviewed-by: Hugo Landau 
(Merged from https://github.com/openssl/openssl/pull/18925)




[openssl/openssl] 143d7d: Fix EC_KEY_set_private_key() priv_key regression

2022-08-04 Thread Roberto Hueso
  Branch: refs/heads/OpenSSL_1_1_1-stable
  Home:   https://github.com/openssl/openssl
  Commit: 143d7d4c791df8b9051356be51d9f77bc241fe4c
  
https://github.com/openssl/openssl/commit/143d7d4c791df8b9051356be51d9f77bc241fe4c
  Author: Roberto Hueso Gomez 
  Date:   2022-08-04 (Thu, 04 Aug 2022)

  Changed paths:
M crypto/ec/ec_key.c

  Log Message:
  ---
  Fix EC_KEY_set_private_key() priv_key regression

This allows to set EC_KEY's private key to NULL and fixes regression
issue following OTC guideline in
https://github.com/openssl/openssl/issues/18744#issuecomment-1195175696

Fixes #18744.

Reviewed-by: Nicola Tuveri 
Reviewed-by: Matt Caswell 
(Merged from https://github.com/openssl/openssl/pull/18874)


  Commit: 1c2f52bed3ebee6222cf078278074c72717df4ec
  
https://github.com/openssl/openssl/commit/1c2f52bed3ebee6222cf078278074c72717df4ec
  Author: Roberto Hueso Gomez 
  Date:   2022-08-04 (Thu, 04 Aug 2022)

  Changed paths:
M test/ec_internal_test.c

  Log Message:
  ---
  Add test for EC_KEY_set_private_key()

This tests the behavior and API of the EC_KEY_set_private_key function.
It tests compliance with legacy features related to NULL private keys
too.

Reviewed-by: Nicola Tuveri 
Reviewed-by: Matt Caswell 
(Merged from https://github.com/openssl/openssl/pull/18874)


  Commit: 4648839300475055e3d3ec6859704e80785402e2
  
https://github.com/openssl/openssl/commit/4648839300475055e3d3ec6859704e80785402e2
  Author: Roberto Hueso Gomez 
  Date:   2022-08-04 (Thu, 04 Aug 2022)

  Changed paths:
M doc/man3/EC_KEY_new.pod

  Log Message:
  ---
  Fix EC_KEY_set_private_key() NULL priv_key docs

Updates the docs to describe EC_KEY_set_private_key() function behavior
when a NULL priv_key argument is passed.

Reviewed-by: Nicola Tuveri 
Reviewed-by: Matt Caswell 
(Merged from https://github.com/openssl/openssl/pull/18874)


Compare: https://github.com/openssl/openssl/compare/0b755cdfb52f...464883930047


[openssl/openssl] f76cf4: Fix EC_KEY_set_private_key() priv_key regression

2022-08-04 Thread Roberto Hueso
  Branch: refs/heads/openssl-3.0
  Home:   https://github.com/openssl/openssl
  Commit: f76cf4d9885e0d39aa1d200ba851173939fd0bb6
  
https://github.com/openssl/openssl/commit/f76cf4d9885e0d39aa1d200ba851173939fd0bb6
  Author: Roberto Hueso Gomez 
  Date:   2022-08-04 (Thu, 04 Aug 2022)

  Changed paths:
M crypto/ec/ec_key.c

  Log Message:
  ---
  Fix EC_KEY_set_private_key() priv_key regression

This allows to set EC_KEY's private key to NULL and fixes regression
issue following OTC guideline in
https://github.com/openssl/openssl/issues/18744#issuecomment-1195175696

Fixes #18744.

Reviewed-by: Nicola Tuveri 
Reviewed-by: Todd Short 
(Merged from https://github.com/openssl/openssl/pull/18941)


  Commit: 66627cdfc2450a3604ca23d8a4c9b02de2132b44
  
https://github.com/openssl/openssl/commit/66627cdfc2450a3604ca23d8a4c9b02de2132b44
  Author: Roberto Hueso Gomez 
  Date:   2022-08-04 (Thu, 04 Aug 2022)

  Changed paths:
M test/ec_internal_test.c

  Log Message:
  ---
  Add test for EC_KEY_set_private_key()

This tests the behavior and API of the EC_KEY_set_private_key function.
It tests compliance with legacy features related to NULL private keys
too.

Reviewed-by: Nicola Tuveri 
Reviewed-by: Todd Short 
(Merged from https://github.com/openssl/openssl/pull/18941)


  Commit: c682dfdbdf503e776a9afadb1e6f9de47b729014
  
https://github.com/openssl/openssl/commit/c682dfdbdf503e776a9afadb1e6f9de47b729014
  Author: Roberto Hueso Gomez 
  Date:   2022-08-04 (Thu, 04 Aug 2022)

  Changed paths:
M doc/man3/EC_KEY_new.pod

  Log Message:
  ---
  Fix EC_KEY_set_private_key() NULL priv_key docs

Updates the docs to describe EC_KEY_set_private_key() function behavior
when a NULL priv_key argument is passed.

Reviewed-by: Nicola Tuveri 
Reviewed-by: Todd Short 
(Merged from https://github.com/openssl/openssl/pull/18941)


Compare: https://github.com/openssl/openssl/compare/b0501275ef56...c682dfdbdf50


[openssl/openssl] b304b3: Fix EC_KEY_set_private_key() priv_key regression

2022-08-04 Thread Roberto Hueso
  Branch: refs/heads/master
  Home:   https://github.com/openssl/openssl
  Commit: b304b3e8f7397c3e949e3664e6ceaee5dc811b32
  
https://github.com/openssl/openssl/commit/b304b3e8f7397c3e949e3664e6ceaee5dc811b32
  Author: Roberto Hueso Gomez 
  Date:   2022-08-04 (Thu, 04 Aug 2022)

  Changed paths:
M crypto/ec/ec_key.c

  Log Message:
  ---
  Fix EC_KEY_set_private_key() priv_key regression

This allows to set EC_KEY's private key to NULL and fixes regression
issue following OTC guideline in
https://github.com/openssl/openssl/issues/18744#issuecomment-1195175696

Fixes #18744.

Reviewed-by: Nicola Tuveri 
Reviewed-by: Todd Short 
(Merged from https://github.com/openssl/openssl/pull/18942)


  Commit: d93f154d5a524e6ed71ff276447de7fe11d85949
  
https://github.com/openssl/openssl/commit/d93f154d5a524e6ed71ff276447de7fe11d85949
  Author: Roberto Hueso Gomez 
  Date:   2022-08-04 (Thu, 04 Aug 2022)

  Changed paths:
M test/ec_internal_test.c

  Log Message:
  ---
  Add test for EC_KEY_set_private_key()

This tests the behavior and API of the EC_KEY_set_private_key function.
It tests compliance with legacy features related to NULL private keys
too.

Reviewed-by: Nicola Tuveri 
Reviewed-by: Todd Short 
(Merged from https://github.com/openssl/openssl/pull/18942)


  Commit: fae06b5779bd3e2e1af22b370f32e60efb59fcd6
  
https://github.com/openssl/openssl/commit/fae06b5779bd3e2e1af22b370f32e60efb59fcd6
  Author: Roberto Hueso Gomez 
  Date:   2022-08-04 (Thu, 04 Aug 2022)

  Changed paths:
M doc/man3/EC_KEY_new.pod

  Log Message:
  ---
  Fix EC_KEY_set_private_key() NULL priv_key docs

Updates the docs to describe EC_KEY_set_private_key() function behavior
when a NULL priv_key argument is passed.

Reviewed-by: Nicola Tuveri 
Reviewed-by: Todd Short 
(Merged from https://github.com/openssl/openssl/pull/18942)


Compare: https://github.com/openssl/openssl/compare/0a90577e717f...fae06b5779bd