Coverity Scan: Analysis completed for openssl/openssl

2022-09-13 Thread scan-admin


Your request for analysis of openssl/openssl has been completed 
successfully.
The results are available at 
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yoN-2BQSVjTtaSz8wS4wOr7HlekBtV1P4YRtWclMVkCdvAA-3D-3DzYUV_MulOTlHne1IxTRELXXnGni8d68xSVF-2BUCe3a7Ux-2BjeH4d9IZ8hAZrRzdrDUtQYeG9hah7Jg7DwJHjsuyysY-2BVSbh9z9wkNjMKd1dGysCxpqut3ciUIoiiLYgp0glPH2-2FizEY3m4WzRG0sVQECv8xmaCyv3XA4YKG4DL1KcwZ2fzFwYqUcQ3hfDJlUpMImlanvIsG3n4s6dygcKsOGVsZEcb19i0TeKYkuU05QFYn2pk-3D

Build ID: 479618

Analysis Summary:
   New defects found: 0
   Defects eliminated: 1



[openssl/openssl] 45e7ef: QUIC QRL: Fix bug in Handshake packet processing

2022-09-13 Thread Hugo Landau
  Branch: refs/heads/master
  Home:   https://github.com/openssl/openssl
  Commit: 45e7ef5fe34b3f519f1454c47dc08aa4563e4247
  
https://github.com/openssl/openssl/commit/45e7ef5fe34b3f519f1454c47dc08aa4563e4247
  Author: Hugo Landau 
  Date:   2022-09-13 (Tue, 13 Sep 2022)

  Changed paths:
M ssl/quic/quic_record_rx.c

  Log Message:
  ---
  QUIC QRL: Fix bug in Handshake packet processing

We automatically dropped Initial keys when receiving a Handshake packet,
but did this regardless of whether the packet was successfully decrypted
and authenticated. Per the RFC, we should only drop Initial keys when
successfully processing a Handshake packet.

Reviewed-by: Matt Caswell 
Reviewed-by: Tomas Mraz 
(Merged from https://github.com/openssl/openssl/pull/19176)




[openssl/openssl] 9ab6b6: Fix AES-GCM on Power 8 CPUs

2022-09-13 Thread Tomáš Mráz
  Branch: refs/heads/master
  Home:   https://github.com/openssl/openssl
  Commit: 9ab6b64ac856157a31a54c0d12207c2338bfa8e2
  
https://github.com/openssl/openssl/commit/9ab6b64ac856157a31a54c0d12207c2338bfa8e2
  Author: Tomas Mraz 
  Date:   2022-09-13 (Tue, 13 Sep 2022)

  Changed paths:
M include/crypto/aes_platform.h
M providers/implementations/ciphers/cipher_aes_gcm_hw_ppc.inc

  Log Message:
  ---
  Fix AES-GCM on Power 8 CPUs

Properly fallback to the default implementation on CPUs
missing necessary instructions.

Fixes #19163

Reviewed-by: Dmitry Belyavskiy 
Reviewed-by: Paul Dale 
(Merged from https://github.com/openssl/openssl/pull/19182)




[openssl/openssl] fabce8: design: TX Packetiser

2022-09-13 Thread Pauli
  Branch: refs/heads/master
  Home:   https://github.com/openssl/openssl
  Commit: fabce8090c3ba49527d434a4621c660eedad2aaa
  
https://github.com/openssl/openssl/commit/fabce8090c3ba49527d434a4621c660eedad2aaa
  Author: Pauli 
  Date:   2022-09-13 (Tue, 13 Sep 2022)

  Changed paths:
A doc/designs/quic-design/tx-packetiser.md

  Log Message:
  ---
  design: TX Packetiser

Reviewed-by: Tomas Mraz 
Reviewed-by: Matt Caswell 
(Merged from https://github.com/openssl/openssl/pull/18570)




[openssl/openssl] 364c3b: time: add some additional utilities and document e...

2022-09-13 Thread Pauli
  Branch: refs/heads/master
  Home:   https://github.com/openssl/openssl
  Commit: 364c3b7b1ac3172dbe2108be23ae215b86ef8e08
  
https://github.com/openssl/openssl/commit/364c3b7b1ac3172dbe2108be23ae215b86ef8e08
  Author: Pauli 
  Date:   2022-09-13 (Tue, 13 Sep 2022)

  Changed paths:
M doc/internal/man3/OSSL_TIME.pod
M include/internal/time.h
M ssl/time.c

  Log Message:
  ---
  time: add some additional utilities and document everything

Some of the recently added functions were not documents.  This has been 
addressed.
Also added utility functions for conversions between time_t, seconds and struct 
timeval
to/from OSSL_TIME.

Reviewed-by: Todd Short 
Reviewed-by: Richard Levitte 
Reviewed-by: Matt Caswell 
(Merged from https://github.com/openssl/openssl/pull/19082)


  Commit: f0131dc04a39afcb1629f5bec2814ef3a4925bbf
  
https://github.com/openssl/openssl/commit/f0131dc04a39afcb1629f5bec2814ef3a4925bbf
  Author: Pauli 
  Date:   2022-09-13 (Tue, 13 Sep 2022)

  Changed paths:
M ssl/d1_lib.c
M ssl/quic/quic_impl.c
M ssl/quic/quic_local.h
M ssl/s3_lib.c
M ssl/ssl_asn1.c
M ssl/ssl_lib.c
M ssl/ssl_local.h
M ssl/ssl_sess.c
M ssl/ssl_txt.c
M ssl/statem/extensions_clnt.c
M ssl/statem/extensions_srvr.c
M ssl/statem/statem_clnt.c
M ssl/statem/statem_srvr.c
M ssl/t1_lib.c

  Log Message:
  ---
  ssl: modify libssl so that it uses OSSL_TIME

This is instead of time_t and struct timeval.  Some public APIs mandate a
presence of these two types, but they are converted to OSSL_TIME internally.

Reviewed-by: Todd Short 
Reviewed-by: Richard Levitte 
Reviewed-by: Matt Caswell 
(Merged from https://github.com/openssl/openssl/pull/19082)


  Commit: 4fc04c71acf180dad0b4418d12b3ed31ba46179a
  
https://github.com/openssl/openssl/commit/4fc04c71acf180dad0b4418d12b3ed31ba46179a
  Author: Pauli 
  Date:   2022-09-13 (Tue, 13 Sep 2022)

  Changed paths:
M ssl/quic/quic_ackm.c
M ssl/quic/quic_statm.c

  Log Message:
  ---
  Avoid struct timeval in QUIC code

Reviewed-by: Todd Short 
Reviewed-by: Richard Levitte 
Reviewed-by: Matt Caswell 
(Merged from https://github.com/openssl/openssl/pull/19082)


  Commit: 02d0f87a8ba143eaeaee3334a2f63543b10148a9
  
https://github.com/openssl/openssl/commit/02d0f87a8ba143eaeaee3334a2f63543b10148a9
  Author: Pauli 
  Date:   2022-09-13 (Tue, 13 Sep 2022)

  Changed paths:
M crypto/build.info
A crypto/time.c
M ssl/build.info
R ssl/time.c

  Log Message:
  ---
  time: move OSSL_TIME to libcrypto

Keep building it for libssl without exposing any symbols.

Reviewed-by: Todd Short 
Reviewed-by: Richard Levitte 
Reviewed-by: Matt Caswell 
(Merged from https://github.com/openssl/openssl/pull/19082)


  Commit: 5d1bb4fc47582b06dd224a788bdfaaced60e72a0
  
https://github.com/openssl/openssl/commit/5d1bb4fc47582b06dd224a788bdfaaced60e72a0
  Author: Pauli 
  Date:   2022-09-13 (Tue, 13 Sep 2022)

  Changed paths:
M crypto/bio/bss_dgram.c
M crypto/ct/ct_policy.c
M crypto/ts/ts_rsp_sign.c
M include/internal/e_os.h

  Log Message:
  ---
  libcrypto: remove reliance on struct timeval

Reviewed-by: Todd Short 
Reviewed-by: Richard Levitte 
Reviewed-by: Matt Caswell 
(Merged from https://github.com/openssl/openssl/pull/19082)


  Commit: 0f4be8a14a2bcb8a92cf78d94d157152c0a03d88
  
https://github.com/openssl/openssl/commit/0f4be8a14a2bcb8a92cf78d94d157152c0a03d88
  Author: Pauli 
  Date:   2022-09-13 (Tue, 13 Sep 2022)

  Changed paths:
M include/internal/safe_math.h

  Log Message:
  ---
  Fix white space

Reviewed-by: Todd Short 
Reviewed-by: Richard Levitte 
Reviewed-by: Matt Caswell 
(Merged from https://github.com/openssl/openssl/pull/19082)


Compare: https://github.com/openssl/openssl/compare/ee68d2b95792...0f4be8a14a2b


[openssl/openssl] 800869: Revert (most of) "Makefile: Generate crypto object...

2022-09-13 Thread David von Oheimb
  Branch: refs/heads/master
  Home:   https://github.com/openssl/openssl
  Commit: 800869b84e027a63c1dd0c77cdb95407edf45734
  
https://github.com/openssl/openssl/commit/800869b84e027a63c1dd0c77cdb95407edf45734
  Author: Dr. David von Oheimb 
  Date:   2022-09-13 (Tue, 13 Sep 2022)

  Changed paths:
M Configurations/unix-Makefile.tmpl

  Log Message:
  ---
  Revert (most of) "Makefile: Generate crypto objects only as far as needed"

This reverts all adaptations by commit 89c39bd8f6528ad268c1c0d0c9e196ba4396941b
on Configurations/unix-Makefile.tmpl except for additions to .PHONY

Fixes #19087

Reviewed-by: Richard Levitte 
Reviewed-by: Tomas Mraz 
Reviewed-by: David von Oheimb 
(Merged from https://github.com/openssl/openssl/pull/19179)


  Commit: ee68d2b957923e2e4d1d76d7ad66e0e8b3674d71
  
https://github.com/openssl/openssl/commit/ee68d2b957923e2e4d1d76d7ad66e0e8b3674d71
  Author: Dr. David von Oheimb 
  Date:   2022-09-13 (Tue, 13 Sep 2022)

  Changed paths:
M apps/openssl-vms.cnf

  Log Message:
  ---
  apps/openssl-vms.cnf: reflect latest changes by 'make update'

Reviewed-by: Richard Levitte 
Reviewed-by: Tomas Mraz 
Reviewed-by: David von Oheimb 
(Merged from https://github.com/openssl/openssl/pull/19179)


Compare: https://github.com/openssl/openssl/compare/b1104a3a2dd4...ee68d2b95792


[openssl/openssl] b1104a: Checking __STDC_VERSION__ rather than __STRICT_ANSI__

2022-09-13 Thread Richard Levitte
  Branch: refs/heads/master
  Home:   https://github.com/openssl/openssl
  Commit: b1104a3a2dd4351af85cf48f677691a414ffc3a2
  
https://github.com/openssl/openssl/commit/b1104a3a2dd4351af85cf48f677691a414ffc3a2
  Author: Richard Levitte 
  Date:   2022-09-13 (Tue, 13 Sep 2022)

  Changed paths:
M apps/lib/log.c

  Log Message:
  ---
  Checking __STDC_VERSION__ rather than __STRICT_ANSI__

`__STRICT_ANSI__` is a gnuish flag macro that indicates if `-ansi`
was given on the command line.  To check the C version, it's better
to check the macro `__STDC_VERSION__`.

Reviewed-by: Hugo Landau 
Reviewed-by: Shane Lontis 
Reviewed-by: Tomas Mraz 
Reviewed-by: Todd Short 
(Merged from https://github.com/openssl/openssl/pull/19197)