Coverity Scan: Analysis completed for openssl/openssl
Your request for analysis of openssl/openssl has been completed successfully. The results are available at https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yoN-2BQSVjTtaSz8wS4wOr7HlekBtV1P4YRtWclMVkCdvAA-3D-3DXyGN_MulOTlHne1IxTRELXXnGni8d68xSVF-2BUCe3a7Ux-2BjeGyyo99ckibMaGkljpN-2FPUpVE9pVHm7uInSSbgWqcFbP0Y5Z8rjQdr7SYOeBm3iNKUaKmXKD7GNQI1r0pH5EAWuuNuA69CQHdoecE60pqCNkjawIFKQR9dqreAYbQpSxZ-2F0SVqtqgnbnBlRISqVotqYtItU2ar3XvhCKg7-2FIiV50MSeJSVsgNlu-2FlmlBoBtThM-3D Build ID: 488629 Analysis Summary: New defects found: 0 Defects eliminated: 0
[openssl/tools] 5c7aaa: ghmerge: support handling conflicts on --cherry-pick
Branch: refs/heads/master Home: https://github.com/openssl/tools Commit: 5c7aaae1ab46466d01d3c7b81b4c53e3cc56d45f https://github.com/openssl/tools/commit/5c7aaae1ab46466d01d3c7b81b4c53e3cc56d45f Author: Dr. David von Oheimb Date: 2022-10-21 (Fri, 21 Oct 2022) Changed paths: M review-tools/ghmerge Log Message: --- ghmerge: support handling conflicts on --cherry-pick Reviewed-by: Paul Dale Reviewed-by: Tomas Mraz (Merged from https://github.com/openssl/tools/pull/129)
[openssl/openssl] 367ee2: stack: Do not add error if pop/shift/value accesse...
Branch: refs/heads/openssl-3.0 Home: https://github.com/openssl/openssl Commit: 367ee2152e019d72f63537ae898eda311bc9219a https://github.com/openssl/openssl/commit/367ee2152e019d72f63537ae898eda311bc9219a Author: Tomas Mraz Date: 2022-10-21 (Fri, 21 Oct 2022) Changed paths: M crypto/conf/conf_def.c M crypto/stack/stack.c M ssl/ssl_lib.c M ssl/statem/statem_srvr.c M test/helpers/ssltestlib.c Log Message: --- stack: Do not add error if pop/shift/value accesses outside of the stack This partially reverts commit 30eba7f35983a917f1007bce45040c0af3442e42. This is legitimate use of the stack functions and no error should be reported apart from the NULL return value. Fixes #19389 Reviewed-by: Todd Short Reviewed-by: Paul Dale (Merged from https://github.com/openssl/openssl/pull/19400) (cherry picked from commit a8086e6bfc37355626393751a94bc5c92df7e9d3) Commit: b20d44eac8f0af4ecd7038f4c6b16c55eb794d0f https://github.com/openssl/openssl/commit/b20d44eac8f0af4ecd7038f4c6b16c55eb794d0f Author: Tomas Mraz Date: 2022-10-21 (Fri, 21 Oct 2022) Changed paths: M doc/man3/DEFINE_STACK_OF.pod Log Message: --- Document the stack functions that are forgiving I.e., those that can be called with NULL stack parameter or invalid index. Reviewed-by: Todd Short Reviewed-by: Paul Dale (Merged from https://github.com/openssl/openssl/pull/19400) (cherry picked from commit 0778364f8ec1f9702e62e6298aaa212ec40b6111) Commit: 6c366417f74e0c74256c102601efdced2b62829b https://github.com/openssl/openssl/commit/6c366417f74e0c74256c102601efdced2b62829b Author: Tomas Mraz Date: 2022-10-21 (Fri, 21 Oct 2022) Changed paths: M crypto/stack/stack.c Log Message: --- Errors raised from OPENSSL_sk_set should have ERR_LIB_CRYPTO Reviewed-by: Todd Short Reviewed-by: Paul Dale (Merged from https://github.com/openssl/openssl/pull/19400) (cherry picked from commit 3a09dfb4f9aace93d2c20d6d1b4968cc583884d6) Compare: https://github.com/openssl/openssl/compare/d8f0b0fc1fe5...6c366417f74e
[openssl/openssl] a8086e: stack: Do not add error if pop/shift/value accesse...
Branch: refs/heads/master Home: https://github.com/openssl/openssl Commit: a8086e6bfc37355626393751a94bc5c92df7e9d3 https://github.com/openssl/openssl/commit/a8086e6bfc37355626393751a94bc5c92df7e9d3 Author: Tomas Mraz Date: 2022-10-21 (Fri, 21 Oct 2022) Changed paths: M crypto/conf/conf_def.c M crypto/stack/stack.c M ssl/ssl_lib.c M ssl/statem/statem_srvr.c M test/helpers/ssltestlib.c Log Message: --- stack: Do not add error if pop/shift/value accesses outside of the stack This partially reverts commit 30eba7f35983a917f1007bce45040c0af3442e42. This is legitimate use of the stack functions and no error should be reported apart from the NULL return value. Fixes #19389 Reviewed-by: Todd Short Reviewed-by: Paul Dale (Merged from https://github.com/openssl/openssl/pull/19400) Commit: 0778364f8ec1f9702e62e6298aaa212ec40b6111 https://github.com/openssl/openssl/commit/0778364f8ec1f9702e62e6298aaa212ec40b6111 Author: Tomas Mraz Date: 2022-10-21 (Fri, 21 Oct 2022) Changed paths: M doc/man3/DEFINE_STACK_OF.pod Log Message: --- Document the stack functions that are forgiving I.e., those that can be called with NULL stack parameter or invalid index. Reviewed-by: Todd Short Reviewed-by: Paul Dale (Merged from https://github.com/openssl/openssl/pull/19400) Commit: 3a09dfb4f9aace93d2c20d6d1b4968cc583884d6 https://github.com/openssl/openssl/commit/3a09dfb4f9aace93d2c20d6d1b4968cc583884d6 Author: Tomas Mraz Date: 2022-10-21 (Fri, 21 Oct 2022) Changed paths: M crypto/stack/stack.c Log Message: --- Errors raised from OPENSSL_sk_set should have ERR_LIB_CRYPTO Reviewed-by: Todd Short Reviewed-by: Paul Dale (Merged from https://github.com/openssl/openssl/pull/19400) Compare: https://github.com/openssl/openssl/compare/fba324204f3b...3a09dfb4f9aa
[openssl/openssl] d8f0b0: Fix trivial check_docs CI failure
Branch: refs/heads/openssl-3.0 Home: https://github.com/openssl/openssl Commit: d8f0b0fc1fe520939c0a2ae1aafd394afcde4e55 https://github.com/openssl/openssl/commit/d8f0b0fc1fe520939c0a2ae1aafd394afcde4e55 Author: Tomas Mraz Date: 2022-10-21 (Fri, 21 Oct 2022) Changed paths: M README-ENGINES.md Log Message: --- Fix trivial check_docs CI failure Reviewed-by: Todd Short Reviewed-by: Paul Dale (Merged from https://github.com/openssl/openssl/pull/19442)
[openssl/openssl] 0c9441: Add changes entry for RIPEMD160 in 3.0.7
Branch: refs/heads/openssl-3.0 Home: https://github.com/openssl/openssl Commit: 0c9441652bbf34dcb781a4a2ff9606dce140e5f6 https://github.com/openssl/openssl/commit/0c9441652bbf34dcb781a4a2ff9606dce140e5f6 Author: Tomas Mraz Date: 2022-10-21 (Fri, 21 Oct 2022) Changed paths: M CHANGES.md Log Message: --- Add changes entry for RIPEMD160 in 3.0.7 Reviewed-by: Todd Short Reviewed-by: Paul Dale (Merged from https://github.com/openssl/openssl/pull/19438) (cherry picked from commit b6553796190ad7401b89c6cd0499bae77b39d1a6)
[openssl/openssl] b65537: Add changes entry for RIPEMD160 in 3.0.7
Branch: refs/heads/master Home: https://github.com/openssl/openssl Commit: b6553796190ad7401b89c6cd0499bae77b39d1a6 https://github.com/openssl/openssl/commit/b6553796190ad7401b89c6cd0499bae77b39d1a6 Author: Tomas Mraz Date: 2022-10-21 (Fri, 21 Oct 2022) Changed paths: M CHANGES.md Log Message: --- Add changes entry for RIPEMD160 in 3.0.7 Reviewed-by: Todd Short Reviewed-by: Paul Dale (Merged from https://github.com/openssl/openssl/pull/19438) Commit: fba324204f3bdd8ba9e99d42db030aaf6482d896 https://github.com/openssl/openssl/commit/fba324204f3bdd8ba9e99d42db030aaf6482d896 Author: Tomas Mraz Date: 2022-10-21 (Fri, 21 Oct 2022) Changed paths: M CHANGES.md Log Message: --- Remove changes entry for RIPEMD160 in 3.2 It is already in 3.0.7. Reviewed-by: Todd Short Reviewed-by: Paul Dale (Merged from https://github.com/openssl/openssl/pull/19438) Compare: https://github.com/openssl/openssl/compare/a73bdc24e147...fba324204f3b
[openssl/openssl] 2561de: Replace BIO_free(bio_err) with BIO_free_all(bio_err)
Branch: refs/heads/openssl-3.0 Home: https://github.com/openssl/openssl Commit: 2561dea8c60571dd1dca185eed7d3d6a11828ea5 https://github.com/openssl/openssl/commit/2561dea8c60571dd1dca185eed7d3d6a11828ea5 Author: xkernel Date: 2022-10-21 (Fri, 21 Oct 2022) Changed paths: M apps/openssl.c Log Message: --- Replace BIO_free(bio_err) with BIO_free_all(bio_err) dup_bio_err() can return a BIO chain when 'OPENSSL_SYS_VMS' is defined. Reviewed-by: Matt Caswell Reviewed-by: Tomas Mraz (Merged from https://github.com/openssl/openssl/pull/19446) (cherry picked from commit a73bdc24e14760413a65d478d7c88356b4b95bb5)
[openssl/openssl] a73bdc: Replace BIO_free(bio_err) with BIO_free_all(bio_err)
Branch: refs/heads/master Home: https://github.com/openssl/openssl Commit: a73bdc24e14760413a65d478d7c88356b4b95bb5 https://github.com/openssl/openssl/commit/a73bdc24e14760413a65d478d7c88356b4b95bb5 Author: xkernel Date: 2022-10-21 (Fri, 21 Oct 2022) Changed paths: M apps/openssl.c Log Message: --- Replace BIO_free(bio_err) with BIO_free_all(bio_err) dup_bio_err() can return a BIO chain when 'OPENSSL_SYS_VMS' is defined. Reviewed-by: Matt Caswell Reviewed-by: Tomas Mraz (Merged from https://github.com/openssl/openssl/pull/19446)
[openssl/openssl] 75ecda: CI: add Clang 15
Branch: refs/heads/master Home: https://github.com/openssl/openssl Commit: 75ecda930e0a961f9605ce090af64d95c98ed161 https://github.com/openssl/openssl/commit/75ecda930e0a961f9605ce090af64d95c98ed161 Author: Sam James Date: 2022-10-21 (Fri, 21 Oct 2022) Changed paths: M .github/workflows/compiler-zoo.yml Log Message: --- CI: add Clang 15 We have to use the PPA provided by LLVM because Clang 15 isn't officially part of Ubuntu 22.04 (or any other Ubuntu release yet), see https://apt.llvm.org/ for details. Signed-off-by: Sam James Reviewed-by: Paul Dale Reviewed-by: Hugo Landau Reviewed-by: Tomas Mraz (Merged from https://github.com/openssl/openssl/pull/19450) Commit: 71bc497dc321adeb08e7541556dea019c81c9a87 https://github.com/openssl/openssl/commit/71bc497dc321adeb08e7541556dea019c81c9a87 Author: Sam James Date: 2022-10-21 (Fri, 21 Oct 2022) Changed paths: M crypto/pem/pem_lib.c Log Message: --- pem: fix -Wunused-but-set-variable The loop never uses the value of 'line'. Fixes this error with Clang 15: ``` crypto/pem/pem_lib.c:821:14: error: variable 'line' set but not used [-Werror,-Wunused-but-set-variable] int len, line, ret = 0, end = 0, prev_partial_line_read = 0, partial_line_read = 0; ^ 1 error generated. ``` Signed-off-by: Sam James Reviewed-by: Paul Dale Reviewed-by: Hugo Landau Reviewed-by: Tomas Mraz (Merged from https://github.com/openssl/openssl/pull/19450) Commit: f9e8e2c0ab73409862bb78a9285c1b72e0511750 https://github.com/openssl/openssl/commit/f9e8e2c0ab73409862bb78a9285c1b72e0511750 Author: Sam James Date: 2022-10-21 (Fri, 21 Oct 2022) Changed paths: M crypto/txt_db/txt_db.c Log Message: --- txt_db: fix -Wunused-but-set-variable The loop never uses the value of 'ln'. Fixes this error with Clang 15: ``` crypto/txt_db/txt_db.c:24:10: error: variable 'ln' set but not used [-Werror,-Wunused-but-set-variable] long ln = 0; ^ 1 error generated. ``` Signed-off-by: Sam James Reviewed-by: Paul Dale Reviewed-by: Hugo Landau Reviewed-by: Tomas Mraz (Merged from https://github.com/openssl/openssl/pull/19450) Commit: c71318668571b3680fe10035a1a350ff46e459af https://github.com/openssl/openssl/commit/c71318668571b3680fe10035a1a350ff46e459af Author: Sam James Date: 2022-10-21 (Fri, 21 Oct 2022) Changed paths: M crypto/x509/x_name.c Log Message: --- x509: fix -Wunused-but-set-variable The value of 'l' isn't ever actually used. Fixes this error with Clang 15: ``` crypto/x509/x_name.c:506:9: error: variable 'l' set but not used [-Werror,-Wunused-but-set-variable] int l, i; ^ 1 error generated. ``` Signed-off-by: Sam James Reviewed-by: Paul Dale Reviewed-by: Hugo Landau Reviewed-by: Tomas Mraz (Merged from https://github.com/openssl/openssl/pull/19450) Commit: 6a94c5849ea7d1f08d4fcaa9a6fc0a947e19da66 https://github.com/openssl/openssl/commit/6a94c5849ea7d1f08d4fcaa9a6fc0a947e19da66 Author: Sam James Date: 2022-10-21 (Fri, 21 Oct 2022) Changed paths: M test/testutil/driver.c Log Message: --- test: driver: fix -Wunused-but-set-variable The value of 'num_failed_inner' isn't ever used. Fixes this error with Clang 15: ``` test/testutil/driver.c:341:17: error: variable 'num_failed_inner' set but not used [-Werror,-Wunused-but-set-variable] int num_failed_inner = 0; ^ 1 error generated. ``` Signed-off-by: Sam James Reviewed-by: Paul Dale Reviewed-by: Hugo Landau Reviewed-by: Tomas Mraz (Merged from https://github.com/openssl/openssl/pull/19450) Compare: https://github.com/openssl/openssl/compare/bd1b396d...6a94c5849ea7
[openssl/openssl] bd1999: Add af_alg errors to the error queue
Branch: refs/heads/master Home: https://github.com/openssl/openssl Commit: bd1b396d03d39eab4a86c6402a970191c9e1 https://github.com/openssl/openssl/commit/bd1b396d03d39eab4a86c6402a970191c9e1 Author: ramin Date: 2022-10-21 (Fri, 21 Oct 2022) Changed paths: M engines/e_afalg.c M engines/e_afalg.txt M engines/e_afalg_err.c M engines/e_afalg_err.h Log Message: --- Add af_alg errors to the error queue If the kernel operation failed the EVP functions just returned without any error message. This commit adds them. Reviewed-by: Richard Levitte Reviewed-by: Tomas Mraz (Merged from https://github.com/openssl/openssl/pull/19289)
[openssl/openssl] 4e43bc: crypto: thread: serialize concurrent joins
Branch: refs/heads/master Home: https://github.com/openssl/openssl Commit: 4e43bc06f7673597a99f61325543449e72070c8c https://github.com/openssl/openssl/commit/4e43bc06f7673597a99f61325543449e72070c8c Author: Čestmír Kalina Date: 2022-10-21 (Fri, 21 Oct 2022) Changed paths: M crypto/thread/arch.c M crypto/thread/arch/thread_none.c M crypto/thread/arch/thread_posix.c M crypto/thread/arch/thread_win.c M include/internal/thread_arch.h M test/threadstest.c Log Message: --- crypto: thread: serialize concurrent joins Multiple concurrent joins with a running thread suffer from a race condition that allows concurrent join calls to perform concurrent arch specific join calls, which is UB on POSIX, or to concurrently execute join and terminate calls. As soon as a thread T1 exists, one of the threads that joins with T1 is selected to perform the join, the remaining ones await completion. Once completed, the remaining calls immediately return. If the join failed, another thread is selected to attempt the join operation. Forcefully terminating a thread that is in the process of joining another thread is not supported. Common code from thread_posix and thread_win was refactored to use common wrapper that handles synchronization. Signed-off-by: Čestmír Kalina Reviewed-by: Hugo Landau Reviewed-by: Tomas Mraz (Merged from https://github.com/openssl/openssl/pull/19433) Commit: 6ca4bd2e4c92531e74acba3e1ff08e6fbb664b20 https://github.com/openssl/openssl/commit/6ca4bd2e4c92531e74acba3e1ff08e6fbb664b20 Author: Čestmír Kalina Date: 2022-10-21 (Fri, 21 Oct 2022) Changed paths: M test/threadstest.c Log Message: --- test: threads: replace test_thread_noreturn While POSIX threads are cancellable and may be asynchronously cancelled, their cancellation is not guaranteed by the POSIX standard. test_thread_noreturn, which simulates a long-running possibly unresponsive thread: THREAD #1 THREAD #2 LOCK L1 SPAWN #2 LOCK L1 On MacOS, cancelling such thread only queues cancellation request, but the following pthread_join hangs. Replace this implementation by an unbounded sequence of sleeps instead. Signed-off-by: Čestmír Kalina Reviewed-by: Hugo Landau Reviewed-by: Tomas Mraz (Merged from https://github.com/openssl/openssl/pull/19433) Compare: https://github.com/openssl/openssl/compare/ec1d5970be59...6ca4bd2e4c92
[openssl/openssl] ec1d59: openssl list: add an empty row at the end of each ...
Branch: refs/heads/master Home: https://github.com/openssl/openssl Commit: ec1d5970be596daed15a3fa723cfa2ac726b0dba https://github.com/openssl/openssl/commit/ec1d5970be596daed15a3fa723cfa2ac726b0dba Author: Daniel Fiala Date: 2022-10-21 (Fri, 21 Oct 2022) Changed paths: M apps/list.c Log Message: --- openssl list: add an empty row at the end of each printed list of commands and algorithms Fixes openssl#19140 Reviewed-by: Tomas Mraz Reviewed-by: Matt Caswell Reviewed-by: Paul Dale (Merged from https://github.com/openssl/openssl/pull/19372)
