Coverity Scan: Analysis completed for openssl/openssl

2022-11-24 Thread scan-admin


Your request for analysis of openssl/openssl has been completed 
successfully.
The results are available at 
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yoN-2BQSVjTtaSz8wS4wOr7HlekBtV1P4YRtWclMVkCdvAA-3D-3DmU1c_MulOTlHne1IxTRELXXnGni8d68xSVF-2BUCe3a7Ux-2BjeGk7cp-2Bn7b3x1mi9dlVDDvWs0bI9fN7uqwRRXs5BzDMcJ-2BxApRoEE5-2FAVABBZomtcivx1WwXKDRqib6nRC5JcMe81X5JuZrcjTv5iA-2B-2BNuZ4rYZo1-2BHZtkvETQ2CnBmVrkeJRGONFOLlmZw1RoYl1GqIMjAe2ZCdZDBX9XZKnCD2zXP7zN-2BESfeBQeWYgX3YVQ-3D

Build ID: 496348

Analysis Summary:
   New defects found: 0
   Defects eliminated: 0



[openssl/openssl] 0b7ad5: Fix typo in openssl-x509.pod.in

2022-11-24 Thread Jan
  Branch: refs/heads/master
  Home:   https://github.com/openssl/openssl
  Commit: 0b7ad5d928f9ee749cfc670ad08067a961217fea
  
https://github.com/openssl/openssl/commit/0b7ad5d928f9ee749cfc670ad08067a961217fea
  Author: Jan 
  Date:   2022-11-25 (Fri, 25 Nov 2022)

  Changed paths:
M doc/man1/openssl-x509.pod.in

  Log Message:
  ---
  Fix typo in openssl-x509.pod.in

CLA: trivial

Reviewed-by: Tomas Mraz 
Reviewed-by: Paul Dale 
(Merged from https://github.com/openssl/openssl/pull/19746)




[openssl/openssl] 79701d: Fix typo in openssl-x509.pod.in

2022-11-24 Thread Jan
  Branch: refs/heads/openssl-3.0
  Home:   https://github.com/openssl/openssl
  Commit: 79701dea4293ee8cf68e183ce27e2c5304893abb
  
https://github.com/openssl/openssl/commit/79701dea4293ee8cf68e183ce27e2c5304893abb
  Author: Jan 
  Date:   2022-11-25 (Fri, 25 Nov 2022)

  Changed paths:
M doc/man1/openssl-x509.pod.in

  Log Message:
  ---
  Fix typo in openssl-x509.pod.in

CLA: trivial

Reviewed-by: Tomas Mraz 
Reviewed-by: Paul Dale 
(Merged from https://github.com/openssl/openssl/pull/19746)

(cherry picked from commit 0b7ad5d928f9ee749cfc670ad08067a961217fea)




[openssl/openssl] 9bf67e: Fix typo in openssl-x509.pod.in

2022-11-24 Thread Jan
  Branch: refs/heads/openssl-3.1
  Home:   https://github.com/openssl/openssl
  Commit: 9bf67ed5525aaeebbed96d3c8a4caa93eb1b43ac
  
https://github.com/openssl/openssl/commit/9bf67ed5525aaeebbed96d3c8a4caa93eb1b43ac
  Author: Jan 
  Date:   2022-11-25 (Fri, 25 Nov 2022)

  Changed paths:
M doc/man1/openssl-x509.pod.in

  Log Message:
  ---
  Fix typo in openssl-x509.pod.in

CLA: trivial

Reviewed-by: Tomas Mraz 
Reviewed-by: Paul Dale 
(Merged from https://github.com/openssl/openssl/pull/19746)

(cherry picked from commit 0b7ad5d928f9ee749cfc670ad08067a961217fea)




[openssl/openssl] 5e6164: Disable test/timing_load_creds.c on VMS

2022-11-24 Thread Richard Levitte
  Branch: refs/heads/openssl-3.1
  Home:   https://github.com/openssl/openssl
  Commit: 5e616482dc12a6c2ba56e4b8359b220921891461
  
https://github.com/openssl/openssl/commit/5e616482dc12a6c2ba56e4b8359b220921891461
  Author: Richard Levitte 
  Date:   2022-11-24 (Thu, 24 Nov 2022)

  Changed paths:
M test/timing_load_creds.c

  Log Message:
  ---
  Disable test/timing_load_creds.c on VMS

Reviewed-by: Tomas Mraz 
Reviewed-by: Dmitry Belyavskiy 
(Merged from https://github.com/openssl/openssl/pull/19713)

(cherry picked from commit 81929ac49aa583b2347348953d8399ad775c6fd1)


  Commit: 80d89bde84320e85bad0ad46ef1e72dd997d6a82
  
https://github.com/openssl/openssl/commit/80d89bde84320e85bad0ad46ef1e72dd997d6a82
  Author: Richard Levitte 
  Date:   2022-11-24 (Thu, 24 Nov 2022)

  Changed paths:
M test/timing_load_creds.c

  Log Message:
  ---
  test/timing_load_creds.c: use OPENSSL_SYS_ macros

A previous change was only half done.  To avoid such mistakes again, we
switch to using the OPENSSL_SYS_ macros, as the are clearer than having
to check a pile of very platform and compiler specific macros.

Reviewed-by: Matt Caswell 
Reviewed-by: Dmitry Belyavskiy 
(Merged from https://github.com/openssl/openssl/pull/19720)

(cherry picked from commit 83c1220ad137bb4b651478444c3666c66ec9d640)


Compare: https://github.com/openssl/openssl/compare/5d8c9e2c28fb...80d89bde8432


[openssl/openssl] 1c8b17: Add SM2 support for EVP_PKEY_Q_keygen

2022-11-24 Thread Jiaxun Yang
  Branch: refs/heads/openssl-3.0
  Home:   https://github.com/openssl/openssl
  Commit: 1c8b17358fef7daca24d090cfbd5fca2e65ab388
  
https://github.com/openssl/openssl/commit/1c8b17358fef7daca24d090cfbd5fca2e65ab388
  Author: Jiaxun Yang 
  Date:   2022-11-24 (Thu, 24 Nov 2022)

  Changed paths:
M crypto/evp/evp_lib.c
M doc/man3/EVP_PKEY_keygen.pod

  Log Message:
  ---
  Add SM2 support for EVP_PKEY_Q_keygen

There is no reason preventing this API to support SM2,
which gives us a simple method to do SM2 key gen.

CLA: trivial

Reviewed-by: Hugo Landau 
Reviewed-by: Paul Dale 
Reviewed-by: Tomas Mraz 
(Merged from https://github.com/openssl/openssl/pull/19736)

(cherry picked from commit 3f32d29ad464591ed968a1e430111e1525280f4c)




[openssl/openssl] 5d8c9e: Add SM2 support for EVP_PKEY_Q_keygen

2022-11-24 Thread Jiaxun Yang
  Branch: refs/heads/openssl-3.1
  Home:   https://github.com/openssl/openssl
  Commit: 5d8c9e2c28fb973b842e88105eb618d0254b42af
  
https://github.com/openssl/openssl/commit/5d8c9e2c28fb973b842e88105eb618d0254b42af
  Author: Jiaxun Yang 
  Date:   2022-11-24 (Thu, 24 Nov 2022)

  Changed paths:
M crypto/evp/evp_lib.c
M doc/man3/EVP_PKEY_keygen.pod

  Log Message:
  ---
  Add SM2 support for EVP_PKEY_Q_keygen

There is no reason preventing this API to support SM2,
which gives us a simple method to do SM2 key gen.

CLA: trivial

Reviewed-by: Hugo Landau 
Reviewed-by: Paul Dale 
Reviewed-by: Tomas Mraz 
(Merged from https://github.com/openssl/openssl/pull/19736)

(cherry picked from commit 3f32d29ad464591ed968a1e430111e1525280f4c)




[openssl/openssl] 3f32d2: Add SM2 support for EVP_PKEY_Q_keygen

2022-11-24 Thread Jiaxun Yang
  Branch: refs/heads/master
  Home:   https://github.com/openssl/openssl
  Commit: 3f32d29ad464591ed968a1e430111e1525280f4c
  
https://github.com/openssl/openssl/commit/3f32d29ad464591ed968a1e430111e1525280f4c
  Author: Jiaxun Yang 
  Date:   2022-11-24 (Thu, 24 Nov 2022)

  Changed paths:
M crypto/evp/evp_lib.c
M doc/man3/EVP_PKEY_keygen.pod

  Log Message:
  ---
  Add SM2 support for EVP_PKEY_Q_keygen

There is no reason preventing this API to support SM2,
which gives us a simple method to do SM2 key gen.

CLA: trivial

Reviewed-by: Hugo Landau 
Reviewed-by: Paul Dale 
Reviewed-by: Tomas Mraz 
(Merged from https://github.com/openssl/openssl/pull/19736)




[openssl/openssl] 12dbea: CMP: fix status held in OSSL_CMP_CTX, in particula...

2022-11-24 Thread David von Oheimb
  Branch: refs/heads/openssl-3.1
  Home:   https://github.com/openssl/openssl
  Commit: 12dbea73ef515b7c83d6d3bdc56dacebfc36e2e0
  
https://github.com/openssl/openssl/commit/12dbea73ef515b7c83d6d3bdc56dacebfc36e2e0
  Author: Dr. David von Oheimb 
  Date:   2022-11-24 (Thu, 24 Nov 2022)

  Changed paths:
M apps/cmp.c
M crypto/cmp/cmp_client.c
M crypto/cmp/cmp_ctx.c
M crypto/cmp/cmp_msg.c
M crypto/cmp/cmp_server.c
M crypto/cmp/cmp_status.c
M doc/man3/OSSL_CMP_CTX_new.pod
M doc/man3/OSSL_CMP_exec_certreq.pod
M include/openssl/cmp.h.in

  Log Message:
  ---
  CMP: fix status held in OSSL_CMP_CTX, in particular for genp messages

On this occasion, replace magic constants by mnemonic ones; update doc

Reviewed-by: Tomas Mraz 
Reviewed-by: Todd Short 
Reviewed-by: David von Oheimb 
(Merged from https://github.com/openssl/openssl/pull/19205)

(cherry picked from commit 19ddcc4cbb43464493a4b82332a1ab96da823451)


  Commit: fb705bebeef035b9d5984db20280fd5c1016b4a0
  
https://github.com/openssl/openssl/commit/fb705bebeef035b9d5984db20280fd5c1016b4a0
  Author: Dr. David von Oheimb 
  Date:   2022-11-24 (Thu, 24 Nov 2022)

  Changed paths:
M crypto/cmp/cmp_client.c
M crypto/cmp/cmp_status.c
M doc/man3/OSSL_CMP_CTX_new.pod

  Log Message:
  ---
  CMP: fix handling of unset or missing failInfo PKI status information

Reviewed-by: Tomas Mraz 
Reviewed-by: Todd Short 
Reviewed-by: David von Oheimb 
(Merged from https://github.com/openssl/openssl/pull/19205)

(cherry picked from commit cba0e2afd6a222aa041e05f8455e83c9e959d05b)


Compare: https://github.com/openssl/openssl/compare/0703f3f9dff4...fb705bebeef0


[openssl/openssl] 69d3c8: CMP: fix status held in OSSL_CMP_CTX, in particula...

2022-11-24 Thread David von Oheimb
  Branch: refs/heads/openssl-3.0
  Home:   https://github.com/openssl/openssl
  Commit: 69d3c81ca5c6cb03b0d1d1063fe6a2fa731ff461
  
https://github.com/openssl/openssl/commit/69d3c81ca5c6cb03b0d1d1063fe6a2fa731ff461
  Author: Dr. David von Oheimb 
  Date:   2022-11-24 (Thu, 24 Nov 2022)

  Changed paths:
M apps/cmp.c
M crypto/cmp/cmp_client.c
M crypto/cmp/cmp_ctx.c
M crypto/cmp/cmp_msg.c
M crypto/cmp/cmp_server.c
M crypto/cmp/cmp_status.c
M doc/man3/OSSL_CMP_CTX_new.pod
M doc/man3/OSSL_CMP_exec_certreq.pod
M include/openssl/cmp.h.in

  Log Message:
  ---
  CMP: fix status held in OSSL_CMP_CTX, in particular for genp messages

On this occasion, replace magic constants by mnemonic ones; update doc

Reviewed-by: Tomas Mraz 
Reviewed-by: Todd Short 
Reviewed-by: David von Oheimb 
(Merged from https://github.com/openssl/openssl/pull/19205)

(cherry picked from commit 19ddcc4cbb43464493a4b82332a1ab96da823451)


  Commit: f2784497264bcf2c0080adab99a2fee93756199a
  
https://github.com/openssl/openssl/commit/f2784497264bcf2c0080adab99a2fee93756199a
  Author: Dr. David von Oheimb 
  Date:   2022-11-24 (Thu, 24 Nov 2022)

  Changed paths:
M crypto/cmp/cmp_client.c
M crypto/cmp/cmp_status.c
M doc/man3/OSSL_CMP_CTX_new.pod

  Log Message:
  ---
  CMP: fix handling of unset or missing failInfo PKI status information

Reviewed-by: Tomas Mraz 
Reviewed-by: Todd Short 
Reviewed-by: David von Oheimb 
(Merged from https://github.com/openssl/openssl/pull/19205)

(cherry picked from commit cba0e2afd6a222aa041e05f8455e83c9e959d05b)


Compare: https://github.com/openssl/openssl/compare/c28c2e0c7e65...f2784497264b


[openssl/openssl] 19ddcc: CMP: fix status held in OSSL_CMP_CTX, in particula...

2022-11-24 Thread David von Oheimb
  Branch: refs/heads/master
  Home:   https://github.com/openssl/openssl
  Commit: 19ddcc4cbb43464493a4b82332a1ab96da823451
  
https://github.com/openssl/openssl/commit/19ddcc4cbb43464493a4b82332a1ab96da823451
  Author: Dr. David von Oheimb 
  Date:   2022-11-24 (Thu, 24 Nov 2022)

  Changed paths:
M apps/cmp.c
M crypto/cmp/cmp_client.c
M crypto/cmp/cmp_ctx.c
M crypto/cmp/cmp_msg.c
M crypto/cmp/cmp_server.c
M crypto/cmp/cmp_status.c
M doc/man3/OSSL_CMP_CTX_new.pod
M doc/man3/OSSL_CMP_exec_certreq.pod
M include/openssl/cmp.h.in

  Log Message:
  ---
  CMP: fix status held in OSSL_CMP_CTX, in particular for genp messages

On this occasion, replace magic constants by mnemonic ones; update doc

Reviewed-by: Tomas Mraz 
Reviewed-by: Todd Short 
Reviewed-by: David von Oheimb 
(Merged from https://github.com/openssl/openssl/pull/19205)


  Commit: cba0e2afd6a222aa041e05f8455e83c9e959d05b
  
https://github.com/openssl/openssl/commit/cba0e2afd6a222aa041e05f8455e83c9e959d05b
  Author: Dr. David von Oheimb 
  Date:   2022-11-24 (Thu, 24 Nov 2022)

  Changed paths:
M crypto/cmp/cmp_client.c
M crypto/cmp/cmp_status.c
M doc/man3/OSSL_CMP_CTX_new.pod

  Log Message:
  ---
  CMP: fix handling of unset or missing failInfo PKI status information

Reviewed-by: Tomas Mraz 
Reviewed-by: Todd Short 
Reviewed-by: David von Oheimb 
(Merged from https://github.com/openssl/openssl/pull/19205)


Compare: https://github.com/openssl/openssl/compare/33a73e33dce1...cba0e2afd6a2


[openssl/openssl] 357bfe: CMP+CRMF: fix formatting nits in crypto/, include/...

2022-11-24 Thread David von Oheimb
  Branch: refs/heads/master
  Home:   https://github.com/openssl/openssl
  Commit: 357bfe73453b018c7aee94cbb4f6eeca8b85695a
  
https://github.com/openssl/openssl/commit/357bfe73453b018c7aee94cbb4f6eeca8b85695a
  Author: Dr. David von Oheimb 
  Date:   2022-11-24 (Thu, 24 Nov 2022)

  Changed paths:
M crypto/cmp/cmp_asn.c
M crypto/cmp/cmp_client.c
M crypto/cmp/cmp_local.h
M crypto/cmp/cmp_msg.c
M crypto/cmp/cmp_protect.c
M crypto/cmp/cmp_status.c
M crypto/cmp/cmp_util.c
M crypto/cmp/cmp_vfy.c
M crypto/crmf/crmf_asn.c
M crypto/crmf/crmf_lib.c
M crypto/crmf/crmf_local.h
M crypto/crmf/crmf_pbm.c
M include/crypto/cmperr.h
M include/openssl/crmf.h.in
M test/cmp_asn_test.c
M test/cmp_client_test.c
M test/cmp_hdr_test.c
M test/cmp_msg_test.c
M test/cmp_protect_test.c
M test/cmp_status_test.c
M test/cmp_vfy_test.c

  Log Message:
  ---
  CMP+CRMF: fix formatting nits in crypto/, include/, and test/

Reviewed-by: Tomas Mraz 
Reviewed-by: Dmitry Belyavskiy 
Reviewed-by: David von Oheimb 
(Merged from https://github.com/openssl/openssl/pull/19230)


  Commit: 33a73e33dce1e62613d67471ba8b68afe01166c0
  
https://github.com/openssl/openssl/commit/33a73e33dce1e62613d67471ba8b68afe01166c0
  Author: Dr. David von Oheimb 
  Date:   2022-11-24 (Thu, 24 Nov 2022)

  Changed paths:
M doc/man3/OSSL_CMP_ITAV_set0.pod

  Log Message:
  ---
  OSSL_CMP_ITAV_set0.pod: fix formatting nits, update example

Reviewed-by: Tomas Mraz 
Reviewed-by: Dmitry Belyavskiy 
Reviewed-by: David von Oheimb 
(Merged from https://github.com/openssl/openssl/pull/19230)


Compare: https://github.com/openssl/openssl/compare/cd715b7e7fdd...33a73e33dce1


[openssl/openssl] cd715b: Add support for KTLS zerocopy sendfile on Linux

2022-11-24 Thread nvmmax
  Branch: refs/heads/master
  Home:   https://github.com/openssl/openssl
  Commit: cd715b7e7fdd2aeb0fd80220d2df5187b291f87a
  
https://github.com/openssl/openssl/commit/cd715b7e7fdd2aeb0fd80220d2df5187b291f87a
  Author: Maxim Mikityanskiy 
  Date:   2022-11-24 (Thu, 24 Nov 2022)

  Changed paths:
M CHANGES.md
M apps/s_server.c
M crypto/bio/bss_conn.c
M crypto/bio/bss_sock.c
M doc/man1/openssl-s_server.pod.in
M doc/man3/SSL_CONF_cmd.pod
M doc/man3/SSL_CTX_set_options.pod
M include/internal/bio.h
M include/internal/ktls.h
M include/openssl/bio.h.in
M include/openssl/ssl.h.in
M ssl/record/methods/ktls_meth.c
M ssl/ssl_conf.c
M test/sslapitest.c

  Log Message:
  ---
  Add support for KTLS zerocopy sendfile on Linux

TLS device offload allows to perform zerocopy sendfile transmissions.
FreeBSD provides this feature by default, and Linux 5.19 introduced it
as an opt-in. Zerocopy improves the TX rate significantly, but has a
side effect: if the underlying file is changed while being transmitted,
and a TCP retransmission happens, the receiver may get a TLS record
containing both new and old data, which leads to an authentication
failure and termination of connection. This effect is the reason Linux
makes a copy on sendfile by default.

This commit adds support for TLS zerocopy sendfile on Linux disabled by
default to avoid any unlikely backward compatibility issues on Linux,
although sacrificing consistency in OpenSSL's behavior on Linux and
FreeBSD. A new option called KTLSTxZerocopySendfile is added to enable
the new zerocopy behavior on Linux. This option should be used when the
the application guarantees that the file is not modified during
transmission, or it doesn't care about breaking the connection.

The related documentation is also added in this commit. The unit test
added doesn't test the actual functionality (it would require specific
hardware and a non-local peer), but solely checks that it's possible to
set the new option flag.

Signed-off-by: Maxim Mikityanskiy 
Reviewed-by: Tariq Toukan 
Reviewed-by: Boris Pismenny 
Reviewed-by: Matt Caswell 
Reviewed-by: Todd Short 
Reviewed-by: Tomas Mraz 
(Merged from https://github.com/openssl/openssl/pull/18650)




[openssl/openssl] 394f6f: QUIC TXP: Fix missing OSSL_NELEM include

2022-11-24 Thread Hugo Landau
  Branch: refs/heads/master
  Home:   https://github.com/openssl/openssl
  Commit: 394f6f246af23876f3d7a0332eb194aaa5127643
  
https://github.com/openssl/openssl/commit/394f6f246af23876f3d7a0332eb194aaa5127643
  Author: Hugo Landau 
  Date:   2022-11-24 (Thu, 24 Nov 2022)

  Changed paths:
M ssl/quic/quic_stream_map.c

  Log Message:
  ---
  QUIC TXP: Fix missing OSSL_NELEM include

Reviewed-by: Matt Caswell 
Reviewed-by: Dmitry Belyavskiy 
(Merged from https://github.com/openssl/openssl/pull/19756)




[openssl/openssl] 18af4d: Make parsing of piped data in `speed.c` more robust

2022-11-24 Thread faramir-dev
  Branch: refs/heads/master
  Home:   https://github.com/openssl/openssl
  Commit: 18af4d154cc563a5b02409215a576276caece0f4
  
https://github.com/openssl/openssl/commit/18af4d154cc563a5b02409215a576276caece0f4
  Author: Daniel Fiala 
  Date:   2022-11-24 (Thu, 24 Nov 2022)

  Changed paths:
M apps/speed.c

  Log Message:
  ---
  Make parsing of piped data in `speed.c` more robust

Fixes openssl#19050

Reviewed-by: Paul Dale 
Reviewed-by: Tomas Mraz 
(Merged from https://github.com/openssl/openssl/pull/19238)




[openssl/openssl] a73078: QUIC TX Packetiser and Streams Mapper

2022-11-24 Thread Hugo Landau
  Branch: refs/heads/master
  Home:   https://github.com/openssl/openssl
  Commit: a73078b79fc6f229b95312dcb20e4f61120a108c
  
https://github.com/openssl/openssl/commit/a73078b79fc6f229b95312dcb20e4f61120a108c
  Author: Hugo Landau 
  Date:   2022-11-24 (Thu, 24 Nov 2022)

  Changed paths:
M doc/designs/quic-design/tx-packetiser.md
M include/internal/quic_ackm.h
M include/internal/quic_fc.h
M include/internal/quic_fifd.h
M include/internal/quic_record_tx.h
M include/internal/quic_stream.h
A include/internal/quic_stream_map.h
A include/internal/quic_txp.h
M include/internal/quic_txpim.h
M include/internal/quic_types.h
M include/internal/quic_wire.h
M include/internal/quic_wire_pkt.h
M ssl/quic/build.info
M ssl/quic/quic_ackm.c
M ssl/quic/quic_fifd.c
M ssl/quic/quic_record_rx.c
M ssl/quic/quic_record_tx.c
M ssl/quic/quic_sstream.c
A ssl/quic/quic_stream_map.c
A ssl/quic/quic_txp.c
M ssl/quic/quic_wire.c
M ssl/quic/quic_wire_pkt.c
M test/build.info
M test/quic_fifd_test.c
M test/quic_record_test.c
A test/quic_record_test_util.h
M test/quic_stream_test.c
A test/quic_txp_test.c
M test/quic_wire_test.c
A test/recipes/70-test_quic_txp.t

  Log Message:
  ---
  QUIC TX Packetiser and Streams Mapper

Reviewed-by: Tomas Mraz 
Reviewed-by: Paul Dale 
Reviewed-by: Matt Caswell 
(Merged from https://github.com/openssl/openssl/pull/19346)