[openssl.org #2470] [PATCH] Cygwin: Don't call ERR_remove_state from DllMain
Hi, the below patch is against current CVS HEAD, but it should be applied to all supported branches of OpenSSL, starting with 0.9.8. On systems running on the Windows platform, there's a DllMain function in crypto/cryptlib.c which always calls ERR_remove_state(0) if an application thread exits. While this may be ok for native Windows applications, it's wrong for applications running under Cygwin, given that Cygwin is a POSIX environment. Not only that compliant applications are written so that they call ERR_remove_state by themselves right before exiting from a thread, the gratuitous ERR_remove_state call in DllMain also potentially crashes threaded applications. For examples see http://bugs.python.org/issue3947 and http://cygwin.com/ml/cygwin/2008-11/msg00341.html The latest openssl package in the Cygwin net distribution also has this patch applied. Thanks, Corinna Index: crypto/cryptlib.c === RCS file: /home/cvs/cvsroot/src/openssl/crypto/cryptlib.c,v retrieving revision 1.85 diff -u -p -r1.85 cryptlib.c --- crypto/cryptlib.c 19 Nov 2010 00:12:01 - 1.85 +++ crypto/cryptlib.c 16 Mar 2011 20:45:45 - @@ -744,7 +744,9 @@ BOOL WINAPI DllMain(HINSTANCE hinstDLL, case DLL_THREAD_ATTACH: break; case DLL_THREAD_DETACH: +#ifndef __CYGWIN__ ERR_remove_state(0); +#endif break; case DLL_PROCESS_DETACH: break; -- Corinna Vinschen Cygwin Project Co-Leader Red Hat __ OpenSSL Project http://www.openssl.org Development Mailing List openssl-dev@openssl.org Automated List Manager majord...@openssl.org
Re: [openssl.org #2449] [BUG] openssl 1.0.0d warnings during build and ACCVIO on OpenVMS
In message 11031501491312_20200...@antinode.info on Tue, 15 Mar 2011 01:49:13 -0500 (CDT), Steven M. Schweda s...@antinode.info said: sms http://antinode.info/ftp/openssl/1_0_0d/openssl-1_0_0d_s4a.zip Got openssl-1_0_0d_s4.zip and openssl-1_0_0d_s4a.zip couple of days ago, it's getting tested right now. -- Richard Levitte rich...@levitte.org http://richard.levitte.org/ Life is a tremendous celebration - and I'm invited! -- from a friend's blog, translated from Swedish __ OpenSSL Project http://www.openssl.org Development Mailing List openssl-dev@openssl.org Automated List Manager majord...@openssl.org
[openssl.org #2471] [PATCH] util/cygwin.sh from CVS HEAD should be applied to 0.9.8 branch
Hi,
would you mind to apply the below patch to util/cygwin.sh in the 0.9.8
branch, too? It has been applied only to HEAD, accidentally.
Thanks,
Corinna
--- openssl-0.9.8r/util/cygwin.sh 2005-06-23 22:55:35.0 +0200
+++ openssl-0.9.8r-1/util/cygwin.sh 2011-02-08 19:22:45.010931465 +0100
@@ -7,8 +7,8 @@
# Uncomment when debugging
#set -x
-CONFIG_OPTIONS=--prefix=/usr shared no-idea no-rc5 no-mdc2
-INSTALL_PREFIX=/tmp/install
+CONFIG_OPTIONS=--prefix=/usr shared zlib no-idea no-rc5
+INSTALL_PREFIX=/tmp/install/INSTALL
VERSION=
SUBVERSION=$1
@@ -66,7 +66,7 @@ function create_cygwin_readme()
./config ${CONFIG_OPTIONS}
- The IDEA, RC5 and MDC2 algorithms are disabled due to patent and/or
+ The IDEA and RC5 algorithms are disabled due to patent and/or
licensing issues.
EOF
}
@@ -124,8 +124,12 @@ strip usr/bin/*.exe usr/bin/*.dll usr/li
chmod u-w usr/lib/engines/*.so
# Runtime package
-find etc usr/bin usr/lib/engines usr/share/doc usr/ssl/certs \
- usr/ssl/man/man[157] usr/ssl/misc usr/ssl/openssl.cnf usr/ssl/private \
+tar cjf libopenssl${VERSION//[!0-9]/}-${VERSION}-${SUBVERSION}.tar.bz2 \
+ usr/bin/cyg*dll
+# Base package
+find etc usr/bin/openssl.exe usr/bin/c_rehash usr/lib/engines usr/share/doc \
+ usr/ssl/certs usr/ssl/man/man[157] usr/ssl/misc usr/ssl/openssl.cnf \
+ usr/ssl/private \
-empty -o \! -type d |
tar cjfT openssl-${VERSION}-${SUBVERSION}.tar.bz2 -
# Development package
@@ -135,6 +139,7 @@ tar cjfT openssl-devel-${VERSION}-${SUBV
ls -l openssl-${VERSION}-${SUBVERSION}.tar.bz2
ls -l openssl-devel-${VERSION}-${SUBVERSION}.tar.bz2
+ls -l libopenssl${VERSION//[!0-9]/}-${VERSION}-${SUBVERSION}.tar.bz2
cleanup
--
Corinna Vinschen
Cygwin Project Co-Leader
Red Hat
__
OpenSSL Project http://www.openssl.org
Development Mailing List openssl-dev@openssl.org
Automated List Manager majord...@openssl.org
Re: [openssl.org #2449] [BUG] openssl 1.0.0d warnings during build and ACCVIO on OpenVMS
From: Richard Levitte rich...@levitte.org Got openssl-1_0_0d_s4.zip and openssl-1_0_0d_s4a.zip couple of days ago, it's getting tested right now. My VAX just finished its run through the latest stuff, and it seems to be happy. (The Perl build finished, some of its tests passed, and it seems to work well enough to do test/cms-test.pl. Having a working bc is nice, too.) What could go wrong? Of course, What won't you like? is a different question. I've already supplied a list (or two, or ...) of things I don't like. I still haven't tried to use these libraries or shared images with any other programs. Because of the new HP-like naming, existing builders for other programs may not find the expected .OLB or .EXE without some help -- either revised builders, or SET FILE /ENTER = old_name SSL_whatever. SMS. __ OpenSSL Project http://www.openssl.org Development Mailing List openssl-dev@openssl.org Automated List Manager majord...@openssl.org
