Re: [openssl-dev] [openssl.org #3198] [PATCH] Fix missing NULL pointer checks and memory leaks in crypto/asn1 files
On 10/06/14 21:48, Jonas Maebe via RT wrote: > On 13/12/13 11:54, The default queue via RT wrote: > >> In attachment you can find 7 patches against git master (generated via git >> format-patch) to fix a number of memory leaks (in case of failures) and >> missing NULL pointer checks (generally for malloc results) for source files >> under crypto/asn1. I've tried to follow the coding conventions of the >> surrounding code. >> >> I have about 50 more similar patches to various other parts of OpenSSL, but >> I'll wait with submitting them in case you'd like something different about >> the way I'm grouping/formatting/splitting them. > > I've rebased those 7 patches and all of my other similar patches against > current git HEAD and pushed them to a fork on github. I've created a > pull request for them at https://github.com/openssl/openssl/pull/131 All of my patches have been applied or superseded by other patches in the mean time. I've created a pull request for the four remaining, relevant patches at https://github.com/openssl/openssl/pull/511 Jonas ___ openssl-dev mailing list To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev
Re: [openssl-dev] Mailman version used by OpenSSL is misconfigured and/or broken in relation to DKIM
On 05/08/15 23:00, mancha wrote: OpenSSL is certainly not alone in its practice of mangling headers and adding body footers so I'd be curious to hear how other lists handle domains such as yahoo.com. We warn people that DKIM-using domains may experience bounces, and that they should subscribe using a different email address to our lists. Yahoo/AOL switching it on before the probably most used mailing list manager could handle it certainly did not help in creating goodwill. Even now the mailman version included in our distribution still can't handle it, and manually installing and maintaining a different one is not something we care to do. Jonas ___ openssl-dev mailing list To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev
Re: [openssl.org #3198] [PATCH] Fix missing NULL pointer checks and memory leaks in crypto/asn1 files
On 13/12/13 11:54, The default queue via RT wrote: In attachment you can find 7 patches against git master (generated via git format-patch) to fix a number of memory leaks (in case of failures) and missing NULL pointer checks (generally for malloc results) for source files under crypto/asn1. I've tried to follow the coding conventions of the surrounding code. I have about 50 more similar patches to various other parts of OpenSSL, but I'll wait with submitting them in case you'd like something different about the way I'm grouping/formatting/splitting them. I've rebased those 7 patches and all of my other similar patches against current git HEAD and pushed them to a fork on github. I've created a pull request for them at https://github.com/openssl/openssl/pull/131 Jonas __ OpenSSL Project http://www.openssl.org Development Mailing List openssl-dev@openssl.org Automated List Manager majord...@openssl.org
Re: [openssl.org #3198] [PATCH] Fix missing NULL pointer checks and memory leaks in crypto/asn1 files
On 10/06/14 21:59, Kurt Roeckx via RT wrote: On Tue, Jun 10, 2014 at 09:48:19PM +0200, Jonas Maebe via RT wrote: On 13/12/13 11:54, The default queue via RT wrote: In attachment you can find 7 patches against git master (generated via git format-patch) to fix a number of memory leaks (in case of failures) and missing NULL pointer checks (generally for malloc results) for source files under crypto/asn1. I've tried to follow the coding conventions of the surrounding code. I have about 50 more similar patches to various other parts of OpenSSL, but I'll wait with submitting them in case you'd like something different about the way I'm grouping/formatting/splitting them. I've rebased those 7 patches and all of my other similar patches against current git HEAD and pushed them to a fork on github. I've created a pull request for them at https://github.com/openssl/openssl/pull/131 So that actually contains 57 commits. It's going to take some time for someone to review it. Yes, sorry. I was originally planning on submitting them piecemeal, but as nothing happened with the initial batch I kind of lost motivation... Jonas __ OpenSSL Project http://www.openssl.org Development Mailing List openssl-dev@openssl.org Automated List Manager majord...@openssl.org
[openssl.org #3198] [PATCH] Fix missing NULL pointer checks and memory leaks in crypto/asn1 files
Hi, In attachment you can find 7 patches against git master (generated via git format-patch) to fix a number of memory leaks (in case of failures) and missing NULL pointer checks (generally for malloc results) for source files under crypto/asn1. I've tried to follow the coding conventions of the surrounding code. I have about 50 more similar patches to various other parts of OpenSSL, but I'll wait with submitting them in case you'd like something different about the way I'm grouping/formatting/splitting them. Jonas 0001-SetBlob-free-rgSetBlob-on-error-path.patch Description: Binary data 0002-ASN1_verify-ASN1_item_verify-cleanse-and-free-buf_in.patch Description: Binary data 0003-mime_hdr_new-free-mhdr-tmpname-tmpval-on-error-path.patch Description: Binary data 0004-mime_hdr_addparam-free-tmpname-tmpval-and-mparam-on-.patch Description: Binary data 0005-multi_split-check-for-NULL-when-allocating-parts-and.patch Description: Binary data 0006-asn1_bio_new-free-ctx-on-error-path.patch Description: Binary data 0007-asn1_set_seq_out-free-derlist-and-tmpdat-on-error-pa.patch Description: Binary data
Re: [openssl.org #3198] [PATCH] Fix missing NULL pointer checks and memory leaks in crypto/asn1 files
On 13 Dec 2013, at 11:54, The default queue via RT wrote: In attachment you can find 7 patches against git master (generated via git format-patch) to fix a number of memory leaks (in case of failures) and missing NULL pointer checks (generally for malloc results) for source files under crypto/asn1. I've tried to follow the coding conventions of the surrounding code. Of course, right before I sent those patches I discovered some more issues, changed the code, rebased/fixed up the previous commits and then forgot to test the result. Please find corrected replacements for patches 0003 and 0004 in the previous series in attachments. Sorry. Jonas 0003-mime_hdr_new-free-mhdr-tmpname-tmpval-on-error-path.patch Description: Binary data 0004-mime_hdr_addparam-free-tmpname-tmpval-and-mparam-on-.patch Description: Binary data
