Re: memory.h confusion: Is it needed?
Bhola, On Wed, Dec 29, 2010 at 3:55 PM, Bhola Ray wrote: > memory.h is in the following path: [ I am using Linux debian 2.6.26-2-686 #1 > SMP Thu Nov 25 01:53:57 UTC 2010 i686 GNU/Linux ] > /usr/src/linux-headers-2.6.26-2-686/include/linux/memory.h > So make sure your path is set properly to include the linux include files Yes, I know where memory.h is on a linux machine. However, I am working on a port to eCos which I mentioned in my first post as quoted below. > While porting OpenSSL v1.0.0c I got a 'no such file' error on an include of > . The error is correct. My platform has no memory.h. Thanks for a response, but it unfortunately doesn't address the issue. -- Mike __ OpenSSL Project http://www.openssl.org Development Mailing List openssl-dev@openssl.org Automated List Manager majord...@openssl.org
memory.h confusion: Is it needed?
Hi all, While porting OpenSSL v1.0.0c I got a 'no such file' error on an include of . The error is correct. My platform has no memory.h. So, I investigated a little further as to where and if it is needed. I only see memory.h included in the following: $ grep \ . -r -C2 ./crypto/asn1/bio_ndef.c- ./crypto/asn1/bio_ndef.c-#ifndef OPENSSL_SYSNAME_NETWARE ./crypto/asn1/bio_ndef.c:#include ./crypto/asn1/bio_ndef.c-#endif ./crypto/asn1/bio_ndef.c-#include grep: ./crypto/cms/cms.h: Too many levels of symbolic links -- ./crypto/jpake/jpake.c-#include ./crypto/jpake/jpake.c-#include ./crypto/jpake/jpake.c:#include ./crypto/jpake/jpake.c- ./crypto/jpake/jpake.c-/* -- ./crypto/pkcs7/bio_pk7.c- ./crypto/pkcs7/bio_pk7.c-#ifndef OPENSSL_SYSNAME_NETWARE ./crypto/pkcs7/bio_pk7.c:#include ./crypto/pkcs7/bio_pk7.c-#endif ./crypto/pkcs7/bio_pk7.c-#include -- ./crypto/seed/seed.c-#include ./crypto/seed/seed.c-#ifdef WIN32 ./crypto/seed/seed.c:#include ./crypto/seed/seed.c-#endif ./crypto/seed/seed.c- -- ./demos/ssl/cli.cpp- ./demos/ssl/cli.cpp-#include ./demos/ssl/cli.cpp:#include ./demos/ssl/cli.cpp-#include ./demos/ssl/cli.cpp-#include -- ./demos/ssl/serv.cpp-#include ./demos/ssl/serv.cpp-#include ./demos/ssl/serv.cpp:#include ./demos/ssl/serv.cpp-#include ./demos/ssl/serv.cpp-#include grep: ./include/openssl/cms.h: Too many levels of symbolic links My concern is with the actual library code, not the demo stuff. My confusion comes from the #ifdef's around the include. In one place, it gets include for everyone but NETWARE, in another only for WIN32, and in JPAKE (i know this experimental code) says include it for everyone. I looked through the source for each and I can't determine where anything from memory.h is even being used. Can someone else confirm whether or not memory.h is actually needed? If so, under what system should it be included? I can submit a patch to clean it up after we sort it out. -- Mike __ OpenSSL Project http://www.openssl.org Development Mailing List openssl-dev@openssl.org Automated List Manager majord...@openssl.org
Is there a list of files no longer used/built in the repository?
Hi all, I am working on a port of OpenSSL 1.0.0c to eCos. As I work though the processes I am trying to determine what source files in the repository are used and which have been left as historical references/artifacts. For example, crypto/evp/openbsd_hw.c doesn't appear to be used anymore and it's content is #if 0'd out. Cases like that are easy. However, some are a bit more difficult. Is there list of files that are no longer used/built, but are still lying around in the repository for whatever reason? A list is probably wishful thinking on my part, but hey, you never know. I was just hoping that I could prevent having to keep coming back to the list to ask if a particular source file is used or not. If it comes to that, I will put post a list of files I suspect are not used to get confirmation. Mind you, I will have heavily grep'd the tree and read the source before adding it to the list. If anyone knows wants to throw out the names of any dead files, feel free. Perhaps someone can confirm if the following are no longer built: crypto/evp/e_dsa.c crypto/pkcs7/bio_ber.c Thank you for your input. -- Mike __ OpenSSL Project http://www.openssl.org Development Mailing List openssl-dev@openssl.org Automated List Manager majord...@openssl.org
[Patch] fix definition typo in bss_dgram.c
Hi all, During a port of OpenSSL I saw the following message during the build: crypto/bio/bss_dgram.c:343:5: warning: "OPENSSL_USE_IVP6" is not defined Well, of course, it isn't defined because it is spelled incorrectly. Should be OPENSSL_USE_IPV6 as used everywhere else. What I am actually surprised about is that this typo was introduced in the IPv6 patch set introduced back in Jan. 2010 and this hasn't been caught or fixed yet. I guess people don't check warnings anymore :(. The patch is attached and is included here: diff -ur openssl/crypto/bio/bss_dgram.c openssl-work/crypto/bio/bss_dgram.c --- openssl/crypto/bio/bss_dgram.c 2010-01-07 05:42:39.0 -0500 +++ openssl-work/crypto/bio/bss_dgram.c 2010-12-28 15:37:24.726625000 -0500 @@ -340,7 +340,7 @@ if (data->peer.sa.sa_family == AF_INET) peerlen = sizeof(data->peer.sa_in); -#if OPENSSL_USE_IVP6 +#if OPENSSL_USE_IPV6 else if (data->peer.sa.sa_family == AF_INET6) peerlen = sizeof(data->peer.sa_in6); #endif Not a stellar contribution, but it gets rid of a warning message and probably prevents a random breakage when using IPv6 :) -- Mike bss_dgram_ipv6_typo.patch Description: Binary data
