Re: [openssl-dev] [openssl-commits] [openssl] master update ("Add Camellia CTR mode", dda8199922f9d52087d2c41b22a61eb4f9671385)
On 02/12/15 12:49, Rainer Jung wrote: > Am 12.02.2015 um 12:00 schrieb Andy Polyakov: diff --git a/crypto/evp/c_allc.c b/crypto/evp/c_allc.c index 174a419..7ae36d7 100644 --- a/crypto/evp/c_allc.c +++ b/crypto/evp/c_allc.c @@ -245,5 +245,8 @@ void OpenSSL_add_all_ciphers(void) EVP_add_cipher(EVP_camellia_256_ofb()); EVP_add_cipher_alias(SN_camellia_256_cbc, "CAMELLIA256"); EVP_add_cipher_alias(SN_camellia_256_cbc, "camellia256"); +EVP_add_cipher(EVP_camellia_128_ctr()); +EVP_add_cipher(EVP_camellia_192_ctr()); +EVP_add_cipher(EVP_camellia_256_ctr()); #endif } >>> >>> We get build warnings and crashes during run in EVP_add_cipher(). >> >> Thanks. I'm on it. Out of curiosity, with which config do you get >> crashes? I don't mean that this doesn't need fixing, I only want to have >> a reference. > > Thanks to you. > > The crash occurred while using it during a CI build for Tomcat plus > Tomcat native connector (tcnative) which in turn uses OpenSSL. Question was rather about OS. The question I seek answer to is how did it evade the usual test and/or what is so special about your environment. > OpenSSL was build with "config --prefix=... shared enable-deprecated". > > I don't have a full stack available. The Java HS-Error file says: > > [junit] # > [junit] # A fatal error has been detected by the Java Runtime > Environment: > [junit] # > [junit] # SIGSEGV (0xb) at pc=0x7fb882f66ef9, pid=32437, > tid=140431064893184 Ah! Keyword is likely to be that it was shared build. I mean implicit cast can slip through in non-shared case, because in such case code is loaded in lower 2GB, while shared libraries tend to be mapped far above 4GB. Thanks. ___ openssl-dev mailing list To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev
Re: [openssl-dev] [openssl-commits] [openssl] master update ("Add Camellia CTR mode", dda8199922f9d52087d2c41b22a61eb4f9671385)
Am 12.02.2015 um 12:00 schrieb Andy Polyakov: diff --git a/crypto/evp/c_allc.c b/crypto/evp/c_allc.c index 174a419..7ae36d7 100644 --- a/crypto/evp/c_allc.c +++ b/crypto/evp/c_allc.c @@ -245,5 +245,8 @@ void OpenSSL_add_all_ciphers(void) EVP_add_cipher(EVP_camellia_256_ofb()); EVP_add_cipher_alias(SN_camellia_256_cbc, "CAMELLIA256"); EVP_add_cipher_alias(SN_camellia_256_cbc, "camellia256"); +EVP_add_cipher(EVP_camellia_128_ctr()); +EVP_add_cipher(EVP_camellia_192_ctr()); +EVP_add_cipher(EVP_camellia_256_ctr()); #endif } We get build warnings and crashes during run in EVP_add_cipher(). Thanks. I'm on it. Out of curiosity, with which config do you get crashes? I don't mean that this doesn't need fixing, I only want to have a reference. Thanks to you. The crash occurred while using it during a CI build for Tomcat plus Tomcat native connector (tcnative) which in turn uses OpenSSL. OpenSSL was build with "config --prefix=... shared enable-deprecated". I don't have a full stack available. The Java HS-Error file says: [junit] # [junit] # A fatal error has been detected by the Java Runtime Environment: [junit] # [junit] # SIGSEGV (0xb) at pc=0x7fb882f66ef9, pid=32437, tid=140431064893184 [junit] # [junit] # JRE version: Java(TM) SE Runtime Environment (8.0_25-b17) (build 1.8.0_25-b17) [junit] # Java VM: Java HotSpot(TM) 64-Bit Server VM (25.25-b02 mixed mode linux-amd64 compressed oops) [junit] # Problematic frame: [junit] # C [libcrypto.so.1.1.0+0x14fef9] EVP_add_cipher+0x9 [junit] # Regards, Rainer ___ openssl-dev mailing list To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev
Re: [openssl-dev] [openssl-commits] [openssl] master update ("Add Camellia CTR mode", dda8199922f9d52087d2c41b22a61eb4f9671385)
>> diff --git a/crypto/evp/c_allc.c b/crypto/evp/c_allc.c >> index 174a419..7ae36d7 100644 >> --- a/crypto/evp/c_allc.c >> +++ b/crypto/evp/c_allc.c >> @@ -245,5 +245,8 @@ void OpenSSL_add_all_ciphers(void) >> EVP_add_cipher(EVP_camellia_256_ofb()); >> EVP_add_cipher_alias(SN_camellia_256_cbc, "CAMELLIA256"); >> EVP_add_cipher_alias(SN_camellia_256_cbc, "camellia256"); >> +EVP_add_cipher(EVP_camellia_128_ctr()); >> +EVP_add_cipher(EVP_camellia_192_ctr()); >> +EVP_add_cipher(EVP_camellia_256_ctr()); >> #endif >> } > > We get build warnings and crashes during run in EVP_add_cipher(). Thanks. I'm on it. Out of curiosity, with which config do you get crashes? I don't mean that this doesn't need fixing, I only want to have a reference. ___ openssl-dev mailing list To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev
Re: [openssl-dev] [openssl-commits] [openssl] master update ("Add Camellia CTR mode", dda8199922f9d52087d2c41b22a61eb4f9671385)
Am 11.02.2015 um 20:30 schrieb Andy Polyakov: The branch master has been updated via dda8199922f9d52087d2c41b22a61eb4f9671385 (commit) via c79e17731f462d6d42b917027a7085c0f59a2214 (commit) from b7c9187b32a14b5b4a850161aed5c044d2130d5a (commit) - Log - commit dda8199922f9d52087d2c41b22a61eb4f9671385 Author: Andy Polyakov Date: Wed Feb 11 20:30:13 2015 +0100 Add Camellia CTR mode. Reviewed-by: Rich Salz ... --- Summary of changes: crypto/evp/c_allc.c|3 ++ crypto/evp/e_camellia.c|9 ++--- crypto/evp/evptests.txt| 64 ++ crypto/objects/obj_dat.h | 82 +--- crypto/objects/obj_mac.h | 60 crypto/objects/obj_mac.num | 12 +++ crypto/objects/objects.txt | 12 +++ 7 files changed, 231 insertions(+), 11 deletions(-) diff --git a/crypto/evp/c_allc.c b/crypto/evp/c_allc.c index 174a419..7ae36d7 100644 --- a/crypto/evp/c_allc.c +++ b/crypto/evp/c_allc.c @@ -245,5 +245,8 @@ void OpenSSL_add_all_ciphers(void) EVP_add_cipher(EVP_camellia_256_ofb()); EVP_add_cipher_alias(SN_camellia_256_cbc, "CAMELLIA256"); EVP_add_cipher_alias(SN_camellia_256_cbc, "camellia256"); +EVP_add_cipher(EVP_camellia_128_ctr()); +EVP_add_cipher(EVP_camellia_192_ctr()); +EVP_add_cipher(EVP_camellia_256_ctr()); #endif } We get build warnings and crashes during run in EVP_add_cipher(). It seems EVP_camellia_128_ctr(), EVP_camellia_192_ctr() and EVP_camellia_256_ctr() are missing from crypto/evp/evp.h: c_allc.c:248:5: warning: implicit declaration of function "EVP_camellia_128_ctr" [-Wimplicit-function-declaration] EVP_add_cipher(EVP_camellia_128_ctr()); etc. Thanks, Rainer ___ openssl-dev mailing list To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev
