[openssl-dev] [openssl.org #4458] "implicitly declared function" warnings due to missing include

2016-06-01 Thread Richard Levitte via RT
This has been fixed in commit 7233bea263

Closing this ticket.

Cheers,
Richard

On Wed May 25 21:46:01 2016, levitte wrote:
> I don't get such warnings. Can you tell me what system and with what
> tool chain
> (including versions)?
>
> On Sun Mar 20 13:07:43 2016, noloa...@gmail.com wrote:
> > The missing  include caused a number of "implicitly
> > declared function" warnings due to use of strcmpcase and strncmpcase.
> >
> > $ egrep -IR '(strcasecmp|strncasecmp)' * | cut -f 1 -d ':' | sort |
> > uniq
> > apps/apps.c
> > apps/ca.c
> > apps/ocsp.c
> > apps/rehash.c
> > apps/s_server.c
> > crypto/asn1/ameth_lib.c
> > crypto/engine/tb_asnmth.c
> > crypto/o_str.c
> > crypto/x509v3/v3_ncons.c
> > crypto/x509v3/v3_tlsf.c
> > crypto/x509v3/v3_utl.c
> > e_os.h
> > include/internal/o_str.h
> > ssl/ssl_conf.c
> > test/ssltest.c
> > test/v3nametest.c
> >
>
>
> --
> Richard Levitte
> levi...@openssl.org


--
Richard Levitte
levi...@openssl.org

-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4458
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev


Re: [openssl-dev] [openssl.org #4458] "implicitly declared function" warnings due to missing include

2016-05-25 Thread Viktor Dukhovni
On Wed, May 25, 2016 at 09:46:02PM +, Richard Levitte via RT wrote:

> I don't get such warnings. Can you tell me what system and with what tool 
> chain
> (including versions)?

I think that the report is correct, we must be getting away with 
on most platforms.  On NetBSD, for example,  includes 
when _NETBSD_SOURCE is defined true, which requires:

#if !defined(_ANSI_SOURCE) && !defined(_POSIX_C_SOURCE) && \
!defined(_XOPEN_SOURCE) && !defined(_NETBSD_SOURCE)
#define _NETBSD_SOURCE 1
#endif

So generally you get the extended features, but not always.  The
fix might be:

diff --git a/e_os.h b/e_os.h
index 1c4c204..4b3e6fd 100644
--- a/e_os.h
+++ b/e_os.h
@@ -475,6 +475,8 @@ struct servent *PASCAL getservbyname(const char *, const 
char *);
 #  define strcasecmp OPENSSL_strcasecmp
 #  define strncasecmp OPENSSL_strncasecmp
 #  define OPENSSL_IMPLEMENTS_strncasecmp
+# else
+#  include 
 # endif
 
 /* vxworks */

-- 
Viktor.
-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev


[openssl-dev] [openssl.org #4458] "implicitly declared function" warnings due to missing include

2016-05-25 Thread Richard Levitte via RT
I don't get such warnings. Can you tell me what system and with what tool chain
(including versions)?

On Sun Mar 20 13:07:43 2016, noloa...@gmail.com wrote:
> The missing  include caused a number of "implicitly
> declared function" warnings due to use of strcmpcase and strncmpcase.
>
> $ egrep -IR '(strcasecmp|strncasecmp)' * | cut -f 1 -d ':' | sort | uniq
> apps/apps.c
> apps/ca.c
> apps/ocsp.c
> apps/rehash.c
> apps/s_server.c
> crypto/asn1/ameth_lib.c
> crypto/engine/tb_asnmth.c
> crypto/o_str.c
> crypto/x509v3/v3_ncons.c
> crypto/x509v3/v3_tlsf.c
> crypto/x509v3/v3_utl.c
> e_os.h
> include/internal/o_str.h
> ssl/ssl_conf.c
> test/ssltest.c
> test/v3nametest.c
>


--
Richard Levitte
levi...@openssl.org

-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4458
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev


[openssl-dev] [openssl.org #4458] "implicitly declared function" warnings due to missing include

2016-03-20 Thread noloa...@gmail.com via RT
The missing  include caused a number of "implicitly
declared function" warnings due to use of strcmpcase and strncmpcase.

$ egrep -IR '(strcasecmp|strncasecmp)' * | cut -f 1 -d ':' | sort | uniq
apps/apps.c
apps/ca.c
apps/ocsp.c
apps/rehash.c
apps/s_server.c
crypto/asn1/ameth_lib.c
crypto/engine/tb_asnmth.c
crypto/o_str.c
crypto/x509v3/v3_ncons.c
crypto/x509v3/v3_tlsf.c
crypto/x509v3/v3_utl.c
e_os.h
include/internal/o_str.h
ssl/ssl_conf.c
test/ssltest.c
test/v3nametest.c


-- 
Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4458
Please log in as guest with password guest if prompted

-- 
openssl-dev mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev