[openssl.org #3216] Invalid shell syntax == in test/testssl (only 0.9.8 and 1.0.0)

[Tim Hudson via RT]

On Tue Jan 07 09:26:25 2014, rainer.j...@kippdata.de wrote:
 File test/testssl in branches 0.9.8 and 1.0.0 contains the line

 if [ $protocol == SSLv3 ] ; then

Closed as resolved.

SteveH committed fixes.
https://github.com/openssl/openssl/commit/080ae6843299c873808c04487d4ccf51624fe618

Tim

__
OpenSSL Project http://www.openssl.org
Development Mailing List   openssl-dev@openssl.org
Automated List Manager   majord...@openssl.org

[openssl.org #3216] Invalid shell syntax == in test/testssl (only 0.9.8 and 1.0.0)

[Rainer Jung via RT]

File test/testssl in branches 0.9.8 and 1.0.0 contains the line

if [ $protocol == SSLv3 ] ; then

for 1.0.1, 1.0.2 and master it is:

if [ $protocol = SSLv3 ] ; then

The script is executed by /bin/sh and the == syntax is not supported
for all basic shells, e.g. not on Solaris. Other parts of the script use
the = syntax for all versions, so please adjust == to = in
test/testssl for 0.9.8 and 1.0.0:

Patch for 0.9.8:

diff -u test/testssl test/testssl
--- test/testssl2014-01-06 23:24:16.465594000 +0100
+++ test/testssl2014-01-06 23:26:52.817292000 +0100
@@ -125,7 +125,7 @@
   for cipher in `../util/shlib_wrap.sh ../apps/openssl ciphers
RSA+$protocol | tr ':' ' '`; do
 echo Testing $cipher
 prot=
-if [ $protocol == SSLv3 ] ; then
+if [ $protocol = SSLv3 ] ; then
   prot=-ssl3
 fi
 $ssltest -cipher $cipher $prot

Patch for 1.0.0:

diff -u test/testssl test/testssl
--- test/testssl2014-01-06 23:24:39.614747000 +0100
+++ test/testssl2014-01-06 23:26:55.834853000 +0100
@@ -125,7 +125,7 @@
   for cipher in `../util/shlib_wrap.sh ../apps/openssl ciphers
RSA+$protocol | tr ':' ' '`; do
 echo Testing $cipher
 prot=
-if [ $protocol == SSLv3 ] ; then
+if [ $protocol = SSLv3 ] ; then
   prot=-ssl3
 fi
 $ssltest -cipher $cipher $prot


Thanks,

Rainer

__
OpenSSL Project http://www.openssl.org
Development Mailing List   openssl-dev@openssl.org
Automated List Manager   majord...@openssl.org