RE: OpenSSL version 1.0.1g v. VMS

2014-04-07 Thread Zoltan Arpadffy 
Right approach Steven.

Mea culpa :(
I am terribly sorry proposing ignorance of MAYLOSEDATA3 while not testing on
older compilers.

Thank you.
Regards,
Z  

-Original Message-
From: owner-openssl-...@openssl.org [mailto:owner-openssl-...@openssl.org]
On Behalf Of Steven M. Schweda
Sent: den 8 april 2014 05:12
To: openssl-dev@openssl.org
Subject: Re: OpenSSL version 1.0.1g v. VMS

From: "Dr. Stephen Henson" 

> Patch applied. Let me know of any problems.

   Thanks.  Sadly, I forgot one refinement, which would keep the warning
from the test out of the log.  If I could talk you into smoothing over that
blunder, then I'd be able to rest easy (for a while).

--- ssl/ssl-lib.com;-1  2014-04-07 15:18:26 -0500
+++ ssl/ssl-lib.com 2014-04-07 18:26:49 -0500
@@ -1024,6 +1024,8 @@
 $   THEN
 $!Not all compiler versions support MAYLOSEDATA3.
 $ OPT_TEST = "MAYLOSEDATA3"
+$ DEFINE /USER_MODE SYS$ERROR NL:
+$ DEFINE /USER_MODE SYS$OUTPUT NL:
 $ 'CC' /NOCROSS_REFERENCE /NOLIST /NOOBJECT -
/WARNINGS = DISABLE = ('OPT_TEST', EMPTYFILE) NL:
 $ IF ($SEVERITY)

   Sorry about the extra bother.


   For the record (no action required (or even requested)), the only
remaining compiler warnings were:

if (timeleft.tv_sec < 0) ^
%CC-I-QUESTCOMPARE, In this statement, the unsigned expression
"timeleft.tv_sec" is being compared with a relational operator to a
constant whose value is not greater than zero.  This might not be what  you
intended.
at line number 310 in file
ALP$DKC100:[UTILITY.SOURCE.OPENSSL.openssl-1_0_1g.crypto.bio]bss_dgram.c;1

   Around here, time_t tends to be unsigned.


if (*outlen <= 0)
^
%CC-I-QUESTCOMPARE, In this statement, the unsigned expression "*outlen"
is being compared with a relational operator to a constant whose value is
not greater than zero.  This might not be what you intended.
at line number 180 in file
ALP$DKC100:[UTILITY.SOURCE.OPENSSL.openssl-1_0_1g.engines.ccgost]gost94_keyx
.c;1

   Around here, size_t tends to be unsigned.


if (size <= 0 || ((len = data[0])) != (size -1))
^ %CC-I-QUESTCOMPARE, In this statement, the
unsigned expression "size" is  being compared with a relational operator to
a constant whose value is  not greater than zero.  This might not be what
you intended.
at line number 1128 in file
ALP$DKC100:[UTILITY.SOURCE.OPENSSL.openssl-1_0_1g.ssl]t1_lib.c;1

   Here, "size" seems to be declared as unsigned:
unsigned short size;
making the "< 0" part of that test pointless everywhere.

   These are all Informational ("-I-") complaints, so they cause less
trouble than a real warning ("-W-").



   Steven M. Schweda   sms@antinode-info
   382 South Warwick Street(+1) 651-699-9818
   Saint Paul  MN  55105-2547
__
OpenSSL Project http://www.openssl.org
Development Mailing List   openssl-dev@openssl.org
Automated List Manager   majord...@openssl.org

__
OpenSSL Project http://www.openssl.org
Development Mailing List   openssl-dev@openssl.org
Automated List Manager   majord...@openssl.org

Re: OpenSSL version 1.0.1g v. VMS

2014-04-07 Thread Steven M. Schweda 
From: "Dr. Stephen Henson" 

> Patch applied. Let me know of any problems.

   Thanks.  Sadly, I forgot one refinement, which would keep the warning
from the test out of the log.  If I could talk you into smoothing over
that blunder, then I'd be able to rest easy (for a while).

--- ssl/ssl-lib.com;-1  2014-04-07 15:18:26 -0500
+++ ssl/ssl-lib.com 2014-04-07 18:26:49 -0500
@@ -1024,6 +1024,8 @@
 $   THEN
 $!Not all compiler versions support MAYLOSEDATA3.
 $ OPT_TEST = "MAYLOSEDATA3"
+$ DEFINE /USER_MODE SYS$ERROR NL:
+$ DEFINE /USER_MODE SYS$OUTPUT NL:
 $ 'CC' /NOCROSS_REFERENCE /NOLIST /NOOBJECT -
/WARNINGS = DISABLE = ('OPT_TEST', EMPTYFILE) NL:
 $ IF ($SEVERITY)

   Sorry about the extra bother.


   For the record (no action required (or even requested)), the only
remaining compiler warnings were:

if (timeleft.tv_sec < 0)
^
%CC-I-QUESTCOMPARE, In this statement, the unsigned expression
 "timeleft.tv_sec" is being compared with a relational operator to a
 constant whose value is not greater than zero.  This might not be what
 you intended.
at line number 310 in file 
ALP$DKC100:[UTILITY.SOURCE.OPENSSL.openssl-1_0_1g.crypto.bio]bss_dgram.c;1

   Around here, time_t tends to be unsigned.


if (*outlen <= 0)
^
%CC-I-QUESTCOMPARE, In this statement, the unsigned expression "*outlen"
is being compared with a relational operator to a constant whose value
is not greater than zero.  This might not be what you intended.
at line number 180 in file
ALP$DKC100:[UTILITY.SOURCE.OPENSSL.openssl-1_0_1g.engines.ccgost]gost94_keyx.c;1

   Around here, size_t tends to be unsigned.


if (size <= 0 || ((len = data[0])) != (size -1))
^
%CC-I-QUESTCOMPARE, In this statement, the unsigned expression "size" is
 being compared with a relational operator to a constant whose value is
 not greater than zero.  This might not be what you intended.
at line number 1128 in file
ALP$DKC100:[UTILITY.SOURCE.OPENSSL.openssl-1_0_1g.ssl]t1_lib.c;1

   Here, "size" seems to be declared as unsigned:
unsigned short size;
making the "< 0" part of that test pointless everywhere.

   These are all Informational ("-I-") complaints, so they cause less
trouble than a real warning ("-W-").



   Steven M. Schweda   sms@antinode-info
   382 South Warwick Street(+1) 651-699-9818
   Saint Paul  MN  55105-2547
__
OpenSSL Project http://www.openssl.org
Development Mailing List   openssl-dev@openssl.org
Automated List Manager   majord...@openssl.org

Re: OpenSSL version 1.0.1g v. VMS

2014-04-07 Thread Dr. Stephen Henson 
On Mon, Apr 07, 2014, Steven M. Schweda wrote:

> >OpenSSL version 1.0.1g released
> 
>A relatively recent change to the VMS builders causes trouble for
> folks who lack the latest compiler.  Using "HP C V7.3-009 on OpenVMS
> Alpha V8.3" or "HP C V7.3-019 on OpenVMS IA64 V8.3-1H1", for example:
> 
> [...]
> s2_meth.c
> 
> %CC-W-UNKMSGID, Unknown message id or group "MAYLOSEDATA3" is ignored.
> %LIBRAR-W-COMCOD, compilation warnings in module S2_METH file
> ALP$DKC100:[UTILITY.SOURCE.OPENSSL.openssl-1_0_1g.ALPHA.OBJ.SSL]s2_meth.OBJ;1
> [...]
> %LINK-W-WRNERS, compilation warnings  in module S2_METH file
> ALP$DKC100:[UTILITY.SOURCE.OPENSSL.openssl-1_0_1g.ALPHA.EXE.SSL]SSL_LIBSSL32.OLB;1
> [...]
> 
>I see about 48 of the %CC-W-UNKMSGID, 47 of the %LIBRAR-W-COMCOD, and
> 157 of the %LINK-W-WRNERS.  This is annoying.  I propose a change to
> suppress "MAYLOSEDATA3" warnings only if the compiler recognizes it:
> 

Patch applied. Let me know of any problems.

Steve.
--
Dr Stephen N. Henson. OpenSSL project core developer.
Commercial tech support now available see: http://www.openssl.org
__
OpenSSL Project http://www.openssl.org
Development Mailing List   openssl-dev@openssl.org
Automated List Manager   majord...@openssl.org