Re: Will this change causes lock up?
Zhichao Hong wrote:
I have sent email about a client hangs when trying to communicating
with server using 0.9.7e version of the openssl. When looking into the
debugger stack trace, the ssl3_read_n blocks forever in the s3_pkt.c.
When I browsed the cvs change history, the following issue was fixed
later in Nov 2006. I am wondering without the fix (i.e. setting
s-first_packet to 0), will it cause some kind of locked up?
--- s3_pkt.c 2004/05/15 17:46:50 1.46.2.7
+++ s3_pkt.c 2006/11/29 14:44:07 1.46.2.8
@@ -275,11 +275,7 @@
n2s(p,rr-length);
/* Lets check version */
- if (s-first_packet)
- {
- s-first_packet=0;
- }
- else
+ if (!s-first_packet)
{
if (version != s-version)
{
Any insight will be very appreciated
Hmm, the full commit is at
http://cvs.openssl.org/chngview?cn=15686
Best regards,
Lutz
__
OpenSSL Project http://www.openssl.org
Development Mailing List openssl-dev@openssl.org
Automated List Manager [EMAIL PROTECTED]
Re: Will this change causes lock up?
Thank you, Lutz, for the change set information! I have to admit that
I am not a power user of the openssl at the source level. We are not
controlling the server as it is a standard IIS HTTPS. The software
is using openssl library on top of openbsd stack. So do you know what
is the impact on the client side if the fix are not applied?
Best regards,
Zhichao
On Fri, Apr 18, 2008 at 3:57 AM, Lutz Jaenicke [EMAIL PROTECTED] wrote:
Zhichao Hong wrote:
I have sent email about a client hangs when trying to communicating
with server using 0.9.7e version of the openssl. When looking into the
debugger stack trace, the ssl3_read_n blocks forever in the s3_pkt.c.
When I browsed the cvs change history, the following issue was fixed
later in Nov 2006. I am wondering without the fix (i.e. setting
s-first_packet to 0), will it cause some kind of locked up?
--- s3_pkt.c 2004/05/15 17:46:50 1.46.2.7
+++ s3_pkt.c 2006/11/29 14:44:07 1.46.2.8
@@ -275,11 +275,7 @@
n2s(p,rr-length);
/* Lets check version */
- if (s-first_packet)
- {
- s-first_packet=0;
- }
- else
+ if (!s-first_packet)
{
if (version != s-version)
{
Any insight will be very appreciated
Hmm, the full commit is at
http://cvs.openssl.org/chngview?cn=15686
Best regards,
Lutz
__
OpenSSL Project http://www.openssl.org
Development Mailing List openssl-dev@openssl.org
Automated List Manager [EMAIL PROTECTED]
--
Zhichao Hong, CSDP
[EMAIL PROTECTED]
__
OpenSSL Project http://www.openssl.org
Development Mailing List openssl-dev@openssl.org
Automated List Manager [EMAIL PROTECTED]
Re: Will this change causes lock up?
Zhichao Hong wrote: Thank you, Lutz, for the change set information! I have to admit that I am not a power user of the openssl at the source level. We are not controlling the server as it is a standard IIS HTTPS. The software is using openssl library on top of openbsd stack. So do you know what is the impact on the client side if the fix are not applied? If I would have understood the impact I would have explained :-) . I did checkout the mailing lists around the date of commit and did not find any statement regarding this change. Sorry, Lutz __ OpenSSL Project http://www.openssl.org Development Mailing List openssl-dev@openssl.org Automated List Manager [EMAIL PROTECTED]
Re: Will this change causes lock up?
Lutz, Thank you for helping look into this anyway. I did not find any comment either. Maybe the best way is try out the fix for a while anyway. Thanks again, Zhichao On Fri, Apr 18, 2008 at 7:04 AM, Lutz Jaenicke [EMAIL PROTECTED] wrote: Zhichao Hong wrote: Thank you, Lutz, for the change set information! I have to admit that I am not a power user of the openssl at the source level. We are not controlling the server as it is a standard IIS HTTPS. The software is using openssl library on top of openbsd stack. So do you know what is the impact on the client side if the fix are not applied? If I would have understood the impact I would have explained :-) . I did checkout the mailing lists around the date of commit and did not find any statement regarding this change. Sorry, Lutz __ OpenSSL Project http://www.openssl.org Development Mailing List openssl-dev@openssl.org Automated List Manager [EMAIL PROTECTED] -- Zhichao Hong, CSDP [EMAIL PROTECTED] __ OpenSSL Project http://www.openssl.org Development Mailing List openssl-dev@openssl.org Automated List Manager [EMAIL PROTECTED]
