Re: Additional things for deprecation

2020-10-13 Thread Richard Levitte
Hmmm, are we going to start marking types for deprecation?  I would
advise against it on a general level, 'cause that's likely to cause an
implosion.  See for example marking ENGINE for deprecation, i.e. this:

diff --git a/include/openssl/types.h b/include/openssl/types.h
index ee024cef29..4e73c0dc0d 100644
--- a/include/openssl/types.h
+++ b/include/openssl/types.h
@@ -172,7 +172,9 @@ typedef struct ossl_init_settings_st OPENSSL_INIT_SETTINGS;
 typedef struct ui_st UI;
 typedef struct ui_method_st UI_METHOD;
 
-typedef struct engine_st ENGINE;
+# ifndef OPENSSL_NO_DEPRECATED_3_0
+OSSL_DEPRECATEDIN_3_0 typedef struct engine_st ENGINE;
+# endif
 typedef struct ssl_st SSL;
 typedef struct ssl_ctx_st SSL_CTX;
 

Try that and see your build become...  interesting.

Cheers,
Richard

On Tue, 13 Oct 2020 11:40:37 +0200,
Tim Hudson wrote:
> 
> In a 3.0 context, EVP_PKEY_ASN1_METHOD and all the associated functions 
> should be marked
> deprecated in my view.
> 
> Tim.
-- 
Richard Levitte levi...@openssl.org
OpenSSL Project http://www.openssl.org/~levitte/


Additional things for deprecation

2020-10-13 Thread Tim Hudson
In a 3.0 context, EVP_PKEY_ASN1_METHOD and all the associated functions
should be marked deprecated in my view.

Tim.