RE: Beta1 PR deadline

[Dr. Matthias St. Pierre]

> > For a more accurate and timely public overview over the current state of 
> > the blockers,
> > it might be helpful to manage them via the 3.0.0  milestone
> >
> > https://github.com/openssl/openssl/milestone/15
> >
> > Some of the tickets listed below were already associated to the milestone, 
> > the others
> > were added by me now.
> 
> I think the 3.0.0 milestone is what we expect to be in the
> 3.0.0 release, not the beta release. That is bug fixes don't need
> to be in the beta release, but if it adds new functionallity it
> needs to be in the beta release.

I was aware of this subtlety but I thought that we just could (ab-)use the 
milestone for
the beta1 release and reuse it later for the final release, instead of creating 
a new milestone.

Practically all of the relevant PRs are associated to the [3.0 New Core + FIPS] 
GitHub Project
anyway, so it would be possible to remove the post-beta PRs from the milestone 
and restore
them later.  (In my mind, I see project managers running away screeming...)

Matthias


[3.0 New Core + FIPS]:  https://github.com/openssl/openssl/projects/2

Re: Beta1 PR deadline

[Kurt Roeckx]

On Fri, Sep 11, 2020 at 11:07:48AM +, Dr. Matthias St. Pierre wrote:
> For a more accurate and timely public overview over the current state of the 
> blockers,
> it might be helpful to manage them via the 3.0.0  milestone 
> 
> https://github.com/openssl/openssl/milestone/15
> 
> Some of the tickets listed below were already associated to the milestone, 
> the others
> were added by me now.

I think the 3.0.0 milestone is what we expect to be in the 
3.0.0 release, not the beta release. That is bug fixes don't need
to be in the beta release, but if it adds new functionallity it
needs to be in the beta release.


Kurt

RE: Beta1 PR deadline

[Dr. Matthias St. Pierre]

For a more accurate and timely public overview over the current state of the 
blockers,
it might be helpful to manage them via the 3.0.0  milestone 

https://github.com/openssl/openssl/milestone/15

Some of the tickets listed below were already associated to the milestone, the 
others
were added by me now.

Just a suggestion.

Matthias



> -Original Message-
> From: openssl-project  On Behalf Of Matt 
> Caswell
> Sent: Thursday, September 10, 2020 1:24 PM
> To: openssl-project@openssl.org
> Subject: Re: Beta1 PR deadline
> 
> 
> 
> On 10/09/2020 11:40, Matt Caswell wrote:
> >
> >
> > On 09/09/2020 13:03, Kurt Roeckx wrote:
> >> On Wed, Aug 26, 2020 at 04:58:26PM +0100, Matt Caswell wrote:
> >>> Please can anyone with PRs that they wish to have included in OpenSSL
> >>> 3.0 beta1 ensure that they are merged to master by 8th September.
> >>
> >> So that date has passed now. Can someone give an overview of what
> >> we think is still needed to be done before the beta 1 release? Are
> >> there open PRs for everything? Do we a milestone on github to
> >> indicate which PRs need to go in before beta1?
> >
> >
> > I believe the "blockers" to be:
> >
> > https://github.com/openssl/openssl/pull/12536
> > https://github.com/openssl/openssl/pull/12754
> > https://github.com/openssl/openssl/pull/12750
> > https://github.com/openssl/openssl/pull/12781
> > https://github.com/openssl/openssl/pull/12801
> >
> > Aside from these there are potential PRs not yet opened but slated for
> > beta1 regarding:
> > - Refactor serialization? (owner: Richard)
> > - lhash refactor? (owner: Me)
> > - IG D.9 update? (owner: Shane)
> 
> Oh, I think this last one might be:
> 
> https://github.com/openssl/openssl/pull/12835
> 
> Matt
> 
> >
> > There's also this issue - but I'm not sure that it needs to be resolved
> > for beta1:
> > https://github.com/openssl/openssl/issues/12195
> >
> > Matt
> >

Re: Beta1 PR deadline

[Dr Paul Dale]

Shane has done the IG D.9 work: it is in #12835 and is awaiting review.  I 
think it should be in beta if possible.  It’s mostly adding a second test case 
due to NIST changing guidance recently, so low risk and helpful for the lab.

As Shane notes in 12801, there will be some conflicts generated over the FIPS 
error handling and self tests, hopefully they won’t slow progress.

12754 could be considered optional and something better should likely be done 
for 3.1 that what I’m planning there.  With RAND_DRBG removed, there is nothing 
remotely comparable.  Even RAND_DRBG is a bit of a stretch as a comparison.


The API renaming discussion *must* reach a conclusion before beta.


Pauli
-- 
Dr Paul Dale | Distinguished Architect | Cryptographic Foundations 
Phone +61 7 3031 7217
Oracle Australia




> On 10 Sep 2020, at 8:40 pm, Matt Caswell  wrote:
> 
> 
> 
> On 09/09/2020 13:03, Kurt Roeckx wrote:
>> On Wed, Aug 26, 2020 at 04:58:26PM +0100, Matt Caswell wrote:
>>> Please can anyone with PRs that they wish to have included in OpenSSL
>>> 3.0 beta1 ensure that they are merged to master by 8th September.
>> 
>> So that date has passed now. Can someone give an overview of what
>> we think is still needed to be done before the beta 1 release? Are
>> there open PRs for everything? Do we a milestone on github to
>> indicate which PRs need to go in before beta1?
> 
> 
> I believe the "blockers" to be:
> 
> https://urldefense.com/v3/__https://github.com/openssl/openssl/pull/12536__;!!GqivPVa7Brio!O5gzpHuWIANvRtRYOHA9m7SK4SqMUb2uLzEGQbUrX9nFSRhT7-sA0F-JQc5z_l4$
>  
> https://urldefense.com/v3/__https://github.com/openssl/openssl/pull/12754__;!!GqivPVa7Brio!O5gzpHuWIANvRtRYOHA9m7SK4SqMUb2uLzEGQbUrX9nFSRhT7-sA0F-JseFWMvQ$
>  
> https://urldefense.com/v3/__https://github.com/openssl/openssl/pull/12750__;!!GqivPVa7Brio!O5gzpHuWIANvRtRYOHA9m7SK4SqMUb2uLzEGQbUrX9nFSRhT7-sA0F-J0OAUQ5s$
>  
> https://urldefense.com/v3/__https://github.com/openssl/openssl/pull/12781__;!!GqivPVa7Brio!O5gzpHuWIANvRtRYOHA9m7SK4SqMUb2uLzEGQbUrX9nFSRhT7-sA0F-JYPbPTZA$
>  
> https://urldefense.com/v3/__https://github.com/openssl/openssl/pull/12801__;!!GqivPVa7Brio!O5gzpHuWIANvRtRYOHA9m7SK4SqMUb2uLzEGQbUrX9nFSRhT7-sA0F-J_mL-S18$
>  
> 
> Aside from these there are potential PRs not yet opened but slated for
> beta1 regarding:
> - Refactor serialization? (owner: Richard)
> - lhash refactor? (owner: Me)
> - IG D.9 update? (owner: Shane)
> 
> There's also this issue - but I'm not sure that it needs to be resolved
> for beta1:
> https://urldefense.com/v3/__https://github.com/openssl/openssl/issues/12195__;!!GqivPVa7Brio!O5gzpHuWIANvRtRYOHA9m7SK4SqMUb2uLzEGQbUrX9nFSRhT7-sA0F-J1-VRwBk$
>  
> 
> Matt

Re: Beta1 PR deadline

[Matt Caswell]

On 10/09/2020 11:40, Matt Caswell wrote:
> 
> 
> On 09/09/2020 13:03, Kurt Roeckx wrote:
>> On Wed, Aug 26, 2020 at 04:58:26PM +0100, Matt Caswell wrote:
>>> Please can anyone with PRs that they wish to have included in OpenSSL
>>> 3.0 beta1 ensure that they are merged to master by 8th September.
>>
>> So that date has passed now. Can someone give an overview of what
>> we think is still needed to be done before the beta 1 release? Are
>> there open PRs for everything? Do we a milestone on github to
>> indicate which PRs need to go in before beta1?
> 
> 
> I believe the "blockers" to be:
> 
> https://github.com/openssl/openssl/pull/12536
> https://github.com/openssl/openssl/pull/12754
> https://github.com/openssl/openssl/pull/12750
> https://github.com/openssl/openssl/pull/12781
> https://github.com/openssl/openssl/pull/12801
> 
> Aside from these there are potential PRs not yet opened but slated for
> beta1 regarding:
> - Refactor serialization? (owner: Richard)
> - lhash refactor? (owner: Me)
> - IG D.9 update? (owner: Shane)

Oh, I think this last one might be:

https://github.com/openssl/openssl/pull/12835

Matt

> 
> There's also this issue - but I'm not sure that it needs to be resolved
> for beta1:
> https://github.com/openssl/openssl/issues/12195
> 
> Matt
> 

Re: Beta1 PR deadline

[David von Oheimb]

Hi Matt et al.,

thanks to good collaboration with OTC members I've been able to get approved
most of my open PRs that would be good be included before feature freeze,
while a few such PRs appear 'nearly' approved.

Given the 24-hours grace period, the PRs #12478
, #12741
, and #12769
 won't make it today,
or is there a chance to still get them into beta1 a little later?

    David

On 26.08.20 17:58, Matt Caswell wrote:
> Hi all
>
> The OMC had a meeting today.
>
> Please can anyone with PRs that they wish to have included in OpenSSL
> 3.0 beta1 ensure that they are merged to master by 8th September.
>
> Note in particular that there is no PR at the moment to incorporate SM2
> asymmetric encryption into OpenSSL 3.0. This feature currently exists in
> 1.1.1, so if no PR emerges by the above date then this feature is liable
> to be dropped in 3.0. (Note: PRs for SM2 signatures *do* exist and are
> expected to be present).
>
>
> Matt
>
>

Re: Beta1 PR deadline

[David von Oheimb]

Hi Matt et al.,

thanks to good collaboration with OTC members I've been able to get approved
most of my open PRs that would be good be included before feature freeze,
while a few such PRs appear 'nearly' approved.

Given the 24-hours grace period, the PRs #12478
, #12741
, and #12769
 won't make it today,
or is there a chance to still get them into beta1 a little later?

    David

On 26.08.20 17:58, Matt Caswell wrote:
> Hi all
>
> The OMC had a meeting today.
>
> Please can anyone with PRs that they wish to have included in OpenSSL
> 3.0 beta1 ensure that they are merged to master by 8th September.
>
> Note in particular that there is no PR at the moment to incorporate SM2
> asymmetric encryption into OpenSSL 3.0. This feature currently exists in
> 1.1.1, so if no PR emerges by the above date then this feature is liable
> to be dropped in 3.0. (Note: PRs for SM2 signatures *do* exist and are
> expected to be present).
>
>
> Matt
>
>

Re: Beta1 PR deadline

[David von Oheimb]

On 09.09.20 14:03, Kurt Roeckx wrote:
> On Wed, Aug 26, 2020 at 04:58:26PM +0100, Matt Caswell wrote:
>> Please can anyone with PRs that they wish to have included in OpenSSL
>> 3.0 beta1 ensure that they are merged to master by 8th September.
> So that date has passed now. Can someone give an overview of what
> we think is still needed to be done before the beta 1 release?
> Are there open PRs for everything? Do we a milestone on github to
> indicate which PRs need to go in before beta1?
As far as my PRs are concerned (most of which have been related to some
extent to the CMP contribution):

Thanks to intensified exchange with OTC reviewers, everything that I see
urgent for inclusion before feature freeze
has either been merged already or meanwhile has been approved and is
going to be merged by tomorrow.

Just very few fixes/cleanups are not yet fully reviewed but I believe
they can still be handled during the beta phase.

    David

Re: Beta1 PR deadline

[Kurt Roeckx]

On Wed, Aug 26, 2020 at 04:58:26PM +0100, Matt Caswell wrote:
> Please can anyone with PRs that they wish to have included in OpenSSL
> 3.0 beta1 ensure that they are merged to master by 8th September.

So that date has passed now. Can someone give an overview of what
we think is still needed to be done before the beta 1 release? Are
there open PRs for everything? Do we a milestone on github to
indicate which PRs need to go in before beta1?


Kurt

Re: Beta1 PR deadline

[Salz, Rich]

>Please can anyone with PRs that they wish to have included in OpenSSL
3.0 beta1 ensure that they are merged to master by 8th September.

And how are non-committers supposed to do that

Re: Beta1 PR deadline

[Matt Caswell]

On 26/08/2020 17:02, Salz, Rich wrote:
>>Please can anyone with PRs that they wish to have included in OpenSSL
> 3.0 beta1 ensure that they are merged to master by 8th September.
> 
> And how are non-committers supposed to do that
> 

In the same way as normal. Ensure your PRs are raised asap, and
encourage committers/OTC to review them.

Matt

Re: Beta1 PR deadline

[Dr Paul Dale]

It is also worth noting that new features will not be accepted during the beta 
period.


Pauli
-- 
Dr Paul Dale | Distinguished Architect | Cryptographic Foundations 
Phone +61 7 3031 7217
Oracle Australia




> On 27 Aug 2020, at 1:58 am, Matt Caswell  wrote:
> 
> Hi all
> 
> The OMC had a meeting today.
> 
> Please can anyone with PRs that they wish to have included in OpenSSL
> 3.0 beta1 ensure that they are merged to master by 8th September.
> 
> Note in particular that there is no PR at the moment to incorporate SM2
> asymmetric encryption into OpenSSL 3.0. This feature currently exists in
> 1.1.1, so if no PR emerges by the above date then this feature is liable
> to be dropped in 3.0. (Note: PRs for SM2 signatures *do* exist and are
> expected to be present).
> 
> 
> Matt
> 
>