Re: [openssl-users] Error: does not have a number assigned

2018-11-27 Thread EYAL INBAR
Thanks
I add my functions to libcrypto.num at the end (32767 ,32766 ) as your
suggestions.

On Tue, Nov 27, 2018 at 5:28 PM Matthias St. Pierre <
matthias.st.pie...@ncp-e.com> wrote:

>
> Yes, that would be a good idea. Although it does not prevent merge conflicts, 
> at least the ordinals
>
> don't have to be renumbered every time. (That's the way we solved the problem 
> in our company.)
>
> On 27.11.18 15:58, Viktor Dukhovni wrote:
> >> On Nov 27, 2018, at 7:38 AM, Dr. Matthias St. Pierre <
> matthias.st.pie...@ncp-e.com> wrote:
> >>
> >> Short version: Just do 'make update' and the numbers will be added
> automagically.
> >>
> >> Long version:  There  is a script, 'util/mkdef.pl', which gets invoked
> by 'make update'. It scans the header files
> >> for new APIs an updates the .num files  (libcrypto.num/libeay.num and
> libssl.num) accordingly. For windows,
> >> it also  updates the module definition files (*.def).
> > It might be prudent for the OP to assign a high value that OpenSSL
> > will not likely ever reach. Start at 32767 and count down for site-local
> > ordinals?
> >
>
> --
> openssl-users mailing list
> To unsubscribe:
> https://urldefense.proofpoint.com/v2/url?u=https-3A__mta.openssl.org_mailman_listinfo_openssl-2Dusers=DwIGaQ=q3cDpHe1hF8lXU5EFjNM_A=I5-3pNwF1_nDoDkHWrLqDas1-D3ePObax4DniWovRNU=67uowHFQMvna-mV7bC97t3qPXNwPn3yAfoRq4pf7CBM=GhNc-o-KYTetX1mheDmt0ub7ilPFP5zqZujEznqQo-o=
>
-- 
openssl-users mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-users


Re: [openssl-users] Error: does not have a number assigned

2018-11-27 Thread Matthias St. Pierre

Yes, that would be a good idea. Although it does not prevent merge conflicts, 
at least the ordinals
don't have to be renumbered every time. (That's the way we solved the problem 
in our company.)

On 27.11.18 15:58, Viktor Dukhovni wrote:

On Nov 27, 2018, at 7:38 AM, Dr. Matthias St. Pierre 
 wrote:

Short version: Just do 'make update' and the numbers will be added 
automagically.

Long version:  There  is a script, 'util/mkdef.pl', which gets invoked by 'make 
update'. It scans the header files
for new APIs an updates the .num files  (libcrypto.num/libeay.num and 
libssl.num) accordingly. For windows,
it also  updates the module definition files (*.def).

It might be prudent for the OP to assign a high value that OpenSSL
will not likely ever reach. Start at 32767 and count down for site-local
ordinals?



--
openssl-users mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-users


Re: [openssl-users] Error: does not have a number assigned

2018-11-27 Thread Viktor Dukhovni
> On Nov 27, 2018, at 7:38 AM, Dr. Matthias St. Pierre 
>  wrote:
> 
> Short version: Just do 'make update' and the numbers will be added 
> automagically.
> 
> Long version:  There  is a script, 'util/mkdef.pl', which gets invoked by 
> 'make update'. It scans the header files
> for new APIs an updates the .num files  (libcrypto.num/libeay.num and 
> libssl.num) accordingly. For windows,
> it also  updates the module definition files (*.def).

It might be prudent for the OP to assign a high value that OpenSSL
will not likely ever reach. Start at 32767 and count down for site-local
ordinals?

-- 
Viktor.

-- 
openssl-users mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-users


Re: [openssl-users] Error: does not have a number assigned

2018-11-27 Thread Dr. Matthias St. Pierre
Short version: Just do 'make update' and the numbers will be added 
automagically.

Long version:  There  is a script, 'util/mkdef.pl', which gets invoked by 'make 
update'. It scans the header files
for new APIs an updates the .num files  (libcrypto.num/libeay.num and 
libssl.num) accordingly. For windows,
it also  updates the module definition files (*.def).
 
So 'make update' will add your new API function. But be warned: As Jakob 
already mentioned, if you update
OpenSSL it can happen that you get merge conflicts (if you use git) or your 
numbers will get overwritten
(if you extract tarballs). You will have to renumber you symbols (or remove 
them and run 'make update' again).

HTH,
Matthias


> -Ursprüngliche Nachricht-
> Von: openssl-users  Im Auftrag von Jakob 
> Bohm via openssl-users
> Gesendet: Dienstag, 27. November 2018 12:09
> An: openssl-users@openssl.org
> Betreff: Re: [openssl-users] Error: does not have a number assigned
> 
> On 27/11/2018 11:50, EYAL INBAR wrote:
> > Hello
> >
> > I try to add API,CMP_build_KUR_req, to crypto lib and get
> >
> > Error: CMP_build_KUR_req does not have a number assigned
> >
> > Any suggestion?
> This means you are compiling for a platform (probably Windows
> or OS/2) where names exported from DLLs are assigned unique
> numbers for fast lookup during application load.
> 
> There is a source file in OpenSSL giving the assigned numbers.
> You will need to add numbers for you additional exports, and
> deal with the risk that a future OpenSSL release uses that
> number for something else.
> 
> 
> Enjoy
> 
> Jakob
> --
> Jakob Bohm, CIO, Partner, WiseMo A/S.  https://www.wisemo.com
> Transformervej 29, 2860 Søborg, Denmark.  Direct +45 31 13 16 10
> This public discussion message is non-binding and may contain errors.
> WiseMo - Remote Service Management for PCs, Phones and Embedded
> 
> --
> openssl-users mailing list
> To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-users
-- 
openssl-users mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-users


Re: [openssl-users] Error: does not have a number assigned

2018-11-27 Thread Jakob Bohm via openssl-users

On 27/11/2018 11:50, EYAL INBAR wrote:

Hello

I try to add API,CMP_build_KUR_req, to crypto lib and get

Error: CMP_build_KUR_req does not have a number assigned

Any suggestion?

This means you are compiling for a platform (probably Windows
or OS/2) where names exported from DLLs are assigned unique
numbers for fast lookup during application load.

There is a source file in OpenSSL giving the assigned numbers.
You will need to add numbers for you additional exports, and
deal with the risk that a future OpenSSL release uses that
number for something else.


Enjoy

Jakob
--
Jakob Bohm, CIO, Partner, WiseMo A/S.  https://www.wisemo.com
Transformervej 29, 2860 Søborg, Denmark.  Direct +45 31 13 16 10
This public discussion message is non-binding and may contain errors.
WiseMo - Remote Service Management for PCs, Phones and Embedded

--
openssl-users mailing list
To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-users