Re: [Openstack] Working on fixing code after a review? Please mark merge proposal Work In Progress!

[Soren Hansen]

2011/2/25 Salvatore Orlando :
> I realized my previous mail was a bit unclear...
>
> I meant to say "can we avoid showing branches which are proposed to merge 
> into something different than lp:nova?"

Sure. On lp:nova's page[1], it says: 34 branches proposed for merging
into this one. "34 branches" is a link to a page[2] that shows merge
proposals for lp:nova.

[1]: https://code.launchpad.net/~hudson-openstack/nova/trunk (or run
bzr lp-open lp:nova)
[2]: https://code.launchpad.net/~hudson-openstack/nova/trunk/+activereviews

-- 
Soren Hansen
Ubuntu Developer    http://www.ubuntu.com/
OpenStack Developer http://www.openstack.org/

___
Mailing list: https://launchpad.net/~openstack
Post to : openstack@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openstack
More help   : https://help.launchpad.net/ListHelp

Re: [Openstack] multi_nic and mac addresses

[Ilya Alekseyev]

I think that new table for NIC mac addresses is good idea, but we need in
table not only instance id, but network id for interface too. It will be
good for implementation multi-nic in libvirt for example.
___
Mailing list: https://launchpad.net/~openstack
Post to : openstack@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openstack
More help   : https://help.launchpad.net/ListHelp

Re: [Openstack] Working on fixing code after a review? Please mark merge proposal Work In Progress!

[Jay Pipes]

On Fri, Feb 25, 2011 at 11:07 PM, Ewan Mellor  wrote:
> This is all great stuff Jay, but it's going to get lost if it's just in 
> email.  http://wiki.openstack.org/LifeWithBzrAndLaunchpad has some of this 
> on, but it's nothing like as clear and succinct as you've got it below.

Cheers.

> Could someone break out a "how peer reviews work" wiki page, and put this 
> content on it?  We really need these things to be nice clear steps so that 
> everyone knows what to expect.

Sure. I don't want to step on anything termie was doing, though. Andy,
did you have a link to the wiki page you were putting together about
reviewing? I'll add some thoughts to that.

-jay

>> -Original Message-
>> From: openstack-bounces+ewan.mellor=citrix@lists.launchpad.net
>> [mailto:openstack-bounces+ewan.mellor=citrix@lists.launchpad.net]
>> On Behalf Of Jay Pipes
>> Sent: 25 February 2011 10:07
>> To: openstack@lists.launchpad.net
>> Subject: [Openstack] Working on fixing code after a review? Please mark
>> merge proposal Work In Progress!
>>
>> Hey all,
>>
>> The backlog on code reviews continues to mount:
>> https://code.launchpad.net/nova/+activereviews
>>
>> One thing that would REALLY help reviewers is the following:
>>
>> If you receive one or more reviews that have asked for fixes to your
>> branch (Needs Fixing), and you agree to these fixes, please do the
>> following:
>>
>> * Write a quick comment on the merge proposal acknowledging the review
>> and stating you are working on fixing the branch
>> * Set the merge proposal status to Work In Progress
>>
>> When you do this, your branch gets removed from the list of merge
>> proposals that reviewers need to review (the link above), which helps
>> reviewers to identify which branches are truly in need of review and
>> which branches are actually being worked on after reviews.
>>
>> After you make the changes to your branch, please do the following:
>>
>> * bzr push your changes to Launchpad
>> * Go to your merge proposal and set the status back to Needs Review
>>
>> This will trigger:
>>
>> * Launchpad to regenerate the diff that is displayed for your branch
>> * Launchpad to email all prior reviewers to let them know they need to
>> re-review your branch
>>
>> Doing these simple steps will make reviewing dramatically easier; the
>> side-effect of that is reviews will be quicker and we can get through
>> this backlog.
>>
>> Thanks for listening,
>> jay
>>
>> ___
>> Mailing list: https://launchpad.net/~openstack
>> Post to     : openstack@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~openstack
>> More help   : https://help.launchpad.net/ListHelp
>

___
Mailing list: https://launchpad.net/~openstack
Post to : openstack@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openstack
More help   : https://help.launchpad.net/ListHelp

[Openstack] Using useful commit messages while merging code into trunk

[Christian Berendt]

Hi.

Sometimes there are very useless commit messages after merging a
propsal into trunk.

Example:

" 748. Did a pull from trunk to be sure I had the latest, then deleted
the test directory. I guess it appeared when I started using venv. Doh.
(detail)"

or my own:

" 747. reverted my changes from
https://code.launchpad.net/~berendt/nova/lp722554/+merge/50579 and
reused the existing db api methods to add the disabled services. Looks
much better now :)

i couldn't figure out how to uncommit and revert my changes in an
already pushed branch, always ending in "ERROR: These branches
have diverged.". So i created a new branch rev2 and a new
proposal... (detail)"

I think the problem is that per default the last commit message in the
branch is used.

We should always set a correct commit message in the merge propsal and
we should don't merge code with useless commit messages.

Bye, Christian.

***
Visit us at CeBIT 2011!
At our stand located in the Open Source Park in hall 2, booth-no.:
D44/133 we demonstrate "Virtual System Cluster" and "Infrastructure
Cloud with OpenStack" setups.
On Wedensday between 9:00am and 11:59am we invite you to a traditional
Bavarian breakfast at our stand.
***

-- 
Christian Berendt
Linux / Unix Consultant & Developer
Tel.: +49-171-5542175
Mail: bere...@b1-systems.de

B1 Systems GmbH
Osterfeldstraße 7 / 85088 Vohburg / http://www.b1-systems.de
GF: Ralph Dehner / Unternehmenssitz: Vohburg / AG: Ingolstadt,HRB 3537


signature.asc
Description: PGP signature
___
Mailing list: https://launchpad.net/~openstack
Post to : openstack@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openstack
More help   : https://help.launchpad.net/ListHelp

Re: [Openstack] Using useful commit messages while merging code into trunk

[Jay Pipes]

On Sat, Feb 26, 2011 at 1:17 PM, Christian Berendt
 wrote:
> We should always set a correct commit message in the merge propsal and
> we should don't merge code with useless commit messages.

++ :)

-jay

___
Mailing list: https://launchpad.net/~openstack
Post to : openstack@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openstack
More help   : https://help.launchpad.net/ListHelp

Re: [Openstack] Using useful commit messages while merging code into trunk

[Anne Gentle]

Sorry, that was my useless commit message, based on the message from Vish to
the list yesterday - not enough context provided! Will not happen again, I
promise. :)

Anne

* *
*Anne Gentle*

my blog  | my
book|
LinkedIn  |
Delicious|
Twitter 


On Sat, Feb 26, 2011 at 1:37 PM, Jay Pipes  wrote:

> On Sat, Feb 26, 2011 at 1:17 PM, Christian Berendt
>  wrote:
> > We should always set a correct commit message in the merge propsal and
> > we should don't merge code with useless commit messages.
>
> ++ :)
>
> -jay
>
> ___
> Mailing list: https://launchpad.net/~openstack
> Post to : openstack@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~openstack
> More help   : https://help.launchpad.net/ListHelp
>
___
Mailing list: https://launchpad.net/~openstack
Post to : openstack@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openstack
More help   : https://help.launchpad.net/ListHelp

[Openstack] Announcing the OpenStack Dashboard

[Devin Carlen]

Hello all,

I'd like to take this opportunity to formally announce the OpenStack Dashboard. 
 It's been available on Launchpad for a little while now so I could gather a 
bit of initial feedback about it.  Enough people have played with it and found 
it useful that it makes sense to unveil it to a larger audience.

The OpenStack Dashboard is based primarily on code that was developed for the 
NASA Nebula Dashboard.  We received the green light to release the code under 
the Apache licenese and have done so.  The project is based on Django and 
Python and consists of two primary pieces:



django-nova

This is a Django module that contains all of the interesting bits.  It's 
designed to be reusable and modular so it can be used in a variety of projects. 
 The NASA Nebula Dashboard uses this module, as does the OpenStack Dashboard.

The repo is available at: 

  https://launchpad.net/django-nova

As of Ubuntu Natty, it will be available in the apt repo:

  http://www.ubuntuupdates.org/packages/show/302171



openstack-dashboard

This is a Django site that provides a bare minimum reference implementation 
around django-nova.  This is essentially just CSS, django-registration for 
creating accounts, and the settings required to make django-nova function 
properly.  The goal of this site is to provide something demoable with some 
OpenStack branding on it.  Other organizations wanting to deploy a dashboard 
will want to roll their own, but using this as a reference.

The repo is available at:

  https://launchpad.net/openstack-dashboard




--
Future
--

Migrate to OpenStack API

Currently django-nova is based on the EC2 API for several reasons:

* OpenStack API lacks support for Volumes (this is being remedied very soon)
* OpenStack API has some conflicts with how project and user groups are handled.
* OpenStack API lacks admin API functions such as creating users and projects, 
starting VPNs.
  We have cobbled together the admin functions in the EC2 based admin endpoint 
for now.

The goal is to transition to the OpenStack API as soon as it is possible.  
There's no harm in starting this effort in a separate branch now so we can 
begin figuring out exactly where the pain points will be.


Combine django-nova and openstack-dashboard repos

Since these are complementary projects, I originally created them as separate 
Launchpad repos, but this created a lot of extra overhead when applying fixes 
that related to both projects.  The code won't be combined anymore than it 
already is, but I will be restructuring the openstack-dashboard repo to include 
django-nova in a separate folder.  This will make it much easier to deal with.


Improve user experience

We followed an agile development process and created the minimum of what was 
needed as we proceeded, but for the most part the functionality has stabilized. 
 There is room for improvement in the general usability of the sight, such as 
adding more client side scripting, improving layouts, etc.


There is much more to be done, but this is a good starting point for discussion!



Best,


Devin Carlen





___
Mailing list: https://launchpad.net/~openstack
Post to : openstack@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openstack
More help   : https://help.launchpad.net/ListHelp