Re: [Openstack] Using Gerrit to verify the CLA
On 9 January 2012 14:19, Mark McLoughlin wrote: > On Mon, 2012-01-09 at 08:11 -0600, John Dickinson wrote: >> https://rackspace.echosign.com/verifier > > For the record, I've gone back over my approvals and double checked the > transaction numbers. I guess it would help if the audit report was also in HTML format instead of downloading a PDF each time so you could also verify names (and that someone isn't just copy/pasting another ID) easily. Kind Regards -- Andrew Hutchings - Linuxjedi - http://www.linuxjedi.co.uk/ ___ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp
Re: [Openstack] Using Gerrit to verify the CLA
On Jan 9, 2012, at 8:08 AM, Mark McLoughlin wrote: > Hey, > > On Thu, 2012-01-05 at 10:02 -0800, James E. Blair wrote: >> This change is in place; membership in openstack-cla is required in >> order to submit changes to Gerrit. >> >> All of the -core groups have been made administrators of that group. If >> core members could watch for new membership requests, validate that the >> user has added their information to the wiki page, and approve them, >> that would be swell. > > I've done a few of these now. > > Is there any way for -core members to check the EchoSign Transaction > Number isn't just random gibberish before approving? On Mon, 2012-01-09 at 08:11 -0600, John Dickinson wrote: > https://rackspace.echosign.com/verifier Thanks John. For the record, I've gone back over my approvals and double checked the transaction numbers. Cheers, Mark. ___ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp
Re: [Openstack] Using Gerrit to verify the CLA
https://rackspace.echosign.com/verifier On Jan 9, 2012, at 8:08 AM, Mark McLoughlin wrote: > Hey, > > On Thu, 2012-01-05 at 10:02 -0800, James E. Blair wrote: >> This change is in place; membership in openstack-cla is required in >> order to submit changes to Gerrit. >> >> All of the -core groups have been made administrators of that group. If >> core members could watch for new membership requests, validate that the >> user has added their information to the wiki page, and approve them, >> that would be swell. > > I've done a few of these now. > > Is there any way for -core members to check the EchoSign Transaction > Number isn't just random gibberish before approving? > > Cheers, > Mark. > > > ___ > Mailing list: https://launchpad.net/~openstack > Post to : openstack@lists.launchpad.net > Unsubscribe : https://launchpad.net/~openstack > More help : https://help.launchpad.net/ListHelp smime.p7s Description: S/MIME cryptographic signature ___ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp
Re: [Openstack] Using Gerrit to verify the CLA
Hey, On Thu, 2012-01-05 at 10:02 -0800, James E. Blair wrote: > This change is in place; membership in openstack-cla is required in > order to submit changes to Gerrit. > > All of the -core groups have been made administrators of that group. If > core members could watch for new membership requests, validate that the > user has added their information to the wiki page, and approve them, > that would be swell. I've done a few of these now. Is there any way for -core members to check the EchoSign Transaction Number isn't just random gibberish before approving? Cheers, Mark. ___ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp
Re: [Openstack] Using Gerrit to verify the CLA
cor...@inaugust.com (James E. Blair) writes: > In short, the process for new developers will be: > > 1) Sign CLA via Echosign > 2) Record signature in wiki > 3) Apply for membership in openstack-cla > 4) Contribute! This change is in place; membership in openstack-cla is required in order to submit changes to Gerrit. All of the -core groups have been made administrators of that group. If core members could watch for new membership requests, validate that the user has added their information to the wiki page, and approve them, that would be swell. If you have any problems, please contact me (jeblair) or Monty (mtaylor) on IRC. -Jim ___ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp
Re: [Openstack] Using Gerrit to verify the CLA
Mark McLoughlin writes: > Nice work. Do you have a sense of how many past contributors haven't > signed the CLA or added themselves to the wiki? I don't know. > Also, how does this work for the corporate CLA? We're not changing the CLA process at all, so the existing process still stands: Note that: If you are contributing on behalf of a company or organization, someone at your company or organization needs to sign the Corporate Contributor License Agreement. A list of current companies and organizations with an existing Corporate CLA is available for your review. I'm not going to interpret that; I'm just going to make sure that the people currently on the wiki are in the launchpad group, and then add to the instructions an item to also request membership in the launchpad group. There is no technical verification of corporate CLA compliance. -Jim ___ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp
Re: [Openstack] Using Gerrit to verify the CLA
On Fri, 2011-12-30 at 09:41 -0800, James E. Blair wrote: > In short, the process for new developers will be: > > 1) Sign CLA via Echosign > 2) Record signature in wiki > 3) Apply for membership in openstack-cla > 4) Contribute! > > With only step 3 being added by this change. > > I'd like to enable this check on Thursday, January 5th. Please make > sure you have signed the CLA and entered your name on the wiki page by > then: > > http://wiki.openstack.org/HowToContribute > http://wiki.openstack.org/Contributors Nice work. Do you have a sense of how many past contributors haven't signed the CLA or added themselves to the wiki? Also, how does this work for the corporate CLA? Cheers, Mark. ___ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp
[Openstack] Using Gerrit to verify the CLA
Hi, We've gotten some requests from core reviewers to automate verification that people submitting changes have agreed to the CLA. Right now, the expectation is that core reviewers will only approve changes submitted by people who have agreed. That's silly because we have computers that can do that. Gerrit has a CLA system built in. While we could use it to replace the data collection and signature portion of the CLA process, that isn't the most important thing for either us or the lawyers to be working on right now. Instead, we can adopt a hybrid approach where we still use the same signature process, but use Gerrit to make sure people have completed it. The current process involves people adding their Launchpad IDs and Echosign signature transaction codes to a wiki page. To that, we'll add the step of requesting membership in the "openstack-cla" group on Launchpad. When someone has verified the listing for that person on the wiki page, they will be added to the group. Membership in that group will be required to upload changes to Gerrit. If we implement this technically as a CLA in Gerrit, albeit one that simply says something like "Follow the CLA process described in the wiki," we get a couple of benefits. We can tell Gerrit that anyone in a specific group (openstack-cla) has signed that CLA, and they will be able to upload changes. If someone attempts to upload a change without being a member of that group (ie, without having signed the CLA), they will receive a helpful error message: == fatal: A Contributor Agreement must be completed before uploading: https://review.openstack.org/#settings,agreements == That page (which will be present once the CLA is enabled) will show the pseudo-CLA in Gerrit, with a pointer to the wiki page with instructions on the real OpenStack CLA process. Even though it's not the way the Gerrit CLA system was intended to be used, I think this is a reasonable hybrid approach, at least until the next time we feel like overhauling the project CLA process. It's fairly simple, and we get an expressive error message from Gerrit if someone hasn't signed. In short, the process for new developers will be: 1) Sign CLA via Echosign 2) Record signature in wiki 3) Apply for membership in openstack-cla 4) Contribute! With only step 3 being added by this change. I'd like to enable this check on Thursday, January 5th. Please make sure you have signed the CLA and entered your name on the wiki page by then: http://wiki.openstack.org/HowToContribute http://wiki.openstack.org/Contributors -Jim ___ Mailing list: https://launchpad.net/~openstack Post to : openstack@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp
