Re: [Openstack] questions on the dynamic loading of virt drivers in nova

2012-05-10 Thread Thierry Carrez
You might want to talk to Soren and fix it within:

https://blueprints.launchpad.net/nova/+spec/hypervisor-code-consolidation

since this will also result in refactoring in the same area.

Vishvananda Ishaya wrote:
 No this is mostly just legacy stuff that was never refactored.
 
 Vish
 
 On May 9, 2012 3:33 PM, Sean Dague sda...@linux.vnet.ibm.com
 mailto:sda...@linux.vnet.ibm.com wrote:
 
 I'm familiarizing myself with the nova code and trying to reconcile
 that while there is dynamic class based loading in ComputeManager
 using import_utils in __init__() there is also a defaulting to the
 nova.virt.connection.get_ connection function.
 
 That's actually got a big if / else statement of string literals of
 known virt drivers, and then loads specific virt drivers from there.
 
 Is there a reason for both approaches? Can we refactor to a point
 where we don't need need of a common file with driver specific
 imports and string literals? Is there a reason not to?
 
 Thanks,
 
-Sean
 
 -- 
 Sean Dague
 IBM Linux Technology Center
 email: sda...@linux.vnet.ibm.com mailto:sda...@linux.vnet.ibm.com
 alt-email: slda...@us.ibm.com mailto:slda...@us.ibm.com
 
 
 __ _
 Mailing list: https://launchpad.net/~ openstack
 https://launchpad.net/~openstack
 Post to : openstack@lists.launchpad.net
 mailto:openstack@lists.launchpad.net
 Unsubscribe : https://launchpad.net/~ openstack
 https://launchpad.net/~openstack
 More help   : https://help.launchpad.net/ ListHelp
 https://help.launchpad.net/ListHelp
 
 
 
 ___
 Mailing list: https://launchpad.net/~openstack
 Post to : openstack@lists.launchpad.net
 Unsubscribe : https://launchpad.net/~openstack
 More help   : https://help.launchpad.net/ListHelp


-- 
Thierry Carrez (ttx)
Release Manager, OpenStack

___
Mailing list: https://launchpad.net/~openstack
Post to : openstack@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openstack
More help   : https://help.launchpad.net/ListHelp


Re: [Openstack] questions on the dynamic loading of virt drivers in nova

2012-05-09 Thread Vishvananda Ishaya
No this is mostly just legacy stuff that was never refactored.

Vish
On May 9, 2012 3:33 PM, Sean Dague sda...@linux.vnet.ibm.com wrote:

 I'm familiarizing myself with the nova code and trying to reconcile that
 while there is dynamic class based loading in ComputeManager using
 import_utils in __init__() there is also a defaulting to the
 nova.virt.connection.get_**connection function.

 That's actually got a big if / else statement of string literals of known
 virt drivers, and then loads specific virt drivers from there.

 Is there a reason for both approaches? Can we refactor to a point where we
 don't need need of a common file with driver specific imports and string
 literals? Is there a reason not to?

 Thanks,

-Sean

 --
 Sean Dague
 IBM Linux Technology Center
 email: sda...@linux.vnet.ibm.com
 alt-email: slda...@us.ibm.com


 __**_
 Mailing list: 
 https://launchpad.net/~**openstackhttps://launchpad.net/~openstack
 Post to : openstack@lists.launchpad.net
 Unsubscribe : 
 https://launchpad.net/~**openstackhttps://launchpad.net/~openstack
 More help   : 
 https://help.launchpad.net/**ListHelphttps://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~openstack
Post to : openstack@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openstack
More help   : https://help.launchpad.net/ListHelp