Re: [openstack-dev] [ALU] [vitrage] common vs utils

2016-11-29 Thread Yujun Zhang
Ready for review

https://review.openstack.org/#/c/404517/

On Mon, Nov 28, 2016 at 5:50 PM Weyl, Alexey (Nokia - IL) <
alexey.w...@nokia.com> wrote:

> Sounds good to me J
>
>
>
> *From:* Yujun Zhang [mailto:zhangyujun+...@gmail.com]
> *Sent:* Monday, November 28, 2016 10:43 AM
> *To:* OpenStack Development Mailing List (not for usage questions)
> *Subject:* [ALU] [openstack-dev] [vitrage] common vs utils
>
>
>
> Currently, we have `common/utils.py`, `common/file_utils.py` and an empty
> module `utils` in `vitrage`.
>
>
>
> In my understanding, `common` means *common to vitrage package* and utils
> are more *general purpose utility* functions.
>
>
>
> Would it better that we move `utils.py`, `file_utils.py` and
> `datetime_utils.py` to `utils`?
>
>
>
> --
>
> Yujun
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [ALU] [vitrage] common vs utils

2016-11-28 Thread Weyl, Alexey (Nokia - IL)
Sounds good to me ☺

From: Yujun Zhang [mailto:zhangyujun+...@gmail.com]
Sent: Monday, November 28, 2016 10:43 AM
To: OpenStack Development Mailing List (not for usage questions)
Subject: [ALU] [openstack-dev] [vitrage] common vs utils

Currently, we have `common/utils.py`, `common/file_utils.py` and an empty 
module `utils` in `vitrage`.

In my understanding, `common` means common to vitrage package and utils are 
more general purpose utility functions.

Would it better that we move `utils.py`, `file_utils.py` and 
`datetime_utils.py` to `utils`?

--
Yujun
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev