Re: [openstack-dev] [Glance] Removing python-sendfile related code from BaseClient

2013-06-29 Thread Mark Washenberger
Hi Paul,

I'll always cheer when we remove unused code :-)


On Mon, Jun 24, 2013 at 9:58 AM, Paul Bourke  wrote:

> I'm adding some unit tests for glance/common/client.py as part of
> bug/1115551, and noticed the image_iterator() function
> (
> https://github.com/openstack/glance/blob/master/glance/common/client.py#L568
> )
> returns two non-existent types, SendFileIterator and
> ImageBodyIterator.
>
> It seems there's no code path that goes down this route; would I be
> correct in assuming this is left over from the legacy glanceclient?
>
> I think there's two possible actions - one would be to remove this and
> related code that calls it from do_request.  The other would be to
> restore these iterator classes back, so this functionality would still
> be supported if desired.  Thoughts?
>
> Thanks,
> -Paul
>
> ___
> OpenStack-dev mailing list
> OpenStack-dev@lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


[openstack-dev] [Glance] Removing python-sendfile related code from BaseClient

2013-06-24 Thread Paul Bourke
I'm adding some unit tests for glance/common/client.py as part of
bug/1115551, and noticed the image_iterator() function
(https://github.com/openstack/glance/blob/master/glance/common/client.py#L568)
returns two non-existent types, SendFileIterator and
ImageBodyIterator.

It seems there's no code path that goes down this route; would I be
correct in assuming this is left over from the legacy glanceclient?

I think there's two possible actions - one would be to remove this and
related code that calls it from do_request.  The other would be to
restore these iterator classes back, so this functionality would still
be supported if desired.  Thoughts?

Thanks,
-Paul

___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev