Re: [openstack-dev] [Magnum] Make functional tests voting
Bug ticket for python-magnumclient gate test: https://bugs.launchpad.net/python-magnumclient/+bug/1465375 On Jun 15, 2015, at 11:07 AM, Tom Cammann tom.camm...@hp.commailto:tom.camm...@hp.com wrote: Review up for making it voting: https://review.openstack.org/#/c/191921/ It would probably be a good plan to run the functional tests on the python-magnumclient, although I'm not too sure how to set that up. Tom On 15/06/15 18:47, Adrian Otto wrote: Tom, Yes, let’s make it voting now. I went through the full review queue over the weekend, and I did find a few examples of functional tests timing out after 2 hours. It did not look to me like they actually ran, suggesting a malfunction in the setup of the test nodes. There we only one or two like that in the few dozen patches I looked at. I think I ordered one recheck. If that happens a lot, we might need to revisit this decision, but in all honesty I’d prefer to have the pressure of a malfunctioning gate blocking us so that we are motivated to resolve the issue at the root cause. Thanks, Adrian On Jun 15, 2015, at 10:21 AM, Davanum Srinivas dava...@gmail.commailto:dava...@gmail.com wrote: +1 from me Tom. On Mon, Jun 15, 2015 at 1:15 PM, Tom Cammann tom.camm...@hp.commailto:tom.camm...@hp.com wrote: Hello, I haven't seen any false positives in a few weeks from the functional tests, but I have seen a couple reviewers missing the -1 from the non-voting job when there has been a legitimate failures. I think now would be a good time to turn 'check-functional-dsvm-magnum' to voting. Thanks, Tom __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.orgmailto:openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev -- Davanum Srinivas :: https://twitter.com/dims __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.orgmailto:openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.orgmailto:openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.orgmailto:openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Magnum] Make functional tests voting
Review up for making it voting: https://review.openstack.org/#/c/191921/ It would probably be a good plan to run the functional tests on the python-magnumclient, although I'm not too sure how to set that up. Tom On 15/06/15 18:47, Adrian Otto wrote: Tom, Yes, let’s make it voting now. I went through the full review queue over the weekend, and I did find a few examples of functional tests timing out after 2 hours. It did not look to me like they actually ran, suggesting a malfunction in the setup of the test nodes. There we only one or two like that in the few dozen patches I looked at. I think I ordered one recheck. If that happens a lot, we might need to revisit this decision, but in all honesty I’d prefer to have the pressure of a malfunctioning gate blocking us so that we are motivated to resolve the issue at the root cause. Thanks, Adrian On Jun 15, 2015, at 10:21 AM, Davanum Srinivas dava...@gmail.com wrote: +1 from me Tom. On Mon, Jun 15, 2015 at 1:15 PM, Tom Cammann tom.camm...@hp.com wrote: Hello, I haven't seen any false positives in a few weeks from the functional tests, but I have seen a couple reviewers missing the -1 from the non-voting job when there has been a legitimate failures. I think now would be a good time to turn 'check-functional-dsvm-magnum' to voting. Thanks, Tom __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev -- Davanum Srinivas :: https://twitter.com/dims __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
[openstack-dev] [Magnum] Make functional tests voting
Hello, I haven't seen any false positives in a few weeks from the functional tests, but I have seen a couple reviewers missing the -1 from the non-voting job when there has been a legitimate failures. I think now would be a good time to turn 'check-functional-dsvm-magnum' to voting. Thanks, Tom __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Magnum] Make functional tests voting
+1 from me Tom. On Mon, Jun 15, 2015 at 1:15 PM, Tom Cammann tom.camm...@hp.com wrote: Hello, I haven't seen any false positives in a few weeks from the functional tests, but I have seen a couple reviewers missing the -1 from the non-voting job when there has been a legitimate failures. I think now would be a good time to turn 'check-functional-dsvm-magnum' to voting. Thanks, Tom __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev -- Davanum Srinivas :: https://twitter.com/dims __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Magnum] Make functional tests voting
Tom, Yes, let’s make it voting now. I went through the full review queue over the weekend, and I did find a few examples of functional tests timing out after 2 hours. It did not look to me like they actually ran, suggesting a malfunction in the setup of the test nodes. There we only one or two like that in the few dozen patches I looked at. I think I ordered one recheck. If that happens a lot, we might need to revisit this decision, but in all honesty I’d prefer to have the pressure of a malfunctioning gate blocking us so that we are motivated to resolve the issue at the root cause. Thanks, Adrian On Jun 15, 2015, at 10:21 AM, Davanum Srinivas dava...@gmail.com wrote: +1 from me Tom. On Mon, Jun 15, 2015 at 1:15 PM, Tom Cammann tom.camm...@hp.com wrote: Hello, I haven't seen any false positives in a few weeks from the functional tests, but I have seen a couple reviewers missing the -1 from the non-voting job when there has been a legitimate failures. I think now would be a good time to turn 'check-functional-dsvm-magnum' to voting. Thanks, Tom __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev -- Davanum Srinivas :: https://twitter.com/dims __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
