[openstack-dev] [Neutron] DOWN and INACTIVE status in FWaaS and LBaaS

2014-02-26 Thread Xuhan Peng
Hello,

This email is triggered by the comments I received in my patch [1] when
trying to fix bug [2].

The problem I was trying to fix is that current firewall remains in status
ACTIVE after admin state is changed to DOWN. My plan is to change the
status of firewall from ACTIVE to DOWN when admin state is down, as other
network resource is doing currently.

But I noticed besides DOWN state, INACTIVE state is also used in FWaaS
and LBaaS. So I hope someone can help me understand any background of this.
If this is not particularly by design and inconsistent with other network
resource, I can open a bug to fix this in FWaaS and LBaaS.

Thanks,
Xu Han

[1]: https://review.openstack.org/#/c/73944/
[2]: https://launchpad.net/bugs/1279213
___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [Neutron] DOWN and INACTIVE status in FWaaS and LBaaS

2014-02-26 Thread Oleg Bondarev
Hi,

For LBaaS the background is simple: it uses statuses from
neutron/plugins/common/constants.py and INACTIVE was there initially while
DOWN
appeared later (with VPNaaS first commit). So LBaaS doesn't use DOWN at all.
As for INACTIVE, it is currently used only for members that stop responding
to health checks.
Also there is a patch on review (https://review.openstack.org/#/c/55032)
which sets INACTIVE
status for resources with admin state down.

My personal opinion is that we can easily fix that for LBaaS and replace
INACTIVE with DOWN
to be consistent with other network resources.

Thanks,
Oleg


On Wed, Feb 26, 2014 at 1:50 PM, Xuhan Peng pengxu...@gmail.com wrote:

 Hello,

 This email is triggered by the comments I received in my patch [1] when
 trying to fix bug [2].

 The problem I was trying to fix is that current firewall remains in status
 ACTIVE after admin state is changed to DOWN. My plan is to change the
 status of firewall from ACTIVE to DOWN when admin state is down, as other
 network resource is doing currently.

 But I noticed besides DOWN state, INACTIVE state is also used in FWaaS
 and LBaaS. So I hope someone can help me understand any background of this.
 If this is not particularly by design and inconsistent with other network
 resource, I can open a bug to fix this in FWaaS and LBaaS.

 Thanks,
 Xu Han

 [1]: https://review.openstack.org/#/c/73944/
 [2]: https://launchpad.net/bugs/1279213



 ___
 OpenStack-dev mailing list
 OpenStack-dev@lists.openstack.org
 http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [Neutron] DOWN and INACTIVE status in FWaaS and LBaaS

2014-02-26 Thread Xuhan Peng
Oleg,

Thanks a lot for your quick response! I will open a bug to address that
soon. For the LBaaS part, probably I will just make the fix dependent on
the code review you mentioned.

Xu Han

On Wed, Feb 26, 2014 at 6:43 PM, Oleg Bondarev obonda...@mirantis.comwrote:

 Hi,

 For LBaaS the background is simple: it uses statuses from
 neutron/plugins/common/constants.py and INACTIVE was there initially while
 DOWN
 appeared later (with VPNaaS first commit). So LBaaS doesn't use DOWN at
 all.
 As for INACTIVE, it is currently used only for members that stop
 responding to health checks.
 Also there is a patch on review (https://review.openstack.org/#/c/55032)
 which sets INACTIVE
 status for resources with admin state down.

 My personal opinion is that we can easily fix that for LBaaS and replace
 INACTIVE with DOWN
 to be consistent with other network resources.

 Thanks,
 Oleg


 On Wed, Feb 26, 2014 at 1:50 PM, Xuhan Peng pengxu...@gmail.com wrote:

 Hello,

 This email is triggered by the comments I received in my patch [1] when
 trying to fix bug [2].

 The problem I was trying to fix is that current firewall remains in
 status ACTIVE after admin state is changed to DOWN. My plan is to
 change the status of firewall from ACTIVE to DOWN when admin state is down,
 as other network resource is doing currently.

 But I noticed besides DOWN state, INACTIVE state is also used in
 FWaaS and LBaaS. So I hope someone can help me understand any background of
 this. If this is not particularly by design and inconsistent with other
 network resource, I can open a bug to fix this in FWaaS and LBaaS.

 Thanks,
 Xu Han

 [1]: https://review.openstack.org/#/c/73944/
 [2]: https://launchpad.net/bugs/1279213



 ___
 OpenStack-dev mailing list
 OpenStack-dev@lists.openstack.org
 http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev



 ___
 OpenStack-dev mailing list
 OpenStack-dev@lists.openstack.org
 http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev