Re: [openstack-dev] [Openstack-operators] [glance] Remove `run_tests.sh` and `tools/*`

[Nikhil Komawar]

I meant exactly that if you're not using venv for glance testing and
want to use testing tools shipped that have the wrappings of run_test or
even tox then asking packagers to write new scripts for doing the same
thing seems odd.

My question still stands: who is still using run_test towards this
purpose? I am aware that some ops do prefer it.

On 3/4/16 2:20 PM, Flavio Percoco wrote:
> On 04/03/16 14:12 -0500, Nikhil Komawar wrote:
>> Surely you can directly use the standard libraries to test systemwide
>> but I am more curious to know if there are some who are still using
>> run_tests wrappings that exist for to ease the pain a bit.
>
> Oh, sorry if I came off wrong. What I meant is that if you have glance
> installed
> systemwide, you'd be better off running the command found in tox.ini
> rather than
> running `run_tests.sh`. One reason is that one point in favor to `tox`
> and even
> `run_tests.sh` itself is isolating test environments. Other than that,
> I don't
> think they provide much other benefits over just running testr
> directly (which I
> sometimes do).
>
> Hope that's clearer,
> Flavio
>
>> On 3/4/16 12:41 PM, Flavio Percoco wrote:
>>> On 04/03/16 11:59 -0500, Nikhil Komawar wrote:
 I think the hard question to me here is:

 Do people care about testing code on system installs vs. virtual env?
 run_tests does that and for some cases when you want to be extra sure
 about your CICD nodes, packaging and upgrades, the problem is solved.

 Are packagers using tox to this purpose?
>>>
>>> TBH, if you're testing things without venvs and sytemwide, I think
>>> it'd be far
>>> easier to just call nosetests/testr directly in your system than
>>> calling the
>>> run_tests script.
>>>
>>> Some packages don't even ship tests.
>>>
>>> Cheers,
>>> Flavio
>>>
 On 3/4/16 11:16 AM, Steve Martinelli wrote:
>
> The keystone team did the same during Liberty while we were moving
> towards using oslo.* projects instead of oslo-incubator [0]. We also
> noticed that they were rarely used, and we did not go through a
> deprecation process since these are developer tools. We're still
> finding a few spots in our docs that need updating, but overall it
> was
> an easy transition.
>
> [0]
> https://github.com/openstack/keystone/commit/55e9514cbd4e712e2c317335294355cf1596d870
>
>
>
> stevemar
>
> Inactive hide details for Flavio Percoco ---2016/03/04 06:51:47
> AM---Hey Folks, I'm looking at doing some cleanups in our repo Flavio
> Percoco ---2016/03/04 06:51:47 AM---Hey Folks, I'm looking at doing
> some cleanups in our repo and I would like to start by
>
> From: Flavio Percoco 
> To: openstack-dev@lists.openstack.org
> Cc: openstack-operat...@lists.openstack.org
> Date: 2016/03/04 06:51 AM
> Subject: [Openstack-operators] [glance] Remove `run_tests.sh` and
> `tools/*`
>
> 
>
>
>
>
>
> Hey Folks,
>
> I'm looking at doing some cleanups in our repo and I would like to
> start by
> deprecating the `run_tests` script and the contents in the `tools/`
> dir.
>
> As far as I can tell, no one is using this code - we're not even
> using
> it in the
> gate - as it was broken until recently, I believe. The recommended
> way
> to run
> tests is using `tox` and I believe having this script in the code
> base
> misleads
> new contributors and other users.
>
> So, before we do this. I wanted to get feedback from a broader
> audience and give
> a heads up to folks that might be using this code.
>
> Any objections? Something I'm missing?
>
> Flavio
>
> -- 
> @flaper87
> Flavio Percoco
> [attachment "signature.asc" deleted by Steve Martinelli/Toronto/IBM]
> ___
> OpenStack-operators mailing list
> openstack-operat...@lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-operators
>
>
>
>
>
>
> __
>
>
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe:
> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

 -- 

 Thanks,
 Nikhil

>>>
>>
>> -- 
>>
>> Thanks,
>> Nikhil
>>
>

-- 

Thanks,
Nikhil


__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [Openstack-operators] [glance] Remove `run_tests.sh` and `tools/*`

[Flavio Percoco]

On 04/03/16 14:12 -0500, Nikhil Komawar wrote:

Surely you can directly use the standard libraries to test systemwide
but I am more curious to know if there are some who are still using
run_tests wrappings that exist for to ease the pain a bit.


Oh, sorry if I came off wrong. What I meant is that if you have glance installed
systemwide, you'd be better off running the command found in tox.ini rather than
running `run_tests.sh`. One reason is that one point in favor to `tox` and even
`run_tests.sh` itself is isolating test environments. Other than that, I don't
think they provide much other benefits over just running testr directly (which I
sometimes do).

Hope that's clearer,
Flavio


On 3/4/16 12:41 PM, Flavio Percoco wrote:

On 04/03/16 11:59 -0500, Nikhil Komawar wrote:

I think the hard question to me here is:

Do people care about testing code on system installs vs. virtual env?
run_tests does that and for some cases when you want to be extra sure
about your CICD nodes, packaging and upgrades, the problem is solved.

Are packagers using tox to this purpose?


TBH, if you're testing things without venvs and sytemwide, I think
it'd be far
easier to just call nosetests/testr directly in your system than
calling the
run_tests script.

Some packages don't even ship tests.

Cheers,
Flavio


On 3/4/16 11:16 AM, Steve Martinelli wrote:


The keystone team did the same during Liberty while we were moving
towards using oslo.* projects instead of oslo-incubator [0]. We also
noticed that they were rarely used, and we did not go through a
deprecation process since these are developer tools. We're still
finding a few spots in our docs that need updating, but overall it was
an easy transition.

[0]
https://github.com/openstack/keystone/commit/55e9514cbd4e712e2c317335294355cf1596d870


stevemar

Inactive hide details for Flavio Percoco ---2016/03/04 06:51:47
AM---Hey Folks, I'm looking at doing some cleanups in our repo Flavio
Percoco ---2016/03/04 06:51:47 AM---Hey Folks, I'm looking at doing
some cleanups in our repo and I would like to start by

From: Flavio Percoco 
To: openstack-dev@lists.openstack.org
Cc: openstack-operat...@lists.openstack.org
Date: 2016/03/04 06:51 AM
Subject: [Openstack-operators] [glance] Remove `run_tests.sh` and
`tools/*`






Hey Folks,

I'm looking at doing some cleanups in our repo and I would like to
start by
deprecating the `run_tests` script and the contents in the `tools/`
dir.

As far as I can tell, no one is using this code - we're not even using
it in the
gate - as it was broken until recently, I believe. The recommended way
to run
tests is using `tox` and I believe having this script in the code base
misleads
new contributors and other users.

So, before we do this. I wanted to get feedback from a broader
audience and give
a heads up to folks that might be using this code.

Any objections? Something I'm missing?

Flavio

--
@flaper87
Flavio Percoco
[attachment "signature.asc" deleted by Steve Martinelli/Toronto/IBM]
___
OpenStack-operators mailing list
openstack-operat...@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-operators





__

OpenStack Development Mailing List (not for usage questions)
Unsubscribe:
openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


--

Thanks,
Nikhil





--

Thanks,
Nikhil



--
@flaper87
Flavio Percoco


signature.asc
Description: PGP signature
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [Openstack-operators] [glance] Remove `run_tests.sh` and `tools/*`

[Nikhil Komawar]

Surely you can directly use the standard libraries to test systemwide
but I am more curious to know if there are some who are still using
run_tests wrappings that exist for to ease the pain a bit.

On 3/4/16 12:41 PM, Flavio Percoco wrote:
> On 04/03/16 11:59 -0500, Nikhil Komawar wrote:
>> I think the hard question to me here is:
>>
>> Do people care about testing code on system installs vs. virtual env?
>> run_tests does that and for some cases when you want to be extra sure
>> about your CICD nodes, packaging and upgrades, the problem is solved.
>>
>> Are packagers using tox to this purpose?
>
> TBH, if you're testing things without venvs and sytemwide, I think
> it'd be far
> easier to just call nosetests/testr directly in your system than
> calling the
> run_tests script.
>
> Some packages don't even ship tests.
>
> Cheers,
> Flavio
>
>> On 3/4/16 11:16 AM, Steve Martinelli wrote:
>>>
>>> The keystone team did the same during Liberty while we were moving
>>> towards using oslo.* projects instead of oslo-incubator [0]. We also
>>> noticed that they were rarely used, and we did not go through a
>>> deprecation process since these are developer tools. We're still
>>> finding a few spots in our docs that need updating, but overall it was
>>> an easy transition.
>>>
>>> [0]
>>> https://github.com/openstack/keystone/commit/55e9514cbd4e712e2c317335294355cf1596d870
>>>
>>>
>>> stevemar
>>>
>>> Inactive hide details for Flavio Percoco ---2016/03/04 06:51:47
>>> AM---Hey Folks, I'm looking at doing some cleanups in our repo Flavio
>>> Percoco ---2016/03/04 06:51:47 AM---Hey Folks, I'm looking at doing
>>> some cleanups in our repo and I would like to start by
>>>
>>> From: Flavio Percoco 
>>> To: openstack-dev@lists.openstack.org
>>> Cc: openstack-operat...@lists.openstack.org
>>> Date: 2016/03/04 06:51 AM
>>> Subject: [Openstack-operators] [glance] Remove `run_tests.sh` and
>>> `tools/*`
>>>
>>> 
>>>
>>>
>>>
>>>
>>> Hey Folks,
>>>
>>> I'm looking at doing some cleanups in our repo and I would like to
>>> start by
>>> deprecating the `run_tests` script and the contents in the `tools/`
>>> dir.
>>>
>>> As far as I can tell, no one is using this code - we're not even using
>>> it in the
>>> gate - as it was broken until recently, I believe. The recommended way
>>> to run
>>> tests is using `tox` and I believe having this script in the code base
>>> misleads
>>> new contributors and other users.
>>>
>>> So, before we do this. I wanted to get feedback from a broader
>>> audience and give
>>> a heads up to folks that might be using this code.
>>>
>>> Any objections? Something I'm missing?
>>>
>>> Flavio
>>>
>>> -- 
>>> @flaper87
>>> Flavio Percoco
>>> [attachment "signature.asc" deleted by Steve Martinelli/Toronto/IBM]
>>> ___
>>> OpenStack-operators mailing list
>>> openstack-operat...@lists.openstack.org
>>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-operators
>>>
>>>
>>>
>>>
>>>
>>> __
>>>
>>> OpenStack Development Mailing List (not for usage questions)
>>> Unsubscribe:
>>> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
>>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>
>> -- 
>>
>> Thanks,
>> Nikhil
>>
>

-- 

Thanks,
Nikhil


__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [Openstack-operators] [glance] Remove `run_tests.sh` and `tools/*`

[Flavio Percoco]

On 04/03/16 11:59 -0500, Nikhil Komawar wrote:

I think the hard question to me here is:

Do people care about testing code on system installs vs. virtual env?
run_tests does that and for some cases when you want to be extra sure
about your CICD nodes, packaging and upgrades, the problem is solved.

Are packagers using tox to this purpose?


TBH, if you're testing things without venvs and sytemwide, I think it'd be far
easier to just call nosetests/testr directly in your system than calling the
run_tests script.

Some packages don't even ship tests.

Cheers,
Flavio


On 3/4/16 11:16 AM, Steve Martinelli wrote:


The keystone team did the same during Liberty while we were moving
towards using oslo.* projects instead of oslo-incubator [0]. We also
noticed that they were rarely used, and we did not go through a
deprecation process since these are developer tools. We're still
finding a few spots in our docs that need updating, but overall it was
an easy transition.

[0]
https://github.com/openstack/keystone/commit/55e9514cbd4e712e2c317335294355cf1596d870

stevemar

Inactive hide details for Flavio Percoco ---2016/03/04 06:51:47
AM---Hey Folks, I'm looking at doing some cleanups in our repo Flavio
Percoco ---2016/03/04 06:51:47 AM---Hey Folks, I'm looking at doing
some cleanups in our repo and I would like to start by

From: Flavio Percoco 
To: openstack-dev@lists.openstack.org
Cc: openstack-operat...@lists.openstack.org
Date: 2016/03/04 06:51 AM
Subject: [Openstack-operators] [glance] Remove `run_tests.sh` and
`tools/*`





Hey Folks,

I'm looking at doing some cleanups in our repo and I would like to
start by
deprecating the `run_tests` script and the contents in the `tools/` dir.

As far as I can tell, no one is using this code - we're not even using
it in the
gate - as it was broken until recently, I believe. The recommended way
to run
tests is using `tox` and I believe having this script in the code base
misleads
new contributors and other users.

So, before we do this. I wanted to get feedback from a broader
audience and give
a heads up to folks that might be using this code.

Any objections? Something I'm missing?

Flavio

--
@flaper87
Flavio Percoco
[attachment "signature.asc" deleted by Steve Martinelli/Toronto/IBM]
___
OpenStack-operators mailing list
openstack-operat...@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-operators





__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


--

Thanks,
Nikhil



--
@flaper87
Flavio Percoco


signature.asc
Description: PGP signature
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [Openstack-operators] [glance] Remove `run_tests.sh` and `tools/*`

[Nikhil Komawar]

I think the hard question to me here is:

Do people care about testing code on system installs vs. virtual env?
run_tests does that and for some cases when you want to be extra sure
about your CICD nodes, packaging and upgrades, the problem is solved.

Are packagers using tox to this purpose?

On 3/4/16 11:16 AM, Steve Martinelli wrote:
>
> The keystone team did the same during Liberty while we were moving
> towards using oslo.* projects instead of oslo-incubator [0]. We also
> noticed that they were rarely used, and we did not go through a
> deprecation process since these are developer tools. We're still
> finding a few spots in our docs that need updating, but overall it was
> an easy transition.
>
> [0]
> https://github.com/openstack/keystone/commit/55e9514cbd4e712e2c317335294355cf1596d870
>
> stevemar
>
> Inactive hide details for Flavio Percoco ---2016/03/04 06:51:47
> AM---Hey Folks, I'm looking at doing some cleanups in our repo Flavio
> Percoco ---2016/03/04 06:51:47 AM---Hey Folks, I'm looking at doing
> some cleanups in our repo and I would like to start by
>
> From: Flavio Percoco 
> To: openstack-dev@lists.openstack.org
> Cc: openstack-operat...@lists.openstack.org
> Date: 2016/03/04 06:51 AM
> Subject: [Openstack-operators] [glance] Remove `run_tests.sh` and
> `tools/*`
>
> 
>
>
>
> Hey Folks,
>
> I'm looking at doing some cleanups in our repo and I would like to
> start by
> deprecating the `run_tests` script and the contents in the `tools/` dir.
>
> As far as I can tell, no one is using this code - we're not even using
> it in the
> gate - as it was broken until recently, I believe. The recommended way
> to run
> tests is using `tox` and I believe having this script in the code base
> misleads
> new contributors and other users.
>
> So, before we do this. I wanted to get feedback from a broader
> audience and give
> a heads up to folks that might be using this code.
>
> Any objections? Something I'm missing?
>
> Flavio
>
> -- 
> @flaper87
> Flavio Percoco
> [attachment "signature.asc" deleted by Steve Martinelli/Toronto/IBM]
> ___
> OpenStack-operators mailing list
> openstack-operat...@lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-operators
>
>
>
>
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

-- 

Thanks,
Nikhil

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [Openstack-operators] [glance] Remove `run_tests.sh` and `tools/*`

[Ronald Bradford]

+1 from me.   I am all for standardizing this.

Personally when I started looking at OpenStack code as new contributor this
was very confusing with the online docs that listed run_tests.sh but the
first project I looked at, this didn't exist and it was all tox based.

I went on to blog about my first experience of tox, as this was lacking in
OpenStack docs.

Ronald



On Fri, Mar 4, 2016 at 11:16 AM, Steve Martinelli 
wrote:

> The keystone team did the same during Liberty while we were moving towards
> using oslo.* projects instead of oslo-incubator [0]. We also noticed that
> they were rarely used, and we did not go through a deprecation process
> since these are developer tools. We're still finding a few spots in our
> docs that need updating, but overall it was an easy transition.
>
> [0]
> https://github.com/openstack/keystone/commit/55e9514cbd4e712e2c317335294355cf1596d870
>
> stevemar
>
> [image: Inactive hide details for Flavio Percoco ---2016/03/04 06:51:47
> AM---Hey Folks, I'm looking at doing some cleanups in our repo]Flavio
> Percoco ---2016/03/04 06:51:47 AM---Hey Folks, I'm looking at doing some
> cleanups in our repo and I would like to start by
>
> From: Flavio Percoco 
> To: openstack-dev@lists.openstack.org
> Cc: openstack-operat...@lists.openstack.org
> Date: 2016/03/04 06:51 AM
> Subject: [Openstack-operators] [glance] Remove `run_tests.sh` and
> `tools/*`
> --
>
>
>
> Hey Folks,
>
> I'm looking at doing some cleanups in our repo and I would like to start by
> deprecating the `run_tests` script and the contents in the `tools/` dir.
>
> As far as I can tell, no one is using this code - we're not even using it
> in the
> gate - as it was broken until recently, I believe. The recommended way to
> run
> tests is using `tox` and I believe having this script in the code base
> misleads
> new contributors and other users.
>
> So, before we do this. I wanted to get feedback from a broader audience
> and give
> a heads up to folks that might be using this code.
>
> Any objections? Something I'm missing?
>
> Flavio
>
> --
> @flaper87
> Flavio Percoco
> [attachment "signature.asc" deleted by Steve Martinelli/Toronto/IBM]
> ___
> OpenStack-operators mailing list
> openstack-operat...@lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-operators
>
>
>
>
> ___
> OpenStack-operators mailing list
> openstack-operat...@lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-operators
>
>
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [Openstack-operators] [glance] Remove `run_tests.sh` and `tools/*`

[Steve Martinelli]

The keystone team did the same during Liberty while we were moving towards
using oslo.* projects instead of oslo-incubator [0]. We also noticed that
they were rarely used, and we did not go through a deprecation process
since these are developer tools. We're still finding a few spots in our
docs that need updating, but overall it was an easy transition.

[0]
https://github.com/openstack/keystone/commit/55e9514cbd4e712e2c317335294355cf1596d870

stevemar



From:   Flavio Percoco 
To: openstack-dev@lists.openstack.org
Cc: openstack-operat...@lists.openstack.org
Date:   2016/03/04 06:51 AM
Subject:[Openstack-operators] [glance] Remove `run_tests.sh` and
`tools/*`



Hey Folks,

I'm looking at doing some cleanups in our repo and I would like to start by
deprecating the `run_tests` script and the contents in the `tools/` dir.

As far as I can tell, no one is using this code - we're not even using it
in the
gate - as it was broken until recently, I believe. The recommended way to
run
tests is using `tox` and I believe having this script in the code base
misleads
new contributors and other users.

So, before we do this. I wanted to get feedback from a broader audience and
give
a heads up to folks that might be using this code.

Any objections? Something I'm missing?

Flavio

--
@flaper87
Flavio Percoco
[attachment "signature.asc" deleted by Steve Martinelli/Toronto/IBM]
___
OpenStack-operators mailing list
openstack-operat...@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-operators


__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev