Re: [openstack-dev] [Trove] Backup/restore namespace config move has leftovers
On 02/08/14 18:24, Denis Makogon wrote: Mark, we don't have to add backup/restore namespace options to datastores that does't support backup/restore feature. You should take a look how backup procedure is being executed at Trove-API service site, see https://github.com/openstack/trove/blob/master/trove/backup/models.py (Method called _validate_can_perform_action) If you'll have another questions, feel free to catch me up at IRC (denis_makogon). Thanks Denis - I did wonder if it was an optional specification! Doh! However, while I'm a bit ignorant wrt redis and cassandra, I do have a bit todo with mongo and that certainly *does* support backup/restore... Cheers Mark ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Trove] Backup/restore namespace config move has leftovers
суббота, 2 августа 2014 г. пользователь Mark Kirkwood написал: On 02/08/14 18:24, Denis Makogon wrote: Mark, we don't have to add backup/restore namespace options to datastores that does't support backup/restore feature. You should take a look how backup procedure is being executed at Trove-API service site, see https://github.com/openstack/trove/blob/master/trove/backup/models.py (Method called _validate_can_perform_action) If you'll have another questions, feel free to catch me up at IRC (denis_makogon). Thanks Denis - I did wonder if it was an optional specification! Doh! However, while I'm a bit ignorant wrt redis and cassandra, I do have a bit todo with mongo and that certainly *does* support backup/restore... Thank to you too, Mark. There were already filed several BPs related to back/restore procedure: for Cassandra, for Mongodb( through mongodump and tayra). Some of them are already hanging at review queue. Best regards, Denis Makogon Cheers Mark ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Trove] Backup/restore namespace config move has leftovers
On Fri, Aug 1, 2014 at 2:30 AM, Mark Kirkwood mark.kirkw...@catalyst.net.nz wrote: In my latest devstack pull I notice that backup_namespace restore_namespace have moved from the default conf group to per datastore (commit 61935d3). However they still appear in the common_opts section of trove/common/cfg.py Correct, they are still there, see https://github.com/openstack/trove/blob/master/trove/common/cfg.py#L177-L182 . This this options from DEFAULT section should be dropped of, or at least marked as DEPRECATED. This seems like an oversight - or is there something I'm missing? You're not missing anything, you are right. I'd suggest to file a bug report and fix given issue. Best regards, Denis Makogon Cheers Mark ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Trove] Backup/restore namespace config move has leftovers
On 01/08/14 21:35, Denis Makogon wrote: I'd suggest to file a bug report and fix given issue. Done. https://bugs.launchpad.net/trove/+bug/1351545 I also took the opportunity to check if all the currently defined datastores had backup/restore_namespace set - they didn't, so I noted that too (I'm guessing they now actually *need* to have something set to avoid breakage)... regards Mark ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
[openstack-dev] [Trove] Backup/restore namespace config move has leftovers
In my latest devstack pull I notice that backup_namespace restore_namespace have moved from the default conf group to per datastore (commit 61935d3). However they still appear in the common_opts section of trove/common/cfg.py This seems like an oversight - or is there something I'm missing? Cheers Mark ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
